[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On Wed, Jun 18, 2014 at 04:33:39PM -0600, Stephen Warren wrote: > On 06/18/2014 04:19 PM, St?phane Marchesin wrote: > > On Wed, Jun 18, 2014 at 3:00 PM, Thierry Reding > > wrote: > >> On Wed, Jun 18, 2014 at 07:23:47PM +0200, Tomeu Vizoso wrote: > >>> On 06/17/2014 06:15 PM, Stephen Warren wrote:

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On Wed, Jun 18, 2014 at 04:09:06PM -0600, Stephen Warren wrote: > On 06/18/2014 04:03 PM, Thierry Reding wrote: > > On Wed, Jun 18, 2014 at 11:46:49AM -0600, Stephen Warren wrote: > >> On 06/18/2014 11:23 AM, Tomeu Vizoso wrote: > >>> On 06/17/2014 06:15 PM, Stephen Warren wrote: > On

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On Wed, Jun 18, 2014 at 11:46:49AM -0600, Stephen Warren wrote: > On 06/18/2014 11:23 AM, Tomeu Vizoso wrote: > > On 06/17/2014 06:15 PM, Stephen Warren wrote: > >> On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: > >>> On 06/16/2014 10:02 PM, Stephen Warren wrote: > On 06/16/2014 07:35 AM, Tomeu

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On Wed, Jun 18, 2014 at 07:23:47PM +0200, Tomeu Vizoso wrote: > On 06/17/2014 06:15 PM, Stephen Warren wrote: > >On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: > >>On 06/16/2014 10:02 PM, Stephen Warren wrote: > >>>On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: > +#ifdef CONFIG_TEGRA124_EMC >

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On 06/17/2014 06:15 PM, Stephen Warren wrote: > On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: >> On 06/16/2014 10:02 PM, Stephen Warren wrote: >>> On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: +#ifdef CONFIG_TEGRA124_EMC +int tegra124_emc_reserve_bandwidth(unsigned int consumer, unsigned

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On 06/18/2014 05:14 PM, Thierry Reding wrote: > On Wed, Jun 18, 2014 at 04:09:06PM -0600, Stephen Warren wrote: >> On 06/18/2014 04:03 PM, Thierry Reding wrote: ... >>> From what I remember, Mike was fairly strongly opposing the idea of >>> virtual clocks, but what you're proposing here sounds

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On 06/18/2014 04:19 PM, St?phane Marchesin wrote: > On Wed, Jun 18, 2014 at 3:00 PM, Thierry Reding > wrote: >> On Wed, Jun 18, 2014 at 07:23:47PM +0200, Tomeu Vizoso wrote: >>> On 06/17/2014 06:15 PM, Stephen Warren wrote: On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: > On 06/16/2014

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On 06/18/2014 04:03 PM, Thierry Reding wrote: > On Wed, Jun 18, 2014 at 11:46:49AM -0600, Stephen Warren wrote: >> On 06/18/2014 11:23 AM, Tomeu Vizoso wrote: >>> On 06/17/2014 06:15 PM, Stephen Warren wrote: On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: > On 06/16/2014 10:02 PM, Stephen

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On Wed, Jun 18, 2014 at 3:00 PM, Thierry Reding wrote: > On Wed, Jun 18, 2014 at 07:23:47PM +0200, Tomeu Vizoso wrote: >> On 06/17/2014 06:15 PM, Stephen Warren wrote: >> >On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: >> >>On 06/16/2014 10:02 PM, Stephen Warren wrote: >> >>>On 06/16/2014 07:35 AM,

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On Wed, Jun 18, 2014 at 12:35:27AM +0200, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Jun 17, 2014 at 02:16:06PM +0200, Tomeu Vizoso wrote: > > On 06/16/2014 10:02 PM, Stephen Warren wrote: > > >On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: > > >>+ > > >>+Child device nodes

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On 06/18/2014 11:23 AM, Tomeu Vizoso wrote: > On 06/17/2014 06:15 PM, Stephen Warren wrote: >> On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: >>> On 06/16/2014 10:02 PM, Stephen Warren wrote: On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: > +#ifdef CONFIG_TEGRA124_EMC > +int

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On Tue, Jun 17, 2014 at 02:16:06PM +0200, Tomeu Vizoso wrote: > On 06/16/2014 10:02 PM, Stephen Warren wrote: > >On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: > >>+ > >>+Child device nodes describe the memory settings for different > >>configurations and > >>+clock rates. > > > >How do the child

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On 06/17/2014 07:15 PM, Stephen Warren wrote: > On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: >> On 06/16/2014 10:02 PM, Stephen Warren wrote: >>> On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: > >>> This binding looks quite anaemic vs. >>>

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On 06/16/2014 10:02 PM, Stephen Warren wrote: > On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: >> + >> +Child device nodes describe the memory settings for different >> configurations and >> +clock rates. > > How do the child nodes do that? The binding needs to specify the format > of the child

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: > On 06/16/2014 10:02 PM, Stephen Warren wrote: >> On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: >> This binding looks quite anaemic vs. >> Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-emc.txt; I >> would expect that this binding needs all

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

It should be mentioned that calling clk_set_rate on the EMC clock currently does absolutely nothing (except probably returning an error). The rate switching sequence is not implemented (nor is the clock tree entirely correct. For example, the kernel thinks that PLL_M is disabled). Another

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

Adds functionality for registering memory bandwidth needs and setting the EMC clock rate based on that. Also adds API for setting floor and ceiling frequency rates. Signed-off-by: Tomeu Vizoso --- .../bindings/arm/tegra/nvidia,tegra124-emc.txt | 26 drivers/memory/Kconfig

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: > Adds functionality for registering memory bandwidth needs and setting > the EMC clock rate based on that. > > Also adds API for setting floor and ceiling frequency rates. > diff --git >