Re: [RFC PATCH 5/6] drm/qxl: don't use ttm bo->offset

2020-02-14 Thread Nirmoy
On 2/14/20 10:08 AM, Gerd Hoffmann wrote: -   if (bo->mem.mm_node) -   bo->offset = (bo->mem.start << PAGE_SHIFT) + -   bdev->man[bo->mem.mem_type].gpu_offset; -   else -   bo->offset = 0; - My assumption is (bo->tbo.offset - slot->gpu_offset

Re: [RFC PATCH 5/6] drm/qxl: don't use ttm bo->offset

2020-02-14 Thread Gerd Hoffmann
> -   if (bo->mem.mm_node) > -   bo->offset = (bo->mem.start << PAGE_SHIFT) + > -   bdev->man[bo->mem.mem_type].gpu_offset; > -   else > -   bo->offset = 0; > - > > > My assumption is > > (bo->tbo.offset - slot->gpu_offset + offset) ==

[RFC PATCH 5/6] drm/qxl: don't use ttm bo->offset

2020-02-14 Thread Nirmoy Das
Signed-off-by: Nirmoy Das --- drivers/gpu/drm/qxl/qxl_drv.h| 6 ++ drivers/gpu/drm/qxl/qxl_kms.c| 3 +++ drivers/gpu/drm/qxl/qxl_object.h | 5 - drivers/gpu/drm/qxl/qxl_ttm.c| 9 - 4 files changed, 5 insertions(+), 18 deletions(-) diff --git

Re: [RFC PATCH 5/6] drm/qxl: don't use ttm bo->offset

2020-02-13 Thread Christian König
Am 13.02.20 um 15:30 schrieb Gerd Hoffmann: @@ -311,10 +311,8 @@ qxl_bo_physical_address(struct qxl_device *qdev, struct qxl_bo *bo, (bo->tbo.mem.mem_type == TTM_PL_VRAM) ? >main_slot : >surfaces_slot; - WARN_ON_ONCE((bo->tbo.offset & slot->gpu_offset) !=

Re: [RFC PATCH 5/6] drm/qxl: don't use ttm bo->offset

2020-02-13 Thread Nirmoy
On 2/13/20 3:30 PM, Gerd Hoffmann wrote: @@ -311,10 +311,8 @@ qxl_bo_physical_address(struct qxl_device *qdev, struct qxl_bo *bo, (bo->tbo.mem.mem_type == TTM_PL_VRAM) ? >main_slot : >surfaces_slot; - WARN_ON_ONCE((bo->tbo.offset & slot->gpu_offset) !=

Re: [RFC PATCH 5/6] drm/qxl: don't use ttm bo->offset

2020-02-13 Thread Gerd Hoffmann
> @@ -311,10 +311,8 @@ qxl_bo_physical_address(struct qxl_device *qdev, struct > qxl_bo *bo, > (bo->tbo.mem.mem_type == TTM_PL_VRAM) > ? >main_slot : >surfaces_slot; > > - WARN_ON_ONCE((bo->tbo.offset & slot->gpu_offset) != slot->gpu_offset); > - > - /* TODO