Re: [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel

2023-09-18 Thread John Watts
On Wed, Sep 13, 2023 at 02:34:38PM -0700, Jessica Zhang wrote: > Hi John, > > Having a separate panel_regs_len field seems a bit unnecessary to me. > > Looks like it's only being called in the panel prepare() and I don't seen > any reason why we shouldn't just call the ARRAY_SIZE() macro there.

Re: [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel

2023-09-15 Thread Jessica Zhang
On 9/11/2023 2:02 AM, John Watts wrote: Panel initialization registers are per-display and not tied to the controller itself. Different panels will specify their own registers. Attach the sequences to the panel info struct so future panels can specify their own sequences. Signed-off-by: John

Re: [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel

2023-09-14 Thread Jessica Zhang
On 9/13/2023 9:09 PM, John Watts wrote: On Wed, Sep 13, 2023 at 02:34:38PM -0700, Jessica Zhang wrote: Hi John, Having a separate panel_regs_len field seems a bit unnecessary to me. Looks like it's only being called in the panel prepare() and I don't seen any reason why we shouldn't just ca

Re: [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel

2023-09-13 Thread Jessica Zhang
On 9/11/2023 2:02 AM, John Watts wrote: Panel initialization registers are per-display and not tied to the controller itself. Different panels will specify their own registers. Attach the sequences to the panel info struct so future panels can specify their own sequences. Signed-off-by: John

[RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel

2023-09-12 Thread John Watts
Panel initialization registers are per-display and not tied to the controller itself. Different panels will specify their own registers. Attach the sequences to the panel info struct so future panels can specify their own sequences. Signed-off-by: John Watts --- .../gpu/drm/panel/panel-newvision