Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-25 Thread Doug Anderson
Hi, On Sun, Sep 24, 2023 at 10:47 PM Laurentiu Palcu wrote: > > Hi Doug, > > On Fri, Sep 22, 2023 at 08:44:16AM -0700, Doug Anderson wrote: > > Hi, > > > > On Fri, Sep 22, 2023 at 12:56 AM Laurentiu Palcu > > wrote: > > > > > > Hi, > > > > > > On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas An

Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-24 Thread Laurentiu Palcu
Hi Doug, On Fri, Sep 22, 2023 at 08:44:16AM -0700, Doug Anderson wrote: > Hi, > > On Fri, Sep 22, 2023 at 12:56 AM Laurentiu Palcu > wrote: > > > > Hi, > > > > On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote: > > > Based on grepping through the source code this driver appears to

Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-22 Thread Doug Anderson
Hi, On Fri, Sep 22, 2023 at 12:56 AM Laurentiu Palcu wrote: > > Hi, > > On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote: > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > time. Among o

Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-22 Thread Laurentiu Palcu
Hi, On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanl

[RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call drm_atomic