Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-21 Thread Lee Jones
On Fri, 21 Jun 2024, Markus Elfring wrote: > > Sadly, I am yet to see a constructive approach or even better a helpful > > patch which improve something, rather than vague suggestions on the list > > Can you get any more constructive impressions from another data > representation? > https://git.

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-21 Thread Lee Jones
On Fri, 21 Jun 2024, Nuno Sá wrote: > On Fri, 2024-06-21 at 12:39 +0530, Vinod Koul wrote: > > On 20-06-24, 18:05, Lee Jones wrote: > > > On Thu, 20 Jun 2024, Vinod Koul wrote: > > > > > > > On 20-06-24, 12:45, Markus Elfring wrote: > > > > > … > > > > > > All errors (new ones prefixed by >>): >

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-21 Thread Markus Elfring
> Yeah, just look at how many automatic replies he get's from Greg pretty much > saying to ignore his comments. Does your feedback just indicate recurring communication difficulties? Regards, Markus

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-21 Thread Markus Elfring
> Sadly, I am yet to see a constructive approach or even better a helpful > patch which improve something, rather than vague suggestions on the list Can you get any more constructive impressions from another data representation? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/lo

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-21 Thread Nuno Sá
On Fri, 2024-06-21 at 12:39 +0530, Vinod Koul wrote: > On 20-06-24, 18:05, Lee Jones wrote: > > On Thu, 20 Jun 2024, Vinod Koul wrote: > > > > > On 20-06-24, 12:45, Markus Elfring wrote: > > > > … > > > > > All errors (new ones prefixed by >>): > > > > > > > > > > > > drivers/iio/industrialio-buf

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-21 Thread Vinod Koul
On 20-06-24, 18:05, Lee Jones wrote: > On Thu, 20 Jun 2024, Vinod Koul wrote: > > > On 20-06-24, 12:45, Markus Elfring wrote: > > > … > > > > All errors (new ones prefixed by >>): > > > > > > > >>> drivers/iio/industrialio-buffer.c:1715:3: error: cannot jump from > > > >>> this goto statement to

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-20 Thread Lee Jones
On Thu, 20 Jun 2024, Vinod Koul wrote: > On 20-06-24, 12:45, Markus Elfring wrote: > > … > > > All errors (new ones prefixed by >>): > > > > > >>> drivers/iio/industrialio-buffer.c:1715:3: error: cannot jump from this > > >>> goto statement to its label > > > 1715 | goto err_d

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-20 Thread Vinod Koul
On 20-06-24, 12:45, Markus Elfring wrote: > … > > All errors (new ones prefixed by >>): > > > >>> drivers/iio/industrialio-buffer.c:1715:3: error: cannot jump from this > >>> goto statement to its label > > 1715 | goto err_dmabuf_unmap_attachment; > … > > Which software design

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-20 Thread Markus Elfring
… > All errors (new ones prefixed by >>): > >>> drivers/iio/industrialio-buffer.c:1715:3: error: cannot jump from this goto >>> statement to its label > 1715 | goto err_dmabuf_unmap_attachment; … Which software design options would you like to try out next so that such a quest

Re: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Markus Elfring
>> … >>> +++ b/drivers/iio/industrialio-buffer.c >> … >>> +static void iio_buffer_dmabuf_release(struct kref *ref) >>> +{ >> … >>> + dma_resv_lock(dmabuf->resv, NULL); >>> + dma_buf_unmap_attachment(attach, priv->sgt, priv->dir); >>> + dma_resv_unlock(dmabuf->resv); >> … >> >> Under which cir

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Nuno Sá
On Wed, 2024-06-19 at 14:21 +0200, Paul Cercueil wrote: > Le mercredi 19 juin 2024 à 13:56 +0200, Markus Elfring a écrit : > > … > > > https://lore.kernel.org/linux-iio/219abc43b4fdd4a13b307ed2efaa0e6869e68e3f.ca...@gmail.com/T/#eefd360069c4261aec9621fafde30924706571c94 > > > > > > (and responses

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Paul Cercueil
Le mercredi 19 juin 2024 à 13:56 +0200, Markus Elfring a écrit : > … > > https://lore.kernel.org/linux-iio/219abc43b4fdd4a13b307ed2efaa0e6869e68e3f.ca...@gmail.com/T/#eefd360069c4261aec9621fafde30924706571c94 > > > > (and responses below) > > > > It's more nuanced than I remembered. > … > > > >

Re: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Paul Cercueil
Le mercredi 19 juin 2024 à 13:43 +0200, Markus Elfring a écrit : > … > > +++ b/drivers/iio/industrialio-buffer.c > … > > +static void iio_buffer_dmabuf_release(struct kref *ref) > > +{ > … > > + dma_resv_lock(dmabuf->resv, NULL); > > + dma_buf_unmap_attachment(attach, priv->sgt, priv->dir); > >

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Markus Elfring
… > https://lore.kernel.org/linux-iio/219abc43b4fdd4a13b307ed2efaa0e6869e68e3f.ca...@gmail.com/T/#eefd360069c4261aec9621fafde30924706571c94 > > (and responses below) > > It's more nuanced than I remembered. … >> * Will the desire grow for further collateral evolution according to >>   affected so

Re: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Markus Elfring
… > +++ b/drivers/iio/industrialio-buffer.c … > +static void iio_buffer_dmabuf_release(struct kref *ref) > +{ … > + dma_resv_lock(dmabuf->resv, NULL); > + dma_buf_unmap_attachment(attach, priv->sgt, priv->dir); > + dma_resv_unlock(dmabuf->resv); … Under which circumstances will another

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Paul Cercueil
Le mercredi 19 juin 2024 à 13:13 +0200, Markus Elfring a écrit : > > > Would you dare to transform the remaining goto chain into further > > > applications > > > of scope-based resource management? > > > > We discussed this after v6 or v7, DRM/DMABUF maintainers were not > > keen > > on doing that

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Markus Elfring
>> Would you dare to transform the remaining goto chain into further >> applications >> of scope-based resource management? > > We discussed this after v6 or v7, DRM/DMABUF maintainers were not keen > on doing that *just yet*. * Would you like to add any links for corresponding development discus

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Paul Cercueil
Hi Markus, Le mercredi 19 juin 2024 à 12:03 +0200, Markus Elfring a écrit : > … > > All errors (new ones prefixed by >>): > > > > > > drivers/iio/industrialio-buffer.c:1715:3: error: cannot jump > > > > from this goto statement to its label > >     1715 | goto err_dmabuf_unmap_att

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-19 Thread Markus Elfring
… > All errors (new ones prefixed by >>): > > >> drivers/iio/industrialio-buffer.c:1715:3: error: cannot jump from this > >> goto statement to its label > 1715 | goto err_dmabuf_unmap_attachment; … Would you dare to transform the remaining goto chain into further applications

Re: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-18 Thread Nuno Sá
/commits/Paul-Cercueil/dmaengine-Add-API-function-dmaengine_prep_peripheral_dma_vec/20240618-180602 > base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg > patch link:    > https://lore.kernel.org/r/20240618100302.72886-4-paul%40crapouillou.net > patch subject: [PATCH v

Re: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-18 Thread kernel test robot
/scm/linux/kernel/git/jic23/iio.git togreg patch link: https://lore.kernel.org/r/20240618100302.72886-4-paul%40crapouillou.net patch subject: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure config: x86_64-randconfig-161-20240619 (https://download.01.org/0day-ci/archiv

[PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-18 Thread Paul Cercueil
Add the necessary infrastructure to the IIO core to support a new optional DMABUF based interface. With this new interface, DMABUF objects (externally created) can be attached to a IIO buffer, and subsequently used for data transfer. A userspace application can then use this interface to share DM