Re: [PATCH v2] drm/rockchip: Use an enum to identify Rockchip VOPs

2017-10-19 Thread Mark yao
On 2017年10月20日 01:46, Kristian Høgsberg wrote: On Wed, Oct 18, 2017 at 5:49 PM, Mark yao wrote: On 2017年10月19日 01:52, Brian Norris wrote: Hi Kristian, On Thu, Nov 03, 2016 at 12:46:48PM -0700, Kristian Högsberg wrote: We used to call drm_of_encoder_active_endpoint_id() from rockchip_dp_drm_e

Re: [PATCH v2] drm/rockchip: Use an enum to identify Rockchip VOPs

2017-10-19 Thread Kristian Høgsberg
On Wed, Oct 18, 2017 at 5:49 PM, Mark yao wrote: > On 2017年10月19日 01:52, Brian Norris wrote: >> >> Hi Kristian, >> >> On Thu, Nov 03, 2016 at 12:46:48PM -0700, Kristian Högsberg wrote: >>> >>> We used to call drm_of_encoder_active_endpoint_id() from >>> rockchip_dp_drm_encoder_atomic_check() to de

Re: [PATCH v2] drm/rockchip: Use an enum to identify Rockchip VOPs

2017-10-18 Thread Mark yao
On 2017年10月19日 01:52, Brian Norris wrote: Hi Kristian, On Thu, Nov 03, 2016 at 12:46:48PM -0700, Kristian Högsberg wrote: We used to call drm_of_encoder_active_endpoint_id() from rockchip_dp_drm_encoder_atomic_check() to determine the endpoint for the active encoder. However, the encoder isn't

Re: [PATCH v2] drm/rockchip: Use an enum to identify Rockchip VOPs

2017-10-18 Thread Brian Norris
Hi Kristian, On Thu, Nov 03, 2016 at 12:46:48PM -0700, Kristian Högsberg wrote: > We used to call drm_of_encoder_active_endpoint_id() from > rockchip_dp_drm_encoder_atomic_check() to determine the endpoint for the > active encoder. However, the encoder isn't necessarily active at this > point or i

[v2] drm/rockchip: Use an enum to identify Rockchip VOPs

2016-11-08 Thread Guenter Roeck
On Thu, Nov 03, 2016 at 12:46:48PM -0700, Kristian Høgsberg wrote: > We used to call drm_of_encoder_active_endpoint_id() from > rockchip_dp_drm_encoder_atomic_check() to determine the endpoint for the > active encoder. However, the encoder isn't necessarily active at this > point or it may be co

[PATCH v2] drm/rockchip: Use an enum to identify Rockchip VOPs

2016-11-03 Thread Kristian H. Kristensen
We used to call drm_of_encoder_active_endpoint_id() from rockchip_dp_drm_encoder_atomic_check() to determine the endpoint for the active encoder. However, the encoder isn't necessarily active at this point or it may be connected to different crtc than what we're switching to. Instead, look at the c