RE: [v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-14 Thread Rajeev Nandan
Hi Dmitry, > > On Wed, 12 Jan 2022 at 19:09, Rajeev Nandan > wrote: > > > > Hi Dmitry, > > > > > > > > > > + if (phy->cfg->ops.tuning_cfg_init) > > > > + phy->cfg->ops.tuning_cfg_init(phy); > > > > > > Please rename to parse_dt_properties() or something like that. > > Sure.

RE: [v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-12 Thread Rajeev Nandan
Hi Dmitry, > > > > + if (phy->cfg->ops.tuning_cfg_init) > > + phy->cfg->ops.tuning_cfg_init(phy); > > Please rename to parse_dt_properties() or something like that. Sure. I didn't understand your comment in v1 to use config_dt() hook. I think, now I understood. This function

Re: [v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-12 Thread Dmitry Baryshkov
On Wed, 12 Jan 2022 at 19:09, Rajeev Nandan wrote: > > Hi Dmitry, > > > > > > > + if (phy->cfg->ops.tuning_cfg_init) > > > + phy->cfg->ops.tuning_cfg_init(phy); > > > > Please rename to parse_dt_properties() or something like that. > Sure. I didn't understand your comment in

[v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-12 Thread Rajeev Nandan
Add support for MSM DSI PHY tuning configuration. Current design is to support drive strength and drive level/amplitude tuning for 10nm PHY version, but this can be extended to other PHY versions. Signed-off-by: Rajeev Nandan --- Changes in v2: - New. - Split into generic code and

Re: [v2 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-10 Thread Dmitry Baryshkov
On Mon, 10 Jan 2022 at 15:56, Rajeev Nandan wrote: > > Add support for MSM DSI PHY tuning configuration. Current design is > to support drive strength and drive level/amplitude tuning for > 10nm PHY version, but this can be extended to other PHY versions. > > Signed-off-by: Rajeev Nandan > --- >