Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-25 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2021年7月25日 週日 上午1:06寫道: > > >On 12.07.21 19:16, Frank Wunderlich wrote: > >> Hi, > >> > >> it turns out that problem is the read+or of the new value > >> > >> i reverted my patch and changed > >> > >> reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val;

Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-24 Thread Frank Wunderlich
>On 12.07.21 19:16, Frank Wunderlich wrote: >> Hi, >> >> it turns out that problem is the read+or of the new value >> >> i reverted my patch and changed >> >> reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val; >> writel_relaxed(reg, mmsys->regs + routes[i].addr); >> >> to >> >>

Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-12 Thread Dafna Hirschfeld
Hi, On 12.07.21 19:16, Frank Wunderlich wrote: Hi, it turns out that problem is the read+or of the new value i reverted my patch and changed reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val; writel_relaxed(reg, mmsys->regs + routes[i].addr); to writel_relaxed(routes[i].val,

Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-12 Thread Frank Wunderlich
Hi, it turns out that problem is the read+or of the new value i reverted my patch and changed reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val; writel_relaxed(reg, mmsys->regs + routes[i].addr); to writel_relaxed(routes[i].val, mmsys->regs + routes[i].addr); and it works too,

Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-12 Thread Frank Wunderlich
> Gesendet: Montag, 12. Juli 2021 um 13:50 Uhr > Von: "Dafna Hirschfeld" > An: "Frank Wunderlich" , linux-media...@lists.infradead.org > Cc: "Frank Wunderlich" , "Matthias Brugger" > , "CK Hu" , > linux-arm-ker...@lists.infradead.org, linux-ker...@vger.kernel.org, "Enric > Balletbo Serra" , "Da