Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-21 Thread Nick Desaulniers
On Wed, Mar 20, 2019 at 2:37 AM Koenig, Christian wrote: > > Am 20.03.19 um 05:34 schrieb Nathan Chancellor: > > On Wed, Mar 20, 2019 at 01:31:27AM +, Pan, Xinhui wrote: > >> these two enumerated types are same for now. both of them might change in > >> the future. Please consider if the

Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-21 Thread Stephen Hines
cher, Alexander ; Koenig, Christian >> >> ; Zhou, David(ChunMing) ; >> >> Pan, Xinhui >> >> Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >> >> linux-ker...@vger.kernel.org; clang-built-li...@googlegroups.com >> >> Su

Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-21 Thread Nathan Chancellor
> > > >> Thanks > > >> xinhui > > >> > > >> > > >> -Original Message- > > >> From: Nathan Chancellor > > >> Sent: 2019年3月20日 8:54 > > >> To: Deucher, Alexander ; Koenig, Christian < > > chris

Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-21 Thread Stephen Hines
> >> To: Deucher, Alexander ; Koenig, Christian < > christian.koe...@amd.com>; Zhou, David(ChunMing) ; > Pan, Xinhui > >> Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > linux-ker...@vger.kernel.org; clang-built-li...@googlegroups.com > &g

RE: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-21 Thread Pan, Xinhui
@lists.freedesktop.org; linux-ker...@vger.kernel.org; clang-built-li...@googlegroups.com Subject: Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c On Wed, Mar 20, 2019 at 07:58:09AM -0700, Stephen Hines wrote: > Why are there 2 different enums for this same thing at all? By > castin

Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-20 Thread Alex Deucher
On Wed, Mar 20, 2019 at 4:49 PM Nick Desaulniers wrote: > > On Wed, Mar 20, 2019 at 2:37 AM Koenig, Christian > wrote: > > > > Am 20.03.19 um 05:34 schrieb Nathan Chancellor: > > > On Wed, Mar 20, 2019 at 01:31:27AM +, Pan, Xinhui wrote: > > >> these two enumerated types are same for now.

Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-20 Thread Koenig, Christian
n >> ; Zhou, David(ChunMing) ; >> Pan, Xinhui >> Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >> linux-ker...@vger.kernel.org; clang-built-li...@googlegroups.com >> Subject: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c >&g

Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-20 Thread Nathan Chancellor
Hi all, The introduction of this file in commit dbd249c24427 ("drm/amdgpu: add amdgpu_ras.c to support ras (v2)") introduces the following Clang warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:544:23: warning: implicit conversion from enumeration type 'enum amdgpu_ras_block' to different

Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-20 Thread Nathan Chancellor
lists.freedesktop.org; > linux-ker...@vger.kernel.org; clang-built-li...@googlegroups.com > Subject: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > > Hi all, > > The introduction of this file in commit dbd249c24427 ("drm/amdgpu: add > amdgpu_ras.c to support ras (

RE: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-19 Thread Pan, Xinhui
ent: 2019年3月20日 8:54 To: Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; Pan, Xinhui Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; clang-built-li...@googlegroups.com Subject: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ra