Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Daniel Vetter
On Sun, Feb 17, 2013 at 5:31 PM, Hugh Dickins wrote: > On Sun, 17 Feb 2013, Daniel Vetter wrote: >> On Sun, Feb 17, 2013 at 3:21 AM, Hugh Dickins wrote: >> > On Sat, 16 Feb 2013, Hugh Dickins wrote: >> >> On Sat, 16 Feb 2013, Linus Torvalds wrote: >> >> > >> >> > I think it's worth it to give the

Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Daniel Vetter
On Sun, Feb 17, 2013 at 2:38 PM, Daniel Vetter wrote: > 2. The new i915 force restore code is indeed missing a safety check > compared to the old crtc helper based one: > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 6eb3882..095094c 100644

Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Daniel Vetter
On Sun, Feb 17, 2013 at 3:21 AM, Hugh Dickins wrote: > On Sat, 16 Feb 2013, Hugh Dickins wrote: >> On Sat, 16 Feb 2013, Linus Torvalds wrote: >> > >> > I think it's worth it to give them a heads-up already. So I've cc'd >> > the main suspects here.. >> >> Okay, thanks. >> >> > >> > Daniel, Dave -

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Hugh Dickins
On Sun, 17 Feb 2013, Daniel Vetter wrote: > On Sun, Feb 17, 2013 at 3:21 AM, Hugh Dickins wrote: > > On Sat, 16 Feb 2013, Hugh Dickins wrote: > >> On Sat, 16 Feb 2013, Linus Torvalds wrote: > >> > > >> > I think it's worth it to give them a heads-up already. So I've cc'd > >> > the main suspects h

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Hugh Dickins
On Sat, 16 Feb 2013, Hugh Dickins wrote: > On Sat, 16 Feb 2013, Linus Torvalds wrote: > > > > I think it's worth it to give them a heads-up already. So I've cc'd > > the main suspects here.. > > Okay, thanks. > > > > > Daniel, Dave - any comments about a NULL fb in > > intel_choose_pipe_bpp_dit

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Hugh Dickins
On Sat, 16 Feb 2013, Linus Torvalds wrote: > On Sat, Feb 16, 2013 at 1:45 PM, Hugh Dickins wrote: > > > > I hacked around on your PM_TRACE set_magic_time() / read_magic_time() > > yesterday, to save an oopsing core kernel ip there, instead of hashed > > pm trace info (it makes sense in this case t

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Daniel Vetter
On Sun, Feb 17, 2013 at 5:31 PM, Hugh Dickins wrote: > On Sun, 17 Feb 2013, Daniel Vetter wrote: >> On Sun, Feb 17, 2013 at 3:21 AM, Hugh Dickins wrote: >> > On Sat, 16 Feb 2013, Hugh Dickins wrote: >> >> On Sat, 16 Feb 2013, Linus Torvalds wrote: >> >> > >> >> > I think it's worth it to give the

Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Hugh Dickins
On Sun, 17 Feb 2013, Daniel Vetter wrote: > On Sun, Feb 17, 2013 at 3:21 AM, Hugh Dickins wrote: > > On Sat, 16 Feb 2013, Hugh Dickins wrote: > >> On Sat, 16 Feb 2013, Linus Torvalds wrote: > >> > > >> > I think it's worth it to give them a heads-up already. So I've cc'd > >> > the main suspects h

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Daniel Vetter
On Sun, Feb 17, 2013 at 2:38 PM, Daniel Vetter wrote: > 2. The new i915 force restore code is indeed missing a safety check > compared to the old crtc helper based one: > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 6eb3882..095094c 100644 >

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-17 Thread Daniel Vetter
On Sun, Feb 17, 2013 at 3:21 AM, Hugh Dickins wrote: > On Sat, 16 Feb 2013, Hugh Dickins wrote: >> On Sat, 16 Feb 2013, Linus Torvalds wrote: >> > >> > I think it's worth it to give them a heads-up already. So I've cc'd >> > the main suspects here.. >> >> Okay, thanks. >> >> > >> > Daniel, Dave -

Debugging Thinkpad T430s occasional suspend failure.

2013-02-16 Thread Hugh Dickins
On Sat, 16 Feb 2013, Hugh Dickins wrote: > On Sat, 16 Feb 2013, Linus Torvalds wrote: > > > > I think it's worth it to give them a heads-up already. So I've cc'd > > the main suspects here.. > > Okay, thanks. > > > > > Daniel, Dave - any comments about a NULL fb in > > intel_choose_pipe_bpp_dit

Debugging Thinkpad T430s occasional suspend failure.

2013-02-16 Thread Hugh Dickins
On Sat, 16 Feb 2013, Linus Torvalds wrote: > On Sat, Feb 16, 2013 at 1:45 PM, Hugh Dickins wrote: > > > > I hacked around on your PM_TRACE set_magic_time() / read_magic_time() > > yesterday, to save an oopsing core kernel ip there, instead of hashed > > pm trace info (it makes sense in this case t

Re: Debugging Thinkpad T430s occasional suspend failure.

2013-02-16 Thread Linus Torvalds
On Sat, Feb 16, 2013 at 1:45 PM, Hugh Dickins wrote: > > I hacked around on your PM_TRACE set_magic_time() / read_magic_time() > yesterday, to save an oopsing core kernel ip there, instead of hashed > pm trace info (it makes sense in this case to invert your sequence, > putting the high order into

Debugging Thinkpad T430s occasional suspend failure.

2013-02-16 Thread Linus Torvalds
On Sat, Feb 16, 2013 at 1:45 PM, Hugh Dickins wrote: > > I hacked around on your PM_TRACE set_magic_time() / read_magic_time() > yesterday, to save an oopsing core kernel ip there, instead of hashed > pm trace info (it makes sense in this case to invert your sequence, > putting the high order into