Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Rodrigo Vivi
On Thu, Jun 30, 2022 at 05:34:22PM +0300, Jani Nikula wrote: > On Thu, 30 Jun 2022, Rodrigo Vivi wrote: > > On Thu, Jun 30, 2022 at 02:09:02PM +0100, Tvrtko Ursulin wrote: > >> > >> On 30/06/2022 12:19, Tetsuo Handa wrote: > >> > On 2022/06/30 19:17, Tvrtko Ursulin wrote: > >> > > Could you give

Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Jani Nikula
On Thu, 30 Jun 2022, Rodrigo Vivi wrote: > On Thu, Jun 30, 2022 at 02:09:02PM +0100, Tvrtko Ursulin wrote: >> >> On 30/06/2022 12:19, Tetsuo Handa wrote: >> > On 2022/06/30 19:17, Tvrtko Ursulin wrote: >> > > Could you give more context on reasoning here please? What is the >> > > difference >>

Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Rodrigo Vivi
On Thu, Jun 30, 2022 at 02:09:02PM +0100, Tvrtko Ursulin wrote: > > On 30/06/2022 12:19, Tetsuo Handa wrote: > > On 2022/06/30 19:17, Tvrtko Ursulin wrote: > > > Could you give more context on reasoning here please? What is the > > > difference > > > between using the system_wq and flushing it

Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tvrtko Ursulin
On 30/06/2022 12:19, Tetsuo Handa wrote: On 2022/06/30 19:17, Tvrtko Ursulin wrote: Could you give more context on reasoning here please? What is the difference between using the system_wq and flushing it from a random context? Or concern is about flushing from specific contexts? Excuse me,

Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tetsuo Handa
On 2022/06/30 19:17, Tvrtko Ursulin wrote: > Could you give more context on reasoning here please? What is the difference > between using the system_wq and flushing it from a random context? Or concern > is about flushing from specific contexts? Excuse me, but I couldn't catch what you want.

Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tvrtko Ursulin
On 30/06/2022 09:06, Tetsuo Handa wrote: On 2022/06/30 16:46, Tvrtko Ursulin wrote: Hi, On 10/06/2022 15:57, Tetsuo Handa wrote: Hello. Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") explains, we are removing flush_scheduled_work() calls. And now

Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tetsuo Handa
On 2022/06/30 16:46, Tvrtko Ursulin wrote: > > Hi, > > On 10/06/2022 15:57, Tetsuo Handa wrote: >> Hello. >> >> Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using >> a macro") explains, we are removing flush_scheduled_work() calls. And now >> >>

Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-30 Thread Tvrtko Ursulin
Hi, On 10/06/2022 15:57, Tetsuo Handa wrote: Hello. Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") explains, we are removing flush_scheduled_work() calls. And now drivers/gpu/drm/i915/display/intel_display.c

Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-29 Thread Tetsuo Handa
Ping? On 2022/06/10 23:57, Tetsuo Handa wrote: > Then, does this flush_scheduled_work() mean to wait all > schedule_work()/schedule_delayed_work() > calls inside drivers/gpu/drm/i915/ directory?

How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-10 Thread Tetsuo Handa
Hello. Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") explains, we are removing flush_scheduled_work() calls. And now drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/gt/selftest_execlists.c are the last flush_scheduled_work() callers which