Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Thomas Zimmermann
Hi Am 06.06.23 um 09:49 schrieb Dan Carpenter: On Tue, Jun 06, 2023 at 09:24:48AM +0200, Thomas Zimmermann wrote: Hi Am 05.06.23 um 22:19 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Monday, June 5, 2023 10:48 AM To:

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Dan Carpenter
On Tue, Jun 06, 2023 at 09:24:48AM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.06.23 um 22:19 schrieb Ruhl, Michael J: > > > -Original Message- > > > From: dri-devel On Behalf Of > > > Thomas Zimmermann > > > Sent: Monday, June 5, 2023 10:48 AM > > > To: dan...@ffwll.ch;

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-06 Thread Thomas Zimmermann
Hi Am 05.06.23 um 22:19 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Thomas Zimmermann Sent: Monday, June 5, 2023 10:48 AM To: dan...@ffwll.ch; javi...@redhat.com; s...@ravnborg.org; del...@gmx.de; geert+rene...@glider.be; l...@kernel.org;

RE: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-05 Thread Ruhl, Michael J
gmail.com; linux- >fb...@vger.kernel.org; Rich Felker ; linux- >s...@vger.kernel.org; linux-stag...@lists.linux.dev; dri- >de...@lists.freedesktop.org; John Paul Adrian Glaubitz berlin.de>; linux-o...@vger.kernel.org >Subject: Re: [PATCH 02/30] backlight/gpio_backlight: Compare against

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-05 Thread Sam Ravnborg
Hi Michael. > > > >Fixes a bug in the backlight driver and prepares fbdev for making > >struct fb_info.dev optional. > > I only see a rename from fbdev to dev... > > Is there missing code? > > Would a fixes: be useful? > > M > > >@@ -35,7 +35,7 @@ static int gpio_backlight_check_fb(struct

RE: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-05 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Thomas Zimmermann >Sent: Monday, June 5, 2023 10:48 AM >To: dan...@ffwll.ch; javi...@redhat.com; s...@ravnborg.org; >del...@gmx.de; geert+rene...@glider.be; l...@kernel.org; >daniel.thomp...@linaro.org; jingooh...@gmail.com >Cc: