RE: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2023-04-04 Thread Dexuan Cui
> From: Daniel Vetter > Sent: Tuesday, April 4, 2023 6:21 AM > ... > On Sat, 2 Jan 2021 at 07:03, Deepak Rawat wrote: > > +/* > > + * PCI/vmbus interface > > + */ > > + > > +static int hyperv_pci_probe(struct pci_dev *pdev, > > + const struct pci_device_id *ent) > > +{

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2023-04-04 Thread Daniel Vetter
Yeah way late reply, but I just stumbled over this and got a bit puzzled ... On Sat, 2 Jan 2021 at 07:03, Deepak Rawat wrote: > +/* > + * PCI/vmbus interface > + */ > + > +static int hyperv_pci_probe(struct pci_dev *pdev, > + const struct pci_device_id *ent) > +{ > +

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-05 Thread Deepak Rawat
On Tue, 2021-01-05 at 12:30 +0100, Thomas Zimmermann wrote: > Hi > > Am 05.01.21 um 12:04 schrieb Gerd Hoffmann: > >    Hi, > > > > > > It's not possible to do page flip with this virtual device. The > > > > call to > > > > SYNTHVID_VRAM_LOCATION is only honoured once. So unfortunately > > > >

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-05 Thread Thomas Zimmermann
Hi Am 05.01.21 um 12:04 schrieb Gerd Hoffmann: Hi, It's not possible to do page flip with this virtual device. The call to SYNTHVID_VRAM_LOCATION is only honoured once. So unfortunately need to use SHMEM helpers. I was thinking about using struct video_output_situation.vram_offset; in

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-05 Thread Gerd Hoffmann
Hi, > > It's not possible to do page flip with this virtual device. The call to > > SYNTHVID_VRAM_LOCATION is only honoured once. So unfortunately need to > > use SHMEM helpers. > > I was thinking about using struct video_output_situation.vram_offset; in > case you want to tinker with that.

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-05 Thread Thomas Zimmermann
Hi Am 05.01.21 um 03:27 schrieb Deepak Rawat: On Mon, 2021-01-04 at 14:03 +0100, Thomas Zimmermann wrote: Hi, I've been looking forward to this patchset. :) The code is really nice already. Thanks Thomas for the review. +config DRM_HYPERV +   tristate "DRM Support for hyperv

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-04 Thread Deepak Rawat
On Mon, 2021-01-04 at 14:03 +0100, Thomas Zimmermann wrote: > Hi, > > I've been looking forward to this patchset. :) The code is really > nice > already. Thanks Thomas for the review. > >   > > +config DRM_HYPERV > > +   tristate "DRM Support for hyperv synthetic video device" > > +  

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-04 Thread Thomas Zimmermann
Hi, I've been looking forward to this patchset. :) The code is really nice already. Am 02.01.21 um 07:03 schrieb Deepak Rawat: DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver. IIRC, this isn't