Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2023-06-08 Thread Lucas Stach
rodzovsky, Andrey > > Cc: Alex Deucher ; Chen, JingWen > ; Maling list - DRI developers > ; amd-gfx list > ; Koenig, Christian > Subject: RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." > > [AMD Official Use Only] > > Hi Daniel >

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-07 Thread Christian König
Am 07.09.21 um 10:47 schrieb Daniel Vetter: [SNIP] If we embed it, then I think it should start existing latest from drm_sched_job_arm. Maybe not yet initialized, but at least allocated. So the right thing to do here is to have the hw fence as a pointer in struct drm_sched_job. And check in drm_

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-07 Thread Daniel Vetter
On Thu, Sep 02, 2021 at 11:36:34AM -0400, Andrey Grodzovsky wrote: > > On 2021-09-02 10:28 a.m., Daniel Vetter wrote: > > On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: > > > On 2021-08-31 9:11 a.m., Daniel Vetter wrote: > > > > On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-02 Thread Andrey Grodzovsky
On 2021-09-02 10:28 a.m., Daniel Vetter wrote: On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: On 2021-08-31 9:11 a.m., Daniel Vetter wrote: On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: O

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-09-02 Thread Daniel Vetter
On Tue, Aug 31, 2021 at 02:24:52PM -0400, Andrey Grodzovsky wrote: > > On 2021-08-31 9:11 a.m., Daniel Vetter wrote: > > On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: > > > On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: > > > > On 2021-08-19 5:30 a.m., Daniel V

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-31 Thread Andrey Grodzovsky
On 2021-08-31 9:11 a.m., Daniel Vetter wrote: On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: On 2021-08-19 5:30 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: On

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-31 Thread Daniel Vetter
On Thu, Aug 26, 2021 at 11:04:14AM +0200, Daniel Vetter wrote: > On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: > > > > On 2021-08-19 5:30 a.m., Daniel Vetter wrote: > > > On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: > > > > On 2021-08-18 10:42 a.m., Danie

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-26 Thread Daniel Vetter
On Thu, Aug 19, 2021 at 11:25:09AM -0400, Andrey Grodzovsky wrote: > > On 2021-08-19 5:30 a.m., Daniel Vetter wrote: > > On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: > > > On 2021-08-18 10:42 a.m., Daniel Vetter wrote: > > > > On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-26 Thread Daniel Vetter
= sched) > > - /* > > -* Add at the head of the queue to reflect it was the > > earliest > > -* job extracted. > > - */ > > - list_add(&bad->list, &sched->pending_list); > > -

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-24 Thread Andrey Grodzovsky
odzovsky, Andrey Cc: Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list ; Koenig, Christian Subject: RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." [AMD Official Use Only] Hi Daniel Why can't we stop the scheduler thread first, s

RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-24 Thread Liu, Monk
--- Monk Liu | Cloud-GPU Core team -- -Original Message- From: Grodzovsky, Andrey Sent: Friday, August 20, 2021 10:07 PM To: Liu, Monk ; Daniel Vetter ; Koenig, Christian Cc: Alex Deucher ; Chen, JingWen ; Maling list - DRI d

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Andrey Grodzovsky
Christian Subject: RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." [AMD Official Use Only] Hi Daniel Why can't we stop the scheduler thread first, so that there's guaranteed no race? I've recently had a lot of discussions with panfrost folks ab

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Andrey Grodzovsky
age- From: Daniel Vetter Sent: Thursday, August 19, 2021 5:31 PM To: Grodzovsky, Andrey Cc: Daniel Vetter ; Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list ; Liu, Monk ; Koenig, Christian Subject: Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Jingwen Chen
loud-GPU Core team > > -- > > > > -Original Message- > > From: Liu, Monk > > Sent: Thursday, August 19, 2021 6:26 PM > > To: Daniel Vetter ; Grodzovsky, Andrey > > > > Cc: Alex Deucher ; Chen, Ji

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Christian König
--Original Message- From: Liu, Monk Sent: Thursday, August 19, 2021 6:26 PM To: Daniel Vetter ; Grodzovsky, Andrey Cc: Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list ; Koenig, Christian Subject: RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed

RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-20 Thread Liu, Monk
st 19, 2021 6:26 PM To: Daniel Vetter ; Grodzovsky, Andrey Cc: Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list ; Koenig, Christian Subject: RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." [AMD Official Use Only] Hi Daniel >>

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-19 Thread Andrey Grodzovsky
On 2021-08-19 5:30 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:42 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:32 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2

RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-19 Thread Liu, Monk
sday, August 19, 2021 5:31 PM To: Grodzovsky, Andrey Cc: Daniel Vetter ; Alex Deucher ; Chen, JingWen ; Maling list - DRI developers ; amd-gfx list ; Liu, Monk ; Koenig, Christian Subject: Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job." On Wed, Aug 18, 2021

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-19 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 10:51:00AM -0400, Andrey Grodzovsky wrote: > > On 2021-08-18 10:42 a.m., Daniel Vetter wrote: > > On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey Grodzovsky wrote: > > > On 2021-08-18 10:32 a.m., Daniel Vetter wrote: > > > > On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-19 Thread Daniel Vetter
int drm_sched_init(struct drm_gpu_scheduler *sched, > > > Thanks > > ------ > Monk Liu | Cloud-GPU Core team > -- > > -Original Message- > From: Daniel Vetter > Sent: Wednesday, Augus

RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Liu, Monk
s -- Monk Liu | Cloud-GPU Core team -- -Original Message- From: Daniel Vetter Sent: Wednesday, August 18, 2021 10:43 PM To: Grodzovsky, Andrey Cc: Daniel Vetter ; Alex Deucher ; Chen, JingWen ; Maling list -

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Andrey Grodzovsky
On 2021-08-18 10:42 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:32 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:02 a.m., Alex Deucher wrote: + dri-devel Sin

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey Grodzovsky wrote: > > On 2021-08-18 10:32 a.m., Daniel Vetter wrote: > > On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey Grodzovsky wrote: > > > On 2021-08-18 10:02 a.m., Alex Deucher wrote: > > > > > > > + dri-devel > > > > > > > > Since schedul

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Andrey Grodzovsky
On 2021-08-18 10:32 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:02 a.m., Alex Deucher wrote: + dri-devel Since scheduler is a shared component, please add dri-devel on all scheduler patches. On Wed, Aug 18, 2021 at 7:21 AM

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey Grodzovsky wrote: > On 2021-08-18 10:02 a.m., Alex Deucher wrote: > > > + dri-devel > > > > Since scheduler is a shared component, please add dri-devel on all > > scheduler patches. > > > > On Wed, Aug 18, 2021 at 7:21 AM Jingwen Chen wrote: > >

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 10:02:06AM -0400, Alex Deucher wrote: > + dri-devel > > Since scheduler is a shared component, please add dri-devel on all > scheduler patches. Do we need a MAINTAINRS entry specifically for this, or just oversight? > On Wed, Aug 18, 2021 at 7:21 AM Jingwen Chen wrote: >

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Andrey Grodzovsky
On 2021-08-18 10:02 a.m., Alex Deucher wrote: + dri-devel Since scheduler is a shared component, please add dri-devel on all scheduler patches. On Wed, Aug 18, 2021 at 7:21 AM Jingwen Chen wrote: [Why] for bailing job, this commit will delete it from pending list thus the bailing job will ne

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Alex Deucher
+ dri-devel Since scheduler is a shared component, please add dri-devel on all scheduler patches. On Wed, Aug 18, 2021 at 7:21 AM Jingwen Chen wrote: > > [Why] > for bailing job, this commit will delete it from pending list thus the > bailing job will never have a chance to be resubmitted even i