Re: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-10 Thread Jason Gunthorpe
On Thu, Nov 10, 2022 at 06:57:57AM +, Tian, Kevin wrote: > > + /* > > +* Emulation for NOIMMU is imperfect in that VFIO blocks almost all > > +* other ioctls. We let them keep working but they mostly fail since no > > +* IOAS should exist. > > +*/ > > + if (IS_ENABLED(CONFI

Re: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-10 Thread Alex Williamson
On Thu, 10 Nov 2022 06:57:57 + "Tian, Kevin" wrote: > > From: Jason Gunthorpe > > Sent: Thursday, November 10, 2022 3:53 AM > > > > On Wed, Nov 09, 2022 at 10:18:09AM -0700, Alex Williamson wrote: > > > > > DPDK supports no-iommu mode. > > > > Er? Huh? How? I thought no-iommu was for

RE: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, November 10, 2022 3:53 AM > > On Wed, Nov 09, 2022 at 10:18:09AM -0700, Alex Williamson wrote: > > > DPDK supports no-iommu mode. > > Er? Huh? How? I thought no-iommu was for applications that didn't do > DMA? How is DPDK getting packets in/out without

Re: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-09 Thread Jason Gunthorpe
On Wed, Nov 09, 2022 at 10:18:09AM -0700, Alex Williamson wrote: > DPDK supports no-iommu mode. Er? Huh? How? I thought no-iommu was for applications that didn't do DMA? How is DPDK getting packets in/out without DMA? I guess it snoops in /proc/ or something to learn PFNs of mlock'd memory? > I

Re: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-09 Thread Alex Williamson
On Tue, 8 Nov 2022 20:54:58 -0400 Jason Gunthorpe wrote: > On Tue, Nov 08, 2022 at 03:28:31PM -0700, Alex Williamson wrote: > > > Perhaps this should have been obvious, but I'm realizing that > > vfio-noiommu mode is completely missing without VFIO_CONTAINER, which > > seems a barrier to depreca

Re: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-08 Thread Jason Gunthorpe
On Tue, Nov 08, 2022 at 03:28:31PM -0700, Alex Williamson wrote: > Perhaps this should have been obvious, but I'm realizing that > vfio-noiommu mode is completely missing without VFIO_CONTAINER, which > seems a barrier to deprecating VFIO_CONTAINER and perhaps makes it a Yes, it is the same as th

Re: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-08 Thread Alex Williamson
On Mon, 7 Nov 2022 20:52:54 -0400 Jason Gunthorpe wrote: > Add a kconfig CONFIG_VFIO_CONTAINER that controls compiling the container > code. If 'n' then only iommufd will provide the container service. All the > support for vfio iommu drivers, including type1, will not be built. > > This allows