RE: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-06 Thread Flavio Suligoi
HI Daniel, ... > > ... > > > ... > > > > > > > +required: > > > > > > > + - compatible > > > > > > > + - reg > > > > > > > + - max-brightness > > > > > > > > > > > > Why is this mandatory? > > > > > > > > > > > > There's no point in setting max-brightness when running in I2C > > > > > > mode >

Re: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-05 Thread Daniel Thompson
On Wed, Oct 04, 2023 at 03:18:24PM +, Flavio Suligoi wrote: > Hi Daniel, > ... > > ... > > > > > > +required: > > > > > > + - compatible > > > > > > + - reg > > > > > > + - max-brightness > > > > > > > > > > Why is this mandatory? > > > > > > > > > > There's no point in setting

RE: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-04 Thread Flavio Suligoi
Hi Daniel, ... > ... > > > > > +required: > > > > > + - compatible > > > > > + - reg > > > > > + - max-brightness > > > > > > > > Why is this mandatory? > > > > > > > > There's no point in setting max-brightness when running in I2C > > > > mode > > > > (max- brightness should default to 31 in

RE: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-03 Thread Flavio Suligoi
Hi Daniel, ... > > > > +required: > > > > + - compatible > > > > + - reg > > > > + - max-brightness > > > > > > Why is this mandatory? > > > > > > There's no point in setting max-brightness when running in I2C mode > > > (max- brightness should default to 31 in that case). > > > > > > > > > >

RE: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-03 Thread Flavio Suligoi
Hi Daniel, ... > > +required: > > + - compatible > > + - reg > > + - max-brightness > > Why is this mandatory? > > There's no point in setting max-brightness when running in I2C mode (max- > brightness should default to 31 in that case). > > > > + - default-brightness > > Again. I'm not

Re: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-03 Thread Daniel Thompson
On Tue, Oct 03, 2023 at 09:43:15AM +, Flavio Suligoi wrote: > Hi Daniel, > > ... > > > > +required: > > > + - compatible > > > + - reg > > > + - max-brightness > > > > Why is this mandatory? > > > > There's no point in setting max-brightness when running in I2C mode (max- > > brightness

Re: [PATCH v3 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-09-26 Thread Daniel Thompson
On Mon, Sep 25, 2023 at 02:26:08PM +0200, Flavio Suligoi wrote: > The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a > programmable switching frequency to optimize efficiency. > The brightness can be controlled either by I2C commands (called "analog" > mode) or by a PWM