Re: Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-22 Thread Lucas De Marchi
On Thu, Feb 22, 2024 at 06:51:52AM -0800, Yury Norov wrote: On Mon, Feb 19, 2024 at 11:13:57PM -0600, Lucas De Marchi wrote: On Fri, Feb 09, 2024 at 08:53:25AM -0800, Yury Norov wrote: > On Wed, Feb 07, 2024 at 11:45:20PM -0800, Lucas De Marchi wrote: > > Implement fixed-type BIT() to help

Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-22 Thread Yury Norov
On Mon, Feb 19, 2024 at 11:13:57PM -0600, Lucas De Marchi wrote: > On Fri, Feb 09, 2024 at 08:53:25AM -0800, Yury Norov wrote: > > On Wed, Feb 07, 2024 at 11:45:20PM -0800, Lucas De Marchi wrote: > > > Implement fixed-type BIT() to help drivers add stricter checks, like was > > > done for GENMASK.

Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-19 Thread Lucas De Marchi
On Fri, Feb 09, 2024 at 08:53:25AM -0800, Yury Norov wrote: On Wed, Feb 07, 2024 at 11:45:20PM -0800, Lucas De Marchi wrote: Implement fixed-type BIT() to help drivers add stricter checks, like was done for GENMASK. Signed-off-by: Lucas De Marchi Acked-by: Jani Nikula So I get v1 from

RE: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-10 Thread David Laight
... > >> +#define BIT_U8(b) ((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b))) > >> +#define BIT_U16(b)((u16)(BIT_INPUT_CHECK(u16, b) + > >> BIT(b))) > >> +#define BIT_U32(b)((u32)(BIT_INPUT_CHECK(u32, b) + > >> BIT(b))) > >> +#define BIT_U64(b)

Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-09 Thread Jani Nikula
On Thu, 08 Feb 2024, Lucas De Marchi wrote: > On Thu, Feb 08, 2024 at 09:04:45PM +0100, Andi Shyti wrote: >>Hi Lucas, >> >>looks good, just one idea... >> >>... >> >>> +#define BIT_U8(b) ((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b))) >>> +#define BIT_U16(b) ((u16)(BIT_INPUT_CHECK(u16,

Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-08 Thread Lucas De Marchi
On Thu, Feb 08, 2024 at 09:04:45PM +0100, Andi Shyti wrote: Hi Lucas, looks good, just one idea... ... +#define BIT_U8(b) ((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b))) +#define BIT_U16(b) ((u16)(BIT_INPUT_CHECK(u16, b) + BIT(b))) +#define BIT_U32(b)