Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-07 Thread Diederik de Haas
On Sat Sep 7, 2024 at 5:02 AM CEST, Min-Hua Chen wrote: > >FWIW: I didn't see it either, but I assumed I was missing the right > >context (i.e. patches) needed to trigger that warning. > > I triggered the warning by the following step: > > install 'sparse' first > > ARCH=arm64 LLVM=1 make C=1 CF='-

Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Min-Hua Chen
>FWIW: I didn't see it either, but I assumed I was missing the right >context (i.e. patches) needed to trigger that warning. > FYI I triggered the warning by the following step: install 'sparse' first git clone https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git cd linux ARCH=arm6

Re:[PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Min-Hua Chen
Hi, >Hi Min Hua, > Thanks for your work > >At 2024-09-06 06:38:50, "Min-Hua Chen" wrote: >>Include rockchip_drm_drv.h to fix the follow sparse warning: >> >>drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: >>warning: symbol 'vop2_platform_driver' was not declared. >>Should it be st

Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Diederik de Haas
Hi, On Fri Sep 6, 2024 at 11:50 AM CEST, Andy Yan wrote: > At 2024-09-06 17:28:33, "Diederik de Haas" wrote: > >On Fri Sep 6, 2024 at 2:42 AM CEST, Andy Yan wrote: > >> At 2024-09-06 06:38:50, "Min-Hua Chen" wrote: > >> >Include rockchip_drm_drv.h to fix the follow sparse warning: > >> > > >> >d

Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-06 Thread Diederik de Haas
On Fri Sep 6, 2024 at 2:42 AM CEST, Andy Yan wrote: > At 2024-09-06 06:38:50, "Min-Hua Chen" wrote: > >Include rockchip_drm_drv.h to fix the follow sparse warning: > > > >drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: > >warning: symbol 'vop2_platform_driver' was not declared. > >Sho

Re:[PATCH] drm/rockchip: include rockchip_drm_drv.h

2024-09-05 Thread Andy Yan
Hi Min Hua, Thanks for your work At 2024-09-06 06:38:50, "Min-Hua Chen" wrote: >Include rockchip_drm_drv.h to fix the follow sparse warning: > >drivers/gpu/drm/rockchip/rockchip_vop2_reg.c:502:24: sparse: >warning: symbol 'vop2_platform_driver' was not declared. >Should it be static? > >No f

Re: [PATCH] drm/rockchip: include rockchip_drm_drv.h

2019-10-13 Thread Heiko Stuebner
Am Mittwoch, 9. Oktober 2019, 15:21:34 CEST schrieb Ben Dooks: > Include rockchip_drm_drv.h for definition of vop_platform_driver > to avoid the following sparse warning: > > drivers/gpu/drm/rockchip/rockchip_vop_reg.c:982:24: warning: symbol > 'vop_platform_driver' was not declared. Should it be