Re: [PATCH] omap2+: add drm device

2012-07-03 Thread Tony Lindgren
* Gross, Andy [120619 14:17]: > Tony, > > Please queue this patch at your earliest convenience. > > We had some discussion on the splitting out of the DMM/Tiler driver > from the omapdrm driver. There might be some interest in leveraging > the Tiler for omapfb. However, we agreed this can be d

Re: [PATCH] omap2+: add drm device

2012-06-19 Thread Gross, Andy
Tony, Please queue this patch at your earliest convenience. We had some discussion on the splitting out of the DMM/Tiler driver from the omapdrm driver. There might be some interest in leveraging the Tiler for omapfb. However, we agreed this can be deferred until some other device (omapfb or ot

Re: [PATCH] omap2+: add drm device

2012-06-11 Thread Rob Clark
On Wed, May 23, 2012 at 3:08 PM, Andy Gross wrote: > Register OMAP DRM/KMS platform device.  DMM is split into a > separate device using hwmod. > > Signed-off-by: Andy Gross Signed-off-by: Rob Clark > --- >  arch/arm/mach-omap2/Makefile           |    4 ++ >  arch/arm/mach-omap2/drm.c        

Re: [PATCH] omap2+: add drm device

2012-06-11 Thread Tomi Valkeinen
On Mon, 2012-06-11 at 09:51 -0500, Gross, Andy wrote: > Tomi, > > > So at this point, are you OK with deferring a split of the DMM until > it necessary to do so (if ever)? I'd like to get this patch in so > that people have a working omapdrm device when they enable the config > options. Yes, I'

Re: [PATCH] omap2+: add drm device

2012-06-11 Thread Gross, Andy
Tomi, So at this point, are you OK with deferring a split of the DMM until it necessary to do so (if ever)? I'd like to get this patch in so that people have a working omapdrm device when they enable the config options. Regards, Andy ___ dri-devel mai

Re: [PATCH] omap2+: add drm device

2012-05-25 Thread Clark, Rob
On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen wrote: > Hi, > > On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: >> Register OMAP DRM/KMS platform device.  DMM is split into a >> separate device using hwmod. >> >> Signed-off-by: Andy Gross > > > >> +static int __init omap_init_drm(void) >>

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
On Thu, 2012-05-24 at 10:09 -0500, Gross, Andy wrote: > On Thu, May 24, 2012 at 7:13 AM, Tomi Valkeinen wrote: > > On Thu, 2012-05-24 at 02:44 -0600, Rob Clark wrote: > > > >> but other drivers *can* use tiler, thanks to dmabuf.. I have omap4iss > >> v4l2 camera working w/ tiler buffers on my pand

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Gross, Andy
On Thu, May 24, 2012 at 7:13 AM, Tomi Valkeinen wrote: > On Thu, 2012-05-24 at 02:44 -0600, Rob Clark wrote: > >> but other drivers *can* use tiler, thanks to dmabuf.. I have omap4iss >> v4l2 camera working w/ tiler buffers on my pandaboard, for example. >> >> Maybe fbdev is an exception to the ru

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Gross, Andy
On Thu, May 24, 2012 at 1:01 AM, Tomi Valkeinen wrote: >> +struct omap_drm_platform_data { >> +     struct omap_kms_platform_data *kms_pdata; >> +}; > > This one is missing struct omap_dmm_platform_data *dmm_pdata, so you > didn't just move the struct. Is that on purpose? Good point. I can clean

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
On Thu, 2012-05-24 at 02:44 -0600, Rob Clark wrote: > but other drivers *can* use tiler, thanks to dmabuf.. I have omap4iss > v4l2 camera working w/ tiler buffers on my pandaboard, for example. > > Maybe fbdev is an exception to the rule because it has no way for > userspace to pass it a buffer t

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
On Thu, 2012-05-24 at 02:35 -0600, Rob Clark wrote: > On Thu, May 24, 2012 at 1:05 AM, Tomi Valkeinen wrote: > > On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: > >> On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen > >> wrote: > >> > Hi, > >> > > >> > On Wed, 2012-05-23 at 15:08 -0500, Andy

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Rob Clark
On Thu, May 24, 2012 at 1:21 AM, Tomi Valkeinen wrote: > On Thu, 2012-05-24 at 10:05 +0300, Tomi Valkeinen wrote: >> On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: >> > On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen >> > wrote: >> > > Hi, >> > > >> > > On Wed, 2012-05-23 at 15:08 -0500,

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Rob Clark
On Thu, May 24, 2012 at 1:05 AM, Tomi Valkeinen wrote: > On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: >> On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen >> wrote: >> > Hi, >> > >> > On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: >> >> Register OMAP DRM/KMS platform device.  DMM is

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
On Thu, 2012-05-24 at 10:05 +0300, Tomi Valkeinen wrote: > On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: > > On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen > > wrote: > > > Hi, > > > > > > On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: > > >> Register OMAP DRM/KMS platform device.

Re: [PATCH] omap2+: add drm device

2012-05-24 Thread Tomi Valkeinen
On Thu, 2012-05-24 at 00:27 -0600, Clark, Rob wrote: > On Thu, May 24, 2012 at 12:01 AM, Tomi Valkeinen > wrote: > > Hi, > > > > On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: > >> Register OMAP DRM/KMS platform device. DMM is split into a > >> separate device using hwmod. > >> > >> Signed

Re: [PATCH] omap2+: add drm device

2012-05-23 Thread Tomi Valkeinen
Hi, On Wed, 2012-05-23 at 15:08 -0500, Andy Gross wrote: > Register OMAP DRM/KMS platform device. DMM is split into a > separate device using hwmod. > > Signed-off-by: Andy Gross > +static int __init omap_init_drm(void) > +{ > + struct omap_hwmod *oh = NULL; > + struct platform_devic

Re: [PATCH] omap2+: add drm device

2012-03-16 Thread Tomi Valkeinen
On Thu, 2012-03-15 at 07:32 -0500, Rob Clark wrote: > On Thu, Mar 15, 2012 at 3:46 AM, Tomi Valkeinen wrote: > > On Wed, 2012-03-14 at 10:06 -0500, Rob Clark wrote: > > > >> > Well, as I said, it's not an issue for me and from my side it can be > >> > improved later. > >> > >> yeah, when CMA is ac

Re: [PATCH] omap2+: add drm device

2012-03-15 Thread Rob Clark
On Thu, Mar 15, 2012 at 3:46 AM, Tomi Valkeinen wrote: > On Wed, 2012-03-14 at 10:06 -0500, Rob Clark wrote: > >> > Well, as I said, it's not an issue for me and from my side it can be >> > improved later. >> >> yeah, when CMA is actually merged, there are a few other things I'd >> like to do to,

Re: [PATCH] omap2+: add drm device

2012-03-15 Thread Tomi Valkeinen
On Wed, 2012-03-14 at 10:06 -0500, Rob Clark wrote: > > Well, as I said, it's not an issue for me and from my side it can be > > improved later. > > yeah, when CMA is actually merged, there are a few other things I'd > like to do to, incl converting omapfb over to use CMA and remove > omap_vram..

Re: [PATCH] omap2+: add drm device

2012-03-14 Thread Rob Clark
On Wed, Mar 14, 2012 at 8:43 AM, Tomi Valkeinen wrote: > On Wed, 2012-03-14 at 08:16 -0500, Rob Clark wrote: >> On Wed, Mar 14, 2012 at 8:07 AM, Tomi Valkeinen >> wrote: >> > On Wed, 2012-03-14 at 07:55 -0500, Rob Clark wrote: >> >> On Wed, Mar 14, 2012 at 7:38 AM, Tomi Valkeinen >> >> wrote:

Re: [PATCH] omap2+: add drm device

2012-03-14 Thread Tomi Valkeinen
On Wed, 2012-03-14 at 08:16 -0500, Rob Clark wrote: > On Wed, Mar 14, 2012 at 8:07 AM, Tomi Valkeinen wrote: > > On Wed, 2012-03-14 at 07:55 -0500, Rob Clark wrote: > >> On Wed, Mar 14, 2012 at 7:38 AM, Tomi Valkeinen > >> wrote: > >> > Hi, > >> > > >> > On Tue, 2012-03-13 at 15:34 -0500, Rob Cl

Re: [PATCH] omap2+: add drm device

2012-03-14 Thread Rob Clark
On Wed, Mar 14, 2012 at 8:07 AM, Tomi Valkeinen wrote: > On Wed, 2012-03-14 at 07:55 -0500, Rob Clark wrote: >> On Wed, Mar 14, 2012 at 7:38 AM, Tomi Valkeinen >> wrote: >> > Hi, >> > >> > On Tue, 2012-03-13 at 15:34 -0500, Rob Clark wrote: >> >> From: Andy Gross >> >> >> >> Register OMAP DRM/K

Re: [PATCH] omap2+: add drm device

2012-03-14 Thread Tomi Valkeinen
On Wed, 2012-03-14 at 07:55 -0500, Rob Clark wrote: > On Wed, Mar 14, 2012 at 7:38 AM, Tomi Valkeinen wrote: > > Hi, > > > > On Tue, 2012-03-13 at 15:34 -0500, Rob Clark wrote: > >> From: Andy Gross > >> > >> Register OMAP DRM/KMS platform device, and reserve a CMA region for > >> the device to u

Re: [PATCH] omap2+: add drm device

2012-03-14 Thread Rob Clark
On Wed, Mar 14, 2012 at 7:38 AM, Tomi Valkeinen wrote: > Hi, > > On Tue, 2012-03-13 at 15:34 -0500, Rob Clark wrote: >> From: Andy Gross >> >> Register OMAP DRM/KMS platform device, and reserve a CMA region for >> the device to use for buffer allocation.  DMM is split into a >> separate device us

Re: [PATCH] omap2+: add drm device

2012-03-14 Thread Tomi Valkeinen
Hi, On Tue, 2012-03-13 at 15:34 -0500, Rob Clark wrote: > From: Andy Gross > > Register OMAP DRM/KMS platform device, and reserve a CMA region for > the device to use for buffer allocation. DMM is split into a > separate device using hwmod. What's the diff with this and the previous one? I se

Re: [PATCH] omap2+: add drm device

2012-03-07 Thread Tomi Valkeinen
On Wed, 2012-03-07 at 09:59 -0600, Gross, Andy wrote: > On Wed, Mar 7, 2012 at 6:05 AM, Tomi Valkeinen wrote: > > > > Does this "DMM has become synonymous" mean that people just started > > calling TILER DMM, and thus the name has stuck, or are there technical > > reasons to handle it as DMM in th

Re: [PATCH] omap2+: add drm device

2012-03-07 Thread Gross, Andy
On Wed, Mar 7, 2012 at 6:05 AM, Tomi Valkeinen wrote: > > Does this "DMM has become synonymous" mean that people just started > calling TILER DMM, and thus the name has stuck, or are there technical > reasons to handle it as DMM in the kernel? If the former, and if TILER > is the technically exact

Re: [PATCH] omap2+: add drm device

2012-03-07 Thread Rob Clark
On Wed, Mar 7, 2012 at 6:05 AM, Tomi Valkeinen wrote: > On Tue, 2012-03-06 at 09:50 -0600, Gross, Andy wrote: >> >> >> On Tue, Mar 6, 2012 at 8:35 AM, Tomi Valkeinen >> wrote: >> >> >>         I have to say I don't know much about DMM, but my >>         understanding is that >>         DMM is a b

Re: [PATCH] omap2+: add drm device

2012-03-07 Thread Tomi Valkeinen
On Wed, 2012-03-07 at 07:06 -0600, Rob Clark wrote: > On Wed, Mar 7, 2012 at 5:59 AM, Tomi Valkeinen wrote: > > Hmm, why does the drm core care about it? > > Because it is the one generating the bus-id.. see > drivers/gpu/drm/drm_platform.c drm_platform_set_busid() > > Anyways, it's just a deta

Re: [PATCH] omap2+: add drm device

2012-03-07 Thread Rob Clark
On Wed, Mar 7, 2012 at 5:59 AM, Tomi Valkeinen wrote: > On Tue, 2012-03-06 at 09:29 -0600, Rob Clark wrote: >> On Tue, Mar 6, 2012 at 8:35 AM, Tomi Valkeinen wrote: >> > On Tue, 2012-03-06 at 08:01 -0600, Rob Clark wrote: >> >> On Tue, Mar 6, 2012 at 7:26 AM, Tomi Valkeinen >> >> wrote: >> > >>

Re: [PATCH] omap2+: add drm device

2012-03-07 Thread Tomi Valkeinen
On Tue, 2012-03-06 at 09:50 -0600, Gross, Andy wrote: > > > On Tue, Mar 6, 2012 at 8:35 AM, Tomi Valkeinen > wrote: > > > I have to say I don't know much about DMM, but my > understanding is that > DMM is a bigger entity, of which TILER is only a small p

Re: [PATCH] omap2+: add drm device

2012-03-07 Thread Tomi Valkeinen
On Tue, 2012-03-06 at 09:29 -0600, Rob Clark wrote: > On Tue, Mar 6, 2012 at 8:35 AM, Tomi Valkeinen wrote: > > On Tue, 2012-03-06 at 08:01 -0600, Rob Clark wrote: > >> On Tue, Mar 6, 2012 at 7:26 AM, Tomi Valkeinen > >> wrote: > > > >> > Can there be more than one omapdrm device? I guess not. I

Re: [PATCH] omap2+: add drm device

2012-03-06 Thread Gross, Andy
On Tue, Mar 6, 2012 at 8:35 AM, Tomi Valkeinen wrote: > > > I have to say I don't know much about DMM, but my understanding is that > DMM is a bigger entity, of which TILER is only a small part, and DMM > manages all memory accesses. > > Can there be other users for the DMM than DRM? I know there c

Re: [PATCH] omap2+: add drm device

2012-03-06 Thread Rob Clark
On Tue, Mar 6, 2012 at 8:35 AM, Tomi Valkeinen wrote: > On Tue, 2012-03-06 at 08:01 -0600, Rob Clark wrote: >> On Tue, Mar 6, 2012 at 7:26 AM, Tomi Valkeinen wrote: > >> > Can there be more than one omapdrm device? I guess not. If so, the id >> > should be -1. >> >> in the past, we have used mult

Re: [PATCH] omap2+: add drm device

2012-03-06 Thread Tomi Valkeinen
On Tue, 2012-03-06 at 08:01 -0600, Rob Clark wrote: > On Tue, Mar 6, 2012 at 7:26 AM, Tomi Valkeinen wrote: > > Can there be more than one omapdrm device? I guess not. If so, the id > > should be -1. > > in the past, we have used multiple devices (using the platform-data to > divide up the dss r

Re: [PATCH] omap2+: add drm device

2012-03-06 Thread Rob Clark
On Tue, Mar 6, 2012 at 7:26 AM, Tomi Valkeinen wrote: > On Mon, 2012-03-05 at 10:54 -0600, Rob Clark wrote: >> From: Andy Gross >> >> Register OMAP DRM/KMS platform device, and reserve a CMA region for >> the device to use for buffer allocation.  DMM is split into a >> separate device using hwmod

Re: [PATCH] omap2+: add drm device

2012-03-06 Thread Tomi Valkeinen
On Mon, 2012-03-05 at 10:54 -0600, Rob Clark wrote: > From: Andy Gross > > Register OMAP DRM/KMS platform device, and reserve a CMA region for > the device to use for buffer allocation. DMM is split into a > separate device using hwmod. > > Signed-off-by: Andy Gross > Signed-off-by: Rob Clark

Re: [PATCH] omap2+: add drm device

2012-03-05 Thread Tony Lindgren
* Rob Clark [120305 08:24]: > From: Andy Gross > > Register OMAP DRM/KMS platform device, and reserve a CMA region for > the device to use for buffer allocation. DMM is split into a > separate device using hwmod. > --- a/arch/arm/plat-omap/common.c > +++ b/arch/arm/plat-omap/common.c > @@ -21,1

Re: [PATCH] omap2+: add drm device

2012-03-05 Thread Rob Clark
On Mon, Mar 5, 2012 at 6:10 PM, Tony Lindgren wrote: > * Rob Clark [120305 08:24]: >> From: Andy Gross >> >> Register OMAP DRM/KMS platform device, and reserve a CMA region for >> the device to use for buffer allocation.  DMM is split into a >> separate device using hwmod. >> --- a/arch/arm/plat