Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-16 Thread Daniel Vetter
On Mon, Apr 15, 2019 at 10:30:14AM +0100, Steven Price wrote: > On 15/04/2019 10:18, Daniel Vetter wrote: > > On Fri, Apr 05, 2019 at 05:42:33PM +0100, Steven Price wrote: > >> On 05/04/2019 17:16, Alyssa Rosenzweig wrote: > >>> acronym once ever and have it as a "??"), I'm not sure how to respond

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-16 Thread Steven Price
On 15/04/2019 10:18, Daniel Vetter wrote: > On Fri, Apr 05, 2019 at 05:42:33PM +0100, Steven Price wrote: >> On 05/04/2019 17:16, Alyssa Rosenzweig wrote: >>> acronym once ever and have it as a "??"), I'm not sure how to respond to >>> that... We don't know how to allocate memory for the

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-15 Thread Daniel Vetter
On Fri, Apr 05, 2019 at 05:42:33PM +0100, Steven Price wrote: > On 05/04/2019 17:16, Alyssa Rosenzweig wrote: > > acronym once ever and have it as a "??"), I'm not sure how to respond to > > that... We don't know how to allocate memory for the GPU-internal data > > structures (the tiler heap, for

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-11 Thread Steven Price
On 09/04/2019 17:15, Rob Herring wrote: > On Tue, Apr 9, 2019 at 10:56 AM Tomeu Vizoso > wrote: >> >> On Mon, 8 Apr 2019 at 23:04, Rob Herring wrote: >>> >>> On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: On 01/04/2019 08:47, Rob Herring wrote: > This adds the initial driver

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-11 Thread Steven Price
On 08/04/2019 22:04, Rob Herring wrote: > On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: >> >> On 01/04/2019 08:47, Rob Herring wrote: >>> This adds the initial driver for panfrost which supports Arm Mali >>> Midgard and Bifrost family of GPUs. Currently, only the T860 and >>> T760 Midgard

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-10 Thread Tomeu Vizoso
On Wed, 10 Apr 2019 at 12:20, Steven Price wrote: > > On 08/04/2019 22:04, Rob Herring wrote: > > On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > >> > >> On 01/04/2019 08:47, Rob Herring wrote: > >>> This adds the initial driver for panfrost which supports Arm Mali > >>> Midgard and Bifrost

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-09 Thread Rob Herring
On Tue, Apr 9, 2019 at 10:56 AM Tomeu Vizoso wrote: > > On Mon, 8 Apr 2019 at 23:04, Rob Herring wrote: > > > > On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > > > > > > On 01/04/2019 08:47, Rob Herring wrote: > > > > This adds the initial driver for panfrost which supports Arm Mali > > >

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-09 Thread Tomeu Vizoso
On Mon, 8 Apr 2019 at 23:04, Rob Herring wrote: > > On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > > > > On 01/04/2019 08:47, Rob Herring wrote: > > > This adds the initial driver for panfrost which supports Arm Mali > > > Midgard and Bifrost family of GPUs. Currently, only the T860 and >

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-08 Thread Rob Herring
On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > > On 01/04/2019 08:47, Rob Herring wrote: > > This adds the initial driver for panfrost which supports Arm Mali > > Midgard and Bifrost family of GPUs. Currently, only the T860 and > > T760 Midgard GPUs have been tested. [...] > > + case

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-08 Thread Steven Price
On 05/04/2019 17:16, Alyssa Rosenzweig wrote: >> I'm also somewhat surprised that you don't need loads of other >> properties from the GPU - in particular knowing the number of shader >> cores is useful for allocating the right amount of memory for TLS (and >> can't be obtained purely from the

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-08 Thread Alyssa Rosenzweig
> I'm also somewhat surprised that you don't need loads of other > properties from the GPU - in particular knowing the number of shader > cores is useful for allocating the right amount of memory for TLS (and > can't be obtained purely from the GPU_ID). Since I have no idea what TLS is (and in my

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-08 Thread Alyssa Rosenzweig
> Sorry - "Thread Local Storage" - e.g. registers spilled to memory from a > shader program. Gotcha, thank you. Register spilling isn't implemented yet, so I haven't run into this. (Partially because the blob's RA is very good so it's somewhat nontrivial to get it to spill... not that I've tried,

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-05 Thread Robin Murphy
On 03/04/2019 05:57, Rob Herring wrote: [...] +static int panfrost_clk_init(struct panfrost_device *pfdev) +{ + int err; + unsigned long rate; + + pfdev->clock = devm_clk_get(pfdev->dev, NULL); + if (IS_ERR(pfdev->clock)) { The DT binding says clocks are optional, but this

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-02 Thread Rob Herring
On Mon, Apr 1, 2019 at 2:12 PM Robin Murphy wrote: > > On 01/04/2019 08:47, Rob Herring wrote: > > This adds the initial driver for panfrost which supports Arm Mali > > Midgard and Bifrost family of GPUs. Currently, only the T860 and > > T760 Midgard GPUs have been tested. > > FWIW, on an antique

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-02 Thread Robin Murphy
On 02/04/2019 01:33, Alyssa Rosenzweig wrote: the userspace definitely doesn't support T624 This is true, yes. Shouldn't be too hard to backport; if there's still interest in Midgard 1st/2nd gen, I suppose I can grab hardware and sort it out... I'm quite likely the only person trying this on

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-02 Thread Alyssa Rosenzweig
> the userspace definitely doesn't support T624 This is true, yes. Shouldn't be too hard to backport; if there's still interest in Midgard 1st/2nd gen, I suppose I can grab hardware and sort it out... > You probably want a dma_set_mask_and_coherent() call for your 'real' output > address size

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-01 Thread Robin Murphy
On 01/04/2019 09:24, Neil Armstrong wrote: On 01/04/2019 09:47, Rob Herring wrote: This adds the initial driver for panfrost which supports Arm Mali Midgard and Bifrost family of GPUs. Currently, only the T860 and T760 Midgard GPUs have been tested. v2: - Add GPU reset on job hangs (Tomeu) -

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-01 Thread Robin Murphy
On 01/04/2019 08:47, Rob Herring wrote: This adds the initial driver for panfrost which supports Arm Mali Midgard and Bifrost family of GPUs. Currently, only the T860 and T760 Midgard GPUs have been tested. FWIW, on an antique T624 (Juno) it seems to work no worse than the kbase driver plus

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-01 Thread Eric Anholt
Rob Herring writes: > This adds the initial driver for panfrost which supports Arm Mali > Midgard and Bifrost family of GPUs. Currently, only the T860 and > T760 Midgard GPUs have been tested. > > v2: > - Add GPU reset on job hangs (Tomeu) > - Add RuntimePM and devfreq support (Tomeu) > - Fix

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-01 Thread Neil Armstrong
On 01/04/2019 09:47, Rob Herring wrote: > This adds the initial driver for panfrost which supports Arm Mali > Midgard and Bifrost family of GPUs. Currently, only the T860 and > T760 Midgard GPUs have been tested. > > v2: > - Add GPU reset on job hangs (Tomeu) > - Add RuntimePM and devfreq support