Re: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-18 Thread Neil Armstrong
Hi, On 16/10/2021 00:34, Martin Blumenstingl wrote: > Hi Neil, Hi Sam, > > On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong > wrote: > [...] >> +static const struct drm_bridge_funcs meson_encoder_cvbs_bridge_funcs = { >> + .attach = meson_encoder_cvbs_attach, >> + .enable =

Re: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Martin Blumenstingl
Hi Neil, Hi Sam, On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: [...] > +static const struct drm_bridge_funcs meson_encoder_cvbs_bridge_funcs = { > + .attach = meson_encoder_cvbs_attach, > + .enable = meson_encoder_cvbs_enable, > + .disable = meson_encoder_cvbs_disable,

Re: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR

2021-10-15 Thread Martin Blumenstingl
On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong wrote: > > Drop the local connector and move all callback to bridge funcs in order > to leverage the generic CVBS display connector. > > This will also permit adding custom cvbs connectors for ADC based HPD > detection on some Amlogic SoC based