Re: [PATCH v2 6/8] drm: vkms: Refactor the plane composer to accept new formats

2021-11-12 Thread Igor Torrente
Hi Pekka, On Thu, Nov 11, 2021 at 11:37 AM Pekka Paalanen wrote: > > On Thu, 11 Nov 2021 11:07:21 -0300 > Igor Torrente wrote: > > > Hi Pekka, > > > > On Thu, Nov 11, 2021 at 6:33 AM Pekka Paalanen wrote: > > > > > > On Wed, 10 Nov 2021 13:56:54 -0300 > > > Igor Torrente wrote: > > > > > > > O

Re: [PATCH v2 6/8] drm: vkms: Refactor the plane composer to accept new formats

2021-11-11 Thread Pekka Paalanen
On Thu, 11 Nov 2021 11:07:21 -0300 Igor Torrente wrote: > Hi Pekka, > > On Thu, Nov 11, 2021 at 6:33 AM Pekka Paalanen wrote: > > > > On Wed, 10 Nov 2021 13:56:54 -0300 > > Igor Torrente wrote: > > > > > On Tue, Nov 9, 2021 at 8:40 AM Pekka Paalanen > > > wrote: > > > > > > > > Hi Igor,

Re: [PATCH v2 6/8] drm: vkms: Refactor the plane composer to accept new formats

2021-11-11 Thread Igor Torrente
Hi Pekka, On Thu, Nov 11, 2021 at 6:33 AM Pekka Paalanen wrote: > > On Wed, 10 Nov 2021 13:56:54 -0300 > Igor Torrente wrote: > > > On Tue, Nov 9, 2021 at 8:40 AM Pekka Paalanen wrote: > > > > > > Hi Igor, > > > > > > again, that is a really nice speed-up. Unfortunately, I find the code > > > r

Re: [PATCH v2 6/8] drm: vkms: Refactor the plane composer to accept new formats

2021-11-11 Thread Pekka Paalanen
On Wed, 10 Nov 2021 13:56:54 -0300 Igor Torrente wrote: > On Tue, Nov 9, 2021 at 8:40 AM Pekka Paalanen wrote: > > > > Hi Igor, > > > > again, that is a really nice speed-up. Unfortunately, I find the code > > rather messy and hard to follow. I hope my comments below help with > > re-designing i

Re: [PATCH v2 6/8] drm: vkms: Refactor the plane composer to accept new formats

2021-11-10 Thread Igor Torrente
On Tue, Nov 9, 2021 at 8:40 AM Pekka Paalanen wrote: > > Hi Igor, > > again, that is a really nice speed-up. Unfortunately, I find the code > rather messy and hard to follow. I hope my comments below help with > re-designing it to be easier to understand. > > > On Tue, 26 Oct 2021 08:34:06 -0300 >

Re: [PATCH v2 6/8] drm: vkms: Refactor the plane composer to accept new formats

2021-11-09 Thread Pekka Paalanen
Hi Igor, again, that is a really nice speed-up. Unfortunately, I find the code rather messy and hard to follow. I hope my comments below help with re-designing it to be easier to understand. On Tue, 26 Oct 2021 08:34:06 -0300 Igor Torrente wrote: > Currently the blend function only accepts XRG