Re: [PATCH v4 3/6] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-17 Thread Nirmoy Das
Thanks for cleaning this. With Matt's suggestion, this is Reviewed-by: Nirmoy Das On 7/17/2023 7:30 PM, Andi Shyti wrote: In preparation of the next patch allign with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in

Re: [PATCH v4 3/6] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-17 Thread Matt Roper
On Mon, Jul 17, 2023 at 07:30:56PM +0200, Andi Shyti wrote: > In preparation of the next patch allign with the datasheet (BSPEC s/allign/align/ Otherwise, Reviewed-by: Matt Roper > 47112) with the naming of the pipe control set of flag values. > The variable "flags" in gen12_emit_flush_rcs()

Re: [PATCH v4 3/6] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-17 Thread Andi Shyti
Hi, On Mon, Jul 17, 2023 at 07:30:56PM +0200, Andi Shyti wrote: > In preparation of the next patch allign with the datasheet (BSPEC > 47112) with the naming of the pipe control set of flag values. > The variable "flags" in gen12_emit_flush_rcs() is applied as a > set of flags called Bit Group 1.