Re: Warnings in DRM code when removing/unbinding a driver

2020-01-13 Thread Thomas Zimmermann
Hi John Am 10.01.20 um 13:54 schrieb John Garry: > > > Hi Thomas, > >> drm-tip now contains > > I have tested today's linux-next, which includes this: > >> >> commit a88248506a2bcfeaef6837a53cde19fe11970e6c >> Author: Thomas Zimmermann >> Date:   Tue Dec 3 09:38:15 2019 +0100 >> >> drm/

Re: Warnings in DRM code when removing/unbinding a driver

2020-01-12 Thread John Garry
Hi Thomas, drm-tip now contains I have tested today's linux-next, which includes this: commit a88248506a2bcfeaef6837a53cde19fe11970e6c Author: Thomas Zimmermann Date: Tue Dec 3 09:38:15 2019 +0100 drm/hisilicon/hibmc: Switch to generic fbdev emulation which removes this entire c

Re: Warnings in DRM code when removing/unbinding a driver

2020-01-10 Thread Thomas Zimmermann
Hi John Am 16.12.19 um 18:23 schrieb John Garry: > Hi all, > > Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system > with the HIBMC hw: > > [   27.788806] WARNING: CPU: 24 PID: 1 at > drivers/gpu/drm/drm_gem_vram_helper.c:564 bo_driver_move_notify+0x8c/0x98 > [   27.798969] Mo

Re: SIGBUS on device disappearance (Re: Warnings in DRM code when removing/unbinding a driver)

2020-01-07 Thread Daniel Vetter
On Mon, Dec 23, 2019 at 11:00:15AM +0200, Pekka Paalanen wrote: > On Thu, 19 Dec 2019 13:42:33 +0100 > Daniel Vetter wrote: > > > On Thu, Dec 19, 2019 at 12:32 PM Gerd Hoffmann wrote: > > > > > > While being at it: How would a driver cleanup properly cleanup gem > > > objects created by userspa

SIGBUS on device disappearance (Re: Warnings in DRM code when removing/unbinding a driver)

2019-12-23 Thread Pekka Paalanen
On Thu, 19 Dec 2019 13:42:33 +0100 Daniel Vetter wrote: > On Thu, Dec 19, 2019 at 12:32 PM Gerd Hoffmann wrote: > > > > While being at it: How would a driver cleanup properly cleanup gem > > objects created by userspace on hotunbind? Specifically a gem object > > pinned to vram? > > Two thi

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-23 Thread John Garry
On 19/12/2019 09:54, Daniel Vetter wrote: On Wed, Dec 18, 2019 at 7:08 PM John Garry wrote: + So the v5.4 kernel does not have this issue. I have bisected the initial occurrence to: commit 37a48adfba6cf6e87df9ba8b75ab85d514ed86d8 Author: Thomas Zimmermann Date: Fri Sep 6 14:20:53 2019 +0

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-19 Thread Daniel Vetter
On Thu, Dec 19, 2019 at 12:32 PM Gerd Hoffmann wrote: > > Hi, > > > > Like I said, for most drivers > > > > you can pretty much assume that their unload sequence has been broken > > > > since forever. It's not often tested, and especially the hotunbind > > > > from a device (as opposed to driv

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-19 Thread Gerd Hoffmann
Hi, > > Like I said, for most drivers > > > you can pretty much assume that their unload sequence has been broken > > > since forever. It's not often tested, and especially the hotunbind > > > from a device (as opposed to driver unload) stuff wasn't even possible > > > to get right until just

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-19 Thread Daniel Vetter
On Thu, Dec 19, 2019 at 11:03 AM John Garry wrote: > > On 19/12/2019 09:54, Daniel Vetter wrote: > > On Wed, Dec 18, 2019 at 7:08 PM John Garry wrote: > >> > >> + > >> > >> So the v5.4 kernel does not have this issue. > >> > >> I have bisected the initial occurrence to: > >> > >> commit 37a48adfb

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-19 Thread Daniel Vetter
On Wed, Dec 18, 2019 at 7:08 PM John Garry wrote: > > + > > So the v5.4 kernel does not have this issue. > > I have bisected the initial occurrence to: > > commit 37a48adfba6cf6e87df9ba8b75ab85d514ed86d8 > Author: Thomas Zimmermann > Date: Fri Sep 6 14:20:53 2019 +0200 > > drm/vram: Add km

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-19 Thread John Garry
+ So the v5.4 kernel does not have this issue. I have bisected the initial occurrence to: commit 37a48adfba6cf6e87df9ba8b75ab85d514ed86d8 Author: Thomas Zimmermann Date: Fri Sep 6 14:20:53 2019 +0200 drm/vram: Add kmap ref-counting to GEM VRAM objects The kmap and kunmap operations

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-18 Thread John Garry
Hi Ezequiel, On Mon, 2019-12-16 at 17:23 +, John Garry wrote: Hi all, Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system with the HIBMC hw: [ 27.788806] WARNING: CPU: 24 PID: 1 at drivers/gpu/drm/drm_gem_vram_helper.c:564 bo_driver_move_notify+0x8c/0x98 A total sho

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-18 Thread John Garry
On 16/12/2019 17:23, John Garry wrote: +, - Hi all, xinliang is bouncing. We need to get his new mail address. John Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system with the HIBMC hw: [   27.788806] WARNING: CPU: 24 PID: 1 at drivers/gpu/drm/drm_gem_vram_helpe

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-17 Thread Ezequiel Garcia
Hi John, On Mon, 2019-12-16 at 17:23 +, John Garry wrote: > Hi all, > > Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system > with the HIBMC hw: > > [ 27.788806] WARNING: CPU: 24 PID: 1 at > drivers/gpu/drm/drm_gem_vram_helper.c:564 bo_driver_move_notify+0x8c/0x98 A t

Re: Warnings in DRM code when removing/unbinding a driver

2019-12-17 Thread Daniel Vetter
On Tue, Dec 17, 2019 at 09:20:43AM +, John Garry wrote: > On 16/12/2019 17:23, John Garry wrote: > > +, - > > > Hi all, > > xinliang is bouncing. We need to get his new > mail address. > > John > > > > > Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system > > with the

Warnings in DRM code when removing/unbinding a driver

2019-12-17 Thread John Garry
Hi all, Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system with the HIBMC hw: [ 27.788806] WARNING: CPU: 24 PID: 1 at drivers/gpu/drm/drm_gem_vram_helper.c:564 bo_driver_move_notify+0x8c/0x98 [ 27.798969] Modules linked in: [ 27.802018] CPU: 24 PID: 1 Comm: swapper/