Why do flush page cache twice when change TT's cache attribute

2012-03-21 Thread Scott Fang
yes, flush page twice cause system slow in some CPU. Meanwhile, set_memory_uc/wc doesn't only do flush page cache, but also change page table attribute, so your solution seems to have some problem. 2012/3/20 Konrad Rzeszutek Wilk > On Tue, Mar 20, 2012 at 10:15:02AM +0800, Scott Fang wrote: > >

Re: Why do flush page cache twice when change TT's cache attribute

2012-03-20 Thread Scott Fang
yes, flush page twice cause system slow in some CPU. Meanwhile, set_memory_uc/wc doesn't only do flush page cache, but also change page table attribute, so your solution seems to have some problem. 2012/3/20 Konrad Rzeszutek Wilk > On Tue, Mar 20, 2012 at 10:15:02AM +0800, Scott Fang wrote: > >

Why do flush page cache twice when change TT's cache attribute

2012-03-20 Thread Konrad Rzeszutek Wilk
On Tue, Mar 20, 2012 at 10:15:02AM +0800, Scott Fang wrote: > Can I do the optimization like: > > if (ttm->caching_state == tt_cached) > -drm_clflush_pages(ttm->pages, ttm->num_pages); > +for (i = 0; i < ttm->num_pages; ++i) > + if (PageHighMem(ttm->pages[i])) > +

Why do flush page cache twice when change TT's cache attribute

2012-03-20 Thread Scott Fang
Can I do the optimization like: if (ttm->caching_state == tt_cached) -drm_clflush_pages(ttm->pages, ttm->num_pages); +for (i = 0; i < ttm->num_pages; ++i) + if (PageHighMem(ttm->pages[i])) +drm_clflush_pages(&ttm->pages[i], 1); only do flush cache wh

Re: Why do flush page cache twice when change TT's cache attribute

2012-03-20 Thread Konrad Rzeszutek Wilk
On Tue, Mar 20, 2012 at 10:15:02AM +0800, Scott Fang wrote: > Can I do the optimization like: > > if (ttm->caching_state == tt_cached) > -drm_clflush_pages(ttm->pages, ttm->num_pages); > +for (i = 0; i < ttm->num_pages; ++i) > + if (PageHighMem(ttm->pages[i])) > +

Why do flush page cache twice when change TT's cache attribute

2012-03-19 Thread Scott Fang
typo error. abundant=>redundant 2012/3/19 Scott Fang > In function ttm_tt_set_caching > ,,, > > if (ttm->caching_state == tt_cached) > drm_clflush_pages(ttm->pages, ttm->num_pages); > > for (i = 0; i < ttm->num_pages; ++i) { > cur_page = ttm->pages[i]; > if (l

Why do flush page cache twice when change TT's cache attribute

2012-03-19 Thread Scott Fang
In function ttm_tt_set_caching ,,, if (ttm->caching_state == tt_cached) drm_clflush_pages(ttm->pages, ttm->num_pages); for (i = 0; i < ttm->num_pages; ++i) { cur_page = ttm->pages[i]; if (likely(cur_page != NULL)) { ret = ttm_tt_set_page_caching(cur

Re: Why do flush page cache twice when change TT's cache attribute

2012-03-19 Thread Scott Fang
Can I do the optimization like: if (ttm->caching_state == tt_cached) -drm_clflush_pages(ttm->pages, ttm->num_pages); +for (i = 0; i < ttm->num_pages; ++i) + if (PageHighMem(ttm->pages[i])) +drm_clflush_pages(&ttm->pages[i], 1); only do flush cache wh

Why do flush page cache twice when change TT's cache attribute

2012-03-19 Thread Jerome Glisse
On Mon, 2012-03-19 at 23:11 +0800, Scott Fang wrote: > In function ttm_tt_set_caching > ,,, > > if (ttm->caching_state == tt_cached) > drm_clflush_pages(ttm->pages, ttm->num_pages); > > for (i = 0; i < ttm->num_pages; ++i) { > cur_page = ttm->pages[i]; > if (li

Re: Why do flush page cache twice when change TT's cache attribute

2012-03-19 Thread Jerome Glisse
On Mon, 2012-03-19 at 23:11 +0800, Scott Fang wrote: > In function ttm_tt_set_caching > ,,, > > if (ttm->caching_state == tt_cached) > drm_clflush_pages(ttm->pages, ttm->num_pages); > > for (i = 0; i < ttm->num_pages; ++i) { > cur_page = ttm->pages[i]; > if (li

Re: Why do flush page cache twice when change TT's cache attribute

2012-03-19 Thread Scott Fang
typo error. abundant=>redundant 2012/3/19 Scott Fang > In function ttm_tt_set_caching > ,,, > > if (ttm->caching_state == tt_cached) > drm_clflush_pages(ttm->pages, ttm->num_pages); > > for (i = 0; i < ttm->num_pages; ++i) { > cur_page = ttm->pages[i]; > if (l

Why do flush page cache twice when change TT's cache attribute

2012-03-19 Thread Scott Fang
In function ttm_tt_set_caching ,,, if (ttm->caching_state == tt_cached) drm_clflush_pages(ttm->pages, ttm->num_pages); for (i = 0; i < ttm->num_pages; ++i) { cur_page = ttm->pages[i]; if (likely(cur_page != NULL)) { ret = ttm_tt_set_page_caching(cur