Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > For reference below the updated commit message. > > Cheers, Daniel > > Author: Jiri Kosina > Date: Tue Mar 19 09:56:57 2013 +0100 > > drm/i915: stop using GMBUS IRQs on Gen4 chips > > Commit 28c70f162 ("drm/i915: use the gmbus irq for wai

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Daniel Vetter
On Tue, Mar 19, 2013 at 4:38 PM, Alan Stern wrote: > On Tue, 19 Mar 2013, Daniel Vetter wrote: > >> For reference below the updated commit message. >> >> Cheers, Daniel >> >> Author: Jiri Kosina >> Date: Tue Mar 19 09:56:57 2013 +0100 > >> >> drm/i915: stop using GMBUS IRQs on Gen4 chips >>

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > > That might be misleading. It's possible that the erroneous IRQs _are_ > > being issued but you're simply not aware of them. If the kernel thinks > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > I guess I should have phras

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Yinghai Lu
On Tue, Mar 19, 2013 at 9:54 AM, Daniel Vetter wrote: > I guess I should have phrased it more precisely, but that's exactly > what I expect is happening on my machine: I don't have anything on > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > the irq is completely disabled

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Alan Stern wrote: > > > That might be misleading. It's possible that the erroneous IRQs _are_ > > > being issued but you're simply not aware of them. If the kernel thinks > > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > > > I guess I should hav

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Alan Stern
On Wed, 20 Mar 2013, Jiri Kosina wrote: > > I don't know of any way. In fact, I have been thinking of writing a > > test driver module, with a module parameter telling it which IRQ number > > to register for. It seems like the sort of thing that would be useful > > to have, from time to time.

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Yinghai Lu wrote: > > I guess I should have phrased it more precisely, but that's exactly > > what I expect is happening on my machine: I don't have anything on > > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > > the irq is completely disabled. Which

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-24 Thread Shawn Starr
On Tuesday, March 19, 2013 04:12:18 PM Daniel Vetter wrote: > On Tue, Mar 19, 2013 at 10:03 AM, Chris Wilson wrote: > >> > How about just using: > >> > if (!HAS_GMBUS_IRQ(dev_priv->dev)) gmbus4_irq_en = 0; > >> > > >> > and the existing wait loop? > >> > >> I explicitly wanted to avoid touchi

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > For reference below the updated commit message. > > Cheers, Daniel > > Author: Jiri Kosina > Date: Tue Mar 19 09:56:57 2013 +0100 > > drm/i915: stop using GMBUS IRQs on Gen4 chips > > Commit 28c70f162 ("drm/i915: use the gmbus irq for wai

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Daniel Vetter
On Tue, Mar 19, 2013 at 4:38 PM, Alan Stern wrote: > On Tue, 19 Mar 2013, Daniel Vetter wrote: > >> For reference below the updated commit message. >> >> Cheers, Daniel >> >> Author: Jiri Kosina >> Date: Tue Mar 19 09:56:57 2013 +0100 > >> >> drm/i915: stop using GMBUS IRQs on Gen4 chips >>

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > > That might be misleading. It's possible that the erroneous IRQs _are_ > > being issued but you're simply not aware of them. If the kernel thinks > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > I guess I should have phras

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Yinghai Lu
On Tue, Mar 19, 2013 at 9:54 AM, Daniel Vetter wrote: > I guess I should have phrased it more precisely, but that's exactly > what I expect is happening on my machine: I don't have anything on > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > the irq is completely disabled

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Alan Stern wrote: > > > That might be misleading. It's possible that the erroneous IRQs _are_ > > > being issued but you're simply not aware of them. If the kernel thinks > > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > > > I guess I should hav

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Alan Stern
On Wed, 20 Mar 2013, Jiri Kosina wrote: > > I don't know of any way. In fact, I have been thinking of writing a > > test driver module, with a module parameter telling it which IRQ number > > to register for. It seems like the sort of thing that would be useful > > to have, from time to time.

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Yinghai Lu wrote: > > I guess I should have phrased it more precisely, but that's exactly > > what I expect is happening on my machine: I don't have anything on > > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > > the irq is completely disabled. Which

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-24 Thread Shawn Starr
On Tuesday, March 19, 2013 04:12:18 PM Daniel Vetter wrote: > On Tue, Mar 19, 2013 at 10:03 AM, Chris Wilson wrote: > >> > How about just using: > >> > if (!HAS_GMBUS_IRQ(dev_priv->dev)) gmbus4_irq_en = 0; > >> > > >> > and the existing wait loop? > >> > >> I explicitly wanted to avoid touchi

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > For reference below the updated commit message. > > Cheers, Daniel > > Author: Jiri Kosina > Date: Tue Mar 19 09:56:57 2013 +0100 > > drm/i915: stop using GMBUS IRQs on Gen4 chips > > Commit 28c70f162 ("drm/i915: use the gmbus irq for wai

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Daniel Vetter
On Tue, Mar 19, 2013 at 4:38 PM, Alan Stern wrote: > On Tue, 19 Mar 2013, Daniel Vetter wrote: > >> For reference below the updated commit message. >> >> Cheers, Daniel >> >> Author: Jiri Kosina >> Date: Tue Mar 19 09:56:57 2013 +0100 > >> >> drm/i915: stop using GMBUS IRQs on Gen4 chips >>

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > > That might be misleading. It's possible that the erroneous IRQs _are_ > > being issued but you're simply not aware of them. If the kernel thinks > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > I guess I should have phras

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Yinghai Lu
On Tue, Mar 19, 2013 at 9:54 AM, Daniel Vetter wrote: > I guess I should have phrased it more precisely, but that's exactly > what I expect is happening on my machine: I don't have anything on > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > the irq is completely disabled

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Alan Stern wrote: > > > That might be misleading. It's possible that the erroneous IRQs _are_ > > > being issued but you're simply not aware of them. If the kernel thinks > > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > > > I guess I should hav

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Alan Stern
On Wed, 20 Mar 2013, Jiri Kosina wrote: > > I don't know of any way. In fact, I have been thinking of writing a > > test driver module, with a module parameter telling it which IRQ number > > to register for. It seems like the sort of thing that would be useful > > to have, from time to time.

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Yinghai Lu wrote: > > I guess I should have phrased it more precisely, but that's exactly > > what I expect is happening on my machine: I don't have anything on > > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > > the irq is completely disabled. Which

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-24 Thread Shawn Starr
On Tuesday, March 19, 2013 04:12:18 PM Daniel Vetter wrote: > On Tue, Mar 19, 2013 at 10:03 AM, Chris Wilson wrote: > >> > How about just using: > >> > if (!HAS_GMBUS_IRQ(dev_priv->dev)) gmbus4_irq_en = 0; > >> > > >> > and the existing wait loop? > >> > >> I explicitly wanted to avoid touchi

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > For reference below the updated commit message. > > Cheers, Daniel > > Author: Jiri Kosina > Date: Tue Mar 19 09:56:57 2013 +0100 > > drm/i915: stop using GMBUS IRQs on Gen4 chips > > Commit 28c70f162 ("drm/i915: use the gmbus irq for wai

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Daniel Vetter
On Tue, Mar 19, 2013 at 4:38 PM, Alan Stern wrote: > On Tue, 19 Mar 2013, Daniel Vetter wrote: > >> For reference below the updated commit message. >> >> Cheers, Daniel >> >> Author: Jiri Kosina >> Date: Tue Mar 19 09:56:57 2013 +0100 > >> >> drm/i915: stop using GMBUS IRQs on Gen4 chips >>

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > > That might be misleading. It's possible that the erroneous IRQs _are_ > > being issued but you're simply not aware of them. If the kernel thinks > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > I guess I should have phras

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Yinghai Lu
On Tue, Mar 19, 2013 at 9:54 AM, Daniel Vetter wrote: > I guess I should have phrased it more precisely, but that's exactly > what I expect is happening on my machine: I don't have anything on > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > the irq is completely disabled

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Alan Stern wrote: > > > That might be misleading. It's possible that the erroneous IRQs _are_ > > > being issued but you're simply not aware of them. If the kernel thinks > > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > > > I guess I should hav

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Alan Stern
On Wed, 20 Mar 2013, Jiri Kosina wrote: > > I don't know of any way. In fact, I have been thinking of writing a > > test driver module, with a module parameter telling it which IRQ number > > to register for. It seems like the sort of thing that would be useful > > to have, from time to time.

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Yinghai Lu wrote: > > I guess I should have phrased it more precisely, but that's exactly > > what I expect is happening on my machine: I don't have anything on > > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > > the irq is completely disabled. Which

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-24 Thread Shawn Starr
On Tuesday, March 19, 2013 04:12:18 PM Daniel Vetter wrote: > On Tue, Mar 19, 2013 at 10:03 AM, Chris Wilson wrote: > >> > How about just using: > >> > if (!HAS_GMBUS_IRQ(dev_priv->dev)) gmbus4_irq_en = 0; > >> > > >> > and the existing wait loop? > >> > >> I explicitly wanted to avoid touchi

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > For reference below the updated commit message. > > Cheers, Daniel > > Author: Jiri Kosina > Date: Tue Mar 19 09:56:57 2013 +0100 > > drm/i915: stop using GMBUS IRQs on Gen4 chips > > Commit 28c70f162 ("drm/i915: use the gmbus irq for wai

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Daniel Vetter
On Tue, Mar 19, 2013 at 4:38 PM, Alan Stern wrote: > On Tue, 19 Mar 2013, Daniel Vetter wrote: > >> For reference below the updated commit message. >> >> Cheers, Daniel >> >> Author: Jiri Kosina >> Date: Tue Mar 19 09:56:57 2013 +0100 > >> >> drm/i915: stop using GMBUS IRQs on Gen4 chips >>

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > > That might be misleading. It's possible that the erroneous IRQs _are_ > > being issued but you're simply not aware of them. If the kernel thinks > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > I guess I should have phras

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Yinghai Lu
On Tue, Mar 19, 2013 at 9:54 AM, Daniel Vetter wrote: > I guess I should have phrased it more precisely, but that's exactly > what I expect is happening on my machine: I don't have anything on > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > the irq is completely disabled

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Alan Stern wrote: > > > That might be misleading. It's possible that the erroneous IRQs _are_ > > > being issued but you're simply not aware of them. If the kernel thinks > > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > > > I guess I should hav

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Alan Stern
On Wed, 20 Mar 2013, Jiri Kosina wrote: > > I don't know of any way. In fact, I have been thinking of writing a > > test driver module, with a module parameter telling it which IRQ number > > to register for. It seems like the sort of thing that would be useful > > to have, from time to time.

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Yinghai Lu wrote: > > I guess I should have phrased it more precisely, but that's exactly > > what I expect is happening on my machine: I don't have anything on > > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > > the irq is completely disabled. Which

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-24 Thread Shawn Starr
On Tuesday, March 19, 2013 04:12:18 PM Daniel Vetter wrote: > On Tue, Mar 19, 2013 at 10:03 AM, Chris Wilson wrote: > >> > How about just using: > >> > if (!HAS_GMBUS_IRQ(dev_priv->dev)) gmbus4_irq_en = 0; > >> > > >> > and the existing wait loop? > >> > >> I explicitly wanted to avoid touchi

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > For reference below the updated commit message. > > Cheers, Daniel > > Author: Jiri Kosina > Date: Tue Mar 19 09:56:57 2013 +0100 > > drm/i915: stop using GMBUS IRQs on Gen4 chips > > Commit 28c70f162 ("drm/i915: use the gmbus irq for wai

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Daniel Vetter
On Tue, Mar 19, 2013 at 4:38 PM, Alan Stern wrote: > On Tue, 19 Mar 2013, Daniel Vetter wrote: > >> For reference below the updated commit message. >> >> Cheers, Daniel >> >> Author: Jiri Kosina >> Date: Tue Mar 19 09:56:57 2013 +0100 > >> >> drm/i915: stop using GMBUS IRQs on Gen4 chips >>

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Daniel Vetter wrote: > > That might be misleading. It's possible that the erroneous IRQs _are_ > > being issued but you're simply not aware of them. If the kernel thinks > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > I guess I should have phras

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-19 Thread Yinghai Lu
On Tue, Mar 19, 2013 at 9:54 AM, Daniel Vetter wrote: > I guess I should have phrased it more precisely, but that's exactly > what I expect is happening on my machine: I don't have anything on > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > the irq is completely disabled

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Alan Stern wrote: > > > That might be misleading. It's possible that the erroneous IRQs _are_ > > > being issued but you're simply not aware of them. If the kernel thinks > > > that no device is using IRQ 16 then it will leave that IRQ disabled. > > > > I guess I should hav

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Alan Stern
On Wed, 20 Mar 2013, Jiri Kosina wrote: > > I don't know of any way. In fact, I have been thinking of writing a > > test driver module, with a module parameter telling it which IRQ number > > to register for. It seems like the sort of thing that would be useful > > to have, from time to time.

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-20 Thread Jiri Kosina
On Tue, 19 Mar 2013, Yinghai Lu wrote: > > I guess I should have phrased it more precisely, but that's exactly > > what I expect is happening on my machine: I don't have anything on > > irq16 (i.e. in non-msi mode the gfx interrupt isn't shared) and hence > > the irq is completely disabled. Which

Re: gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt respo

2013-03-24 Thread Shawn Starr
On Tuesday, March 19, 2013 04:12:18 PM Daniel Vetter wrote: > On Tue, Mar 19, 2013 at 10:03 AM, Chris Wilson wrote: > >> > How about just using: > >> > if (!HAS_GMBUS_IRQ(dev_priv->dev)) gmbus4_irq_en = 0; > >> > > >> > and the existing wait loop? > >> > >> I explicitly wanted to avoid touchi