nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-27 Thread chris
I think page_flip ioctl need to realize a synchronous mechanism to control fresh rate...!!! At 2011-10-25 20:30:39,"Ben Skeggs" wrote: >On Tue, 2011-10-25 at 14:15 +0200, Francisco Jerez wrote: >> Maarten Maathuis writes: >> >> > 2011/10/25 chris : >> >> Can anyone give a suggestion, is wait-vb

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-27 Thread Thomas Hellstrom
On 10/27/2011 12:49 PM, Francisco Jerez wrote: > Thomas Hellstrom writes: > > >> FWIW, there was a quite long discussion / argument when the page flip >> ioctl was designed, and at that time >> I pointed out that there are hardware capable of pageflipping using >> the fifo/pipe with optional V

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-27 Thread Francisco Jerez
Thomas Hellstrom writes: > FWIW, there was a quite long discussion / argument when the page flip > ioctl was designed, and at that time > I pointed out that there are hardware capable of pageflipping using > the fifo/pipe with optional VSYNC barriers, and that it is actually > possible to queue u

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-27 Thread Thomas Hellstrom
FWIW, there was a quite long discussion / argument when the page flip ioctl was designed, and at that time I pointed out that there are hardware capable of pageflipping using the fifo/pipe with optional VSYNC barriers, and that it is actually possible to queue up a number of pageflips in the fif

Re: nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-27 Thread Thomas Hellstrom
On 10/27/2011 12:49 PM, Francisco Jerez wrote: Thomas Hellstrom writes: FWIW, there was a quite long discussion / argument when the page flip ioctl was designed, and at that time I pointed out that there are hardware capable of pageflipping using the fifo/pipe with optional VSYNC barriers,

Re: nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-27 Thread Francisco Jerez
Thomas Hellstrom writes: > FWIW, there was a quite long discussion / argument when the page flip > ioctl was designed, and at that time > I pointed out that there are hardware capable of pageflipping using > the fifo/pipe with optional VSYNC barriers, and that it is actually > possible to queue u

Re: nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-27 Thread Thomas Hellstrom
FWIW, there was a quite long discussion / argument when the page flip ioctl was designed, and at that time I pointed out that there are hardware capable of pageflipping using the fifo/pipe with optional VSYNC barriers, and that it is actually possible to queue up a number of pageflips in the fif

Re:Re: nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-27 Thread chris
I think page_flip ioctl need to realize a synchronous mechanism to control fresh rate...!!! At 2011-10-25 20:30:39,"Ben Skeggs" wrote: >On Tue, 2011-10-25 at 14:15 +0200, Francisco Jerez wrote: >> Maarten Maathuis writes: >> >> > 2011/10/25 chris : >> >> Can anyone give a suggestion, is wait-vb

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-25 Thread Ben Skeggs
On Tue, 2011-10-25 at 14:15 +0200, Francisco Jerez wrote: > Maarten Maathuis writes: > > > 2011/10/25 chris : > >> Can anyone give a suggestion, is wait-vblank fully implemented in > >> page_flip() for nouveau drm driver? > >> > > It's intentionally not implemented. The reason is that I wanted

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-25 Thread chris
It seems that nv04_graph_mthd_page_flip() was called from isr , and page_flip ioctl only send a NV_SW_PAGE_FLIP pushbuffer bo to gem. If you don't want the screen show garbage you must make sure not to change frontbuffer or backbuffer in GPU when nv_set_crtc_base() is called, and not change

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-25 Thread Francisco Jerez
Maarten Maathuis writes: > 2011/10/25 chris : >> Can anyone give a suggestion, is wait-vblank fully implemented in >> page_flip() for nouveau drm driver? >> It's intentionally not implemented. The reason is that I wanted to support non-vsync'ed vblank as well, and for vsync'ed blits we had to t

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-25 Thread chris
Can anyone give a suggestion, is wait-vblank fully implemented in page_flip() for nouveau drm driver? At 2011-10-24 14:30:55,chris wrote: Dear, I use NVidia Geforce 7300GT graphics card in my PC, and Linux 3.1rc4 kernel code, git drm 2.4.36. When I run the vbltest program, it prints "60

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-25 Thread Maarten Maathuis
2011/10/25 chris : > Can anyone give a suggestion, is wait-vblank fully implemented in > page_flip() for nouveau drm driver? > > > At 2011-10-24 14:30:55,chris? wrote: > > Dear, > > I use NVidia Geforce 7300GT graphics card in my PC, and Linux 3.1rc4 kernel > code, git drm 2.4.36. > ? When I run th

Re: nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-25 Thread Ben Skeggs
On Tue, 2011-10-25 at 14:15 +0200, Francisco Jerez wrote: > Maarten Maathuis writes: > > > 2011/10/25 chris : > >> Can anyone give a suggestion, is wait-vblank fully implemented in > >> page_flip() for nouveau drm driver? > >> > > It's intentionally not implemented. The reason is that I wanted

Re: nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-25 Thread Francisco Jerez
Maarten Maathuis writes: > 2011/10/25 chris : >> Can anyone give a suggestion, is wait-vblank fully implemented in >> page_flip() for nouveau drm driver? >> It's intentionally not implemented. The reason is that I wanted to support non-vsync'ed vblank as well, and for vsync'ed blits we had to t

Re:Re: nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-25 Thread chris
It seems that nv04_graph_mthd_page_flip() was called from isr , and page_flip ioctl only send a NV_SW_PAGE_FLIP pushbuffer bo to gem. If you don't want the screen show garbage you must make sure not to change frontbuffer or backbuffer in GPU when nv_set_crtc_base() is called, and not change

Re: nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-24 Thread Maarten Maathuis
2011/10/25 chris : > Can anyone give a suggestion, is wait-vblank fully implemented in > page_flip() for nouveau drm driver? > > > At 2011-10-24 14:30:55,chris  wrote: > > Dear, > > I use NVidia Geforce 7300GT graphics card in my PC, and Linux 3.1rc4 kernel > code, git drm 2.4.36. >   When I run th

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-24 Thread chris
Dear, I use NVidia Geforce 7300GT graphics card in my PC, and Linux 3.1rc4 kernel code, git drm 2.4.36. When I run the vbltest program, it prints "60HZ" which indicated the implementation of drmWaitVBlank() and drm_vblank_wait() is correct. But when I run modetest with option " -v -s 12:

nouveau page_flip function implement not wait vblank, which cause screen garbage

2011-10-23 Thread chris
Dear, I use NVidia Geforce 7300GT graphics card in my PC, and Linux 3.1rc4 kernel code, git drm 2.4.36. When I run the vbltest program, it prints "60HZ" which indicated the implementation of drmWaitVBlank() and drm_vblank_wait() is correct. But when I run modetest with option " -v -s 12: