[PATCH v5 03/19] drm/i915: support 64K GTT pages for discrete cards

2022-02-01 Thread Ramalingam C
From: Matthew Auld discrete cards optimise 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no

[PATCH v5 02/19] drm/i915: enforce min GTT alignment for discrete cards

2022-02-01 Thread Ramalingam C
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into

[PATCH v5 11/19] drm/i915/lmem: Enable lmem for platforms with Flat CCS

2022-02-01 Thread Ramalingam C
From: Abdiel Janulgue A portion of device memory is reserved for Flat CCS so usable device memory will be reduced by size of Flat CCS. Size of Flat CCS is specified in “XEHPSDV_FLAT_CCS_BASE_ADDR”. So to get effective device memory we need to subtract total device memory by Flat CCS memory size.

[PATCH v5 12/19] drm/i915/gt: Clear compress metadata for Xe_HP platforms

2022-02-01 Thread Ramalingam C
From: Ayaz A Siddiqui Xe-HP and latest devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. Flat CCS memory can not be directly accessed by S/W.

[PATCH v5 05/19] drm/i915/gtt: allow overriding the pt alignment

2022-02-01 Thread Ramalingam C
From: Matthew Auld On some platforms we have alignment restrictions when accessing LMEM from the GTT. In the next patch few patches we need to be able to modify the page-tables directly via the GTT itself. Suggested-by: Ramalingam C Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc:

[PATCH v5 04/19] drm/i915: add gtt misalignment test

2022-02-01 Thread Ramalingam C
From: Robert Beckett add test to check handling of misaligned offsets and sizes v4: * remove spurious blank lines * explicitly cast intel_region_id to intel_memory_type in misaligned_pin Reported-by: kernel test robot v6: * use NEEDS_COMPACT_PT instead of hard coding

[PATCH v5 06/19] drm/i915/gtt: add xehpsdv_ppgtt_insert_entry

2022-02-01 Thread Ramalingam C
From: Matthew Auld If this is LMEM then we get a 32 entry PT, with each PTE pointing to some 64K block of memory, otherwise it's just the usual 512 entry PT. This very much assumes the caller knows what they are doing. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Ramalingam C

[PATCH v5 09/19] Doc/gpu/rfc/i915: i915 DG2 64k pagesize uAPI

2022-02-01 Thread Ramalingam C
Details of the 64k pagesize support added as part of DG2 enabling and its implicit impact on the uAPI. v2: improvised the Flat-CCS documentation [Danvet & CQ] v3: made only for 64k pagesize support Signed-off-by: Ramalingam C cc: Daniel Vetter cc: Matthew Auld cc: Simon Ser cc: Pekka

[PATCH v5 10/19] drm/i915/xehpsdv: Add has_flat_ccs to device info

2022-02-01 Thread Ramalingam C
From: CQ Tang Platforms of XeHP and beyond support 3D surface (buffer) compression and various compression formats. This is accomplished by an additional compression control state (CCS) stored for each surface. Gen 12 devices(TGL family and DG1) stores compression states in a separate region of

[PATCH v5 01/19] drm/i915: add needs_compact_pt flag

2022-02-01 Thread Ramalingam C
Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages. With this flag has_64k_pages will only indicate requirement of 64K GTT page sizes or larger for device local memory access. v6: * minor doc formatting

Re: [PATCH] dma-buf: heaps: Fix potential spectre v1 gadget

2022-02-01 Thread Sumit Semwal
Hello Jordy, On Tue, 1 Feb 2022 at 02:09, John Stultz wrote: > > On Sat, Jan 29, 2022 at 7:06 AM Jordy Zomer wrote: > > > > It appears like nr could be a Spectre v1 gadget as it's supplied by a > > user and used as an array index. Prevent the contents > > of kernel memory from being leaked to

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > > On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven > wrote: > > > What's the story with the Rn formats? > > > > The comments say "n bpp Red", while this is a monochrome (even > > inverted) display? > > I don't think the color matters

Re: [PATCH v3 2/3] drm/i915: Fix header test for !CONFIG_X86

2022-02-01 Thread Siva Mullati
Reviewed-by: Siva Mullati On 31/01/22 10:29 pm, Lucas De Marchi wrote: > Architectures others than x86 have a stub implementation calling > WARN_ON_ONCE(). The appropriate headers need to be included, otherwise > the header-test target will fail with: > > HDRTEST drivers/gpu/drm/i915/i915_mm.h

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 09:38, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: >> >> On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven >> wrote: >> >>> What's the story with the Rn formats? >>> >>> The comments say "n bpp Red", while this is a monochrome (even >>> inverted)

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Tue, Feb 01, 2022 at 10:33:31AM +0100, Thomas Zimmermann wrote: > Am 31.01.22 um 21:29 schrieb Javier Martinez Canillas: > > +obj-$(CONFIG_TINYDRM_SSD1307) += ssd1307.o > > Maybe call it ssd130x Either way it's good to list all supported models in "help" of Kconfig. Also here

Re: [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed()

2022-02-01 Thread Thomas Zimmermann
Hi Am 31.01.22 um 21:12 schrieb Javier Martinez Canillas: Add support to convert 8-bit grayscale to reversed monochrome for drivers that control monochromatic displays, that only have 1 bit per pixel depth. This helper function was based on repaper_gray8_to_mono_reversed() from the

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Thomas Zimmermann
Am 31.01.22 um 22:05 schrieb Daniel Vetter: Ever since Tomi extracted the core code in 2014 it's been defacto me maintaining this, with help from others from dri-devel and sometimes Linus (but those are mostly merge conflicts): $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 35

Re: [PATCH v11] drm/bridge: add it6505 driver

2022-02-01 Thread Robert Foss
On Fri, 14 Jan 2022 at 10:29, allen wrote: > > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen > Tested-by: Hsin-yi Wang > Signed-off-by: Hermes Wu > Signed-off-by: Allen Chen > --- > v10 -> v11 : remove drm_bridge_new_crtc_state >

Re: [PATCH 09/20] drm/i915/buddy: tweak 2big check

2022-02-01 Thread Thomas Hellström
On Wed, 2022-01-26 at 15:21 +, Matthew Auld wrote: > Otherwise we get -EINVAL, instead of the more useful -E2BIG if the > allocation doesn't fit within the pfn range, like with mappable lmem. > The hugepages selftest, for example, needs this to know if a smaller > size is needed. > >

Re: [PULL] drm-misc-next

2022-02-01 Thread Maarten Lankhorst
Op 01-02-2022 om 07:38 schreef Dave Airlie: > On Thu, 27 Jan 2022 at 21:57, Maarten Lankhorst > wrote: >> Hi Dave & Daniel, >> >> First pull for v5.18 > I was trying to be all efficient and get this pulled in time for once. > > > However it broke building on my arm test build. > > The new DP

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Simon, On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven > wrote: > > What's the story with the Rn formats? > > > > The comments say "n bpp Red", while this is a monochrome (even > > inverted) display? > > I don't think the color

[PATCH] drm/panel-simple: Add a timing for the Raspberry Pi 7" panel

2022-02-01 Thread Detlev Casanova
From: Dave Stevenson The Raspberry Pi 7" 800x480 panel uses a Toshiba TC358762 DSI to DPI bridge chip, so there is a requirement for the timings to be specified for the end panel. Add such a definition. Signed-off-by: Dave Stevenson Signed-off-by: Detlev Casanova ---

Re: [PATCH] drm/bridge_connector: enable HPD by default if supported

2022-02-01 Thread Nikita Yushchenko
Hotplug events reported by bridge drivers over drm_bridge_hpd_notify() get ignored unless somebody calls drm_bridge_hpd_enable(). When the connector for the bridge is bridge_connector, such a call is done from drm_bridge_connector_enable_hpd(). However drm_bridge_connector_enable_hpd() is never

[PATCH 1/3] drm/panel: ltk050h3146w: add mipi_dsi_device.mode_flags to of_match_data

2022-02-01 Thread quentin . schulz
From: Quentin Schulz To prepare for a new display to be supported by this driver which has a slightly different set of DSI mode related flags, let's move the currently hardcoded mode flags to the .data field of of_device_id structure. Cc: Quentin Schulz Signed-off-by: Quentin Schulz ---

[PATCH v2] drm: document struct drm_mode_fb_cmd2

2022-02-01 Thread Simon Ser
Follow-up for the DRM_IOCTL_MODE_GETFB2 docs. v2: (Daniel Stone) - Replace fourcc.org with drm_fourcc.h because this is the authoritative source and the website may have mismatches. - Drop assumption that offsets will generally be 0. - Mention that unused entries must be zero'ed out.

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote: ... > > +config TINYDRM_SSD1307 > > + tristate "DRM support for Solomon SSD1307 OLED displays" > Use SSD130X here - so SSD1306 users can find it. It's

[Bug 215511] Dual monitor with amd 5700 causes system to hang at startup.

2022-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215511 --- Comment #2 from Jose Mestre (pmes...@gmail.com) --- Hello. I've been unable to compile a specific kernel commit (i did not have too much time to find the docs about how to do it) and i don't know C. I've tried releases for archlinux and i

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 11:08, Thomas Zimmermann wrote: > Am 01.02.22 um 09:36 schrieb Geert Uytterhoeven: > > > I'd expect 8-bit grayscale to be Y8 instead. > > I like this naming, but DRM_FORMAT_R8 is uapi already. :/ If anything, > we could add Yn formats in addition to existing Rn

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 11:11 schrieb Simon Ser: On Tuesday, February 1st, 2022 at 11:08, Thomas Zimmermann wrote: Am 01.02.22 um 09:36 schrieb Geert Uytterhoeven: I'd expect 8-bit grayscale to be Y8 instead. I like this naming, but DRM_FORMAT_R8 is uapi already. :/ If anything, we could add

[PATCH v5 00/19] drm/i915/dg2: Enabling 64k page size and flat ccs

2022-02-01 Thread Ramalingam C
This series introduces the enabling patches for new memory compression feature Flat CCS and 64k page support for i915 local memory, along with documentation on the uAPI impact. Included the details of the feature and the implications on the uAPI below. Which is also added into

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Greg Kroah-Hartman
On Tue, Feb 01, 2022 at 11:19:54AM +0100, Thomas Zimmermann wrote: > > > Am 31.01.22 um 22:05 schrieb Daniel Vetter: > > Ever since Tomi extracted the core code in 2014 it's been defacto me > > maintaining this, with help from others from dri-devel and sometimes > > Linus (but those are mostly

Re: [PATCH v5 07/19] drm/i915/migrate: add acceleration support for DG2

2022-02-01 Thread Matthew Auld
On 01/02/2022 10:41, Ramalingam C wrote: From: Matthew Auld This is all kinds of awkward since we now have to contend with using 64K GTT pages when mapping anything in LMEM(including the page-tables themselves). v2: Rebased [Ram] Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc:

[PATCH v3] fbdev: fbmem: Fix the implicit type casting

2022-02-01 Thread Yizhuo Zhai
In function do_fb_ioctl(), the "arg" is the type of unsigned long, and in "case FBIOBLANK:" this argument is casted into an int before passig to fb_blank(). In fb_blank(), the comparision if (blank > FB_BLANK_POWERDOWN) would be bypass if the original "arg" is a large number, which is possible

[PATCH v3] fbdev: fbmem: Fix the implicit type casting

2022-02-01 Thread Yizhuo Zhai
In function do_fb_ioctl(), the "arg" is the type of unsigned long, and in "case FBIOBLANK:" this argument is casted into an int before passig to fb_blank(). In fb_blank(), the comparision if (blank > FB_BLANK_POWERDOWN) would be bypass if the original "arg" is a large number, which is possible

Re: [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 11:36, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: >> >> On 1/31/22 22:05, Daniel Vetter wrote: >>> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated >>> scrolling"), but behind the FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION >>> option. >> >>

Re: [PATCH] drm/panel: simple: Assign data from panel_dpi_probe() correctly

2022-02-01 Thread Marek Vasut
On 2/1/22 12:01, Christoph Niedermaier wrote: In the function panel_simple_probe() the pointer panel->desc is assigned to the passed pointer desc. If function panel_dpi_probe() is called panel->desc will be updated, but further on only desc will be evaluated. So update the desc pointer to be

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Pekka, On Tue, Feb 1, 2022 at 11:42 AM Pekka Paalanen wrote: > On Tue, 1 Feb 2022 10:49:03 +0100 > Javier Martinez Canillas wrote: > > On 2/1/22 09:38, Daniel Vetter wrote: > > > On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > > >> On Tuesday, February 1st, 2022 at 09:26, Geert

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven wrote: > What's the story with the Rn formats? > > The comments say "n bpp Red", while this is a monochrome (even > inverted) display? I don't think the color matters that much. "Red" was picked just because it was an arbitrary color,

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: ... > > Patch #3 adds the driver. The name ssd1307 was used instead of ssd130x > > (which would be more accurate) to avoid confusion for users who want to > >

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote: > On 1/31/22 22:30, Sam Ravnborg wrote: > > On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote: ... > > The driver uses the pwms property for the backlight. > > It would have been much better to bite

Re: [PATCH] drm/i915/ttm: Return some errors instead of trying memcpy move

2022-02-01 Thread Matthew Auld
On 01/02/2022 07:03, Thomas Hellström wrote: The i915_ttm_accel_move() function may return error codes that should be propagated further up the stack rather than consumed assuming that the accel move failed and could be replaced with a memcpy move. For -EINTR, -ERESTARTSYS and -EAGAIN, just

[Bug 215549] My 6900XT can't recover while it's idle (but not asleep), and sometimes doesn't show at boot

2022-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215549 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed()

2022-02-01 Thread Pekka Paalanen
On Tue, 1 Feb 2022 10:59:43 +0100 Thomas Zimmermann wrote: > Hi > > Am 31.01.22 um 21:12 schrieb Javier Martinez Canillas: > > Add support to convert 8-bit grayscale to reversed monochrome for drivers > > that control monochromatic displays, that only have 1 bit per pixel depth. > > > > This

Re: [PULL] drm-misc-next

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 09:17 schrieb Maarten Lankhorst: Op 01-02-2022 om 07:38 schreef Dave Airlie: On Thu, 27 Jan 2022 at 21:57, Maarten Lankhorst wrote: Hi Dave & Daniel, First pull for v5.18 I was trying to be all efficient and get this pulled in time for once. However it broke building on

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 10:33, Thomas Zimmermann wrote: > Hi Javier, > > please see comments and questions below. > Thanks again for your comments. [snip] >> >> +config TINYDRM_SSD1307 > > TINYDRM is so 2010's. Just call it DRM. > Haha, Ok. I just followed what other drivers did and thought was a

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
Hello Geert, On 2/1/22 12:38, Geert Uytterhoeven wrote: [snip] >> >> Since the current binding has a compatible "ssd1305fb-i2c", we could make the >> new one "ssd1305drm-i2c" or better, just "ssd1305-i2c". > > DT describes hardware, not software policy. > If the hardware is the same, the DT

Re: [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 12:01 PM Helge Deller wrote: > On 2/1/22 11:36, Daniel Vetter wrote: > > On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: > >> > >> On 1/31/22 22:05, Daniel Vetter wrote: > >>> This functionally undoes 39aead8373b3 ("fbcon: Disable accelerated > >>> scrolling"), but

[Bug 215558] New: amdgpu driver sometimes crashes when playing games

2022-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215558 Bug ID: 215558 Summary: amdgpu driver sometimes crashes when playing games Product: Drivers Version: 2.5 Kernel Version: 5.15 Hardware: All OS: Linux Tree:

Re: [PATCH 4/4] MAINTAINERS: Add entry for Solomon SSD1307 OLED displays DRM driver

2022-02-01 Thread Javier Martinez Canillas
Hello Andy, On 2/1/22 10:32, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 09:15:37PM +0100, Javier Martinez Canillas wrote: >> To make sure that tools like the get_maintainer.pl script will suggest >> to Cc me if patches are posted for this driver. >> >> Also include the Device Tree binding

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 10:41, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote: >> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote: > > ... > >>> +config TINYDRM_SSD1307 >>> + tristate "DRM support for Solomon SSD1307 OLED displays" >> Use

[PATCH -next 1/2 v2] video: fbdev: pxa168fb: Remove unnecessary print function dev_err()

2022-02-01 Thread Yang Li
The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/video/fbdev/pxa168fb.c:621:2-9: line 621 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang

[PATCH -next 2/2 v2] video: fbdev: pxa3xx-gcu: Remove unnecessary print function dev_err()

2022-02-01 Thread Yang Li
The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/video/fbdev/pxa3xx-gcu.c:615:2-9: line 615 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by:

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Noralf Trønnes
Den 01.02.2022 14.06, skrev Javier Martinez Canillas: > Hello Noralf, > > On 2/1/22 13:58, Noralf Trønnes wrote: >> >> >> Den 31.01.2022 21.52, skrev Sam Ravnborg: >>> On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: There isn't a connector type for display

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 13:58, Noralf Trønnes wrote: > It turned out that I wasn't entirely correct here, mpv didn't cope with > unknown types. In the PR to add support Emil Velikov wondered if libdrm > should handle these connector names: Opened this MR to try to make things

[Bug 215558] amdgpu driver sometimes crashes when playing games

2022-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215558 smoe...@uni-bremen.de changed: What|Removed |Added Component|Video(DRI - non Intel) |Video(Other) -- You may reply

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Tue, Feb 1, 2022 at 12:31 PM Javier Martinez Canillas wrote: > On 2/1/22 10:37, Andy Shevchenko wrote: > > On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: > >> On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: > > > > ... > > > >>> Patch #3

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 10:44, Andy Shevchenko wrote: > On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote: >> On 1/31/22 22:30, Sam Ravnborg wrote: >>> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote: > > ... > >>> The driver uses the pwms property for the

Re: [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed()

2022-02-01 Thread Javier Martinez Canillas
Hello Thomas, Thanks a lot for your feedback. On 2/1/22 10:59, Thomas Zimmermann wrote: > Hi > > Am 31.01.22 um 21:12 schrieb Javier Martinez Canillas: >> Add support to convert 8-bit grayscale to reversed monochrome for drivers >> that control monochromatic displays, that only have 1 bit per

[PATCH v2] drm/fb-helper: Mark screen buffers in system memory with FB_VIRTFB

2022-02-01 Thread Thomas Zimmermann
Mark screen buffers in system memory with FB_VIRTFB. Otherwise, fbdev deferred I/O marks mmap'ed areas of system memory with VM_IO. (There's an inverse relation ship between the two flags.) For shadow buffers, also set the FB_READS_FAST hint. v2: * updated commit description (Daniel)

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 14:20, Noralf Trønnes wrote: > > > Den 01.02.2022 14.06, skrev Javier Martinez Canillas: >> Hello Noralf, >> >> On 2/1/22 13:58, Noralf Trønnes wrote: >>> >>> >>> Den 31.01.2022 21.52, skrev Sam Ravnborg: On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote:

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 10:37, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: >> On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: > > ... > >>> Patch #3 adds the driver. The name ssd1307 was used instead of ssd130x >>> (which would be more

Re: [PATCH -next 1/2] video: fbdev: pxa168fb: Remove unnecessary print function dev_err()

2022-02-01 Thread Helge Deller
On 2/1/22 07:26, Yang Li wrote: > The print function dev_err() is redundant because platform_get_irq() > already prints an error. > > Eliminate the follow coccicheck warning: > ./drivers/video/fbdev/pxa168fb.c:621:2-9: line 621 is redundant because > platform_get_irq() already prints an error > >

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Noralf Trønnes
Den 31.01.2022 21.52, skrev Sam Ravnborg: > On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >> There isn't a connector type for display controllers accesed through I2C, >> most drivers use DRM_MODE_CONNECTOR_Unknown or DRM_MODE_CONNECTOR_VIRTUAL. >> >> Add an I2C

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Javier Martinez Canillas
Hello Noralf, On 2/1/22 13:58, Noralf Trønnes wrote: > > > Den 31.01.2022 21.52, skrev Sam Ravnborg: >> On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote: >>> There isn't a connector type for display controllers accesed through I2C, >>> most drivers use

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Javier Martinez Canillas
On 1/31/22 22:05, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 >

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Tue, Feb 01, 2022 at 12:45:53PM +0100, Javier Martinez Canillas wrote: > On 2/1/22 10:44, Andy Shevchenko wrote: > > On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote: ... > > The problem with no backward compatibility means that removal of old driver > > makes users

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Tue, Feb 1, 2022 at 2:09 PM Javier Martinez Canillas wrote: > On 2/1/22 12:38, Geert Uytterhoeven wrote: > >> Since the current binding has a compatible "ssd1305fb-i2c", we could make > >> the > >> new one "ssd1305drm-i2c" or better, just "ssd1305-i2c". > > > > DT describes

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 15:05, Geert Uytterhoeven wrote: > Hi Javier, > > On Tue, Feb 1, 2022 at 2:02 PM Javier Martinez Canillas > wrote: >> On 2/1/22 10:33, Thomas Zimmermann wrote: +{ +u8 col_end = col_start + cols - 1; +int ret; + +if (col_start == ssd1307->col_start

[Bug 215558] amdgpu driver sometimes crashes when playing games

2022-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215558 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Geert Uytterhoeven
On Mon, Jan 31, 2022 at 10:06 PM Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ |

Re: [PATCH] fbdev: fbmem: Fix the implicit type casting

2022-02-01 Thread Helge Deller
On 1/31/22 07:57, Yizhuo Zhai wrote: > In function do_fb_ioctl(), the "arg" is the type of unsigned long, yes, because it comes from the ioctl framework... > and in "case FBIOBLANK:" this argument is casted into an int before > passig to fb_blank(). which makes sense IMHO. > In fb_blank(), the

Re: [PATCH 3/3] tools: add hmm gup test for long term pinned device pages

2022-02-01 Thread Felix Kuehling
Am 2022-02-01 um 02:05 schrieb Alistair Popple: From: Alex Sierra The intention is to test device coherent type pages that have been called through get user pages with PIN_LONGTERM flag set. These pages should get migrated back to normal system memory. Signed-off-by: Alex Sierra

Re: [PATCH v8 00/10] vgaarb: Rework default VGA device selection

2022-02-01 Thread Maarten Lankhorst
Hey,   Op 31-01-2022 om 23:23 schreef Bjorn Helgaas: > [+to Maarten, Maxime, Thomas; beginning of thread: > https://lore.kernel.org/r/20220106000658.243509-1-helg...@kernel.org] > > On Wed, Jan 05, 2022 at 06:06:48PM -0600, Bjorn Helgaas wrote: >> From: Bjorn Helgaas >> >> Current default VGA

[PATCH v4 0/3] drm/lsdc: add drm driver for loongson display controller

2022-02-01 Thread Sui Jingfeng
v4: add dts required and explain why device tree is required. give more description about the code. fix warnings reported by kernel test robot. introduce stride_alignment member into struct lsdc_chip_desc, the stride alignment is 256 bytes for ls7a1000, ls2k1000 and ls2k0500

[PATCH v4 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-01 Thread Sui Jingfeng
From: suijingfeng There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge, and the DC in those chip is a PCI device. This display controller have two display pipes but with only one hardware cursor. Each way has a DVO output interface and the CRTC is able to scanout from

[PATCH v4 2/3] dt-bingdings: ls2k1000: add the display controller device node

2022-02-01 Thread Sui Jingfeng
From: suijingfeng Signed-off-by: suijingfeng Signed-off-by: Sui Jingfeng <15330273...@189.cn> --- arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi

[PATCH v6 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping

2022-02-01 Thread Alex Sierra
This is hopefully the final version, with all patches Reviewed. Andrew, if there are no further objections, please merge this version. This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory owned by a device that can be mapped into CPU page tables like MEMORY_DEVICE_GENERIC and can

[PATCH v4 3/3] dt-bingdings: mips: loongson: introduce board specific dts

2022-02-01 Thread Sui Jingfeng
From: suijingfeng For board specific devices which is outside of the cpu and bridge chip Signed-off-by: suijingfeng Signed-off-by: Sui Jingfeng <15330273...@189.cn> --- arch/mips/boot/dts/loongson/lemote_a1901.dts | 64 + .../boot/dts/loongson/ls3a4000_7a1000_evb.dts | 69

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-01 Thread Jani Nikula
On Mon, 31 Jan 2022, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns drivers/video/fbdev/core/ | head -n5 >

Re: [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration

2022-02-01 Thread Helge Deller
On 2/1/22 14:45, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 12:01 PM Helge Deller wrote: >> On 2/1/22 11:36, Daniel Vetter wrote: >>> On Tue, Feb 1, 2022 at 11:16 AM Helge Deller wrote: On 1/31/22 22:05, Daniel Vetter wrote: > This functionally undoes 39aead8373b3 ("fbcon:

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
Hello Geert, On 2/1/22 15:14, Geert Uytterhoeven wrote: > Hi Javier, > > On Tue, Feb 1, 2022 at 2:09 PM Javier Martinez Canillas > wrote: >> On 2/1/22 12:38, Geert Uytterhoeven wrote: Since the current binding has a compatible "ssd1305fb-i2c", we could make the new one

Re: [PATCH 2/3] mm/gup.c: Migrate device coherent pages when pinning instead of failing

2022-02-01 Thread Felix Kuehling
Am 2022-02-01 um 02:05 schrieb Alistair Popple: Currently any attempts to pin a device coherent page will fail. This is because device coherent pages need to be managed by a device driver, and pinning them would prevent a driver from migrating them off the device. However this is no reason to

[PATCH v6 08/10] lib: add support for device coherent type in test_hmm

2022-02-01 Thread Alex Sierra
Device Coherent type uses device memory that is coherently accesible by the CPU. This could be shown as SP (special purpose) memory range at the BIOS-e820 memory enumeration. If no SP memory is supported in system, this could be faked by setting CONFIG_EFI_FAKE_MEMMAP. Currently, test_hmm only

[PATCH v6 09/10] tools: update hmm-test to support device coherent type

2022-02-01 Thread Alex Sierra
Test cases such as migrate_fault and migrate_multiple, were modified to explicit migrate from device to sys memory without the need of page faults, when using device coherent type. Snapshot test case updated to read memory device type first and based on that, get the proper returned results

[PATCH v6 10/10] tools: update test_hmm script to support SP config

2022-02-01 Thread Alex Sierra
Add two more parameters to set spm_addr_dev0 & spm_addr_dev1 addresses. These two parameters configure the start SP addresses for each device in test_hmm driver. Consequently, this configures zone device type as coherent. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling Reviewed-by: Alistair

[PATCH v6 04/10] drm/amdkfd: add SPM support for SVM

2022-02-01 Thread Alex Sierra
When CPU is connected throug XGMI, it has coherent access to VRAM resource. In this case that resource is taken from a table in the device gmc aperture base. This resource is used along with the device type, which could be DEVICE_PRIVATE or DEVICE_COHERENT to create the device page map region.

[PATCH v6 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type

2022-02-01 Thread Alex Sierra
Avoid long term pinning for Coherent device type pages. This could interfere with their own device memory manager. For now, we are just returning error for PIN_LONGTERM Coherent device type pages. Eventually, these type of pages will get migrated to system memory, once the device migration pages

[PATCH v6 07/10] lib: test_hmm add module param for zone device type

2022-02-01 Thread Alex Sierra
In order to configure device coherent in test_hmm, two module parameters should be passed, which correspond to the SP start address of each device (2) spm_addr_dev0 & spm_addr_dev1. If no parameters are passed, private device type is configured. Signed-off-by: Alex Sierra Acked-by: Felix

[PATCH v6 06/10] lib: test_hmm add ioctl to get zone device type

2022-02-01 Thread Alex Sierra
new ioctl cmd added to query zone device type. This will be used once the test_hmm adds zone device coherent type. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling Reviewed-by: Alistair Poppple --- lib/test_hmm.c | 23 +-- lib/test_hmm_uapi.h | 8 2 files

[PATCH v6 05/10] drm/amdkfd: coherent type as sys mem on migration to ram

2022-02-01 Thread Alex Sierra
Coherent device type memory on VRAM to RAM migration, has similar access as System RAM from the CPU. This flag sets the source from the sender. Which in Coherent type case, should be set as MIGRATE_VMA_SELECT_DEVICE_COHERENT. Signed-off-by: Alex Sierra Reviewed-by: Felix Kuehling ---

[PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-01 Thread Alex Sierra
Device memory that is cache coherent from device and CPU point of view. This is used on platforms that have an advanced system bus (like CAPI or CXL). Any page of a process can be migrated to such memory. However, no one should be allowed to pin such memory so that it can always be evicted.

[PATCH v6 02/10] mm: add device coherent vma selection for memory migration

2022-02-01 Thread Alex Sierra
This case is used to migrate pages from device memory, back to system memory. Device coherent type memory is cache coherent from device and CPU point of view. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling Reviewed-by: Alistair Poppple --- v2: condition added when migrations from device

Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Tue, Feb 1, 2022 at 2:02 PM Javier Martinez Canillas wrote: > On 2/1/22 10:33, Thomas Zimmermann wrote: > >> +{ > >> +u8 col_end = col_start + cols - 1; > >> +int ret; > >> + > >> +if (col_start == ssd1307->col_start && col_end == ssd1307->col_end) > >> +

Re: [PATCH 1/4] drm: Add I2C connector type

2022-02-01 Thread Noralf Trønnes
Den 01.02.2022 14.38, skrev Simon Ser: > > On Tuesday, February 1st, 2022 at 13:58, Noralf Trønnes > wrote: > >> It turned out that I wasn't entirely correct here, mpv didn't cope with >> unknown types. In the PR to add support Emil Velikov wondered if libdrm >> should handle these

[PATCH 3/6] drm/msm/dpu: allow just single IRQ callback

2022-02-01 Thread Dmitry Baryshkov
DPU interrupts code allows multiple callbacks per interrut. In reality none of the interrupts is shared between blocks (and will probably never be). Drop support for registering multiple callbacks per interrupt to simplify interrupt handling code. Signed-off-by: Dmitry Baryshkov ---

[PATCH 4/6] drm/msm/dpu: get rid of dpu_encoder_helper_(un)register_irq

2022-02-01 Thread Dmitry Baryshkov
Get rid of dpu_encoder_helper_register_irq/unregister_irq helpers, call dpu_core_register/unregister_callback directly, without surrounding them with helpers. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 63 ---

[PATCH 6/6] drm/msm/dpu: pass irq to dpu_encoder_helper_wait_for_irq()

2022-02-01 Thread Dmitry Baryshkov
Pass IRQ number directly rather than passing an index in the dpu_encoder's irq table. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 29 +-- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 4 +-- .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c

[PATCH 1/6] drm/msm/dpu: remove extra wrappers around dpu_core_irq

2022-02-01 Thread Dmitry Baryshkov
Remove extra dpu_irq_* wrappers from dpu_kms.c, merge them directly into dpu_core_irq_* functions. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 12 - .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 9 ---

[PATCH 2/6] drm/msm/dpu: remove always-true argument of dpu_core_irq_read()

2022-02-01 Thread Dmitry Baryshkov
The argument clear of the function dpu_core_irq_read() is always true. Remove it. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 4 +--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 4 ++--

[PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-02-01 Thread Dmitry Baryshkov
Remove additional indirection: specify IRQ callbacks and IRQ indices directly rather than through the pointer in the irq structure. For each IRQ we have a constant IRQ callback. This change simplifies code review as the reader no longer needs to remember which function is called. Signed-off-by:

<    1   2   3   >