Re: [PATCH v3 1/3] usb: gadget: add Aspeed ast2600 udc driver

2022-05-19 Thread Greg Kroah-Hartman
On Fri, May 20, 2022 at 02:29:36AM +, Neal Liu wrote: > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Thursday, May 19, 2022 11:56 PM > > To: Neal Liu > > Cc: Rob Herring ; Krzysztof Kozlowski > > ; Joel Stanley ; Andrew > > Jeffery ; Felipe Balbi ; Sumit Semwal > > ;

[PULL] drm-intel-fixes

2022-05-19 Thread Joonas Lahtinen
Hi Dave & Daniel, Here's the previous PR + additional fix for regression #5806: GPU hangs and display artifacts on 5.18-rc3 on Intel GM45. Was also discussed here: https://lore.kernel.org/all/CAHk-=wj0ghsg6iw3d8ufptm9a_dvtsqrrofy9wopobbybyu...@mail.gmail.com/ Regards, Joonas ***

Re: [PATCH 1/2] MAINTAINERS: Broaden scope of simpledrm entry

2022-05-19 Thread Javier Martinez Canillas
Hello Thomas, On 5/18/22 20:30, Thomas Zimmermann wrote: > There will be more DRM drivers for firmware-provided framebuffers. Use > the existing entry for simpledrm instead of adding a new one for each > driver. Also add DRM's aperture helpers, which are part of the driver's > infrastructure. >

Re: [RFC PATCH] procfs: Add file path and size to /proc//fdinfo

2022-05-19 Thread Kees Cook
On Thu, May 19, 2022 at 02:40:15PM -0700, Kalesh Singh wrote: > [...] > + seq_file_path(m, file, "\n"); > + seq_putc(m, '\n'); > > /* show_fd_locks() never deferences files so a stale value is safe */ > show_fd_locks(m, file, files); This comment implies "file" might be

Re: [PATCH] staging: fbtft: fix checkpatch.pl struct should normally be const

2022-05-19 Thread kernel test robot
Hi Uri, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Uri-Arev/staging-fbtft-fix-checkpatch-pl-struct-should-normally-be-const/20220520-012948 base:

Re: [PATCH] staging: fbtft: fix checkpatch.pl struct should normally be const

2022-05-19 Thread kernel test robot
/linux/kernel/git/gregkh/staging.git 4d0cc9e0e53e9946d7b8dc58279c62dfa7a2191b config: arm64-randconfig-r011-20220519 (https://download.01.org/0day-ci/archive/20220520/202205200821.njq0ifft-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project

Re: [PATCH v3 1/4] drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux

2022-05-19 Thread Stephen Boyd
Quoting Doug Anderson (2022-05-12 16:24:13) > On Wed, May 11, 2022 at 6:58 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2022-04-18 10:17:54) > > > diff --git a/include/drm/dp/drm_dp_helper.h > > > b/include/drm/dp/drm_dp_helper.h > > > index 53d1e722f4de..0940c415db8c 100644 > > > ---

Re: [PATCH v2] drm: Document the power requirements for DP AUX transfers

2022-05-19 Thread Doug Anderson
Hi, On Mon, May 9, 2022 at 4:18 PM Douglas Anderson wrote: > > When doing DP AUX transfers there are two actors that need to be > powered in order for the DP AUX transfer to work: the DP source and > the DP sink. Commit bacbab58f09d ("drm: Mention the power state > requirement on side-channel

Re: [PATCH v3 2/2] drm/probe-helper: For DP, add 640x480 if all other modes are bad

2022-05-19 Thread Doug Anderson
Hi, On Wed, May 11, 2022 at 3:58 PM Douglas Anderson wrote: > > As per Displayport spec section 5.2.1.2 ("Video Timing Format") says > that all detachable sinks shall support 640x480 @60Hz as a fail safe > mode. > > A DP compliance test expected us to utilize the above fact when all > modes it

Re: [PATCH v3 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes()

2022-05-19 Thread Doug Anderson
Hi, On Wed, May 11, 2022 at 3:58 PM Douglas Anderson wrote: > > The drm_helper_probe_single_connector_modes() is a bit long. Let's > break a chunk off to update and validate modes. This helps avoid one > goto and also will allow us to more easily call the helper a second > time in a future patch

Re: [PATCH v6 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-19 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-19 16:11:40) > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c > b/drivers/phy/qualcomm/phy-qcom-edp.c > index cacd32f..78b7306 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -87,14 +87,19 @@ struct qcom_edp { > >

Re: [PATCH v8 02/16] clk: Provide new devm_clk helpers for prepared and enabled clocks

2022-05-19 Thread Stephen Boyd
The Cc list is huge. Here it goes! Quoting Uwe Kleine-König (2022-03-14 07:16:29) > When a driver keeps a clock prepared (or enabled) during the whole > lifetime of the driver, these helpers allow to simplify the drivers. > > Reviewed-by: Jonathan Cameron > Reviewed-by: Alexandru Ardelean >

[PATCH v6 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

2022-05-19 Thread Kuogee Hsieh
Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov ---

[PATCH v6 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-05-19 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/phy/qualcomm/phy-qcom-qmp.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c

[PATCH v6 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-19 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-edp.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c

[PATCH v6 0/3] eDP/DP Phy vdda realted function

2022-05-19 Thread Kuogee Hsieh
1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-05-19 Thread Zanoni, Paulo R
On Tue, 2022-05-17 at 11:32 -0700, Niranjana Vishwanathapura wrote: > VM_BIND and related uapi definitions > > v2: Ensure proper kernel-doc formatting with cross references. > Also add new uapi and documentation as per review comments > from Daniel. > > Signed-off-by: Niranjana

Re: [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-05-19 Thread Zanoni, Paulo R
On Tue, 2022-05-17 at 11:32 -0700, Niranjana Vishwanathapura wrote: > VM_BIND design document with description of intended use cases. > > v2: Add more documentation and format as per review comments > from Daniel. > > Signed-off-by: Niranjana Vishwanathapura > --- > > diff --git

Re: [PATCH v5 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-19 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-19 10:45:37) > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c > b/drivers/phy/qualcomm/phy-qcom-edp.c > index cacd32f..90093cd 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -87,14 +87,19 @@ struct qcom_edp { > >

Re: [PATCH v5 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-05-19 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-19 10:45:38) > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c > b/drivers/phy/qualcomm/phy-qcom-qmp.c > index b144ae1..24f39ee 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -5008,6 +5019,11 @@ static int

[PATCH RESEND v6] drm/i915/display: disable HPD workers before display driver unregister

2022-05-19 Thread Andrzej Hajda
Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deferred fbdev after fbdev unregistration. 2. Access to DP-AUX after DP-AUX removal. Below stacktraces of both cases observed on CI: [272.634530] general protection fault,

Re: [PATCH v7 3/7] drm/i915: Prepare for multiple GTs

2022-05-19 Thread Andi Shyti
Hi Daniele, > > > @@ -909,6 +903,8 @@ int i915_driver_probe(struct pci_dev *pdev, > > > const struct pci_device_id *ent) > > >   i915_ggtt_driver_late_release(i915); > > >   out_cleanup_mmio: > > >   i915_driver_mmio_release(i915); > > > +out_tiles_cleanup: > > > +   

Re: [RFC PATCH] procfs: Add file path and size to /proc//fdinfo

2022-05-19 Thread Randy Dunlap
Hi-- On 5/19/22 14:40, Kalesh Singh wrote: > diff --git a/Documentation/filesystems/proc.rst > b/Documentation/filesystems/proc.rst > index 061744c436d9..ad66d78aca51 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -1922,13 +1922,16 @@ if precise

Re: [Intel-gfx] [PATCH] drm/i915: Fix vm use-after-free in vma destruction

2022-05-19 Thread Andi Shyti
Hi Thomas, On Thu, May 12, 2022 at 11:40:45AM +0200, Thomas Hellström wrote: > In vma destruction, the following race may occur: > > Thread 1: Thread 2: > i915_vma_destroy(); > > ... > list_del_init(vma->vm_link); > ... > mutex_unlock(vma->vm->mutex); >

Re: [PATCH] staging: fbtft: fix checkpatch.pl struct should normally be const

2022-05-19 Thread kernel test robot
Hi Uri, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Uri-Arev/staging-fbtft-fix-checkpatch-pl-struct-should-normally-be-const/20220520-012948 base:

Re: [PATCH] dt-bindings: Fix properties without any type

2022-05-19 Thread Mark Brown
On Thu, May 19, 2022 at 04:14:11PM -0500, Rob Herring wrote: > Now that the schema tools can extract type information for all > properties (in order to decode dtb files), finding properties missing > any type definition is fairly trivial though not yet automated. > > Fix the various property

[PATCH] dt-bindings: Fix properties without any type

2022-05-19 Thread Rob Herring
Now that the schema tools can extract type information for all properties (in order to decode dtb files), finding properties missing any type definition is fairly trivial though not yet automated. Fix the various property schemas which are missing a type. Most of these tend to be device specific

Re: [PATCH] staging: fbtft: fix checkpatch.pl struct should normally be const

2022-05-19 Thread Andy Shevchenko
On Thu, May 19, 2022 at 08:25:01PM +0300, Uri Arev wrote: > This simple patch fixes a checkpatch.pl warning in `fbtft/fbtft-core.c`. > > Reported by Checkpatch: > WARNING: struct fb_ops should normally be const ... > - fbops = devm_kzalloc(dev, sizeof(struct fb_ops), GFP_KERNEL); > +

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-19 Thread Andrew Morton
On Wed, 18 May 2022 20:41:27 -0700 Guenter Roeck wrote: > On 5/18/22 17:55, kernel test robot wrote: > > tree/branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > branch HEAD: 736ee37e2e8eed7fe48d0a37ee5a709514d478b3 Add linux-next > > specific files for

Re: [PATCH v7] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-19 Thread Kuogee Hsieh
On 5/17/2022 9:21 AM, Kuogee Hsieh wrote: Is anyone has comments on this patch? dp_catalog_ctrl_reset() will software reset DP controller. But it will not reset programmable registers to default value. DP driver still have to clear mask bits to interrupt status registers to disable interrupts

[PATCH v5 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

2022-05-19 Thread Kuogee Hsieh
Vdda regulators are related to both eDP and DP phy so that it should be managed at eDP and DP phy driver instead of controller. This patch removes vdda regulators related functions out of eDP/DP controller. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov ---

[PATCH v5 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-19 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at eDP phy driver. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-edp.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c

[PATCH v5 2/3] phy: qcom-qmp: add regulator_set_load to dp phy

2022-05-19 Thread Kuogee Hsieh
This patch add regulator_set_load() before enable regulator at DP phy driver. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/phy/qualcomm/phy-qcom-qmp.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c

[PATCH v5 0/3] eDP/DP Phy vdda realted function

2022-05-19 Thread Kuogee Hsieh
1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related

[RESEND 3/6 v2] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm MZP280 panel for the Raspberry Pi. Signed-off-by: Chris Morgan --- include/uapi/linux/media-bus-format.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[RESEND 6/6 v2] drm/vc4: dpi: Support DPI interface in mode3 for RGB565

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add support for the VC4 DPI driver to utilize DPI mode 3. This is defined here as xxxRxxGGxxxB: https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#parallel-display-interface-dpi This mode is required to use the Geekworm MZP280 DPI display.

[RESEND 4/6 v2] dt-bindings: display: simple: add Geekworm MZP280 Panel

2022-05-19 Thread Chris Morgan
From: Chris Morgan The Geekworm MZP280 panel is a 480x640 (portrait) panel with a capacitive touch interface and a 40 pin header meant to interface directly with the Raspberry Pi. The screen is 2.8 inches diagonally, and there appear to be at least 4 distinct versions all with the same panel

[RESEND 5/6 v2] drm/panel: simple: add Geekworm MZP280 Panel

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add support for the Geekworm MZP280 Panel Signed-off-by: Chris Morgan Acked-by: Maxime Ripard --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c

[RESEND 1/6 v2] dt-bindings: vendor-prefixes: Add Geekworm

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add vendor prefix for Geekworm (https://geekworm.com). Signed-off-by: Chris Morgan --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml

[RESEND 2/6 v2] media: uapi: Document format MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-05-19 Thread Chris Morgan
From: Chris Morgan Add support for MEDIA_BUS_FMT_RGB565_1X24_CPADHI. This format is used by the Geekworm MZP280 panel which interfaces with the Raspberry Pi. Signed-off-by: Chris Morgan --- .../media/v4l/subdev-formats.rst | 37 +++ 1 file changed, 37

[RESEND 0/6 v2] Support Geekworm MZP280 Panel for Raspberry Pi

2022-05-19 Thread Chris Morgan
From: Chris Morgan This patch series is to add support for the MZP280 panel for the Raspberry Pi. This panel requires adding support for Mode 3 of the Raspberry Pi DPI connector, which necessitates a new media bus format. This patch series has been tested on my Raspberry Pi 4 with version 1 of

Re: [PATCH v9 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-05-19 Thread Guillaume Ranquet
On Thu, 12 May 2022 09:44, Maxime Ripard wrote: >Hi, > >On Wed, May 11, 2022 at 05:59:13AM -0700, Guillaume Ranquet wrote: >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >> >> +#include >>

[GIT PULL] drm/msm: drm-msm-fixes-2022-05-19

2022-05-19 Thread Abhinav Kumar
Hi Rob Here is the pull request for the fixes for 5.19. Just a few more changes on top of msm-fixes-staging. Mainly it has the foll fixes: - Limiting WB modes to max sspp linewidth - Fixing the supported rotations to add 180 back for IGT - Fix to handle pm_runtime_get_sync() errors to avoid

Re: [PATCH v3 0/3] add Aspeed udc driver for ast2600

2022-05-19 Thread Greg Kroah-Hartman
On Wed, May 18, 2022 at 02:20:40PM +0800, Neal Liu wrote: > This patch series aim to add Aspeed USB 2.0 Device Controller (udc) > driver, including driver itself, device tree node and documentation. > > Change since v2: > - Rename device tree nodes. > - Fix unusual indentation. > > Change since

Re: [PATCH v3 1/3] usb: gadget: add Aspeed ast2600 udc driver

2022-05-19 Thread Greg Kroah-Hartman
On Wed, May 18, 2022 at 02:20:41PM +0800, Neal Liu wrote: > Aspeed udc is compliant with USB2.0, supports USB High Speed > and Full Speed, backward compatible with USB1.1. > > Supports independent DMA channel for each generic endpoint. > Supports 32/256 stages descriptor mode for all generic

[PATCH] drm/panfrost: Job should reference MMU not file_priv

2022-05-19 Thread Steven Price
For a while now it's been allowed for a MMU context to outlive it's corresponding panfrost_priv, however the job structure still references panfrost_priv to get hold of the MMU context. If panfrost_priv has been freed this is a use-after-free which I've been able to trigger resulting in a splat.

Re: [PATCH v7 3/7] drm/i915: Prepare for multiple GTs

2022-05-19 Thread Ceraolo Spurio, Daniele
On 5/11/2022 12:11 PM, Ceraolo Spurio, Daniele wrote: On 3/18/2022 4:39 PM, Andi Shyti wrote: From: Tvrtko Ursulin On a multi-tile platform, each tile has its own registers + GGTT space, and BAR 0 is extended to cover all of them. Up to four GTs are supported in i915->gt[], with slot

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-19 Thread Dmitry Osipenko
On 5/19/22 17:13, Daniel Vetter wrote: > On Thu, May 12, 2022 at 10:04:53PM +0300, Dmitry Osipenko wrote: >> On 5/12/22 20:04, Daniel Vetter wrote: >>> On Thu, 12 May 2022 at 13:36, Dmitry Osipenko >>> wrote: On 5/11/22 22:09, Daniel Vetter wrote: > On Wed, May 11, 2022 at

RE: [PATCH 09/11] drm/ttm: audit bo->resource usage

2022-05-19 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, May 19, 2022 5:55 AM >To: intel-...@lists.freedesktop.org >Cc: matthew.william.a...@gmail.com; Christian König >; dri-devel@lists.freedesktop.org >Subject: [PATCH 09/11] drm/ttm: audit bo->resource usage >

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-19 Thread Daniel Vetter
On Thu, May 12, 2022 at 10:04:53PM +0300, Dmitry Osipenko wrote: > On 5/12/22 20:04, Daniel Vetter wrote: > > On Thu, 12 May 2022 at 13:36, Dmitry Osipenko > > wrote: > >> > >> On 5/11/22 22:09, Daniel Vetter wrote: > >>> On Wed, May 11, 2022 at 07:06:18PM +0300, Dmitry Osipenko wrote: > On

RE: [PATCH 06/11] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-05-19 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, May 19, 2022 5:55 AM >To: intel-...@lists.freedesktop.org >Cc: matthew.william.a...@gmail.com; Christian König >; dri-devel@lists.freedesktop.org >Subject: [PATCH 06/11] drm/ttm: rename and cleanup

[PATCH v3] dt-bindings: display: bridge: sil, sii9022: Convert to json-schema

2022-05-19 Thread Geert Uytterhoeven
Convert the Silicon Image sii902x HDMI bridge Device Tree binding documentation to json-schema. Add missing sil,sii9022-cpi and sil,sii9022-tpi compatible values. Signed-off-by: Geert Uytterhoeven --- v3: - Add comments clarifying CPI/TPI, - Improve wording, - Drop port@2, - Add port

Re: [PATCH] drm/bridge: fix anx6345 power up sequence

2022-05-19 Thread Torsten Duwe
On Wed, 18 May 2022 09:53:58 -0700 Vasily Khoruzhick wrote: > On Thu, Apr 28, 2022 at 8:58 AM Torsten Duwe wrote: > > power on the eDP bridge? Could there be any leftovers from that > > mechanism? I use a hacked-up U-Boot with a procedure similar to the > > kernel driver as fixed by this

RE: [PATCH 04/11] drm/ttm: move default BO destructor into VMWGFX

2022-05-19 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, May 19, 2022 5:55 AM >To: intel-...@lists.freedesktop.org >Cc: matthew.william.a...@gmail.com; Christian König >; dri-devel@lists.freedesktop.org >Subject: [PATCH 04/11] drm/ttm: move default BO destructor

RE: [PATCH 02/11] drm/nouveau: switch over to ttm_bo_init_reserved

2022-05-19 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, May 19, 2022 5:55 AM >To: intel-...@lists.freedesktop.org >Cc: matthew.william.a...@gmail.com; Christian König >; dri-devel@lists.freedesktop.org >Subject: [PATCH 02/11] drm/nouveau: switch over to

Re: [PATCH 01/11] drm/radeon: switch over to ttm_bo_init_reserved

2022-05-19 Thread Christian König
Am 19.05.22 um 14:54 schrieb Ruhl, Michael J: -Original Message- From: dri-devel On Behalf Of Christian König Sent: Thursday, May 19, 2022 5:55 AM To: intel-...@lists.freedesktop.org Cc: matthew.william.a...@gmail.com; Christian König ; dri-devel@lists.freedesktop.org Subject: [PATCH

Re: [PATCH 04/11] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-05-19 Thread Daniel Vetter
On Mon, Apr 25, 2022 at 11:46:53AM -0700, Randy Dunlap wrote: > > > On 4/5/22 08:15, Borislav Petkov wrote: > > From: Borislav Petkov > > > > Fix: > > > > drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: > > drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-05-19 Thread Dave Stevenson
Hi Marek and Andrzej On Wed, 18 May 2022 at 23:53, Andrzej Hajda wrote: > > > > On 18.05.2022 16:05, Marek Szyprowski wrote: > > Hi Dave, > > > > On 11.05.2022 17:47, Dave Stevenson wrote: > >> On Wed, 11 May 2022 at 15:58, Marek Szyprowski > >> wrote: > >>> On 05.04.2022 13:43, Dave Stevenson

RE: [PATCH 01/11] drm/radeon: switch over to ttm_bo_init_reserved

2022-05-19 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Christian König >Sent: Thursday, May 19, 2022 5:55 AM >To: intel-...@lists.freedesktop.org >Cc: matthew.william.a...@gmail.com; Christian König >; dri-devel@lists.freedesktop.org >Subject: [PATCH 01/11] drm/radeon: switch over to

[PATCH v3] drm/bridge: tc358767: Make sure Refclk clock are enabled

2022-05-19 Thread Marek Vasut
The Refclk may be supplied by SoC clock output instead of crystal oscillator, make sure the clock are enabled before any other action is performed with the bridge chip, otherwise it may either fail to operate at all, or miss reset GPIO toggle. Reviewed-by: Lucas Stach Fixes: 7caff0fc4296e

Re: [syzbot] WARNING in __dma_map_sg_attrs

2022-05-19 Thread Dmitry Vyukov
On Tue, 8 Feb 2022 at 13:26, Daniel Vetter wrote: > > On Sat, Feb 05, 2022 at 12:18:23PM -0800, syzbot wrote: > > syzbot has found a reproducer for the following issue on: > > > > HEAD commit:0457e5153e0e Merge tag 'for-linus' of git://git.kernel.org.. > > git tree: upstream > > console

Re: [PATCH v2] drm/bridge: tc358767: Make sure Refclk clock are enabled

2022-05-19 Thread Maxime Ripard
On Thu, May 19, 2022 at 01:47:51PM +0200, Marek Vasut wrote: > The Refclk may be supplied by SoC clock output instead of crystal > oscillator, make sure the clock are enabled before any other action > is performed with the bridge chip, otherwise it may either fail to > operate at all, or miss

Re: [PATCH 3/3] drm/bridge: tc358767: Make sure Refclk clock are enabled

2022-05-19 Thread Marek Vasut
On 5/19/22 09:57, Lucas Stach wrote: Am Donnerstag, dem 19.05.2022 um 01:36 +0200 schrieb Marek Vasut: The Refclk may be supplied by SoC clock output instead of crystal oscillator, make sure the clock are enabled before any other action is performed with the bridge chip, otherwise it may either

Re: [PATCH v2] drm/bridge: tc358767: Make sure Refclk clock are enabled

2022-05-19 Thread Lucas Stach
Am Donnerstag, dem 19.05.2022 um 13:47 +0200 schrieb Marek Vasut: > The Refclk may be supplied by SoC clock output instead of crystal > oscillator, make sure the clock are enabled before any other action > is performed with the bridge chip, otherwise it may either fail to > operate at all, or miss

Re: [PATCH 10/11] drm/bridge: msm: Convert to drm_of_get_data_lanes

2022-05-19 Thread Marek Vasut
On 5/19/22 13:43, Dmitry Baryshkov wrote: On 19/05/2022 14:26, Marek Vasut wrote: Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Dmitry Baryshkov Can you please also test it, that it does not break anything ? Minor nit, if you resend this series

[PATCH v4 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-05-19 Thread Marek Vasut
Add support for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. The new LCDIFv3 also supports 36bit address space. Add a separate driver which

[PATCH v4 1/2] dt-bindings: lcdif: Add compatible for i.MX8MP

2022-05-19 Thread Marek Vasut
Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. The new LCDIFv3 also supports 36bit address space. However, except for

[PATCH v2] drm/bridge: tc358767: Make sure Refclk clock are enabled

2022-05-19 Thread Marek Vasut
The Refclk may be supplied by SoC clock output instead of crystal oscillator, make sure the clock are enabled before any other action is performed with the bridge chip, otherwise it may either fail to operate at all, or miss reset GPIO toggle. Fixes: 7caff0fc4296e ("drm/bridge: tc358767: Add DPI

Re: [PATCH 10/11] drm/bridge: msm: Convert to drm_of_get_data_lanes

2022-05-19 Thread Dmitry Baryshkov
On 19/05/2022 14:26, Marek Vasut wrote: Convert driver to use this new helper to standardize OF "data-lanes" parsing. Reviewed-by: Dmitry Baryshkov Minor nit, if you resend this series for any reason: could you please follow the usual subject prefix for the msm driver: 'drm/msm: '

Re: [Intel-gfx] [PATCH v6] drm/i915/display: disable HPD workers before display driver unregister

2022-05-19 Thread Andrzej Hajda
Seems the patch correctly fixes the the issue and passes CI so added maintainers/reviewers to CC. On 13.05.2022 18:06, Andrzej Hajda wrote: Handling HPD during driver removal is pointless, and can cause different use-after-free/concurrency issues: 1. Setup of deferred fbdev after fbdev

[PATCH 05/11] drm/bridge: lt9211: Convert to drm_of_get_data_lanes

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org ---

[PATCH 11/11] drm/bridge: rcar: Convert to drm_of_get_data_lanes_ep

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org ---

[PATCH 08/11] drm/bridge: ti-sn65dsi83: Convert to drm_of_get_data_lanes

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/bridge/ti-sn65dsi83.c

[PATCH 09/11] drm/bridge: ti-sn65dsi86: Convert to drm_of_get_data_lanes

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/bridge/ti-sn65dsi86.c

[PATCH 04/11] drm/bridge: lt8912: Convert to drm_of_get_data_lanes_ep

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Adrien Grassein Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org ---

[PATCH 07/11] drm/bridge: tc358775: Convert to drm_of_get_data_lanes_ep

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/bridge/tc358775.c | 20

[PATCH 10/11] drm/bridge: msm: Convert to drm_of_get_data_lanes

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Abhinav Kumar Cc: Andrzej Hajda Cc: Dmitry Baryshkov Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Rob Clark Cc: Robert Foss Cc: Sam Ravnborg Cc: Sean Paul To:

[PATCH 06/11] drm/bridge: tc358767: Convert to drm_of_get_data_lanes

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/bridge/tc358767.c | 8

[PATCH 02/11] drm/bridge: anx7625: Convert to drm_of_get_data_lanes

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg Cc: Xin Ji To: dri-devel@lists.freedesktop.org ---

[PATCH 03/11] drm/bridge: icn6211: Convert to drm_of_get_data_lanes_ep

2022-05-19 Thread Marek Vasut
Convert driver to use this new helper to standardize OF "data-lanes" parsing. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Jagan Teki Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org ---

[PATCH 01/11] drm: of: Add drm_of_get_data_lanes and drm_of_get_data_lanes_ep

2022-05-19 Thread Marek Vasut
Add helper function to count and sanitize DT "data-lanes" property and return either error or the data-lanes count. This is useful for both DSI and (e)DP "data-lanes" property. The later version of the function is an extra wrapper which handles the endpoint look up by regs, that's what majority of

[PATCH] drm/bridge: ti-sn65dsi83: Do not cache dsi_lanes and host twice

2022-05-19 Thread Marek Vasut
The DSI lane count can be accessed via the dsi device pointer, make use of that. The DSI host pointer is only used in sn65dsi83_host_attach(), move the code around so that the host does not have to be cached in the driver private data. This simplifies the code further. No functional change. This

[PATCH] drm/bridge: tc358767: Do not cache dsi_lanes twice

2022-05-19 Thread Marek Vasut
The DSI lane count can be accessed via the dsi device pointer, make use of that. No functional change. Signed-off-by: Marek Vasut Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg --- drivers/gpu/drm/bridge/tc358767.c | 6 ++ 1

[PATCH] drm/bridge: anx7625: Add missing of_node_put for endpoint

2022-05-19 Thread Marek Vasut
Add of_node_put call on the endpoint node after it is not needed. Signed-off-by: Marek Vasut Cc: Alex Deucher Cc: Javier Martinez Canillas Cc: Lyude Paul Cc: Thomas Zimmermann Cc: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v7 2/6] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory

2022-05-19 Thread eballetbo
From: Enric Balletbo i Serra On Tue, 10 May 2022 23:56:46 +, T.J. Mercier wrote > From: Hridya Valsaraju > > The cgroup controller provides accounting for GPU and GPU-related > memory allocations. The memory being accounted can be device memory or > memory allocated from pools dedicated to

Re:

2022-05-19 Thread Matthew Auld
On Thu, 19 May 2022 at 10:55, Christian König wrote: > > Just sending that out once more to intel-gfx to let the CI systems take > a look. If all went well it should normally appear at [1][2], if CI was able to pick up the series. Since it's not currently there, I assume it's temporarily stuck

[PATCH 06/11] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-05-19 Thread Christian König
Rename ttm_bo_init_reserved to ttm_bo_init_validate since that better matches what the function is actually doing. Remove the unused size parameter, move the function's kerneldoc to the implementation and cleanup the whole error handling. Signed-off-by: Christian König ---

[PATCH 03/11] drm/vram-helper: switch over to ttm_bo_init_reserved

2022-05-19 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_vram_helper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 123045b58fec..7449cbc2f925

[PATCH 02/11] drm/nouveau: switch over to ttm_bo_init_reserved

2022-05-19 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 05076e530e7d..858b9382036c

[PATCH 07/11] drm/amdgpu: audit bo->resource usage

2022-05-19 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 09/11] drm/ttm: audit bo->resource usage

2022-05-19 Thread Christian König
Allow BOs to exist without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 2b01cb30694a..a55564c8b57c 100644 ---

[PATCH 10/11] drm/ttm: stop allocating dummy resources during BO creation

2022-05-19 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle the move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 08/11] drm/nouveau: audit bo->resource usage

2022-05-19 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index

[PATCH 11/11] drm/ttm: stop allocating a dummy resource for pipelined gutting

2022-05-19 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle a move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git

[PATCH 05/11] drm/ttm: drop ttm_bo_init

2022-05-19 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 26 - include/drm/ttm/ttm_bo_api.h | 44 2 files changed, 70 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index

[PATCH 04/11] drm/ttm: move default BO destructor into VMWGFX

2022-05-19 Thread Christian König
It's the only driver using this. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c index 85a66014c2b6..c4f376d5e1d0 100644 ---

[no subject]

2022-05-19 Thread Christian König
Just sending that out once more to intel-gfx to let the CI systems take a look. No functional change compared to the last version. Christian.

[PATCH 01/11] drm/radeon: switch over to ttm_bo_init_reserved

2022-05-19 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_object.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index

[CI 3/3] drm/amd/display: Move connector debugfs to drm

2022-05-19 Thread Bhanuprakash Modem
As drm_connector already have the display_info, instead of creating "output_bpc" debugfs in vendor specific driver, move the logic to the drm layer. This patch will also move "Current" bpc to the crtc debugfs from connector debugfs, since we are getting this info from crtc_state. Cc: Harry

[CI 2/3] drm/i915/display/debug: Expose crtc current bpc via debugfs

2022-05-19 Thread Bhanuprakash Modem
This new debugfs will expose the currently using bpc by crtc. It is very useful for verifying whether we enter the correct output color depth from IGT. This patch will also add the connector's max supported bpc to "i915_display_info" debugfs. Example: cat

  1   2   >