Re: [PATCH v6 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-29 Thread Niranjana Vishwanathapura
On Wed, Jun 29, 2022 at 05:38:59PM -0700, Zanoni, Paulo R wrote: On Sat, 2022-06-25 at 18:49 -0700, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. v3: Expand documentation on dma-resv usage, TLB

Re: [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-29 Thread Jason Ekstrand
On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura < niranjana.vishwanathap...@intel.com> wrote: > VM_BIND and related uapi definitions > > v2: Reduce the scope to simple Mesa use case. > v3: Expand VM_UNBIND documentation and add > I915_GEM_VM_BIND/UNBIND_FENCE_VALID > and

[PATCH] drm/i915/reset: Handle reset timeouts under unrelated kernel hangs

2022-06-29 Thread Ashutosh Dixit
From: Chris Wilson When resuming after hibernate sometimes we see hangs in unrelated kernel subsystems. These hangs often result in the following i915 trace: i915 :00:02.0: [drm] *ERROR* \ intel_gt_reset_global timed out, cancelling all in-flight rendering implying our reset task

Re: [PATCH v2] gpu/drm/bridge/cadence: avoid flush_scheduled_work() usage

2022-06-29 Thread Tetsuo Handa
Ping? On 2022/06/13 22:57, Tetsuo Handa wrote: > Thus, how do we want to handle this race window? > > flush_delayed_work(>hdcp.check_work) followed by > flush_work(>hdcp.prop_work) (i.e. flush as much as possible) ? > > cancel_delayed_work_sync(>hdcp.check_work) followed by >

Re: How to convert drivers/gpu/drm/i915/ to use local workqueue?

2022-06-29 Thread Tetsuo Handa
Ping? On 2022/06/10 23:57, Tetsuo Handa wrote: > Then, does this flush_scheduled_work() mean to wait all > schedule_work()/schedule_delayed_work() > calls inside drivers/gpu/drm/i915/ directory?

RE: [PATCH 1/2] drm/exynos: MAINTAINERS: move Joonyoung Shim to credits

2022-06-29 Thread SR
> -Original Message- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlow...@linaro.org] > Sent: Monday, June 27, 2022 1:33 AM > To: Inki Dae ; Seung-Woo Kim > ; Kyungmin Park ; David > Airlie ; Daniel Vetter ; Rob Herring > ; Krzysztof Kozlowski > ; Alim Akhtar ; > Kishon Vijay Abraham

[Bug 215618] vblank related lockup during start of SteamVR using Valve Index HMD

2022-06-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215618 Konstantin Pereiaslov (per...@perk11.info) changed: What|Removed |Added CC|

[PATCH 5/5] ASoC: amd: enable machine driver build for Jadeite platform

2022-06-29 Thread Vijendar Mukunda
Enable machine driver build for Jadeite platform using ES8336 Codec. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/Kconfig | 11 +++ sound/soc/amd/Makefile | 2 ++ 2 files changed, 13 insertions(+) diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index

[PATCH 4/5] ASoC: amd: add Machine driver for Jadeite platform

2022-06-29 Thread Vijendar Mukunda
Add Machine driver for Jadeite platform which uses ES8336 codec. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/acp-es8336.c | 333 + 1 file changed, 333 insertions(+) create mode 100644 sound/soc/amd/acp-es8336.c diff --git a/sound/soc/amd/acp-es8336.c

[PATCH 3/5] ASoC: amd: add I2S MICSP instance support

2022-06-29 Thread Vijendar Mukunda
Add I2S MICSP instance support for Stoney variant. Signed-off-by: Vijendar Mukunda --- sound/soc/amd/acp-pcm-dma.c | 50 +++-- sound/soc/amd/acp.h | 13 ++ 2 files changed, 61 insertions(+), 2 deletions(-) diff --git a/sound/soc/amd/acp-pcm-dma.c

[PATCH 0/5] I2S driver changes for Jadeite platform

2022-06-29 Thread Vijendar Mukunda
Jadeite(JD) platform is Stoney APU varaint which uses I2S MICSP instance and ES8336 Codec. This patch series creates I2S platform devices for JD platform, adds I2S MICSP instance support and Machine driver support This patch set depends on: --checkpatch warnings patch

[PATCH 2/5] drm/amdgpu: create I2S platform devices for Jadeite platform

2022-06-29 Thread Vijendar Mukunda
Jadeite platform uses I2S MICSP instance. Create platform devices for DMA controller and I2S controller for Jadeite platform. Signed-off-by: Vijendar Mukunda Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 293 +++- 1 file changed, 184 insertions(+),

[PATCH 1/5] drm/amdgpu: add dmi check for jadeite platform

2022-06-29 Thread Vijendar Mukunda
DMI check is required to distinguish Jadeite platform from Stoney base variant. Add DMI check logic for Jadeite platform. Signed-off-by: Vijendar Mukunda Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 36 + 1 file changed, 36 insertions(+) diff

Re: [Freedreno] [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-06-29 Thread Abhinav Kumar
On 6/29/2022 6:57 PM, Rob Clark wrote: On Wed, Jun 29, 2022 at 5:36 PM Doug Anderson wrote: Hi, On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov wrote: On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main

Re: [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-06-29 Thread Rob Clark
On Wed, Jun 29, 2022 at 5:36 PM Doug Anderson wrote: > > Hi, > > On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov > wrote: > > > > On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh > > wrote: > > >Some userspace presumes that the first connected connector is the main > > >display, where it's

[PATCH v3 9/9] drm: selftest: convert drm_mm selftest to KUnit

2022-06-29 Thread Maíra Canal
From: Arthur Grillo Considering the current adoption of the KUnit framework, convert the DRM mm selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- Documentation/gpu/todo.rst| 11 -

[PATCH v3 8/9] drm: selftest: convert drm_buddy selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM buddy selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm/selftests/drm_buddy_selftests.h | 15 -

[PATCH v3 7/9] drm: selftest: convert drm_framebuffer selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM framebuffer selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 5 +-- .../gpu/drm/selftests/drm_modeset_selftests.h |

[PATCH v3 6/9] drm: selftest: convert drm_dp_mst_helper selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM DP MST helper selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Co-developed-by: Rubens Gomes Neto Signed-off-by: Rubens Gomes Neto Signed-off-by: Maíra Canal ---

[PATCH v3 5/9] drm: selftest: convert drm_plane_helper selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM plane helper selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Co-developed-by: Djakson C. G. Filho Signed-off-by: Djakson C. G. Filho Co-developed-by: Anderson Fraga Signed-off-by: Anderson Fraga

[PATCH v3 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM format selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 3 -

[PATCH v3 3/9] drm: selftest: convert drm_rect selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM rect selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Co-developed-by: Carlos Veras Signed-off-by: Carlos Veras Co-developed-by: Matheus Vieira Signed-off-by: Matheus Vieira Signed-off-by: Maíra

[PATCH v3 2/9] drm: selftest: convert drm_cmdline_parser selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM cmdline parser selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile

[PATCH v3 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM damage helper selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/Kconfig

[PATCH v3 0/9] drm: selftest: Convert to KUnit

2022-06-29 Thread Maíra Canal
Hi everyone, Here is the v3 of the conversion of selftests to KUnit. Since the v2, there have been minor fixes. drm_format_test received the biggest change: the KUNIT_EXPECT_FALSE and KUNIT_EXPECT_TRUE macros were changed to KUNIT_EXPECT_EQ, as suggested by Daniel. Most of all, the patches were

Re: [PATCH v6 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-29 Thread Zanoni, Paulo R
On Sat, 2022-06-25 at 18:49 -0700, Niranjana Vishwanathapura wrote: > VM_BIND design document with description of intended use cases. > > v2: Reduce the scope to simple Mesa use case. > v3: Expand documentation on dma-resv usage, TLB flushing and > execbuf3. > v4: Remove vm_bind tlb flush

Re: [PATCH] drm/msm/dp: make eDP panel as the first connected connector

2022-06-29 Thread Doug Anderson
Hi, On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov wrote: > > On 28 June 2022 18:20:06 GMT+03:00, Kuogee Hsieh > wrote: > >Some userspace presumes that the first connected connector is the main > >display, where it's supposed to display e.g. the login screen. For > >laptops, this should be

Re: [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-29 Thread Zanoni, Paulo R
On Sat, 2022-06-25 at 18:49 -0700, Niranjana Vishwanathapura wrote: > VM_BIND and related uapi definitions > > v2: Reduce the scope to simple Mesa use case. > v3: Expand VM_UNBIND documentation and add > I915_GEM_VM_BIND/UNBIND_FENCE_VALID > and I915_GEM_VM_BIND_TLB_FLUSH flags. > v4:

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-29 Thread Stephen Boyd
Quoting Prashant Malani (2022-06-29 15:55:10) > On Wed, Jun 29, 2022 at 2:58 PM Stephen Boyd wrote: > > > > My understanding is there are 4 DP lanes on it6505 and two lanes are > > connected to one usb-c-connector and the other two lanes are connected > > to a different usb-c-connector. The

Re: [PATCH v7 03/14] mm: handling Non-LRU pages returned by vm_normal_pages

2022-06-29 Thread Andrew Morton
On Wed, 29 Jun 2022 11:59:26 +0200 David Hildenbrand wrote: > On 29.06.22 05:54, Alex Sierra wrote: > > With DEVICE_COHERENT, we'll soon have vm_normal_pages() return > > device-managed anonymous pages that are not LRU pages. Although they > > behave like normal pages for purposes of mapping in

Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages

2022-06-29 Thread Andrew Morton
On Wed, 29 Jun 2022 18:08:40 -0400 Felix Kuehling wrote: > > > > I'd have called it "is_longterm_pinnable_page", but I am not a native > > speaker, so no strong opinion :) > > I think only the patch title has the name backwards. The code uses > is_longterm_pinnable_page. Patch title was

Re: [PATCH v6 02/22] drm/gem: Move mapping of imported dma-bufs to drm_gem_mmap_obj()

2022-06-29 Thread Dmitry Osipenko
On 6/29/22 11:43, Thomas Hellström (Intel) wrote: > > On 6/29/22 10:22, Dmitry Osipenko wrote: >> On 6/29/22 09:40, Thomas Hellström (Intel) wrote: >>> On 5/27/22 01:50, Dmitry Osipenko wrote: Drivers that use drm_gem_mmap() and drm_gem_mmap_obj() helpers don't handle imported dma-bufs

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-29 Thread Prashant Malani
On Wed, Jun 29, 2022 at 2:58 PM Stephen Boyd wrote: > > > What device controls the switching in this case? Again, block diagrams > > please if you want advice on what the binding should look like. > > My understanding is there are 4 DP lanes on it6505 and two lanes are > connected to one

[PATCH v3 09/11] drm/msm/dsi_phy_14nm: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c |

[PATCH v3 06/11] drm/msm/dsi/phy: Replace hardcoded char-array length with sizeof()

2022-06-29 Thread Marijn Suijten
Now that the last DSI PHY PLL driver (dsi_phy_28nm_8960) has been converted to use a simple stack-local char-array instead of a devm_kzalloc heap allocation we can safely call sizeof() on every string variable (that's now a sized array instead of a pointer) passed into snprintf instead of

[PATCH v3 07/11] drm/msm/dsi_phy_28nm_8960: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov ---

[PATCH v3 10/11] drm/msm/dsi_phy_10nm: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c |

[PATCH v3 04/11] drm/msm/dsi/phy: Reindent and reflow multiline function calls

2022-06-29 Thread Marijn Suijten
Patch 613cbd1da3c9 ("drm/msm/dsi: use devm_clk_*register to registe DSI PHY clocks") introduced the devm_ prefix to clk_hw registration calls, without updating the indentation of the arguments on the following lines. Similarly e55b3fc8 ("drm/msm/dsi: drop PLL accessor functions") moved from

[PATCH v3 11/11] drm/msm/dsi_phy_7nm: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 70

[PATCH v3 08/11] drm/msm/dsi_phy_28nm: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c |

[PATCH v3 00/11] drm/msm/dsi_phy: Replace parent names with clk_hw pointers

2022-06-29 Thread Marijn Suijten
parent_hw pointers are easier to manage and cheaper to use than repeatedly formatting the parent name and subsequently leaving the clk framework to perform lookups based on that name. This series starts out by adding extra constructors for divider, mux and fixed-factor clocks that have

[PATCH v3 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-06-29 Thread Marijn Suijten
Add the devres and non-devres variant of clk_hw_register_fixed_factor_parent_hw() for registering a fixed factor clock with clk_hw parent pointer instead of parent name. Signed-off-by: Marijn Suijten --- drivers/clk/clk-fixed-factor.c | 45 ++

[PATCH v3 05/11] drm/msm/dsi_phy_28nm_8960: Use stack memory for temporary clock names

2022-06-29 Thread Marijn Suijten
The clock names formatted into the hw_clk's init structure are only used for the duration of the registration function where they are kstrdup'ed, making it unnecessary to keep the allocations alive for the duration of the device (through devm). Just like the other DSI PHY PLL clock trees, use a

[PATCH v3 01/11] clk: divider: Introduce devm_clk_hw_register_divider_parent_hw()

2022-06-29 Thread Marijn Suijten
Add the devres variant of clk_hw_register_divider_parent_hw() for registering a divider clock with clk_hw parent pointer instead of parent name. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- include/linux/clk-provider.h | 19 +++ 1 file changed, 19

[PATCH v3 02/11] clk: mux: Introduce devm_clk_hw_register_mux_parent_hws()

2022-06-29 Thread Marijn Suijten
Add the devres variant of clk_hw_register_mux_hws() for registering a mux clock with clk_hw parent pointers instead of parent names. Signed-off-by: Marijn Suijten Reviewed-by: Dmitry Baryshkov --- include/linux/clk-provider.h | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH v2] drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init

2022-06-29 Thread Dmitry Osipenko
On 6/2/22 13:42, Miaoqian Lin wrote: > Since drm_prime_pages_to_sg() function return error pointers. > The drm_gem_shmem_get_sg_table() function returns error pointers too. > Using IS_ERR() to check the return value to fix this. > > Fixes: 2f2aa13724d5 ("drm/virtio: move virtio_gpu_mem_entry

Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages

2022-06-29 Thread David Hildenbrand
On 30.06.22 00:08, Felix Kuehling wrote: > On 2022-06-29 03:33, David Hildenbrand wrote: >> On 29.06.22 05:54, Alex Sierra wrote: >>> is_pinnable_page() and folio_is_pinnable() were renamed to >>> is_longterm_pinnable_page() and folio_is_longterm_pinnable() >>> respectively. These functions are

Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages

2022-06-29 Thread Felix Kuehling
On 2022-06-29 03:33, David Hildenbrand wrote: On 29.06.22 05:54, Alex Sierra wrote: is_pinnable_page() and folio_is_pinnable() were renamed to is_longterm_pinnable_page() and folio_is_longterm_pinnable() respectively. These functions are used in the FOLL_LONGTERM flag context. Subject talks

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-29 Thread Stephen Boyd
Quoting Rob Herring (2022-06-29 10:58:52) > On Wed, Jun 29, 2022 at 9:01 AM Pin-yen Lin wrote: > > > > > > Yes it6505 is just a protocol converter. But in our use case, the output > > > DP > > > lines are connected to the Type-C ports and the chip has to know which > > > port has DP Alt mode

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Luca Ceresoli
Hi, [keeping only individuals and lists in Cc to avoid bounces] On 28/06/22 16:03, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is

[PATCH 2/2] drm/msm/gpu: Add GEM debug label to devcore

2022-06-29 Thread Rob Clark
From: Rob Clark When trying to understand an iova fault devcore, once you figure out which buffer we accessed beyond the end of, it is useful to see the buffer's debug label. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 + drivers/gpu/drm/msm/msm_gpu.c |

[PATCH 1/2] drm/msm/gpu: Capture all BO addr+size in devcore

2022-06-29 Thread Rob Clark
From: Rob Clark It is useful to know what buffers userspace thinks are associated with the submit, even if we don't care to capture their content. This brings things more inline with $debugfs/rd cmdstream dumping. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 36

[PATCH 0/2] drm/msm: A couple GPU devcore enhancements

2022-06-29 Thread Rob Clark
From: Rob Clark A couple things useful for debugging iova faults: 1. caputre all buffer addresses and sizes even if we don't capture their contents. 2. capture the GEM buffer debug labels Rob Clark (2): drm/msm/gpu: Capture all BO addr+size in devcore drm/msm/gpu: Add GEM debug label to

[PATCH] Revert "drivers/video/backlight/platform_lcd.c: add support for device tree based probe"

2022-06-29 Thread Rob Herring
This reverts commit 52e842432f36d5b15227d0ee0d2aa3d2bc3cc0b2. The DT support never would have worked because there's no platform_data providing ops. There's not any documented binding for it either. Cc: Jingoo Han Signed-off-by: Rob Herring --- drivers/video/backlight/platform_lcd.c | 10

drm-misc-next: WARNING: at drivers/gpu/drm/vc4/vc4_hdmi_regs.h:487

2022-06-29 Thread Stefan Wahren
Hi Maxime, i tested todays drm-misc-next 9db35bb349 with Raspberry Pi 3 B Plus (arm/multi_v7_defconfig, mainline DTB) and get the following warning in the kernel logs: [   25.698459] vc4-drm soc:gpu: bound 3f40.hvs (ops vc4_hvs_ops [vc4]) [   25.698657] [ cut here

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Greg Kroah-Hartman
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the

Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag

2022-06-29 Thread Sumit Semwal
On Mon, 27 Jun 2022 at 14:38, Daniel Vetter wrote: > > On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > > This is already set by anon_inode_getfile(), since dma_buf_fops has > > non-NULL ->llseek, so we don't need to set it here too. > > > > Suggested-by: Al Viro > > Cc:

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Miguel Ojeda
On Tue, Jun 28, 2022 at 4:08 PM Uwe Kleine-König wrote: > > drivers/auxdisplay/ht16k33.c | 4 +--- > drivers/auxdisplay/lcd2s.c| 3 +-- Acked-by: Miguel Ojeda Cheers, Miguel

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Hans Verkuil
On 28/06/2022 16:03, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Marek Behún
On Tue, 28 Jun 2022 16:03:12 +0200 Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Heikki Krogerus
On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c > index cd47c3597e19..2a58185fb14c 100644 > --- a/drivers/usb/typec/hd3ss3220.c > +++ b/drivers/usb/typec/hd3ss3220.c > @@ -245,14 +245,12 @@ static int

Re: [PATCH v2 26/27] dyndbg: 4 new trace-events: pr_debug, dev_dbg, drm_{,dev}debug

2022-06-29 Thread Steven Rostedt
Sorry for the late review. I finally got some time to look at this. On Mon, 16 May 2022 16:56:39 -0600 Jim Cromie wrote: > diff --git a/include/trace/events/drm.h b/include/trace/events/drm.h > new file mode 100644 > index ..6de80dd68620 > --- /dev/null > +++

Re: [PATCH v6 3/4] fbcon: Prevent that screen size is smaller than font size

2022-06-29 Thread Helge Deller
On 6/29/22 09:03, Geert Uytterhoeven wrote: > Hi Helge, > > On Tue, Jun 28, 2022 at 10:52 PM Helge Deller wrote: >> On 6/28/22 10:39, Geert Uytterhoeven wrote: >>> On Sun, Jun 26, 2022 at 12:33 PM Helge Deller wrote: We need to prevent that users configure a screen size which is smaller

[PATCH] drm/vc4: change vc4_dma_range_matches from a global to static

2022-06-29 Thread Tom Rix
sparse reports drivers/gpu/drm/vc4/vc4_drv.c:270:27: warning: symbol 'vc4_dma_range_matches' was not declared. Should it be static? vc4_dma_range_matches is only used in vc4_drv.c, so it's storage class specifier should be static. Fixes: da8e393e23ef ("drm/vc4: drv: Adopt the dma configuration

[PATCH 5/5] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()

2022-06-29 Thread Helge Deller
Use the fbcon_info_from_console() wrapper which was added to kernel v5.19 with commit 409d6c95f9c6 ("fbcon: Introduce wrapper for console->fb_info lookup"). Signed-off-by: Helge Deller --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/5] fbcon: Disallow setting font bigger than screen size

2022-06-29 Thread Helge Deller
Prevent that users set a font size which is bigger than the physical screen. It's unlikely this may happen (because screens are usually much larger than the fonts and each font char is limited to 32x32 pixels), but it may happen on smaller screens/LCD displays. Signed-off-by: Helge Deller

[PATCH 4/5] fbmem: Prevent invalid virtual screen sizes in fb_set_var()

2022-06-29 Thread Helge Deller
Prevent that drivers configure a virtual screen resolution smaller than the physical screen resolution. This is important, because otherwise we may access memory outside of the graphics memory area. Signed-off-by: Helge Deller Cc: sta...@vger.kernel.org # v5.4+ ---

[PATCH 3/5] fbcon: Prevent that screen size is smaller than font size

2022-06-29 Thread Helge Deller
We need to prevent that users configure a screen size which is smaller than the currently selected font size. Otherwise rendering chars on the screen will access memory outside the graphics memory region. This patch adds a new function fbcon_modechange_possible() which implements this check and

[PATCH 2/5] fbcon: Fix up user-provided virtual screen size

2022-06-29 Thread Helge Deller
The virtual screen size can't be smaller than the physical screen size. Based on the general rule that we round up user-provided input if neccessary, adjust the virtual screen size as well if needed. Signed-off-by: Helge Deller Cc: sta...@vger.kernel.org # v5.4+ ---

[PATCH 0/5] fbcon: Fixes for screen resolution changes - round 2

2022-06-29 Thread Helge Deller
This series fixes possible out-of-bound memory accesses when users trigger screen resolutions changes with invalid input parameters, e.g. reconfigures screen which is smaller than the current font size, or if the virtual screen size is smaller than the physical screen size. Helge Deller (5):

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-06-29 Thread Chanwoo Choi
Hi Uwe, On 22. 6. 28. 23:03, Uwe Kleine-König wrote: > static const struct of_device_id atmel_sha204a_dt_ids[] = { > diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/extcon-rt8973a.c > index 40c07f4d656e..d1c674f3f2b9 100644 > --- a/drivers/extcon/extcon-rt8973a.c > +++

[pull] amdgpu drm-fixes-5.19

2022-06-29 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.19. The following changes since commit 76f0544428aced9e2f0d50ac7429e0f3064658cd: Merge tag 'drm-msm-fixes-2022-06-28' of https://gitlab.freedesktop.org/drm/msm into drm-fixes (2022-06-29 14:16:46 +1000) are available in the Git repository at:

Re: linux-next: Tree for Jun 29 (gpu/drm/amd/display/dc/)

2022-06-29 Thread Alex Deucher
On Wed, Jun 29, 2022 at 3:05 PM Randy Dunlap wrote: > > > > On 6/29/22 00:23, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20220628: > > > > on i386: > > ld: drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.o: in function > `dcn32_init_clocks': >

[PATCH] drm/mediatek: ensure bridge disable happends before suspend

2022-06-29 Thread Hsin-Yi Wang
Make sure bridge_disable will be called before suspend by calling drm_mode_config_helper_suspend() in .prepare callback. Signed-off-by: Hsin-Yi Wang --- The issue is found if suspend is called via VT2 in several MTK SoC (eg. MT8173, MT8183, MT8186) chromebook boards with eDP bridge: bridge

Re: linux-next: Tree for Jun 29 (gpu/drm/amd/display/dc/)

2022-06-29 Thread Randy Dunlap
On 6/29/22 00:23, Stephen Rothwell wrote: > Hi all, > > Changes since 20220628: > on i386: ld: drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.o: in function `dcn32_init_clocks': dcn32_clk_mgr.c:(.text+0x70d): undefined reference to `__nedf2' ld: dcn32_clk_mgr.c:(.text+0x9bf):

Re: [PATCH v7 02/14] mm: add zone device coherent type memory support

2022-06-29 Thread David Hildenbrand
On 29.06.22 05:54, Alex Sierra wrote: > Device memory that is cache coherent from device and CPU point of view. > This is used on platforms that have an advanced system bus (like CAPI > or CXL). Any page of a process can be migrated to such memory. However, > no one should be allowed to pin such

Re: [PATCH] drm/fb-helper: Fix out-of-bounds access

2022-06-29 Thread Geert Uytterhoeven
Hi Thomas, On Tue, 21 Jun 2022, Thomas Zimmermann wrote: Clip memory range to screen-buffer size to avoid out-of-bounds access in fbdev deferred I/O's damage handling. Fbdev's deferred I/O can only track pages. From the range of pages, the damage handler computes the clipping rectangle

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-06-29 Thread Rob Herring
On Wed, Jun 29, 2022 at 9:01 AM Pin-yen Lin wrote: > > On Wed, Jun 29, 2022 at 10:33 PM Pin-yen Lin wrote: > > > > On Wed, Jun 29, 2022 at 2:23 AM Rob Herring wrote: > > > > > > On Mon, Jun 27, 2022 at 02:43:39PM -0700, Prashant Malani wrote: > > > > Hello Rob, > > > > > > > > On Mon, Jun 27,

Re: [PATCH v3 11/13] drm/i915/ttm: handle blitter failure on DG2

2022-06-29 Thread Thomas Hellström
On 6/29/22 18:28, Matthew Auld wrote: On 29/06/2022 17:11, Thomas Hellström wrote: Hi, Matthew, On 6/29/22 14:14, Matthew Auld wrote: If the move or clear operation somehow fails, and the memory underneath is not cleared, like when moving to lmem, then we currently fallback to memcpy or

Re: [PATCH v3 09/13] drm/i915/selftests: skip the mman tests for stolen

2022-06-29 Thread Matthew Auld
On 29/06/2022 17:22, Thomas Hellström wrote: On 6/29/22 14:14, Matthew Auld wrote: It's not supported, and just skips later anyway. With small-BAR things get more complicated since all of stolen is likely not even CPU accessible, hence not passing I915_BO_ALLOC_GPU_ONLY just results in the

Re: [PATCH v3 11/13] drm/i915/ttm: handle blitter failure on DG2

2022-06-29 Thread Matthew Auld
On 29/06/2022 17:11, Thomas Hellström wrote: Hi, Matthew, On 6/29/22 14:14, Matthew Auld wrote: If the move or clear operation somehow fails, and the memory underneath is not cleared, like when moving to lmem, then we currently fallback to memcpy or memset. However with small-BAR systems this

Re: [PATCH v2 00/96] Refactor non_legacy_dai_naming flag

2022-06-29 Thread Mark Brown
On Thu, 23 Jun 2022 13:51:14 +0100, Charles Keepax wrote: > Historically, the legacy DAI naming scheme was applied to platform > drivers and the newer scheme to CODEC drivers. During componentisation > the core lost the knowledge of if a driver was a CODEC or platform, they > were all now

Re: [PATCH 00/96] Refactor non_legacy_dai_naming flag

2022-06-29 Thread Mark Brown
On Thu, 16 Jun 2022 15:32:53 +0100, Charles Keepax wrote: > Historically, the legacy DAI naming scheme was applied to platform > drivers and the newer scheme to CODEC drivers. During componentisation > the core lost the knowledge of if a driver was a CODEC or platform, they > were all now

Re: [PATCH v3 09/13] drm/i915/selftests: skip the mman tests for stolen

2022-06-29 Thread Thomas Hellström
On 6/29/22 14:14, Matthew Auld wrote: It's not supported, and just skips later anyway. With small-BAR things get more complicated since all of stolen is likely not even CPU accessible, hence not passing I915_BO_ALLOC_GPU_ONLY just results in the object create failing. Signed-off-by: Matthew

Re: [PATCH v3 13/13] drm/i915: turn on small BAR support

2022-06-29 Thread Thomas Hellström
On 6/29/22 14:14, Matthew Auld wrote: With the uAPI in place we should now have enough in place to ensure a working system on small BAR configurations. v2: (Nirmoy & Thomas): - s/full BAR/Resizable BAR/ which is hopefully more easily understood by users. Signed-off-by: Matthew Auld

Re: [PATCH v3 11/13] drm/i915/ttm: handle blitter failure on DG2

2022-06-29 Thread Thomas Hellström
Hi, Matthew, On 6/29/22 14:14, Matthew Auld wrote: If the move or clear operation somehow fails, and the memory underneath is not cleared, like when moving to lmem, then we currently fallback to memcpy or memset. However with small-BAR systems this fallback might no longer be possible. For now

Re: [PATCH] drm: Create support for Write-Only property blob

2022-06-29 Thread Mark Yacoub
Hi Jani, let me know if you need more info or more changes are needed. Thanks! On Wed, May 25, 2022 at 3:31 PM Mark Yacoub wrote: > > Hi Jani, thanks for your review. I got all the user space > implementation ready to see it in context. > > libdrm patch to wrap this functionality: >

Re: [PATCH] drm/bridge: anx7625: use pm_runtime_force_suspend(resume)

2022-06-29 Thread Hsin-Yi Wang
On Tue, Jun 28, 2022 at 6:46 PM Hsin-Yi Wang wrote: > > There's no need to check for IRQ or disable it in suspend. > > Use pm_runtime_force_suspend(resume) to make sure anx7625 is powered off > correctly. Make the system suspend/resume and pm runtime suspend/resume > more consistant. > >

[PATCH 4/4] drm/bridge: anx7625: Add wait_hpd_asserted() callback

2022-06-29 Thread Hsin-Yi Wang
Move hpd polling check into wait_hpd_asserted() callback. For the cases that aux transfer function wasn't used, do hpd polling check after pm runtime resume, which will power on the bridge. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/bridge/analogix/anx7625.c | 33 ++- 1

[PATCH 2/4] drm/bridge: anx7625: Use pm_runtime_force_suspend(resume)

2022-06-29 Thread Hsin-Yi Wang
There's no need to check for IRQ or disable it in suspend. Use pm_runtime_force_suspend(resume) to make sure anx7625 is powered off correctly. Make the system suspend/resume and pm runtime suspend/resume more consistant. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/bridge/analogix/anx7625.c

[PATCH 1/4] drm/bridge: anx7625: Convert to devm_i2c_new_dummy_device()

2022-06-29 Thread Hsin-Yi Wang
Simplify the resource management. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/bridge/analogix/anx7625.c | 96 +++ 1 file changed, 27 insertions(+), 69 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index

[PATCH 3/4] drm/bridge: anx7625: Fix NULL pointer crash when using edp-panel

2022-06-29 Thread Hsin-Yi Wang
Move devm_of_dp_aux_populate_ep_devices() after pm runtime and i2c setup to avoid NULL pointer crash. edp-panel probe (generic_edp_panel_probe) calls pm_runtime_get_sync() to read EDID. At this time, bridge should have pm runtime enabled and i2c clients ready. Fixes: adca62ec370c ("drm/bridge:

[PATCH 0/4] anx7625: Cleanup, fixes, and implement wait_hpd_asserted

2022-06-29 Thread Hsin-Yi Wang
This series contains: Cleanup: - Convert to use devm_i2c_new_dummy_device() - Use pm_runtime_force_suspend(resume) Fixes: - Fix NULL pointer crash when using edp-panel and Impelment wait_hpd_asserted() callback. The patches are not related to each other, but they are all anx7625 patches so they

Re: [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-29 Thread Tvrtko Ursulin
On 29/06/2022 16:30, Mauro Carvalho Chehab wrote: On Tue, 28 Jun 2022 16:49:23 +0100 Tvrtko Ursulin wrote: .. which for me means a different patch 1, followed by patch 6 (moved to be patch 2) would be ideal stable material. Then we have the current patch 2 which is open/unknown (to me at

Re: [PATCH v2 1/2] drm/msm/a6xx: Add support for a new 7c3 sku

2022-06-29 Thread Rob Clark
On Tue, Jun 28, 2022 at 10:32 PM Akhil P Oommen wrote: > > On 6/29/2022 9:59 AM, Bjorn Andersson wrote: > > On Tue 10 May 02:53 CDT 2022, Akhil P Oommen wrote: > > > >> Add a new sku to the fuse map of 7c3 gpu. > >> > >> Signed-off-by: Akhil P Oommen > > Is this series still needed/wanted? I've

Re: [PATCH v3 11/14] power: supply: mt6370: Add Mediatek MT6370 charger driver

2022-06-29 Thread ChiaEn Wu
Hi Andy, Sorry for the late reply, I have some questions to ask you below. Thanks! Andy Shevchenko 於 2022年6月24日 週五 凌晨2:56寫道: > > On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu wrote: > > > > From: ChiaEn Wu > > > > Add Mediatek MT6370 charger driver. > > ... > > > +config CHARGER_MT6370 > > +

Re: [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-29 Thread Mauro Carvalho Chehab
On Tue, 28 Jun 2022 16:49:23 +0100 Tvrtko Ursulin wrote: >.. which for me means a different patch 1, followed by patch 6 (moved > to be patch 2) would be ideal stable material. > > Then we have the current patch 2 which is open/unknown (to me at least). > > And the rest seem like

[PATCH v2 3/3] drm/i915/gt: Serialize TLB invalidates with GT resets

2022-06-29 Thread Mauro Carvalho Chehab
From: Chris Wilson Avoid trying to invalidate the TLB in the middle of performing an engine reset, as this may result in the reset timing out. Currently, the TLB invalidate is only serialised by its own mutex, forgoing the uncore lock, but we can take the uncore->lock as well to serialise the

[PATCH v2 0/3] Fix TLB invalidate issues with Broadwell

2022-06-29 Thread Mauro Carvalho Chehab
i915 selftest hangcheck is causing the i915 driver timeouts, as reported by Intel CI bot: http://gfx-ci.fi.intel.com/cibuglog-ng/issuefilterassoc/24297?query_key=42a999f48fa6ecce068bc8126c069be7c31153b4 When such test runs, the only output is: [ 68.811639] i915: Performing live

[PATCH v2 1/3] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-06-29 Thread Mauro Carvalho Chehab
From: Chris Wilson As an extension of the current skip TLB invalidations, check if the device is powered down prior to any engine activity, as, on such cases, all the TLBs were already invalidated, so an explicit TLB invalidation is not needed. This becomes more significant with GuC, as it can

  1   2   3   >