Hi Sam,
I will study vc4_drm.h and update newer portions (i.e., the section I am
actively adding to via_drm.h) with new comments that can be converted to
kernel-doc automatically.
I also plan to rework the uAPI somewhat.
- Remove DRM_VIA_GEM_UNMAP
- Revive a uAPI that can pass a PCI Device ID
Hi Thomas,
Okay, I will try to remember this.
Regards,
Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
> Sent: Tuesday, July 26, 2022 at 12:29 AM
> From: "Thomas Zimmermann"
> To: "Kevin Brace" , dri-devel@lists.freedesktop.org
> Cc: "Kevin Brace"
> Subject: Re:
Hi Thomas,
In general, I am okay with the idea of keeping DRI1 based VIA DRM for now.
Personally, I am not that interested in keeping it, but I am not against
keeping it, either.
Coming up with a scheme to keep the DRI1 based VIA DRM is sort of beyond my
skill level, so I am glad you and Sam
Hi Thomas,
Okay, I will take that into consideration when I prepare my next patch series.
Regards,
Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com
> Sent: Tuesday, July 26, 2022 at 12:21 AM
> From: "Thomas Zimmermann"
> To: "Kevin Brace" ,
to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Rob-Clark/dma-buf-map-info-support/20220730-010844
base
Hi Thomas,
I cannot drop the older DRI1 based uAPI calls.
This is because include/uapi/drm/via_drm.h needs to retain backward
compatibility with the existing OpenChrome DDX's XvMC library (it gets compiled
when OpenChrome DDX is built) and likely with the existing DDX Xv code as well.
If I
Hi Hayama-san,
Thank you for the patch.
On Mon, Jul 04, 2022 at 11:52:31AM +0900, Takanari Hayama wrote:
> R-Car DU supports different blend modes via VSP1. Add DRM blend mode
> supports to make it configurable.
>
> As drm_plane_create_blend_mode_property() creates the blend mode
> property
Hi Hayama-san,
Thank you for the patch.
On Mon, Jul 04, 2022 at 11:52:30AM +0900, Takanari Hayama wrote:
> To support DRM blend mode in R-Car DU driver, we must add blend mode
> support in VSP1. Although VSP1 hardware is capable to support all blend
> mode defined in DRM, the current R-Car DU
Hi!
> From: Alice Chen
>
> The MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery
> charger, a USB Type-C & Power Delivery (PD) controller, dual Flash
> LED current sources, a RGB LED driver, a backlight WLED
Hi!
> From: ChiYuan Huang
>
> The MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery
> charger, a USB Type-C & Power Delivery (PD) controller, dual
> Flash LED current sources, a RGB LED driver, a backlight WLED
On Fri 2022-07-22 18:23:58, ChiaEn Wu wrote:
> From: Alice Chen
>
> Add MediaTek MT6370 flashlight binding documentation.
>
> Signed-off-by: Alice Chen
> Reviewed-by: Krzysztof Kozlowski
You'll need to get sign-offs right... And review from dt people before
this can be applied.
Best
Hello Hayama-san,
Thank you for the patch (and sorry for the long delay).
On Mon, Jul 04, 2022 at 11:52:29AM +0900, Takanari Hayama wrote:
> In order to support DRM blend mode, we need to able to override pixel
> alpha flag. When DRM_MODE_BLEND_PIXEL_NONE is desired, we'd like to let
> VSP1 to
On Sat, Jul 30, 2022 at 02:06:10AM -0700, Guenter Roeck wrote:
> On 7/29/22 22:12, Paul E. McKenney wrote:
> > On Fri, Jul 29, 2022 at 11:41:55PM -0300, André Almeida wrote:
> > > Hi Paul,
> > >
> > > Às 23:25 de 29/07/22, Paul E. McKenney escreveu:
> > > > Hello!
> > > >
> > > > I am seeing the
When changing the console font with ioctl(KDFONTOP) the new font size
can be bigger than the previous font. A previous selection may thus now
be outside of the new screen size and thus trigger out-of-bounds
accesses to graphics memory if the selection is removed in
vc_do_resize().
Prevent such
The line and column numbers for the selection need to start at 1.
Add the checks to prevent invalid input.
Signed-off-by: Helge Deller
Reported-by: syzbot+14b0e8f3fd1612e35...@syzkaller.appspotmail.com
diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
index
On 7/29/22 08:51, Khalid Masum wrote:
> Here is a simplified reproducer for the issue:
>
> https://gist.githubusercontent.com/Labnann/923d6b9b3a19848fc129637b839b8a55/raw/a68271fcc724569735fe27f80817e561b3ff629a/reproducer.c
The reproducer does this:
ioctl(3, TIOCLINUX, TIOCL_SETSEL, selection:
https://bugzilla.kernel.org/show_bug.cgi?id=211807
crptdng...@gmx.net changed:
What|Removed |Added
CC||crptdng...@gmx.net
--- Comment #22
Hey all,
I am trying to test Jagan's patch series [1] to add support for the
samsung dsim bridge which is used on the imx8mm to output DSI video.
The DSIM gets the video from the mxsfb, and in my case, the DSI is
sent to the adv7535 for connecting to HDMI.
I have been able to get the device tree
Remove second 'should'
Spelling replacements
aqcuire -> acquire
applcations -> applications
assumings -> assumes
begining-> beginning
commited-> committed
contol -> control
inbetween -> in between
resorces-> resources
succesful -> successful
successfule -> successful
a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Akhil-P-Oommen/clk-qcom-Support-gdsc-collapse-polling-using-reset-inteface/20220730-171922
base
Hi Thomas,
On Wed, Jul 27, 2022 at 01:33:05PM +0200, Thomas Zimmermann wrote:
> Update XRGB-to-RGB565 conversion to support struct iosys_map
> and convert all users. Although these are single-plane color formats,
> the new interface supports multi-plane formats for consistency with
>
Variable ret is assigned a value that is never read; it is either
being re-assigned during the following while-loop or after the loop.
The assignmnt is redundant and can be removed.
Cleans up clang scan build warning:
drivers/gpu/drm/i915/gem/i915_gem_userptr.c:295:11: warning: Although
the value
On Sat, Jul 30, 2022 at 10:55 AM Markuss Broks wrote:
> On 7/29/22 00:19, Andy Shevchenko wrote:
> > On Thu, Jul 28, 2022 at 4:32 PM Markuss Broks
> > wrote:
...
> I suppose we could use something like:
>
> if (region_intersects() == REGION_INTERSECTS)
Yes.
...
> >> + ret =
We can do a few more things to improve our chance at a successful gpu
recovery, especially during a hangcheck timeout:
1. Halt CP and GMU core
2. Do RBBM GBIF HALT sequence
3. Do a soft reset of GPU core
Signed-off-by: Akhil P Oommen
---
(no changes since v1)
WARN(gpu->active_submits) during runtime_suspend doesn't make sense now
because we force runtime suspend during a gpu recovery when there are
active submissions pending.
Signed-off-by: Akhil P Oommen
---
(no changes since v1)
drivers/gpu/drm/msm/adreno/adreno_device.c | 7 ---
1 file
When prepare-slumber hfi fails, we should follow a6xx_gmu_force_off()
sequence.
Signed-off-by: Akhil P Oommen
---
(no changes since v1)
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
Because there could be transient votes from other drivers/tz/hyp which
may keep the cx gdsc enabled, we should poll until cx gdsc collapses.
We can use the reset framework to poll for cx gdsc collapse from gpucc
clk driver.
This feature requires support from the platform's gpucc driver.
We already enable gpu power from msm_gpu_submit(), so avoid a duplicate
pm_runtime_get/put from msm_job_run().
Signed-off-by: Akhil P Oommen
---
(no changes since v1)
drivers/gpu/drm/msm/msm_ringbuffer.c | 4
1 file changed, 4 deletions(-)
diff --git
In the scenario where there is one a single submit which is hung, gpu is
power collapsed when it is retired. Because of this, by the time we call
reover(), gpu state would be already clear. Fix this by correctly
managing the pm runtime votes.
Signed-off-by: Akhil P Oommen
---
(no changes since
There are some hardware logic under CX domain. For a successful
recovery, we should ensure cx headswitch collapses to ensure all the
stale states are cleard out. This is especially true to for a6xx family
where we can GMU co-processor.
Currently, cx doesn't collapse due to a devlink between gpu
Instead of separate refcount for each submit, take single rpm refcount
on behalf of all the submits. This makes it easier to drop the rpm
refcount during recovery in an upcoming patch.
Signed-off-by: Akhil P Oommen
---
(no changes since v1)
drivers/gpu/drm/msm/msm_gpu.c | 12
1
Recently, I debugged a few device crashes which occured during recovery
after a hangcheck timeout. It looks like there are a few things we can
do to improve our chance at a successful gpu recovery.
First one is to ensure that CX GDSC collapses which clears the internal
states in gpu's CX
Add a reset op compatible function to poll for gdsc collapse.
Signed-off-by: Akhil P Oommen
---
drivers/clk/qcom/gdsc.c | 23 +++
drivers/clk/qcom/gdsc.h | 7 +++
2 files changed, 26 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/qcom/gdsc.c
Add necessary definitions in gpucc bindings to ensure gpu cx gdsc collapse
through 'reset' framework for SC7280.
Signed-off-by: Akhil P Oommen
---
include/dt-bindings/clock/qcom,gpucc-sc7280.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/dt-bindings/clock/qcom,gpucc-sc7280.h
Add support for Reset using GPUCC driver for GPU. This helps to ensure
that GPU state is reset by making sure that CX head switch is collapsed.
Signed-off-by: Akhil P Oommen
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git
Allow a consumer driver to poll for cx gdsc collapse through Reset
framework.
Signed-off-by: Akhil P Oommen
---
drivers/clk/qcom/gpucc-sc7280.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc7280.c
index 9a832f2..f5df51d
Add support to allow soc specific clk drivers to specify a custom reset
operation. A consumer-driver of the reset framework can call
"reset_control_reset()" api to trigger this.
Signed-off-by: Akhil P Oommen
---
drivers/clk/qcom/reset.c | 6 ++
drivers/clk/qcom/reset.h | 2 ++
2 files
Some clients like adreno gpu driver would like to ensure that its gdsc
is collapsed at hardware during a gpu reset sequence. This is because it
has a votable gdsc which could be ON due to a vote from another subsystem
like tz, hyp etc or due to an internal hardware signal. To allow
this, gpucc
Dne petek, 29. julij 2022 ob 18:35:14 CEST je Maxime Ripard napisal(a):
> The reset line is deasserted at bind, and asserted if we ever encounter an
> error there. However, it's never deasserted in unbind which will lead to a
s/deasserted/asserted/
Once fixed:
Reviewed-by: Jernej Skrabec
Best
Dne petek, 29. julij 2022 ob 18:35:13 CEST je Maxime Ripard napisal(a):
> The other error labels in sun4i_tv_bind() are named after the task they
> perform (err_disable_clk to call clk_disable_unprepare for example).
>
> However, the err_cleanup_connector is named after the calling site
>
Dne petek, 29. julij 2022 ob 18:35:12 CEST je Maxime Ripard napisal(a):
> Our destroy implementation is just calling the generic helper, so let's
> just remove our function and directly use the helper.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Jernej Skrabec
Best regards,
Jernej
>
>
Dne petek, 29. julij 2022 ob 18:35:08 CEST je Maxime Ripard napisal(a):
> The mode_valid implementation is pretty much a nop, let's remove it.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Jernej Skrabec
Best regards,
Jernej
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c
>
Dne petek, 29. julij 2022 ob 18:35:09 CEST je Maxime Ripard napisal(a):
> The VC4 VEC driver still uses legacy enable and disable hook
s/VC4 VEC/sun4i tv/
Best regards,
Jernej
> implementation. Let's convert to the atomic variants.
>
> Signed-off-by: Maxime Ripard
>
> diff --git
On 7/29/22 22:12, Paul E. McKenney wrote:
On Fri, Jul 29, 2022 at 11:41:55PM -0300, André Almeida wrote:
Hi Paul,
Às 23:25 de 29/07/22, Paul E. McKenney escreveu:
Hello!
I am seeing the following in allmodconfig builds of recent -next on x86:
Hi Andy,
On 7/29/22 00:19, Andy Shevchenko wrote:
On Thu, Jul 28, 2022 at 4:32 PM Markuss Broks wrote:
Add early console support for generic linear framebuffer devices.
This driver supports probing from cmdline early parameters
or from the device-tree using information in simple-framebuffer
Hi Maxime,
I think that declaring PAL-B and SECAM-B as the only supported 576i
norms is a bit random.
Norms B, D, G, H, I, K, K1 and L (for both PAL and SECAM) are
essentially identical if we're talking about baseband signals, AFAIK
they only differ when those are modulated as RF signals.
Hi Maxime,
I'm just noting that the modelines you defined in drm_modes.c are
different to the ones you're removing here.
The horizontal sync differences probably doesn't matter too much, VC4
uses those only as a hint anyway and generates sync autonomously, so the
slight differences will
Hi Maxime,
I'm pretty sure that PAL-60 and SECAM-60 should be tied to the 480i
mode. Those are non-standard "norms" that use 60 Hz sync (which is
largely synonymous with 480i in the analog TV world) with PAL/SECAM
color encoding.
Best regards,
Mateusz Kwiatkowski
W dniu 29.07.2022 o 18:34,
to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Rob-Clark/dma-buf-map-info-support/20220730-010844
base
49 matches
Mail list logo
