[PATCH 2/6] drm/amdgpu: Add separate mode for syncing DMA_RESV_USAGE_BOOKKEEP.

2022-08-12 Thread Bas Nieuwenhuizen
To prep for allowing different sync modes in a follow-up patch. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11 +++

[PATCH 5/6] drm/amdgpu: Add option to disable implicit sync for a context.

2022-08-12 Thread Bas Nieuwenhuizen
This changes all BO usages in a submit to BOOKKEEP instead of READ, which effectively disables implicit sync for these submits. This is configured at a context level using the existing IOCTL. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 13 ++

[PATCH 6/6] drm/amdgpu: Bump amdgpu driver version.

2022-08-12 Thread Bas Nieuwenhuizen
For detection of the new explicit sync functionality without having to try the ioctl. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

[PATCH 3/6] drm/amdgpu: Allow explicit sync for VM ops.

2022-08-12 Thread Bas Nieuwenhuizen
This should be okay because moves themselves use KERNEL usage and hence still sync with BOOKKEEP usage. Then any later submits still wait on any pending VM operations. (i.e. we only made VM ops not wait on BOOKKEEP submits, not the other way around) Signed-off-by: Bas Nieuwenhuizen ---

[PATCH 1/6] drm/ttm: Add usage to ttm_validate_buffer.

2022-08-12 Thread Bas Nieuwenhuizen
This way callsites can choose between READ/BOOKKEEP reservations. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 1 +

[PATCH v6 7/8] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-08-12 Thread Gwan-gyeong Mun
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG.

[PATCH v6 4/8] drm/i915: Check for integer truncation on scatterlist creation

2022-08-12 Thread Gwan-gyeong Mun
From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the

[PATCH v6 6/8] drm/i915: Check if the size is too big while creating shmem file

2022-08-12 Thread Gwan-gyeong Mun
The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. v4: If BITS_PER_LONG is

[PATCH v6 3/8] drm/i915/gem: Typecheck page lookups

2022-08-12 Thread Gwan-gyeong Mun
From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe.

[PATCH v6 2/8] util_macros: Add exact_type macro to catch type mis-match while compiling

2022-08-12 Thread Gwan-gyeong Mun
It adds exact_type and exactly_pgoff_t macro to catch type mis-match while compiling. The existing typecheck() macro outputs build warnings, but the newly added exact_type() macro uses the BUILD_BUG_ON() macro to generate a build break when the types are different and can be used to detect

[PATCH v6 1/8] overflow: Move and add few utility macros into overflow

2022-08-12 Thread Gwan-gyeong Mun
It moves overflows_type utility macro into overflow header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion() macro which performs a type conversion (cast) of an source value into a new variable, checking that the

[PATCH v6 0/8] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-08-12 Thread Gwan-gyeong Mun
This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead

[PATCH libdrm v2 1/2] tests/modetest: Allocate drmModeAtomicReq before setting properties

2022-08-12 Thread Rohith Iyer
Fix null pointer deference caused by drmModeAtomicReq being allocated before set_property was called when modetest was run with the atomic flag. Reviewed-by: Rob Clark Signed-off-by: Rohith Iyer --- tests/modetest/modetest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH libdrm v2 2/2] tests/modetest: Add support for writeback connector

2022-08-12 Thread Rohith Iyer
Add writeback support to modetest with the below options: - Passing in -c will now also show the writeback connector - Test a built-in mode on writeback connector - Test a custom mode from user input on writeback connector Usage: "./modetest -M msm -x : -a -P @:+0+0@RG24." Refer

[PATCH libdrm v2 0/2] Add Writeback Support for Modetest

2022-08-12 Thread Rohith Iyer
Add writeback support to modetest with the below options: - Passing in -c will now also show the writeback connector - Test a built-in mode on writeback connector - Test a custom mode from user input on writeback connector Usage: "./modetest -M msm -x : -a -P @:+0+0@RG24." Refer

Re: [PATCH 2/4] dt-bindings: display: sun6i-dsi: Add the A100 variant

2022-08-12 Thread Samuel Holland
Hi Krzysztof, On 8/12/22 5:49 AM, Krzysztof Kozlowski wrote: > On 12/08/2022 10:42, Samuel Holland wrote: >> The "40nm" MIPI DSI controller found in the A100 and D1 SoCs has the >> same register layout as previous SoC integrations. However, its module >> clock now comes from the TCON, which means

[PATCH] drm/virtio: Fix same-context optimization

2022-08-12 Thread Rob Clark
From: Rob Clark When VIRTGPU_EXECBUF_RING_IDX is used, we should be considering the timeline that the EB if running on rather than the global driver fence context. Fixes: 85c83ea915ed ("drm/virtio: implement context init: allocate an array of fence contexts") Signed-off-by: Rob Clark ---

Re: Selecting CPUs for queuing work on

2022-08-12 Thread Tejun Heo
Hello, On Fri, Aug 12, 2022 at 04:54:04PM -0400, Felix Kuehling wrote: > In principle, I think IRQ routing to CPUs can change dynamically with > irqbalance. I wonder whether this is something which should be exposed to userland rather than trying to do dynamically in the kernel and let

[PATCH 3/5] drm/msm: Drop of_gpio header

2022-08-12 Thread Maíra Canal
These drivers include the deprecated OF GPIO header yet fail to use symbols from it, so drop the include. Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Signed-off-by: Maíra Canal --- drivers/gpu/drm/msm/dp/dp_parser.c | 2 +- drivers/gpu/drm/msm/hdmi/hdmi.c| 1 - 2

[PATCH 4/5] drm/sti: Drop of_gpio header

2022-08-12 Thread Maíra Canal
This driver includes the deprecated OF GPIO header yet fail to use symbols from it, so drop this include. Cc: Alain Volmat Signed-off-by: Maíra Canal --- drivers/gpu/drm/sti/sti_dvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_dvo.c

[PATCH 5/5] drm/vc4: Drop of_gpio header

2022-08-12 Thread Maíra Canal
This driver includes the deprecated OF GPIO header yet fail to use symbols from it, so drop the include. Cc: Emma Anholt Cc: Maxime Ripard Signed-off-by: Maíra Canal --- drivers/gpu/drm/vc4/vc4_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c

[PATCH 2/5] drm/mediatek: Drop of_gpio header

2022-08-12 Thread Maíra Canal
These drivers include the deprecated OF GPIO header yet fail to use symbols from it, so drop the include. Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Matthias Brugger Cc: linux-media...@lists.infradead.org Signed-off-by: Maíra Canal --- drivers/gpu/drm/mediatek/mtk_dpi.c | 1 -

[PATCH 1/5] drm/bridge: anx7625: Drop of_gpio header

2022-08-12 Thread Maíra Canal
This driver includes the deprecated OF GPIO header yet fail to use symbols from it, so drop the include. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Maíra Canal --- drivers/gpu/drm/bridge/analogix/anx7625.c

[PATCH 0/5] Drop of_gpio header

2022-08-12 Thread Maíra Canal
The legacy GPIO header and the deprecated OF GPIO header should not be used anymore due to the existance of the new GPIO header . Currently, the DRM still holds seven OF GPIO header includes. That said, this series drops all the OF GPIO header includes from the DRM, replacing it, when proper,

Re: Selecting CPUs for queuing work on

2022-08-12 Thread Felix Kuehling
On 2022-08-12 16:30, Tejun Heo wrote: On Fri, Aug 12, 2022 at 04:26:47PM -0400, Felix Kuehling wrote: Hi workqueue maintainers, In the KFD (amdgpu) driver we found a need to schedule bottom half interrupt handlers on CPU cores different from the one where the top-half interrupt handler runs to

Re: Selecting CPUs for queuing work on

2022-08-12 Thread Tejun Heo
On Fri, Aug 12, 2022 at 04:26:47PM -0400, Felix Kuehling wrote: > Hi workqueue maintainers, > > In the KFD (amdgpu) driver we found a need to schedule bottom half interrupt > handlers on CPU cores different from the one where the top-half interrupt > handler runs to avoid the interrupt handler

Selecting CPUs for queuing work on

2022-08-12 Thread Felix Kuehling
Hi workqueue maintainers, In the KFD (amdgpu) driver we found a need to schedule bottom half interrupt handlers on CPU cores different from the one where the top-half interrupt handler runs to avoid the interrupt handler stalling the bottom half in extreme scenarios. See my latest patch that

Re: [PATCH] drm/amdgpu: use native mode for dp aux transfer

2022-08-12 Thread kernel test robot
Hi Zhenneng, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v5.19 next-20220812] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH AUTOSEL 5.10 01/46] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-08-12 Thread Pavel Machek
Hi! In this series, I only received patches up-to 42/46. Is problem at sender or receiver? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures)

Re: [PATCH 4/4] drm/format-helper: Add drm_fb_build_fourcc_list() helper

2022-08-12 Thread Sam Ravnborg
Hi Thomas, On Wed, Aug 10, 2022 at 01:20:53PM +0200, Thomas Zimmermann wrote: > Add drm_fb_build_fourcc_list() function that builds a list of supported > formats from native and emulated ones. Helpful for all drivers that do > format conversion as part of their plane updates. Update current

[PATCH] drm/amd/amdgpu: Replace kmap() with kmap_local_page()

2022-08-12 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it

Re: [PATCH] drm/amd/display: remove unreachable code

2022-08-12 Thread Tales Lelo da Aparecida
Hi, On 12/08/2022 00:19, Jiapeng Chong wrote: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:1658 dml32_TruncToValidBPP() warn: ignoring unreachable code. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1894 Reported-by: Abaci Robot Signed-off-by: Jiapeng

Re: [PATCH 2/4] drm/probe-helper: Add drm_crtc_helper_mode_valid_static()

2022-08-12 Thread Sam Ravnborg
On Fri, Aug 12, 2022 at 06:37:17PM +0200, Thomas Zimmermann wrote: > Hi Sam > > Am 10.08.22 um 21:26 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Wed, Aug 10, 2022 at 01:20:51PM +0200, Thomas Zimmermann wrote: > > > Add drm_crtc_helper_mode_valid_static(), which validates a given mode > > >

Re: [PATCH] spi/panel: dt-bindings: drop 3-wire from common properties

2022-08-12 Thread Rob Herring
On Wed, 10 Aug 2022 16:13:11 +0300, Krzysztof Kozlowski wrote: > The spi-3wire property is device specific and should be accepted only if > device really needs them. Drop it from common spi-peripheral-props.yaml > schema, mention in few panel drivers which use it and include instead in > the SPI

Re: [EXT] Re: [PATCH 1/3] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-12 Thread Brian Starkey
Hi, On Mon, Aug 08, 2022 at 02:39:53PM +, Olivier Masse wrote: > Hi Brian, > > On ven., 2022-08-05 at 16:41 +0100, Brian Starkey wrote: > > Caution: EXT Email > > > > Hi Olivier, > > > > Thanks, I think this is looking much better. > > > > I'd like to know how others feel about landing

Re: [PATCH 2/4] drm/probe-helper: Add drm_crtc_helper_mode_valid_static()

2022-08-12 Thread Thomas Zimmermann
Hi Sam Am 10.08.22 um 21:26 schrieb Sam Ravnborg: Hi Thomas, On Wed, Aug 10, 2022 at 01:20:51PM +0200, Thomas Zimmermann wrote: Add drm_crtc_helper_mode_valid_static(), which validates a given mode against a display hardware's mode. Convert simpledrm and use it in a few other drivers with

Re: [git pull] drm fixes for 6.0-rc1

2022-08-12 Thread pr-tracker-bot
The pull request you sent on Fri, 12 Aug 2022 06:09:44 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2022-08-12-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7ce2aa6d7fe121e243e1c8a8093911fecdf1c88e Thank you! -- Deet-doot-dot, I am a bot.

Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset

2022-08-12 Thread Ceraolo Spurio, Daniele
On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall occurred; when the CTs have space again we pick up the

Re: [PATCH 1/3] dt-bindings: display/msm: Add binding for SC8280XP MDSS

2022-08-12 Thread Rob Herring
On Wed, 10 Aug 2022 21:01:19 -0700, Bjorn Andersson wrote: > Add binding for the display subsystem and display processing unit in the > Qualcomm SC8280XP platform. > > Signed-off-by: Bjorn Andersson > --- > .../bindings/display/msm/dpu-sc8280xp.yaml| 284 ++ > 1 file

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-12 Thread Rob Clark
On Fri, Aug 12, 2022 at 7:57 AM Rob Clark wrote: > > On Fri, Aug 12, 2022 at 4:26 AM Dmitry Osipenko > wrote: > > > > On 8/11/22 02:19, Rob Clark wrote: > > > On Wed, Aug 10, 2022 at 3:23 PM Dmitry Osipenko > > > wrote: > > >> > > >> On 8/11/22 01:03, Rob Clark wrote: > > >>> On Wed, Aug 10,

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-12 Thread Rob Clark
On Fri, Aug 12, 2022 at 4:26 AM Dmitry Osipenko wrote: > > On 8/11/22 02:19, Rob Clark wrote: > > On Wed, Aug 10, 2022 at 3:23 PM Dmitry Osipenko > > wrote: > >> > >> On 8/11/22 01:03, Rob Clark wrote: > >>> On Wed, Aug 10, 2022 at 12:26 PM Dmitry Osipenko > >>> wrote: > > On 8/10/22

[RFC 4/4] phy/rockchip: inno-dsidphy: Add support for rk3568

2022-08-12 Thread Chris Morgan
From: Chris Morgan Add support for the Rockchip RK3568 DSI-DPHY. Registers were taken from the BSP kernel driver and wherever possible cross referenced with the TRM. Signed-off-by: Chris Morgan --- .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 204 ++ 1 file changed, 158

[RFC 3/4] drm/rockchip: dsi: add rk3568 support

2022-08-12 Thread Chris Morgan
From: Chris Morgan Add the compatible and GRF definitions for the RK3568 soc. Signed-off-by: Chris Morgan --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 51 ++- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c

[RFC 1/4] dt-bindings: display: rockchip-dsi: add rk3568 compatible

2022-08-12 Thread Chris Morgan
From: Chris Morgan The rk3568 uses the same dw-mipi-dsi controller as previous Rockchip SOCs, so add a compatible string for it. Signed-off-by: Chris Morgan --- .../bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[RFC 2/4] dt-bindings: phy: phy-rockchip-inno-dsidphy: add compatible for rk3568

2022-08-12 Thread Chris Morgan
From: Chris Morgan Add a compatible string for the rk3568 dsi-dphy. Signed-off-by: Chris Morgan --- .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml

[RFC 0/4] rockchip-dsi for rk3568

2022-08-12 Thread Chris Morgan
From: Chris Morgan This series adds support for the dsi and dphy controllers on the Rockchip RK3568. I can confirm that for the Rockchip RK3568 this current series DOES NOT WORK properly yet. The image on the screen is shifted about 100 pixels to the right and does not appear to be a timing

[PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-12 Thread Olivier Masse
From: Etienne Carriere This change allows userland to create a tee_shm object that refers to a dmabuf reference. Userland provides a dmabuf file descriptor as buffer reference. The created tee_shm object exported as a brand new dmabuf reference used to provide a clean fd to userland. Userland

[PATCH v2 0/1] tee: Add tee_shm_register_fd

2022-08-12 Thread Olivier Masse
Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a shared memory from a dmabuf file descriptor. This new ioctl will allow the Linux Kernel to register a buffer to be used by the Secure Data Path OPTEE OS feature. Please find more information here:

Re: [EXT] Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-12 Thread Olivier Masse
Hi Sumit, Thanks for your comments, please find my answer below. On ven., 2022-08-12 at 19:36 +0530, Sumit Garg wrote: > Caution: EXT Email > > Hi Olivier, > > On Thu, 11 Aug 2022 at 19:26, Olivier Masse > wrote: > > > > From: Etienne Carriere > > > > This change allows userland to create

[PATCH] drm/panel: simple: Add Multi-Inno Technology MI0800FT-9

2022-08-12 Thread Christoph Niedermaier
Add Multi-Inno Technology MI0800FT-9 8" 800x600 DPI panel support. Signed-off-by: Christoph Niedermaier Cc: Sam Ravnborg To: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/panel/panel-simple.c | 33 + 1 file changed, 33 insertions(+) diff --git

Re: [PATCH v1 34/35] drm/modes: Introduce the tv_mode property as a command-line option

2022-08-12 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Jul 29, 2022 at 6:37 PM Maxime Ripard wrote: > Our new tv mode option allows to specify the TV mode from a property. > However, it can still be useful, for example to avoid any boot time > artifact, to set that property directly from the kernel command line. > > Let's add some

[PATCH v6 6/6] drm/ttm: Switch to using the new res callback

2022-08-12 Thread Arunpravin Paneer Selvam
Apply new intersect and compatible callback instead of having a generic placement range verfications. v2: Added a separate callback for compatiblilty checks (Christian) v3: Cleanups and removal of workarounds Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam ---

[PATCH v6 5/6] drm/nouveau: Implement intersect/compatible functions

2022-08-12 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching the start offset from struct ttm_resource. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/nouveau/nouveau_mem.c | 29 +++

[PATCH v6 4/6] drm/i915: Implement intersect/compatible functions

2022-08-12 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching start offset from drm buddy allocator. v3: move the bits that are specific to buddy_man (Matthew) v4: consider the block size /range (Matthew) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam

[PATCH v6 3/6] drm/amdgpu: Implement intersect/compatible functions

2022-08-12 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback function fetching start offset from backend drm buddy allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 38 +++

[PATCH v6 2/6] drm/ttm: Implement intersect/compatible functions

2022-08-12 Thread Arunpravin Paneer Selvam
Implemented a new intersect and compatible callback functions to ttm range manager fetching start offset from drm mm range allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/ttm/ttm_range_manager.c | 33 + 1 file

[PATCH v6 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-12 Thread Arunpravin Paneer Selvam
We are adding two new callbacks to ttm resource manager function to handle intersection and compatibility of placement and resources. v2: move the amdgpu and ttm_range_manager changes to separate patches (Christian) v3: rename "intersect" to "intersects" (Matthew) v4: move !place check to the

Re: [PATCH v1 09/35] drm/modes: Move named modes parsing to a separate function

2022-08-12 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Jul 29, 2022 at 6:36 PM Maxime Ripard wrote: > The current construction of the named mode parsing doesn't allow to extend > it easily. Let's move it to a separate function so we can add more > parameters and modes. > > Signed-off-by: Maxime Ripard Thanks for your patch,

Re: [PATCH v1 07/35] drm/modes: Only consider bpp and refresh before options

2022-08-12 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Jul 29, 2022 at 6:35 PM Maxime Ripard wrote: > Some video= options might have a value that contains a dash. However, the > command line parsing mode considers all dashes as the separator between the > mode and the bpp count. > > Let's rework the parsing code a bit to only

Re: [PATCH v1 05/35] drm/connector: Add TV standard property

2022-08-12 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Jul 29, 2022 at 6:35 PM Maxime Ripard wrote: > The TV mode property has been around for a while now to select and get the > current TV mode output on an analog TV connector. > > Despite that property name being generic, its content isn't and has been > driver-specific which

Re: [EXT] Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-12 Thread Olivier Masse
Hi Christian, On ven., 2022-08-12 at 12:18 +0200, Christian König wrote: > Caution: EXT Email > > Hi Etienne, > > at least I don't see anything obvious broken. > > Just two comments: > > 1. Dmitry is working on a change which renames some functions and > makes > it mandatory to call them with

Re: [PATCH v1 04/35] drm/modes: Introduce 480i and 576i modes

2022-08-12 Thread Geert Uytterhoeven
Hi Maxime, Thanks for your patch! On Fri, Jul 29, 2022 at 6:35 PM Maxime Ripard wrote: > Multiple drivers (meson, vc4) define the analog TV 525-lines and 625-lines > modes in the drivers. Nit: strictly speaking these are not analog modes, but the digital variants (ITU-R BT.656 and DVD-Video

Re: [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-12 Thread Dmitry Osipenko
On 8/12/22 14:34, Christian König wrote: > > > Am 10.08.22 um 20:53 schrieb Dmitry Osipenko: >> On 8/10/22 21:25, Christian König wrote: >>> Am 10.08.22 um 19:49 schrieb Dmitry Osipenko: On 8/10/22 14:30, Christian König wrote: > Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: >> This

Re: [Linaro-mm-sig] [PATCH v2 3/5] dma-buf: Move all dma-bufs to dynamic locking specification

2022-08-12 Thread Christian König
Am 10.08.22 um 20:53 schrieb Dmitry Osipenko: On 8/10/22 21:25, Christian König wrote: Am 10.08.22 um 19:49 schrieb Dmitry Osipenko: On 8/10/22 14:30, Christian König wrote: Am 25.07.22 um 17:18 schrieb Dmitry Osipenko: This patch moves the non-dynamic dma-buf users over to the dynamic

[PATCH v3] drm/fb-helper: add virtual screen size check to drm_fb_helper_check_var()

2022-08-12 Thread Andrey Strachuk
Make sure that virtual screen size is not less than physical screen one. Reviewed-by: Geert Uytterhoeven Signed-off-by: Andrey Strachuk --- drivers/gpu/drm/drm_fb_helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_fb_helper.c

Re: [PATCH v8 2/2] drm/gem: Don't map imported GEMs

2022-08-12 Thread Dmitry Osipenko
On 8/11/22 02:19, Rob Clark wrote: > On Wed, Aug 10, 2022 at 3:23 PM Dmitry Osipenko > wrote: >> >> On 8/11/22 01:03, Rob Clark wrote: >>> On Wed, Aug 10, 2022 at 12:26 PM Dmitry Osipenko >>> wrote: On 8/10/22 18:08, Rob Clark wrote: > On Wed, Aug 10, 2022 at 4:47 AM Daniel Vetter

Re: [PATCH] drm/amdgpu: remove useless condition in amdgpu_job_stop_all_jobs_on_sched()

2022-08-12 Thread Christian König
@Alex was that one already picked up? Am 25.07.22 um 18:40 schrieb Andrey Grodzovsky: Reviewed-by: Andrey Grodzovsky Andrey On 2022-07-19 06:39, Andrey Strachuk wrote: Local variable 'rq' is initialized by an address of field of drm_sched_job, so it does not make sense to compare 'rq' with

Re: [PATCH] drm/radeon: add a force flush to delay work when radeon

2022-08-12 Thread Christian König
Am 11.08.22 um 09:25 schrieb Zhenneng Li: Although radeon card fence and wait for gpu to finish processing current batch rings, there is still a corner case that radeon lockup work queue may not be fully flushed, and meanwhile the radeon_suspend_kms() function has called pci_set_power_state()

Re: [PATCH 2/4] dt-bindings: display: sun6i-dsi: Add the A100 variant

2022-08-12 Thread Krzysztof Kozlowski
On 12/08/2022 10:42, Samuel Holland wrote: > The "40nm" MIPI DSI controller found in the A100 and D1 SoCs has the > same register layout as previous SoC integrations. However, its module > clock now comes from the TCON, which means it no longer runs at a fixed > rate, so this needs to be

Re: [PATCH 1/4] dt-bindings: display: sun6i-dsi: Fix clock conditional

2022-08-12 Thread Krzysztof Kozlowski
On 12/08/2022 10:42, Samuel Holland wrote: > The A64 case should have limited maxItems, instead of duplicating the > minItems value from the main binding. While here, simplify the binding > by making this an "else" case of the two-clock conditional block. > > Fixes: fe5040f2843a ("dt-bindings:

Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-12 Thread Christian König
Hi Etienne, at least I don't see anything obvious broken. Just two comments: 1. Dmitry is working on a change which renames some functions and makes it mandatory to call them with the dma_resv lock held. Depending on how you want to upstream this change you will certainly run into

[PATCH v2 5/7] gpu: drm: simplify drivers using devm_regulator_*get_enable*()

2022-08-12 Thread Matti Vaittinen
Simplify drivers using managed "regulator get and enable". meson: Use the devm_regulator_get_enable_optional(). Also drop the seemingly unused struct member 'hdmi_supply'. sii902x: Simplify using devm_regulator_bulk_get_enable() Signed-off-by: Matti Vaittinen --- RFCv1 => v2: - Change also

[PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-12 Thread Matti Vaittinen
Devm helpers for regulator get and enable First patch in the series is actually just a simple documentation fix which could be taken in as it is now. A few* drivers seem to use pattern demonstrated by pseudocode: - devm_regulator_get() - regulator_enable() -

Re: [PATCH] dt-bindings: display: sun4i: Add D1 TCONs to conditionals

2022-08-12 Thread Krzysztof Kozlowski
On 12/08/2022 10:37, Samuel Holland wrote: > When adding the D1 TCON bindings, I missed the conditional blocks that > restrict the binding for TCON LCD vs TCON TV hardware. Add the D1 TCON > variants to the appropriate blocks for DE2 TCON LCDs and TCON TVs. > > Fixes: ae5a5d26c15c ("dt-bindings:

[PATCH 4/4] drm/sun4i: dsi: Add the A100 variant

2022-08-12 Thread Samuel Holland
The A100 variant of the MIPI DSI controller now gets its module clock from the TCON via the TCON TOP, so the clock rate cannot be set to a fixed value. Otherwise, it appears to be the same as the A31 variant. Signed-off-by: Samuel Holland --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 8

[PATCH 3/4] drm/sun4i: dsi: Add a variant structure

2022-08-12 Thread Samuel Holland
Replace the ad-hoc calls to of_device_is_compatible() with a structure describing the differences between variants. This is in preparation for adding more variants to the driver. Signed-off-by: Samuel Holland --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 50 +-

[PATCH 2/4] dt-bindings: display: sun6i-dsi: Add the A100 variant

2022-08-12 Thread Samuel Holland
The "40nm" MIPI DSI controller found in the A100 and D1 SoCs has the same register layout as previous SoC integrations. However, its module clock now comes from the TCON, which means it no longer runs at a fixed rate, so this needs to be distinguished in the driver. The controller also now uses

[PATCH 0/4] drm/sun4i: dsi: Support the A100/D1 controller variant

2022-08-12 Thread Samuel Holland
This series adds support for the digital part of the DSI controller found in the A100 and D1 SoCs (plus T7, which is not supported by mainline Linux). There are two changes to the hardware integration: 1) the module clock routes through the TCON TOP, and 2) the separate I/O domain is removed.

[PATCH 1/4] dt-bindings: display: sun6i-dsi: Fix clock conditional

2022-08-12 Thread Samuel Holland
The A64 case should have limited maxItems, instead of duplicating the minItems value from the main binding. While here, simplify the binding by making this an "else" case of the two-clock conditional block. Fixes: fe5040f2843a ("dt-bindings: sun6i-dsi: Document A64 MIPI-DSI controller")

[PATCH] dt-bindings: display: sun4i: Add D1 TCONs to conditionals

2022-08-12 Thread Samuel Holland
When adding the D1 TCON bindings, I missed the conditional blocks that restrict the binding for TCON LCD vs TCON TV hardware. Add the D1 TCON variants to the appropriate blocks for DE2 TCON LCDs and TCON TVs. Fixes: ae5a5d26c15c ("dt-bindings: display: Add D1 display engine compatibles")

Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset

2022-08-12 Thread Tvrtko Ursulin
On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall occurred; when the CTs have space again we pick up the request submission from where we left off.

[PATCH] drm/vmwgfx: Fix comment typo

2022-08-12 Thread min tang
The double `to' is duplicated in line 384, remove one,The double `to' is duplicated in line 412, remove one. Signed-off-by: min tang --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c

Re: [ldv-project] [PATCH v2] drm/fb-helper: add virtual screen size check to drm_fb_helper_check_var()

2022-08-12 Thread Alexey Khoroshilov
For v2 I would suggest to update description to something like this: Make sure that virtual screen size is not less than physical screen one. and comment to: /* make sure that virtual resolution >= physical resolution */ -- Alexey On 11.08.2022 17:54, Geert Uytterhoeven wrote: > Hi

[PATCH] drm/vmwgfx: Fix comment typo

2022-08-12 Thread min tang
The double `should' is duplicated in line 72, remove one. Signed-off-by: min tang --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.h index

[PATCH 2/3] drm/i915/gt: Replace kmap() with kmap_local_page()

2022-08-12 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it

[PATCH 0/3] drm/i915: Replace kmap() with kmap_local_page()

2022-08-12 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it

[PATCH] drm/ttm: Fix comment typo

2022-08-12 Thread min tang
The double `sure' is duplicated in line 454, remove one. Signed-off-by: min tang --- drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c b/drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c index

[PATCH] drm/i915: Fix comment typo

2022-08-12 Thread min tang
The double `for' is duplicated in line 2537, remove one. Signed-off-by: min tang --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 9ccb67eec1bd..617a33e4bbb6 100644 ---

Re: [PATCH] drm/bridge_connector: enable HPD by default if supported

2022-08-12 Thread Yongqin Liu
Hi, Nikita, All We have one X15 Android build based on the android mainline kernel, and it failed to boot with this change because of one kernel panic. And it would boot to the home screen if this change is reverted. Could you please help have a look and give suggestions on what should be done

[PATCH 3/3] drm/i915/gem: Replace kmap() with kmap_local_page()

2022-08-12 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-08-12 Thread Yongqin Liu
Hi, Ivaylo, Tomi We have one X15 Android AOSP master build, it could not have the home screen displayed on the hdmi monitor connected with this change, with the following message printed on the serial console [ 607.404205] omapdrm omapdrm.0: Failed to setup plane plane-0 [ 607.410522]

[PATCH 1/3] drm/i915: Replace kmap() with kmap_local_page()

2022-08-12 Thread Fabio M. De Francesco
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap’s pool wraps and it

[PATCH] drm: Fix comment typo

2022-08-12 Thread min tang
The double `buffer' is duplicated in line 96, remove one. Signed-off-by: min tang --- drivers/gpu/drm/drm_vblank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index 2ff31717a3de..25660c30bbbf 100644 ---

RE: [PATCH v3 2/3] drm/amdgpu_dm: Rely on split out luminance calculation function

2022-08-12 Thread Jani Nikula
On Thu, 11 Aug 2022, "Deucher, Alexander" wrote: > [Public] > >> -Original Message- >> From: amd-gfx On Behalf Of Jani >> Nikula >> Sent: Thursday, August 4, 2022 5:55 AM >> To: Jouni Högander ; dri- >> de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd- >>

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-12 Thread Greg KH
On Thu, Aug 11, 2022 at 06:52:40PM +0200, Daniel Vetter wrote: > On Wed, Aug 03, 2022 at 04:13:05PM -0400, Jason Baron wrote: > > > > > > On 8/3/22 15:56, jim.cro...@gmail.com wrote: > > > On Wed, Jul 20, 2022 at 9:32 AM Jim Cromie wrote: > > >> > > > > > >> Hi Jason, Greg, DRM-folk, > > >> >