Re: [PATCH 01/10] Revert "drm/msm: Add missing check and destroy for alloc_ordered_workqueue"

2023-03-07 Thread Johan Hovold
On Wed, Mar 08, 2023 at 10:10:24AM +0800, Jiasheng Jiang wrote: > On Mon, 06 Mar 2023 18:07:13 +0800, Johan Hovold wrote: > > This reverts commit 643b7d0869cc7f1f7a5ac7ca6bd25d88f54e31d0. > > The commit not only adds the allocation sanity check, but also adds the > destroy_workqueue to release

[PATCH 11/13] backlight: qcom-wled: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 09/13] backlight: mt6370-backlight: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 00/13] backlight: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
Hello, this patch series adapts the platform drivers below drivers/video/backlight to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The

[PATCH 04/13] backlight: da9052_bl: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 10/13] backlight: pwm_bl: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 08/13] backlight: lp8788_bl: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 02/13] backlight: adp5520_bl: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 12/13] backlight: rt4831-backlight: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 13/13] backlight: sky81452-backlight: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 06/13] backlight: led_bl: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 01/13] backlight: aat2870_bl: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 05/13] backlight: hp680_bl: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 07/13] backlight: lm3533_bl: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

[PATCH 03/13] backlight: cr_bllcd: Convert to platform remove callback returning void

2023-03-07 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

Re: [PATCH v13 01/10] device property: Add remote endpoint to devcon matcher

2023-03-07 Thread Heikki Krogerus
On Fri, Mar 03, 2023 at 10:33:41PM +0800, Pin-yen Lin wrote: > From: Prashant Malani > > When searching the device graph for device matches, check the > remote-endpoint itself for a match. > > Some drivers register devices for individual endpoints. This allows > the matcher code to evaluate

[PATCH] MAINTAINERS: orphan SIS FRAMEBUFFER DRIVER

2023-03-07 Thread Lukas Bulwahn
This was triggered by the fact that the webpage: http://www.winischhofer.net/linuxsisvga.shtml cannot be reached anymore. Thomas Winischhofer is still reachable at the given email address, but he has not been active since 2005. Mark the SIS FRAMEBUFFER DRIVER as orphan to reflect the current

[PATCH] fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release()

2023-03-07 Thread Takashi Iwai
The recent fix for the deferred I/O by the commit 3efc61d95259 ("fbdev: Fix invalid page access after closing deferred I/O devices") caused a regression when the same fb device is opened/closed while it's being used. It resulted in a frozen screen even if something is redrawn there after the

Re: [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-07 Thread Christian König
Am 08.03.23 um 03:26 schrieb Steven Rostedt: On Tue, 7 Mar 2023 21:22:23 -0500 Steven Rostedt wrote: Looks like there was a lock possibly used after free. But as commit 9bff18d13473a9fdf81d5158248472a9d8ecf2bd ("drm/ttm: use per BO cleanup workers") changed a lot of this code, I figured it

Re: [PATCH 3/3] drm/i915/pmu: Use common freq functions with sysfs

2023-03-07 Thread Belgaumkar, Vinay
On 3/7/2023 9:33 PM, Ashutosh Dixit wrote: Using common freq functions with sysfs in PMU (but without taking forcewake) solves the following issues (a) missing support for MTL (b) For the requested_freq, we read it only if actual_freq is zero below (meaning, GT is in C6). So then what is

[PATCH -next] fbdev/clps711x-fb: Use devm_platform_get_and_ioremap_resource()

2023-03-07 Thread Yang Li
According to commit 890cc39a8799 ("drivers: provide devm_platform_get_and_ioremap_resource()"), convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li ---

Re: [PATCH 2/2] drm/i915/pmu: Use correct requested freq for SLPC

2023-03-07 Thread Dixit, Ashutosh
On Mon, 06 Mar 2023 03:10:24 -0800, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 04/03/2023 01:27, Ashutosh Dixit wrote: > > SLPC does not use 'struct intel_rps'. Use UNSLICE_RATIO bits from > > Would it be more accurate to say 'SLPC does not use rps->cur_freq' rather > than it not using struct

Re: [PATCH 1/2] drm/i915/pmu: Use only freq bits for falling back to requested freq

2023-03-07 Thread Dixit, Ashutosh
On Mon, 06 Mar 2023 03:04:40 -0800, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 04/03/2023 01:27, Ashutosh Dixit wrote: > > On newer generations, the GEN12_RPSTAT1 register contains more than freq > > information, e.g. see GEN12_VOLTAGE_MASK. Therefore use only the freq bits > > to decide whether to

[PATCH 0/3] drm/i915/pmu: Use common freq functions with sysfs

2023-03-07 Thread Ashutosh Dixit
Using common freq functions with sysfs in PMU (but without taking forcewake) solves the following issues (a) missing support for MTL (b) missing support for older generations (prior to Gen6) (c) missing support for slpc when freq sampling has to fall back to requested freq. It also makes the PMU

[PATCH 2/3] drm/i915/rps: Expose get_requested_frequency_fw for PMU

2023-03-07 Thread Ashutosh Dixit
Expose intel_rps_get_requested_frequency_fw to read the requested freq without taking forcewake. This is done for use by PMU which does not take forcewake when reading freq. The code is refactored to use a common set of functions across sysfs and PMU. It also allows PMU to support both host turbo

[PATCH 3/3] drm/i915/pmu: Use common freq functions with sysfs

2023-03-07 Thread Ashutosh Dixit
Using common freq functions with sysfs in PMU (but without taking forcewake) solves the following issues (a) missing support for MTL (b) missing support for older generation (prior to Gen6) (c) missing support for slpc when freq sampling has to fall back to requested freq. It also makes the PMU

[PATCH 1/3] drm/i915/rps: Expose read_actual_frequency_fw for PMU

2023-03-07 Thread Ashutosh Dixit
Expose intel_rps_read_actual_frequency_fw to read the actual/granted freq without taking forcewake. This is done for use by PMU which does not take forcewake when reading freq. The code is refactored to use a common set of functions across sysfs and PMU. It also allows PMU to support MTL as well

Re: [PATCH 9/9] drm: move ttm_execbuf_util into vmwgfx

2023-03-07 Thread Zack Rusin
On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote: > VMWGFX is the only remaining user of this and should probably moved over > to drm_exec when it starts using GEM as well. Is this because vmwgfx piggybacks buffer-id relocations on top of ttm validations or did you just find it too hard

[PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-07 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v3: - Refactor source code Changes in v2: - Refactor and clean up source code MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig

[PATCH v3 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-03-07 Thread Jianhua Lu
Novatek NT36523 is a display driver IC used to drive DSI panels. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- Changes in v3: - pick up Krzysztof's R-b Changes in v2: - Drop unnecessary description - dsi0 -> dsi - Correct indentation

Re: [BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-07 Thread Steven Rostedt
On Tue, 7 Mar 2023 21:22:23 -0500 Steven Rostedt wrote: > Looks like there was a lock possibly used after free. But as commit > 9bff18d13473a9fdf81d5158248472a9d8ecf2bd ("drm/ttm: use per BO cleanup > workers") changed a lot of this code, I figured it may be the culprit. If I bothered to look

[BUG 6.3-rc1] Bad lock in ttm_bo_delayed_delete()

2023-03-07 Thread Steven Rostedt
In a report for a regression in my code, I tried to run v6.3-rc1 through my tests. It crashed at boot up on my first test (my start up tests do take a long time, hence the 206 seconds of boot!). [ 206.238782] [ cut here ] [ 206.277786] DEBUG_LOCKS_WARN_ON(lock->magic

Re: [PATCH 01/10] Revert "drm/msm: Add missing check and destroy for alloc_ordered_workqueue"

2023-03-07 Thread Jiasheng Jiang
On Mon, 06 Mar 2023 18:07:13 +0800, Johan Hovold wrote: > This reverts commit 643b7d0869cc7f1f7a5ac7ca6bd25d88f54e31d0. The commit not only adds the allocation sanity check, but also adds the destroy_workqueue to release the allocated priv->wq. Therefore, revert the commit will cause memory leak.

Re: [PATCH v2 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-07 Thread Jianhua Lu
On Tue, Mar 07, 2023 at 11:34:55PM +0100, Linus Walleij wrote: > Hi Jianhua, > > thanks for your patch! > > It appears Konrad is working on a very similar driver, so I suggest merging > them into one Novatek NT36523 driver. > > Possibly we can fix this up first and then add Konrads Lenovo-panel

Re: [PATCH v2 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-07 Thread Jianhua Lu
On Tue, Mar 07, 2023 at 11:34:55PM +0100, Linus Walleij wrote: > Hi Jianhua, > > thanks for your patch! > > It appears Konrad is working on a very similar driver, so I suggest merging > them into one Novatek NT36523 driver. > > Possibly we can fix this up first and then add Konrads Lenovo-panel

Re: [PATCH 1/2] dt-bindings: display/bridge: toshiba,tc358764: convert to dtschema

2023-03-07 Thread Rob Herring
On Sat, 25 Feb 2023 17:02:51 +0100, Krzysztof Kozlowski wrote: > Convert the Toshiba TC358764 bridge bindings to DT schema. > > Signed-off-by: Krzysztof Kozlowski > --- > .../display/bridge/toshiba,tc358764.txt | 35 > .../display/bridge/toshiba,tc358764.yaml | 89

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-03-07 Thread Jianhua Lu
On Tue, Mar 07, 2023 at 11:22:35PM +0100, Linus Walleij wrote: > On Mon, Feb 20, 2023 at 1:13 PM Jianhua Lu wrote: > > > Novatek NT36523 is a display driver IC used to drive DSI panels. > > > > Signed-off-by: Jianhua Lu > > --- > > Changes in v2: > > - Drop unnecessary description > > -

Re: [PATCH] dt-bindings: display: bridge: parade,ps8622: convert to dtschema

2023-03-07 Thread Rob Herring
On Tue, 21 Feb 2023 18:09:55 +0100, Krzysztof Kozlowski wrote: > Convert the Parade PS8622/PS8625 DisplayPort to LVDS Converter bindings > to DT schema. Changes during conversion: add missing vdd12-supply, used > by Linux driver. > > Signed-off-by: Krzysztof Kozlowski > --- >

[PATCH] drm/amdkfd: fix a potential double free in pqm_create_queue

2023-03-07 Thread Chia-I Wu
Set *q to NULL on errors, otherwise pqm_create_queue would free it again. Signed-off-by: Chia-I Wu --- drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c

Re: [PATCH] drm/amd/display: remove legacy fields of dc_plane_cap struct

2023-03-07 Thread Rodrigo Siqueira Jordao
On 3/7/23 15:53, David Tadokoro wrote: The fields blends_with_above and blends_with_below of struct dc_plane_cap (defined in dc/dc.h) are boolean and set to true by default. All instances of a dc_plane_cap maintain the default values of both. Also, there is only one if statement that checks

Re: [PATCH v4 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel

2023-03-07 Thread Linus Walleij
On Thu, Jan 19, 2023 at 5:32 PM Konrad Dybcio wrote: > From: Konrad Dybcio > > Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2 > Compact smartphones. > > Signed-off-by: Konrad Dybcio > Signed-off-by: Konrad Dybcio > Reviewed-by: Krzysztof Kozlowski Patch applied to

Re: [PATCH v4 2/2] gpu/drm/panel: Add Sony TD4353 JDI panel driver

2023-03-07 Thread Linus Walleij
On Thu, Jan 19, 2023 at 5:32 PM Konrad Dybcio wrote: > From: Konrad Dybcio > > Add support for the Sony TD4353 JDI 2160x1080 display panel used in > some Sony Xperia XZ2 and XZ2 Compact smartphones. Due to the specifics > of smartphone manufacturing, it is impossible to retrieve a better name >

Re: [PATCH 1/2] drm/i915/gsc: flush the GSC worker before wedging on unload

2023-03-07 Thread Teres Alexis, Alan Previn
On Thu, 2023-02-23 at 09:21 -0800, Ceraolo Spurio, Daniele wrote: > If we unload the driver and wedge before the GSC worker is complete, > the worker will hit an error on its submission to the GSC engine and > then exit. This is hard to hit for a user, but it is reproducible > with skipping

Re: [PATCH 2/2] drm/nouveau/clk: avoid usage of list iterator after loop

2023-03-07 Thread Lyude Paul
On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote: > + } >   } >   > + BUG_ON(!pstate); >   nvkm_debug(subdev, "setting performance state %d\n", pstatei); >   clk->pstate = pstatei; We should probably also replace this with if (WARN_ON(!pstate)

Re: [PATCH 1/2] drm/nouveau/device: avoid usage of list iterator after loop

2023-03-07 Thread Lyude Paul
On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote: > If potentially no valid element is found, 'pstate' would contain an > invalid pointer past the iterator loop. To ensure 'pstate' is always > valid, we only set it if the correct element was found. That allows > adding a BUG_ON in case the

Re: [PATCH 0/2] drm/nouveau: avoid usage of list iterator after loop

2023-03-07 Thread Lyude Paul
Actually hm, dim is warning me about this and making me realize there's probably a better way to handle this, going to revoke the previous r-b I gave and respond inline On Tue, 2023-03-07 at 17:43 -0500, Lyude Paul wrote: > Reviewed-by: Lyude Paul > > Will push upstream in just a moment > > On

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-03-07 Thread Liam R. Howlett
* Danilo Krummrich [230306 10:46]: > On 3/2/23 03:38, Liam R. Howlett wrote: > > * Danilo Krummrich [230227 08:17]: > > > > ... > > > > > Would this variant be significantly more efficient? > > > > > > > > Well, what you are doing is walking the tree to see if there's anything > > > > there...

Re: [PATCH 0/2] drm/nouveau: avoid usage of list iterator after loop

2023-03-07 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push upstream in just a moment On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote: > This patch set includes two instances where the list iterator variable > 'pstate' is implicitly assumed to be valid after the iterator loop. > While in pratice that is most

Re: [PATCH v2 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-07 Thread Linus Walleij
Hi Jianhua, thanks for your patch! It appears Konrad is working on a very similar driver, so I suggest merging them into one Novatek NT36523 driver. Possibly we can fix this up first and then add Konrads Lenovo-panel with a patch on top. On Mon, Feb 20, 2023 at 1:13 PM Jianhua Lu wrote: >

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-03-07 Thread Linus Walleij
On Mon, Feb 20, 2023 at 1:13 PM Jianhua Lu wrote: > Novatek NT36523 is a display driver IC used to drive DSI panels. > > Signed-off-by: Jianhua Lu > --- > Changes in v2: > - Drop unnecessary description > - dsi0 -> dsi > - Correct indentation I'd like Konrad and Neil to look at this

Re: [PATCH v6 1/4] drm/rockchip: vop: limit maximium resolution to hardware capabilities

2023-03-07 Thread Heiko Stübner
Hi Sascha, Am Donnerstag, 16. Februar 2023, 11:24:44 CET schrieb Sascha Hauer: > The different VOP variants support different maximum resolutions. Reject > resolutions that are not supported by a specific variant. > > This hasn't been a problem in the upstream driver so far as 1920x1080 > has

Re: [PATCH v2 2/2] gpu/drm/panel: Add Lenovo NT36523W BOE panel

2023-03-07 Thread Linus Walleij
On Tue, Mar 7, 2023 at 2:26 PM Konrad Dybcio wrote: > Introduce support for the BOE panel with a NT36523W touch/driver IC > found on some Lenovo Tab P11 devices. It's a 2000x1200, 24bit RGB > MIPI DSI panel with integrated DCS-controlled backlight (that expects > big-endian communication). > >

Re: [PATCH v2 1/2] dt-bindings: display/panel: Add Lenovo NT36523W BOE panel

2023-03-07 Thread Linus Walleij
On Tue, Mar 7, 2023 at 2:26 PM Konrad Dybcio wrote: > Add bindings for the 2000x1200px IPS panel found on Lenovo Tab P11/ > XiaoXin Pad devices. > > Reviewed-by: Rob Herring > Signed-off-by: Konrad Dybcio (...) > +$id: >

[PULL] drm-intel-next

2023-03-07 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes our first pull request towards 6.3. drm-intel-next-2023-03-07: Cross-subsystem Changes: - MEI patches to fix suspend/resume issues with the i915's PXP. (Alexander) Driver Changes: - Registers helpers and clean-ups. (Lucas) - PXP fixes and clean-ups. (Alan,

Re: [PATCH] drm/format_helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-07 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: [...] > >> +static size_t conversion_buf_size_mono(unsigned int dst_pitch, const struct >> drm_rect *clip) >> +{ >> +if (!dst_pitch) { >> +unsigned int linepixels = drm_rect_width(clip) * 1; >> + >> +dst_pitch =

[PATCH v2] drm/format-helper: Make conversion_buf_size() support sub-byte pixel fmts

2023-03-07 Thread Javier Martinez Canillas
There are DRM fourcc formats that have pixels smaller than a byte, but the conversion_buf_size() function assumes that pixels are a multiple of bytes and use the struct drm_format_info .cpp field to calculate the dst_pitch. Instead, calculate it by using the bits per pixel (bpp) and divide it by

Re: [PATCH 2/2] drm/i915/gsc: Fix race between HW init and GSC FW load

2023-03-07 Thread Teres Alexis, Alan Previn
On Thu, 2023-02-23 at 09:21 -0800, Ceraolo Spurio, Daniele wrote: > The GSC FW load is a slow process (up to 250 ms), so we defer it to a > dedicated worker to avoid stalling the init flow for that long. However, > we currently start this worker before the HW init is complete, so there > is a

Re: [PATCH] drm/format-helper: Make conversion_buf_size() support sub-byte pixel fmts

2023-03-07 Thread kernel test robot
Hi Javier, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.3-rc1 next-20230307] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] habanalabs: Drop redundant pci_enable_pcie_error_reporting()

2023-03-07 Thread Bjorn Helgaas
From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the

[PATCH] drm/amdgpu: Drop redundant pci_enable_pcie_error_reporting()

2023-03-07 Thread Bjorn Helgaas
From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the

Re: [Intel-gfx] [PATCH v2 6/7] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-03-07 Thread kernel test robot
, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-ttm-Fix-a-NULL-pointer-dereference/20230307-224931 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc

Re: [PATCH] drm/format_helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-07 Thread Javier Martinez Canillas
Hello Arthur, Thanks a lot for your patch! Arthur Grillo writes: > Extend the existing test cases to test the conversion from XRGB to > monochromatic. > > Signed-off-by: Arthur Grillo > --- [...] > +static size_t conversion_buf_size_mono(unsigned int dst_pitch, const struct >

[PATCH] drm/format-helper: Make conversion_buf_size() support sub-byte pixel fmts

2023-03-07 Thread Javier Martinez Canillas
There are DRM fourcc formats that have pixels smaller than a byte, but the conversion_buf_size() function assumes that pixels are a multiple of bytes and use the struct drm_format_info .cpp field to calculate the dst_pitch. Instead, calculate it by using the bits per pixel (bpp) and char per

Re: [Freedreno] [PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning

2023-03-07 Thread Rob Clark
On Tue, Mar 7, 2023 at 10:48 AM Fabio Estevam wrote: > > On Tue, Mar 7, 2023 at 2:46 PM Randy Dunlap wrote: > > > > Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter > > should either be selected or DRM_MSM should depend on PM_DEVFREQ. > > Since most drivers select PM_DEVFREQ

Re: [PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning

2023-03-07 Thread Fabio Estevam
On Tue, Mar 7, 2023 at 2:46 PM Randy Dunlap wrote: > > Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter > should either be selected or DRM_MSM should depend on PM_DEVFREQ. > Since most drivers select PM_DEVFREQ instead of depending on it, > add a select here to satisfy kconfig.

Re: [PATCH v3 01/10] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-03-07 Thread Rob Herring
k.ozlabs.org/project/devicetree-bindings/patch/20230307-topic-dsi_qcm-v3-1-8bd7e1add...@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make su

Re: [PATCH v12 10/11] drm/virtio: Support memory shrinking

2023-03-07 Thread Dmitry Osipenko
On 3/7/23 21:25, Dmitry Osipenko wrote: >> Not really a problem with this patchset, but having such branches looks >> like a bug in the driver's GEM design. Whatever your GEM object needs or >> does, it should be hidden in the implementation. Why is virtio doing this? > There is another "VRAM"

Re: [PATCH v2 39/50] drm/msm/dpu: drop duplicate vig_sblk instances

2023-03-07 Thread Dmitry Baryshkov
On 12/02/2023 01:12, Dmitry Baryshkov wrote: After fixing scaler version we are sure that sm8450 and sc8280xp vig sblk's are duplicates of sm8250_vig_sblk and thus can be dropped. I will probably partially withdraw or rework this patch to fix the scaler->version handling. The rest of the

Re: [PATCH v12 10/11] drm/virtio: Support memory shrinking

2023-03-07 Thread Dmitry Osipenko
On 3/7/23 13:42, Thomas Zimmermann wrote: > Hi > > Am 05.03.23 um 23:10 schrieb Dmitry Osipenko: > [...] >>     *bo_ptr = bo; >> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c >> b/drivers/gpu/drm/virtio/virtgpu_plane.c >> index 4c09e313bebc..3f21512ff153 100644 >> ---

Re: [Freedreno] [PATCH v2 00/50] drm/msm/dpu: rework HW catalog

2023-03-07 Thread Abhinav Kumar
Hi Dmitry On 3/7/2023 10:02 AM, Dmitry Baryshkov wrote: On 12/02/2023 01:12, Dmitry Baryshkov wrote: This huge series attempts to restructure the DPU HW catalog into a manageable and reviewable data set. In order to ease review and testing I merged all the necessary fixes into this series.

Re: [PATCH v2 00/50] drm/msm/dpu: rework HW catalog

2023-03-07 Thread Dmitry Baryshkov
On 12/02/2023 01:12, Dmitry Baryshkov wrote: This huge series attempts to restructure the DPU HW catalog into a manageable and reviewable data set. In order to ease review and testing I merged all the necessary fixes into this series. Also I cherry-picked & slightly fixed Konrad's patch adding

Re: [PATCH v2 1/7] drm/ttm: Fix a NULL pointer dereference

2023-03-07 Thread Thomas Hellström
On 3/7/23 17:55, Christian König wrote: Am 07.03.23 um 15:46 schrieb Thomas Hellström: The LRU mechanism may look up a resource in the process of being removed from an object. The locking rules here are a bit unclear but it looks currently like res->bo assignment is protected by the LRU lock,

[PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning

2023-03-07 Thread Randy Dunlap
Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter should either be selected or DRM_MSM should depend on PM_DEVFREQ. Since most drivers select PM_DEVFREQ instead of depending on it, add a select here to satisfy kconfig. WARNING: unmet direct dependencies detected for

Re: [PATCH] amdgpu: Avoid building on UML

2023-03-07 Thread Alex Deucher
Applied. Thanks. Alex On Mon, Mar 6, 2023 at 11:17 AM Felix Kuehling wrote: > > Looks like this patch got lost over the holidays. Alex, are you OK with > applying this patch? Or are people looking for a more general solution > to not build HW drivers for UML? FWIW: > > Acked-by: Felix Kuehling

[PATCH 6.2 0340/1001] drm/ast: Init iosys_map pointer as I/O memory for damage handling

2023-03-07 Thread Greg Kroah-Hartman
From: Thomas Zimmermann [ Upstream commit b1def7fadfa544bd2467581ce40b659583eb7e79 ] Ast hardware scans out the primary plane from video memory, which is in I/O-memory space. Hence init the damage handler's iosys_map pointer as I/O memory. Not all platforms support accessing I/O memory as

[PATCH 6.2 0228/1001] drm/nouveau/disp: Fix nvif_outp_acquire_dp() argument size

2023-03-07 Thread Greg Kroah-Hartman
From: Kees Cook [ Upstream commit 4076ea2419cf15bc1e1580f8b24ddf675fbdb02c ] Both Coverity and GCC with -Wstringop-overflow noticed that nvif_outp_acquire_dp() accidentally defined its second argument with 1 additional element: drivers/gpu/drm/nouveau/dispnv50/disp.c: In function

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-07 Thread Dave Stevenson
Hi Maarten On Tue, 7 Mar 2023 at 16:25, AL13N wrote: > > AL13N schreef op 2023-03-06 17:34: > > Hi, > > > > I have a RPI4B connected on 2nd HDMI port (furthest away from power) > > to a 4K TV, which works until 5.16, from 5.17 there is no X (or > > plymouth), the cause of no X is that EDID gives

Re: [PATCH] drivers/gpu: fix typo in comment

2023-03-07 Thread Alex Deucher
Applied. Thanks! On Sun, Mar 5, 2023 at 5:22 PM Husain Alshehhi wrote: > > Replace "isntance" with "instance". > > Signed-off-by: Husain Alshehhi > --- > .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h| 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git

Re: [PATCH] drm/amd/display: add prefix to amdgpu_dm_plane.h functions

2023-03-07 Thread Alex Deucher
On Mon, Mar 6, 2023 at 3:23 AM David Tadokoro wrote: > > From: David Tadokoro > > The amdgpu_dm_plane.h functions didn't have names that indicated where > they were declared. > > To better filter results in debug tools like ftrace, prefix these > functions with 'amdgpu_dm_plane_'. > > Note that

Re: [PATCH v2 1/7] drm/ttm: Fix a NULL pointer dereference

2023-03-07 Thread Christian König
Am 07.03.23 um 15:46 schrieb Thomas Hellström: The LRU mechanism may look up a resource in the process of being removed from an object. The locking rules here are a bit unclear but it looks currently like res->bo assignment is protected by the LRU lock, whereas bo->resource is protected by the

[PATCH] fbdev: tgafb: Fix potential divide by zero

2023-03-07 Thread harperchen
fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when checking whether reciprocal of var->pixclock is too high. Similar crashes have

drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-07 Thread David Binderman
Hello there, I just ran the static analyser "cppcheck" over the source code of linux-6.2-rc1. It said: linux-6.3-rc1/drivers/gpu/drm/bridge/fsl-ldb.c:101:3: style: int result is returned as long value. If the return value is long to avoid loss of information, then you have loss of

[PATCH 00/11] tree-wide: remove support for Renesas R-Car H3 ES1

2023-03-07 Thread Wolfram Sang
Because H3 ES1 becomes an increasing maintenance burden and was only available to a development group, we decided to remove upstream support for it. Here are the patches to remove driver changes. Review tags have been gathered before during an internal discussion. Only change since the internal

[PATCH 02/11] drm: rcar-du: remove R-Car H3 ES1.* workarounds

2023-03-07 Thread Wolfram Sang
R-Car H3 ES1.* was only available to an internal development group and needed a lot of quirks and workarounds. These become a maintenance burden now, so our development group decided to remove upstream support and disable booting for this SoC. Public users only have ES2 onwards. Signed-off-by:

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-07 Thread AL13N
AL13N schreef op 2023-03-06 17:34: Hi, I have a RPI4B connected on 2nd HDMI port (furthest away from power) to a 4K TV, which works until 5.16, from 5.17 there is no X (or plymouth), the cause of no X is that EDID gives nothing, and in the journal; there is "Cannot find any crct or sizes". Only

Re: [PATCH RFC 00/18] Rust DRM subsystem abstractions (& preview AGX driver)

2023-03-07 Thread Asahi Lina
st makes error cleanup easy!), UAPI-level fuzzing, countless broken > Mesa builds, uptimes of 40+ days, and more. > > The explicit sync refactor significantly increases performance (and > potential problems), but this version has survived a lot of torture > with dEQP/piglit tests and

Re: [PATCH] accel: Link to compute accelerator subsystem intro

2023-03-07 Thread Jeffrey Hugo
On 3/6/2023 9:35 PM, Bagas Sanjaya wrote: Commit 2c204f3d53218d ("accel: add dedicated minor for accelerator devices") adds link to accelerator nodes section of DRM internals doc (Documentation/gpu/drm-internals.rst), but the target doesn't exist. Instead, there is only an introduction doc for

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-07 Thread Maíra Canal
On 3/7/23 11:25, Asahi Lina wrote: DRM drivers need to be able to declare which driver-specific ioctls they support. This abstraction adds the required types and a helper macro to generate the ioctl definition inside the DRM driver. Note that this macro is not usable until further bits of the

Re: (subset) [PATCH] drm/sun4i: fix missing component unbind on bind errors

2023-03-07 Thread Maxime Ripard
On Mon, 06 Mar 2023 11:32:42 +0100, Johan Hovold wrote: > Make sure to unbind all subcomponents when binding the aggregate device > fails. > > Applied to drm/drm-misc (drm-misc-fixes). Thanks! Maxime

[PATCH v4 01/17] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2023-03-07 Thread Harry Wentland
This allows us to use strongly typed arguments. v2: - Bring NO_DATA back - Provide explicit enum values v4: Drop unnecessary '&' from kerneldoc (emersion) Signed-off-by: Harry Wentland Reviewed-by: Simon Ser Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma Shankar

Re: [PATCH RFC 15/18] drm/asahi: Add the Asahi driver UAPI [DO NOT MERGE]

2023-03-07 Thread Karol Herbst
On Tue, Mar 7, 2023 at 3:28 PM Asahi Lina wrote: > > Adds the Asahi GPU driver UAPI. Note: this API is not yet stable and > therefore not ready for merging! > > Signed-off-by: Asahi Lina > --- > include/uapi/drm/asahi_drm.h | 556 > +++ > 1 file changed,

Re: [PATCH v3 01/17] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2023-03-07 Thread Simon Ser
On Tuesday, March 7th, 2023 at 16:10, Harry Wentland wrote: > * This enum is used to indicate DP VSC SDP Colorimetry formats. > * It is based on DP 1.4 spec [Table 2-117: VSC SDP Payload for DB16 through > - * DB18] and a name of enum member follows DRM_MODE_COLORIMETRY definition. > + * DB18]

[PATCH v3 17/17] drm/amd/display: Refactor avi_info_frame colorimetry determination

2023-03-07 Thread Harry Wentland
From: Joshua Ashton Replace the messy two if-else chains here that were on the same value with a switch on the enum. Signed-off-by: Joshua Ashton Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc:

[PATCH v3 14/17] drm/amd/display: Add debugfs for testing output colorspace

2023-03-07 Thread Harry Wentland
In order to IGT test colorspace we'll want to print the currently enabled colorspace on a stream. We add a new debugfs to do so, using the same scheme as current bpc reporting. This might also come in handy when debugging display issues. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc:

[PATCH v3 13/17] drm/amd/display: Add support for explicit BT601_YCC

2023-03-07 Thread Harry Wentland
We use this by default but if userspace passes this explicitly we should respect it. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc: dri-devel@lists.freedesktop.org Cc: amd-...@lists.freedesktop.org Reviewed-By: Joshua

[PATCH v3 16/17] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-03-07 Thread Harry Wentland
From: Joshua Ashton Userspace might not aware whether we're sending RGB or YCbCr data to the display. If COLOR_SPACE_2020_RGB_FULLRANGE is requested but the output encoding is YCbCr we should send COLOR_SPACE_2020_YCBCR. Signed-off-by: Joshua Ashton Signed-off-by: Harry Wentland Cc: Pekka

[PATCH v3 15/17] drm/amd/display: Add default case for output_color_space switch

2023-03-07 Thread Harry Wentland
Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc: dri-devel@lists.freedesktop.org Cc: amd-...@lists.freedesktop.org Reviewed-By: Joshua Ashton --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 43 ++- 1 file

[PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-07 Thread Harry Wentland
We want compositors to be able to set the output colorspace on DP and HDMI outputs, based on the caps reported from the receiver via EDID. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc: dri-devel@lists.freedesktop.org Cc:

[PATCH v3 08/17] drm/amd/display: Always pass connector_state to stream validation

2023-03-07 Thread Harry Wentland
We need the connector_state for colorspace and scaling information and can get it from connector->state. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc: dri-devel@lists.freedesktop.org Cc: amd-...@lists.freedesktop.org

[PATCH v3 05/17] drm/connector: Use common colorspace_names array

2023-03-07 Thread Harry Wentland
We an use bitfields to track the support ones for HDMI and DP. This allows us to print colorspaces in a consistent manner without needing to know whether we're dealing with DP or HDMI. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma

  1   2   3   >