[AMD Official Use Only - General]
Thanks for your time, Lyude!
Regards,
Wayne
> -Original Message-
> From: Lyude Paul
> Sent: Tuesday, August 8, 2023 4:23 AM
> To: Lin, Wayne ; dri-devel@lists.freedesktop.org;
> amd-...@lists.freedesktop.org
> Cc: jani.nik...@intel.com;
[AMD Official Use Only - General]
> -Original Message-
> From: Imre Deak
> Sent: Tuesday, August 8, 2023 12:00 AM
> To: Lin, Wayne
> Cc: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org;
> ly...@redhat.com; jani.nik...@intel.com; ville.syrj...@linux.intel.com;
> Wentland,
Some of these comments have been sitting for a while. Would it be ok if
yi...@chromium.org and myself picked these up and did an iteration so we
could also get
https://patchwork.kernel.org/project/dri-devel/patch/20230711013148.3155572-1-br...@chromium.org/
submitted? These will enable a lot
On Mon, Aug 07, 2023 at 07:09:34PM +0800, Qi Zheng wrote:
> Like global slab shrink, this commit also uses refcount+RCU method to make
> memcg slab shrink lockless.
This patch does random code cleanups amongst the actual RCU changes.
Can you please move the cleanups to a spearate patch to reduce
WIP: Need to run all tast criticals and test the multidisplay tests that
are WIP.
BUG=b:283357160
TEST=Booted on a betty-arc-r device and ran autologin.py -a
Change-Id: I13cef8cf019744813f51cfffed3d7ccb987834e8
Change-Id: Iae7d788bc4725dfdca044204fa1af27a5a1ec5a8
---
Any progress on this? Is it ok if yi...@chromium.org and I do the
followups on this patch so that we can also submit the Hotplug patch I
wrote (that's now archived?).
For the series:
Reviewed-by: Dave Airlie
On Tue, 8 Aug 2023 at 02:32, Danilo Krummrich wrote:
>
> The patch series provides a few fixes for the recently merged VM_BIND uAPI
> mostly addressing a couple of warnings.
>
> It also contains one patch to slightly reduce the memory footprint of
>
On Mon, Aug 07, 2023 at 07:09:33PM +0800, Qi Zheng wrote:
> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h
> index eb342994675a..f06225f18531 100644
> --- a/include/linux/shrinker.h
> +++ b/include/linux/shrinker.h
> @@ -4,6 +4,8 @@
>
> #include
> #include
> +#include
>
On Mon, Aug 07, 2023 at 07:09:32PM +0800, Qi Zheng wrote:
> Currently, we maintain two linear arrays per node per memcg, which are
> shrinker_info::map and shrinker_info::nr_deferred. And we need to resize
> them when the shrinker_nr_max is exceeded, that is, allocate a new array,
> and then copy
On 8 August 2023 00:41:07 GMT+03:00, Jessica Zhang
wrote:
>
>
>On 8/4/2023 6:27 AM, Dmitry Baryshkov wrote:
>> On Fri, 28 Jul 2023 at 20:03, Jessica Zhang
>> wrote:
>>>
>>> Document and add support for solid_fill property to drm_plane. In
>>> addition, add support for setting and getting
On Mon, Aug 07, 2023 at 06:41:44PM -0500, Faith Ekstrand wrote:
> The flags field in drm_syncobj_find_fence() takes SYNCOBJ_WAIT flags
> from the syncobj UAPI whereas sync->flags is from the nouveau UAPI. What
> we actually want is 0 flags which tells it to just try to find the
> fence and then
On 5/18/2023 7:30 PM, Dmitry Baryshkov wrote:
dpu_encoder_phys_wb is the only user of encoder's atomic_check callback.
Move corresponding checks to drm_writeback_connector's implementation
and drop the dpu_encoder_phys_wb_atomic_check() function.
Signed-off-by: Dmitry Baryshkov
---
I dont
On 6/4/2023 7:45 AM, Dmitry Baryshkov wrote:
The atomic_mode_set() callback only sets the phys_enc's IRQ data. As the
INTF and WB are statically allocated to each encoder/phys_enc, drop the
atomic_mode_set callback and set the IRQs during encoder init.
For the CMD panel usecase some of IRQ
The flags field in drm_syncobj_find_fence() takes SYNCOBJ_WAIT flags
from the syncobj UAPI whereas sync->flags is from the nouveau UAPI. What
we actually want is 0 flags which tells it to just try to find the
fence and then return without waiting.
Signed-off-by: Faith Ekstrand
Fixes:
On Mon, Aug 07, 2023 at 07:09:33PM +0800, Qi Zheng wrote:
> The shrinker_rwsem is a global read-write lock in shrinkers subsystem,
> which protects most operations such as slab shrink, registration and
> unregistration of shrinkers, etc. This can easily cause problems in the
> following cases.
On 8/2/2023 12:32 PM, Marijn Suijten wrote:
I find this title very undescriptive, it doesn't really explain from/to
where this move is happening nor why.
On 2023-08-02 11:08:48, Jessica Zhang wrote:
Move the setting of dpu_enc.wide_bus_en to
dpu_encoder_virt_atomic_enable() so that it
On 8/2/2023 12:39 PM, Marijn Suijten wrote:
On 2023-08-02 11:08:49, Jessica Zhang wrote:
DPU supports a data-bus widen mode for DSI INTF.
Enable this mode for all supported chipsets if widebus is enabled for DSI.
Signed-off-by: Jessica Zhang
---
On 8/4/2023 6:27 AM, Dmitry Baryshkov wrote:
On Fri, 28 Jul 2023 at 20:03, Jessica Zhang wrote:
Document and add support for solid_fill property to drm_plane. In
addition, add support for setting and getting the values for solid_fill.
To enable solid fill planes, userspace must assign a
On 8/2/2023 11:20 AM, Dmitry Baryshkov wrote:
On Wed, 2 Aug 2023 at 21:09, Jessica Zhang wrote:
DPU supports a data-bus widen mode for DSI INTF.
Enable this mode for all supported chipsets if widebus is enabled for DSI.
Signed-off-by: Jessica Zhang
---
The previous patch exposed the accumulated amount of active time per
client for each V3D queue. But this doesn't provide a global notion of
the GPU usage.
Therefore, provide the accumulated amount of active time for each V3D
queue (BIN, RENDER, CSD, TFU and CACHE_CLEAN), considering all the jobs
This patch exposes the accumulated amount of active time per client
through the fdinfo infrastructure. The amount of active time is exposed
for each V3D queue: BIN, RENDER, CSD, TFU and CACHE_CLEAN.
In order to calculate the amount of active time per client, a CPU clock
is used through the
This patchset exposes GPU usages stats both globally and per-file
descriptor.
The first patch exposes the accumulated amount of active time per client
through the fdinfo infrastructure. The amount of active time is exposed
for each V3D queue. Moreover, it exposes the number of jobs submitted to
On Mon, Jul 31, 2023 at 3:19 PM Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr here.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to
On Mon, Jul 31, 2023 at 2:43 PM Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr here.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to
Ugh, thanks for catching this!
Reviewed-by: Lyude Paul
On Sat, 2023-08-05 at 12:18 +0200, Karol Herbst wrote:
> The original commit adding that check tried to protect the kenrel against
> a potential invalid NULL pointer access.
>
> However we call nouveau_connector_detect_depth once without a
Oo! This is a wonderful idea so far - keeping track of the status of
allocations like this solves a lot of problems, especially with regards to the
fact this actually seems to make it possible for us to have much better
handling of payload failures in drivers - especially in situations like
On Mon, Aug 7, 2023 at 2:43 AM Yang Li wrote:
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:332 dw_hdmi_cec_suspend() warn:
> inconsistent indenting
>
> Reported-by: Abaci Robot
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6101
> Signed-off-by: Yang Li
> ---
>
On 8/3/2023 06:28, Andi Shyti wrote:
Hi John,
On Wed, Aug 02, 2023 at 11:49:40AM -0700, john.c.harri...@intel.com wrote:
From: John Harrison
It was noticed that if the very first 'stealing' request failed to
create for some reason then the 'steal all ids' loop would immediately
exit with
Hi Christian,
On 8/7/23 20:07, Christian König wrote:
Am 03.08.23 um 18:52 schrieb Danilo Krummrich:
The new (VM_BIND) UAPI exports DMA fences through DRM syncobjs. Hence,
in order to emit fences within DMA fence signalling critical sections
(e.g. as typically done in the DRM GPU schedulers
Am 03.08.23 um 18:52 schrieb Danilo Krummrich:
The new (VM_BIND) UAPI exports DMA fences through DRM syncobjs. Hence,
in order to emit fences within DMA fence signalling critical sections
(e.g. as typically done in the DRM GPU schedulers run_job() callback) we
need to separate fence allocation
On Wed, Aug 02, 2023 at 04:35:01PM -0700, Alan Previn wrote:
> When suspending, add a timeout when calling
> intel_gt_pm_wait_for_idle else if we have a lost
> G2H event that holds a wakeref (which would be
> indicating of a bug elsewhere in the driver), we
> get to complete the suspend-resume
On 8/4/2023 6:15 AM, Sebastian Wick wrote:
On Fri, Jul 28, 2023 at 7:03 PM Jessica Zhang wrote:
Add support for pixel_source property to drm_plane and related
documentation. In addition, force pixel_source to
DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break
legacy
On Wed, Aug 02, 2023 at 04:34:59PM -0700, Alan Previn wrote:
> Suspend is not like reset, it can unroll, so we have to properly
> flush pending context-guc-id deregistrations to complete before
> we return from suspend calls.
But if is 'unrolls' the execution should just continue, no?!
In other
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:53 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open brace '{'
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: space required before the open parenthesis '('
> ERROR: that open brace {
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:50 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 +--
> 1 file changed, 1 insertion(+), 2
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:49 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: trailing statements should be on next line
> ERROR: open brace '{' following struct go on the same line
>
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:43 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> spaces required around that '==' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by:
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:37 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 3 +--
> 1 file changed, 1 insertion(+), 2
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:35 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '-=' (ctx:WxV)
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:34 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/nv.c | 48 +++--
> 1 file
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:31 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:28 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that ':' (ctx:VxW)
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +-
> 1 file changed, 1 insertion(+), 1
On 8/2/2023 3:04 AM, Dmitry Baryshkov wrote:
Since commit 1e7ac595fa46 ("drm/msm/dpu: pass irq to
dpu_encoder_helper_wait_for_irq()") the
dpu_encoder_phys_wb_wait_for_commit_done expects the IRQ index rather
than the IRQ index in phys_enc->intr table, however writeback got the
older
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:26 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 ++--
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:24 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: else should follow close brace '}'
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:23 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 9 +++--
> 1 file changed, 3
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:21 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/soc21.c | 30 ++
> 1 file
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:18 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: code indent should use tabs where possible
> ERROR: space required before the open brace '{'
>
>
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:12 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
> ERROR: space prohibited after that '~' (ctx:WxW)
>
> Signed-off-by: Ran Sun
> ---
>
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:06 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: else should follow close brace '}'
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:04 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 30 +-
> 1 file
Applied. Thanks!
On Wed, Aug 2, 2023 at 3:00 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 3 +--
> 1 file changed, 1 insertion(+),
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:58 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that ':' (ctx:VxE)
> that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
Already fixed.
On Wed, Aug 2, 2023 at 2:55 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: switch and case should be at the same indent
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 64 -
> 1 file changed,
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:51 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '>=' (ctx:WxV)
> ERROR: spaces required around that '!=' (ctx:WxV)
> ERROR: code indent should use tabs where possible
>
> Signed-off-by:
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:48 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: code indent should use tabs where possible
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Ran Sun
> ---
>
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:46 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: trailing statements should be on next line
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
>
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:43 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: trailing statements should be on next line
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
>
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:40 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: open brace '{' following enum go on the same line
>
> Signed-off-by: Ran Sun
> ---
>
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:38 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 9 +++--
> 1 file changed, 3
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:35 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/amdgpu/cik_ih.c | 3 +--
> 1 file changed, 1 insertion(+), 2
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:26 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '?' (ctx:VxE)
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c | 2 +-
> 1 file changed, 1
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:20 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: else should follow close brace '}'
>
> Signed-off-by: Ran Sun
> ---
> .../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 6 ++
> 1 file changed, 2
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:16 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: else should follow close brace '}'
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 3 +--
> 1 file changed, 1 insertion(+),
Applied. Thanks!
On Wed, Aug 2, 2023 at 2:14 AM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 3 +--
> 1 file changed, 1
Applied. Thanks!
As a follow up patch, care to drop the break statements after a return?
On Tue, Aug 1, 2023 at 11:23 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: switch and case should be at the same indent
> ERROR: code indent should use tabs where
From: Rob Clark
For cases where icc_bw_set() can be called in callbaths that could
deadlock against shrinker/reclaim, such as runpm resume, we need to
decouple the icc locking. Introduce a new icc_bw_lock for cases where
we need to serialize bw aggregation and update to decouple that from
paths
From: Rob Clark
Now that the runpm/qos/interconnect lockdep vs reclaim issues are
solved, we can enable the fence signalling annotations without lockdep
making it's immediate displeasure known.
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_ringbuffer.c | 1 +
1 file changed, 1
From: Rob Clark
Based on
https://lore.kernel.org/dri-devel/20200604081224.863494-10-daniel.vet...@ffwll.ch/
but made to be optional.
Signed-off-by: Rob Clark
Reviewed-by: Luben Tuikov
---
drivers/gpu/drm/scheduler/sched_main.c | 9 +
include/drm/gpu_scheduler.h| 2 ++
2
From: Rob Clark
Teach lockdep that icc_bw_lock is needed in code paths that could
deadlock if they trigger reclaim.
Signed-off-by: Rob Clark
---
drivers/interconnect/core.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/interconnect/core.c
From: Rob Clark
Annotate dev_pm_qos_mtx to teach lockdep to scream about allocations
that could trigger reclaim under dev_pm_qos_mtx.
Signed-off-by: Rob Clark
---
drivers/base/power/qos.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/base/power/qos.c
Applied. Thanks!
On Tue, Aug 1, 2023 at 11:03 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Ran Sun
> ---
>
From: Rob Clark
In the process of adding lockdep annotation for drm GPU scheduler's
job_run() to detect potential deadlock against shrinker/reclaim, I hit
this lockdep splat:
==
WARNING: possible circular locking dependency detected
From: Rob Clark
Similar to the previous patch, move the allocation out from under
dev_pm_qos_mtx, by speculatively doing the allocation and handle
any race after acquiring dev_pm_qos_mtx by freeing the redundant
allocation.
Signed-off-by: Rob Clark
---
drivers/base/power/qos.c | 13
From: Rob Clark
In the process of adding lockdep annotation for GPU job_run() path to
catch potential deadlocks against the shrinker/reclaim path, I turned
up this lockdep splat:
==
WARNING: possible circular locking dependency detected
From: Rob Clark
This will make it easier to catch places doing allocations that can
trigger reclaim under devfreq->lock.
Because devfreq->lock is held over various devfreq_dev_profile
callbacks, there might be some fallout if those callbacks do allocations
that can trigger reclaim, but I've
From: Rob Clark
Inspired by
https://lore.kernel.org/dri-devel/20200604081224.863494-10-daniel.vet...@ffwll.ch/
it seemed like a good idea to get rid of memory allocation in job_run()
fence signaling path, and use lockdep annotations to yell at us about
anything that could deadlock against
Applied. Thanks!
On Tue, Aug 1, 2023 at 11:01 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Ran Sun
> ---
> .../gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c | 6 ++
> 1
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:58 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Ran Sun
> ---
>
Hi Thomas,
On Sun, Aug 06, 2023 at 01:58:51PM +0200, Thomas Zimmermann wrote:
> Add initializer macros for struct fb_ops of drivers that operate
> on SBUS-based framebuffers. Also add a Kconfig token to select the
> correct dependencies.
>
> All drivers for SBUS-based framebuffers use the
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:54 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open brace '{'
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/display/dc/dce112/dce112_hw_sequencer.c | 2 +-
> 1 file changed, 1
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:53 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open brace '{'
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +-
> 1 file changed, 1
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:52 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '=' (ctx:WxV)
>
> Signed-off-by: Ran Sun
> ---
> .../gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c | 4 ++--
> 1 file
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:47 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/display/dc/gpio/hpd_regs.h | 10 +-
> 1 file changed, 5
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:44 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Ran Sun
> ---
> .../gpu/drm/amd/display/dc/gpio/ddc_regs.h| 40 +--
> 1 file changed,
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:40 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: trailing whitespace
> ERROR: else should follow close brace '}'
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 5 ++---
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:31 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Ran Sun
> ---
>
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:25 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> .../gpu/drm/amd/pm/legacy-dpm/sislands_smc.h | 63 +++
> 1 file
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:15 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/pm/legacy-dpm/r600_dpm.h | 3 +--
> 1 file changed, 1
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:10 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: Ran Sun
> ---
>
Need to be careful with these changes to make sure we aren't changing
the size calculations somewhere.
Alex
On Tue, Aug 1, 2023 at 10:03 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: Use C99 flexible arrays
>
> Signed-off-by: Ran Sun
> ---
>
Applied. Thanks!
On Tue, Aug 1, 2023 at 9:59 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space prohibited before open square bracket '['
> ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Ran Sun
> ---
>
Applied. Thanks!
On Tue, Aug 1, 2023 at 9:56 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: space prohibited before open square bracket '['
> ERROR: "foo * bar" should be "foo *bar"
>
>
On 7/31/2023 5:52 PM, Dmitry Baryshkov wrote:
On 01/08/2023 03:39, Jessica Zhang wrote:
On 7/30/2023 9:15 PM, Dmitry Baryshkov wrote:
On 28/07/2023 20:02, Jessica Zhang wrote:
Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to
determine if the plane is solid fill. In
Applied. Thanks!
On Tue, Aug 1, 2023 at 9:48 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: Use C99 flexible arrays
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h |
Applied. Thanks!
On Tue, Aug 1, 2023 at 9:39 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h | 3 +--
> 1 file
Applied. Thanks!
On Tue, Aug 1, 2023 at 9:38 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/pp_thermal.h | 6 ++
> 1 file changed,
Applied. Thanks!
On Tue, Aug 1, 2023 at 9:31 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Ran Sun
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h | 6 ++
> 1 file changed, 2
Applied. Thanks!
On Tue, Aug 1, 2023 at 9:29 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: space prohibited before open square bracket '['
>
> Signed-off-by: Ran Sun
> ---
>
Applied. Thanks!
On Tue, Aug 1, 2023 at 9:23 PM Ran Sun wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: space prohibited before open square bracket '['
>
> Signed-off-by: Ran Sun
> ---
>
1 - 100 of 257 matches
Mail list logo
