Re: [PATCH 3/6] drm/amdgpu: Flush VM updates for split bindings eagerly.

2023-11-05 Thread Tatsuyuki Ishi
> On Oct 31, 2023, at 23:07, Christian König wrote: > > Am 31.10.23 um 14:59 schrieb Bas Nieuwenhuizen: >> >> >> On Tue, Oct 31, 2023 at 2:57 PM Christian König > > wrote: >>> Am 31.10.23 um 14:40 schrieb Tatsuyuki Ishi: >>> > The current

Re: [PATCH 02/10] drm/tidss: Use PM autosuspend

2023-11-05 Thread Tomi Valkeinen
On 06/11/2023 00:53, Laurent Pinchart wrote: Hi Tomi, CC'ing Sakari for his expertise on runtime PM (I think he will soon start wishing he would be ignorant in this area). On Thu, Nov 02, 2023 at 08:34:45AM +0200, Tomi Valkeinen wrote: On 01/11/2023 15:54, Laurent Pinchart wrote: On Wed, Nov

[PATCH] drm/atomic-helper: Call stall_checks() before allocate drm_crtc_commit

2023-11-05 Thread oushixiong
From: Shixiong Ou Calling stall_checks() before allocating drm_crtc_commit not after that. Signed-off-by: Shixiong Ou --- drivers/gpu/drm/drm_atomic_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c

Re: [PATCH] accel/qaic: Update MAX_ORDER use to be inclusive

2023-11-05 Thread Jacek Lawrynowicz
On 03.11.2023 16:33, Jeffrey Hugo wrote: > MAX_ORDER was redefined so that valid allocations to the page allocator > are in the range of 0..MAX_ORDER, inclusive in the commit > 23baf831a32c ("mm, treewide: redefine MAX_ORDER sanely"). > > We are treating MAX_ORDER as an exclusive value, and thus

[PATCH v2 2/3] udmabuf: Pin the pages using pin_user_pages_fd() API (v2)

2023-11-05 Thread Vivek Kasireddy
Using pin_user_pages_fd() will ensure that the pages are pinned correctly using FOLL_PIN. And, this also ensures that we don't accidentally break features such as memory hotunplug as it would not allow pinning pages in the movable zone. This patch also adds back support for mapping hugetlbfs

[PATCH v2 1/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v2)

2023-11-05 Thread Vivek Kasireddy
For drivers that would like to longterm-pin the pages associated with a file, the pin_user_pages_fd() API provides an option to not only pin the pages via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with files that belong to

[PATCH v2 0/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v2)

2023-11-05 Thread Vivek Kasireddy
The first patch introduces pin_user_pages_fd() API and the second patch shows how the udmabuf driver can use it to longterm-pin the the pages. The last patch adds two new udmabuf selftests to verify data coherency after page migration. v2: - Updated the first patch to include review feedback from

[PATCH v2 3/3] selftests/dma-buf/udmabuf: Add tests to verify data after page migration

2023-11-05 Thread Vivek Kasireddy
Since the memfd pages associated with a udmabuf may be migrated as part of udmabuf create, we need to verify the data coherency after successful migration. The new tests added in this patch try to do just that using 4k sized pages and also 2 MB sized huge pages for the memfd. Successful

Re: [PATCH 8/9] dt-bindings: reserved-memory: MediaTek: Add reserved memory for SVP

2023-11-05 Thread 吴勇
On Wed, 2023-11-01 at 11:20 +0530, Jaskaran Singh wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 10/20/2023 3:20 PM, Yong Wu (吴勇) wrote: > > On Thu, 2023-10-19 at 10:16 +0530, Vijayanand Jitta wrote: > >>

Re: [PATCH v2 1/1] drm/mediatek: Fix errors when reporting rotation capability

2023-11-05 Thread 胡俊光

Re: [PATCH v2 09/11] drm/mediatek: Add secure flow support to mediatek-drm

2023-11-05 Thread 林睿祥

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-05 Thread Randy Dunlap
On 11/5/23 21:15, Bagas Sanjaya wrote: > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote: >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> index 517b9fb4624c..703fe2542258 100644 >> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> +++

Re: [PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-05 Thread Bagas Sanjaya
On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote: > diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > index 517b9fb4624c..703fe2542258 100644 > --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c > +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c > @@ -990,11

Re: [PATCH v1] docs: gpu: rfc: i915_scheduler.rst remove unused directives for namespacing

2023-11-05 Thread Bagas Sanjaya
On Sat, Nov 04, 2023 at 09:47:08AM -0400, Hunter Chasens wrote: > diff --git a/Documentation/gpu/rfc/i915_scheduler.rst > b/Documentation/gpu/rfc/i915_scheduler.rst > index c237ebc024cd..23ba7006929b 100644 > --- a/Documentation/gpu/rfc/i915_scheduler.rst > +++

Re: [PATCH v2 09/11] drm/mediatek: Add secure flow support to mediatek-drm

2023-11-05 Thread 胡俊光

Re: [PATCH v2 09/11] drm/mediatek: Add secure flow support to mediatek-drm

2023-11-05 Thread 林睿祥

Re: [PATCH v2 07/11] drm/mediatek: Add secure layer config support for ovl

2023-11-05 Thread 林睿祥

[RFC PATCH v3 11/12] net: add SO_DEVMEM_DONTNEED setsockopt to release RX pages

2023-11-05 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the NET_RX dmabuf pages returned as cmsg. The kernel will drop the reference on the NET_RX pages to make them available for re-use. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry

[RFC PATCH v3 12/12] selftests: add ncdevmem, netcat for devmem TCP

2023-11-05 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support,

[RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-05 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a

[RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-05 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[RFC PATCH v3 08/12] net: support non paged skb frags

2023-11-05 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevent callers to handle this case. Correctly handle skb_frag refcounting in the page_pool_iovs case. Signed-off-by: Mina Almasry --- include/linux/skbuff.h | 42

[RFC PATCH v3 07/12] page-pool: device memory support

2023-11-05 Thread Mina Almasry
Overload the LSB of struct page* to indicate that it's a page_pool_iov. Refactor mm calls on struct page* into helpers, and add page_pool_iov handling on those helpers. Modify callers of these mm APIs with calls to these helpers instead. In areas where struct page* is dereferenced, add a check

[RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-05 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem page_pool_iovs. Support of PP_FLAG_DMA_MAP and PP_FLAG_DMA_SYNC_DEV is omitted for simplicity. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for

[RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-05 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates page_pool_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a page_pool_iov struct.

[RFC PATCH v3 04/12] netdev: support binding dma-buf to netdevice

2023-11-05 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a

[RFC PATCH v3 03/12] net: netdev netlink api to bind dma-buf to a net device

2023-11-05 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry --- Changes in v3: - Support binding multiple rx rx-queues --- Documentation/netlink/specs/netdev.yaml |

[RFC PATCH v3 01/12] net: page_pool: factor out releasing DMA from releasing the page

2023-11-05 Thread Mina Almasry
From: Jakub Kicinski Releasing the DMA mapping will be useful for other types of pages, so factor it out. Make sure compiler inlines it, to avoid any regressions. Signed-off-by: Jakub Kicinski Signed-off-by: Mina Almasry --- This is implemented by Jakub in his RFC:

[RFC PATCH v3 02/12] net: page_pool: create hooks for custom page providers

2023-11-05 Thread Mina Almasry
From: Jakub Kicinski The page providers which try to reuse the same pages will need to hold onto the ref, even if page gets released from the pool - as in releasing the page from the pp just transfers the "ownership" reference from pp to the provider, and provider will wait for other references

[RFC PATCH v3 00/12] Device Memory TCP

2023-11-05 Thread Mina Almasry
Changes in RFC v3: -- 1. Pulled in the memory-provider dependency from Jakub's RFC[1] to make the series reviewable and mergable. 2. Implemented multi-rx-queue binding which was a todo in v2. 3. Fix to cmsg handling. The sticking point in RFC v2[2] was the device reset

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-05 Thread Huacai Chen
Hi, Jaak and Evan, On Mon, Nov 6, 2023 at 12:28 AM Jaak Ristioja wrote: > > On 05.11.23 14:40, Huacai Chen wrote: > > Hi, Evan, > > > > On Sat, Nov 4, 2023 at 10:50 AM Evan Preston wrote: > >> > >> Hi Huacai, > >> > >> On 2023-11-03 Fri 02:36pm, Huacai Chen wrote: > >>> Hi, Evan, > >>> > >>> On

Re: [PATCH v18 25/26] drm/virtio: Support shmem shrinking

2023-11-05 Thread Dmitry Osipenko
On 11/4/23 01:55, Gurchetan Singh wrote: > On Sun, Oct 29, 2023 at 4:03 PM Dmitry Osipenko < > dmitry.osipe...@collabora.com> wrote: > >> Support generic drm-shmem memory shrinker and add new madvise IOCTL to >> the VirtIO-GPU driver. BO cache manager of Mesa driver will mark BOs as >> "don't

Re: [PATCH v2 00/11] Add mediate-drm secure flow for SVP

2023-11-05 Thread 林睿祥

Re: [PATCH v2 10/11] drm/mediatek: Add cmdq_insert_backup_cookie before secure pkt finalize

2023-11-05 Thread 林睿祥

Re: [PATCH v2 00/11] Add mediate-drm secure flow for SVP

2023-11-05 Thread 胡俊光

Re: [PATCH v2 10/11] drm/mediatek: Add cmdq_insert_backup_cookie before secure pkt finalize

2023-11-05 Thread 胡俊光

Re: [PATCH v2 07/11] drm/mediatek: Add secure layer config support for ovl

2023-11-05 Thread 胡俊光

Re: [PATCH v2 09/11] drm/mediatek: Add secure flow support to mediatek-drm

2023-11-05 Thread 胡俊光

Re: [Freedreno] [PATCH v7 0/7] incorporate pm runtime framework and eDP clean up

2023-11-05 Thread Leonard Lausen
Verified this fixes the "[drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-107)" issue https://gitlab.freedesktop.org/drm/msm/-/issues/25 Tested-by: Leonard Lausen # on sc7180 lazor On 10/6/23 18:55, Kuogee Hsieh wrote: > The purpose of this patch series is to incorporate pm

Re: [PATCH 04/10] drm/tidss: Move reset to the end of dispc_init()

2023-11-05 Thread Laurent Pinchart
On Thu, Nov 02, 2023 at 08:40:10AM +0200, Tomi Valkeinen wrote: > On 01/11/2023 15:57, Laurent Pinchart wrote: > > On Wed, Nov 01, 2023 at 11:17:41AM +0200, Tomi Valkeinen wrote: > >> We do a DSS reset in the middle of the dispc_init(). While that happens > >> to work now, we should really make

Re: [PATCH 02/10] drm/tidss: Use PM autosuspend

2023-11-05 Thread Laurent Pinchart
Hi Tomi, CC'ing Sakari for his expertise on runtime PM (I think he will soon start wishing he would be ignorant in this area). On Thu, Nov 02, 2023 at 08:34:45AM +0200, Tomi Valkeinen wrote: > On 01/11/2023 15:54, Laurent Pinchart wrote: > > On Wed, Nov 01, 2023 at 11:17:39AM +0200, Tomi

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-05 Thread Evan Preston
Hi Huacai, On 2023-11-05 Sun 08:40pm, Huacai Chen wrote: > Hi, Evan, > > On Sat, Nov 4, 2023 at 10:50 AM Evan Preston wrote: > > > > Hi Huacai, > > > > On 2023-11-03 Fri 02:36pm, Huacai Chen wrote: > > > Hi, Evan, > > > > > > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston wrote: > > > > > > > >

[PATCH v1] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-05 Thread Hunter Chasens
Resolves Sphinx unexpected indentation warning when compiling documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds a literal block to keep vertical formatting of the example power state list. Signed-off-by: Hunter Chasens --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13

[PATCH] nouveau: don't fail driver load if no display hw present.

2023-11-05 Thread Dave Airlie
From: Dave Airlie If we get back ENODEV don't fail load. Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM") Link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/270 Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_display.c | 5 + 1 file changed, 5

Re: [PATCH 1/2] fbdev/imsttfb: fix double free in probe()

2023-11-05 Thread Helge Deller
On 10/27/23 14:04, Dan Carpenter wrote: The init_imstt() function calls framebuffer_release() on error and then the probe() function calls it again. It should only be done in probe. Fixes: 518ecb6a209f ("fbdev: imsttfb: Fix error path of imsttfb_probe()") Signed-off-by: Dan Carpenter Both

Re: [PATCH] drivers/video/fbdev: use new array-copying-wrapper

2023-11-05 Thread Helge Deller
On 11/2/23 20:24, Philipp Stanner wrote: viafbdev.c utilizes memdup_user() to copy an array from userspace. There is a new wrapper, specifically designed for copying arrays. Use this one instead. Suggested-by: Dave Airlie Signed-off-by: Philipp Stanner applied. Thanks! Helge ---

Re: [PATCH] fbdev: omapfb: Drop unused remove function

2023-11-05 Thread Helge Deller
On 11/3/23 18:35, Uwe Kleine-König wrote: OMAP2_VRFB is a bool, so the vrfb driver can never be compiled as a module. With that __exit_p(vrfb_remove) always evaluates to NULL and vrfb_remove() is unused. If the driver was compilable as a module, it would fail to build because the type of

Re: [PATCH v2 6/9] PCI: Rename is_thunderbolt to is_tunneled

2023-11-05 Thread Lukas Wunner
On Fri, Nov 03, 2023 at 02:07:55PM -0500, Mario Limonciello wrote: > The `is_thunderbolt` bit has been used to indicate that a PCIe device > contained the Intel VSEC which is used by various parts of the kernel > to change behavior. To later allow usage with USB4 controllers as well, > rename this

Re: [PATCH 3/8] drm/loongson: Allow attach drm bridge driver by calling lsdc_output_init()

2023-11-05 Thread kernel test robot
Hi Sui, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.6 next-20231103] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-05 Thread Jaak Ristioja
On 05.11.23 14:40, Huacai Chen wrote: Hi, Evan, On Sat, Nov 4, 2023 at 10:50 AM Evan Preston wrote: Hi Huacai, On 2023-11-03 Fri 02:36pm, Huacai Chen wrote: Hi, Evan, On Fri, Nov 3, 2023 at 1:54 PM Evan Preston wrote: Hi Huacai, On 2023-11-02 Thu 08:38pm, Huacai Chen wrote: Hi, Jaak,

[PATCH] amdgpu: Adjust kmalloc_array calls for new -Walloc-size

2023-11-05 Thread Sam James
GCC 14 introduces a new -Walloc-size included in -Wextra which errors out on various files in drivers/gpu/drm/amd/amdgpu like: ``` amdgpu_amdkfd_gfx_v8.c:241:15: error: allocation of insufficient size ‘4’ for type ‘uint32_t[2]’ {aka ‘unsigned int[2]'} with size ‘8’ [-Werror=alloc-size] ``` This

RE: [PATCH] Replace ioremap_cache() with memremap()

2023-11-05 Thread Michael Kelley
From: Nischala Yelchuri Sent: Wednesday, November 1, 2023 9:02 AM > It's customary for the patch "Subject:" line to have a prefix indicating the area of the code being modified. This patch touches on multiple Hyper-V drivers, so there's not a clear choice for prefix. I would suggest using

Re: [PATCH v2 00/11] Add mediate-drm secure flow for SVP

2023-11-05 Thread 林睿祥

Re: [PATCH v2 10/11] drm/mediatek: Add cmdq_insert_backup_cookie before secure pkt finalize

2023-11-05 Thread 林睿祥

Re: [PATCH v2 07/11] drm/mediatek: Add secure layer config support for ovl

2023-11-05 Thread 林睿祥

Re: [PATCH v2 09/11] drm/mediatek: Add secure flow support to mediatek-drm

2023-11-05 Thread 林睿祥

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-05 Thread Huacai Chen
Hi, Evan, On Sat, Nov 4, 2023 at 10:50 AM Evan Preston wrote: > > Hi Huacai, > > On 2023-11-03 Fri 02:36pm, Huacai Chen wrote: > > Hi, Evan, > > > > On Fri, Nov 3, 2023 at 1:54 PM Evan Preston wrote: > > > > > > Hi Huacai, > > > > > > On 2023-11-02 Thu 08:38pm, Huacai Chen wrote: > > > > Hi,

amdgpu_amdkfd_gfx* triggers new -Walloc-size warnings in GCC 14

2023-11-05 Thread Sam James
GCC 14 introduces a new -Walloc-size warning (https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wno-alloc-size) which triggers on the following amdgpu files: """ /var/tmp/portage/sys-kernel/gentoo-kernel-6.5.10/work/linux-6.5/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c: In

[PATCH v3] drm: renesas: rcar-du: use proper naming for R-Car

2023-11-05 Thread Wolfram Sang
Not RCAR, but R-Car. Signed-off-by: Wolfram Sang Reviewed-by: Kieran Bingham Reviewed-by: Geert Uytterhoeven --- Changes since v2: * rebased to 6.6 * added Geert's tag (thanks!) drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git