RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-14 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Biju Das > Sent: Thursday, December 14, 2023 8:50 PM > Subject: RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > Hi Maxime Ripard, > > > > -Original Message- > > From: Biju Das > > Sent: Thursday, December 14, 2023 3:24

[PATCH] drm/rockchip: vop2: Remove the unused variable if_dclk_rate

2023-12-14 Thread Jiapeng Chong
Variable if_dclk_rate is not effectively used, so delete it. drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:1688:16: warning: variable ‘if_dclk_rate’ set but not used. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7750 Signed-off-by: Jiapeng Chong ---

[git pull] drm fixes for 6.7-rc6

2023-12-14 Thread Dave Airlie
Hi Linus, More regular fixes, amdgpu, i915, mediatek and nouveau are most of them this week. Nothing too major, then a few misc bits and pieces in core, panel and ivpu. Dave. drm-fixes-2023-12-15: drm fixes for 6.7-rc6 drm: - fix uninit problems in crtc - fix fd ownership check - edid: add

RE: [RFC PATCH] KVM: Introduce KVM VIRTIO device

2023-12-14 Thread Tian, Kevin
> From: Zhao, Yan Y > Sent: Thursday, December 14, 2023 6:35 PM > > - For host non-MMIO pages, > * virtio guest frontend and host backend driver should be synced to use > the same memory type to map a buffer. Otherwise, there will be > potential problem for incorrect memory data. But

Re: [PATCH V2] drivers: gpu: drm: vmwgfx: fixed typos

2023-12-14 Thread Randy Dunlap
Hi-- On 12/14/23 22:01, Ghanshyam Agrawal wrote: > Fixed multiple typos in vmwgfx_execbuf.c > > Signed-off-by: Ghanshyam Agrawal > --- > V2: > Fixed some more typos suggested by codespell > and the community. > > V1: > Fixed multiple typos > > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 8

Re: [PATCH] drivers: gpu: drm: vmwgfx: fixed typos

2023-12-14 Thread Randy Dunlap
On 12/14/23 21:30, Ghanshyam Agrawal wrote: > Fixed some typos in vmwgfx_execbuf.c > > Signed-off-by: Ghanshyam Agrawal > --- > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c >

Re: [PATCH] gpu: drm: amd: fixed typos

2023-12-14 Thread Randy Dunlap
Hi-- On 12/14/23 21:20, Ghanshyam Agrawal wrote: > Fixed multiple typos in atomfirmware.h > > Signed-off-by: Ghanshyam Agrawal > --- > drivers/gpu/drm/amd/include/atomfirmware.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] drm/nouveau: Fixup gk20a instobj hierarchy

2023-12-14 Thread Dave Airlie
On Thu, 14 Dec 2023 at 19:26, Jon Hunter wrote: > > > > On 08/12/2023 10:46, Thierry Reding wrote: > > From: Thierry Reding > > > > Commit 12c9b05da918 ("drm/nouveau/imem: support allocations not > > preserved across suspend") uses container_of() to cast from struct > > nvkm_memory to struct

Re: [PATCH] drm/exynos: fix accidental on-stack copy of exynos_drm_plane

2023-12-14 Thread Inki Dae
2023년 12월 15일 (금) 오전 12:59, Marek Szyprowski 님이 작성: > On 14.12.2023 13:32, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > gcc rightfully complains about excessive stack usage in the > fimd_win_set_pixfmt() > > function: > > > > drivers/gpu/drm/exynos/exynos_drm_fimd.c: In function >

[PATCH] drm/msm/mdss: specify cfg bandwidth for SDM670

2023-12-14 Thread Dmitry Baryshkov
Lower the requested CFG bus bandwidth for the SDM670 platform. The default value is 153600 kBps, which is twice as big as required by the platform according to the vendor kernel. Fixes: a55c8ff252d3 ("drm/msm/mdss: Handle the reg bus ICC path") Signed-off-by: Dmitry Baryshkov ---

Re: [v5, 02/16] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume"

2023-12-14 Thread Andy Yan
ffer device 240x67 rockchip-drm display-subsystem: [drm] fb0: rockchipdrmfb frame buffer device Reverting it on top of next-20231214 and resolving a conflict fixes/hides the above lock dep issue. --- (no changes since v1) drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 10 +++--- 1 file ch

[PATCH] drm/exynos: fix incorrect type issue

2023-12-14 Thread Inki Dae
Fix incorrect type issue in fimd_commit() of exynos_drm_fimd.c module. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312140930.me9ywf8f-...@intel.com/ Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-12-14 Thread Dmitry Osipenko
On 12/14/23 21:16, Maxime Ripard wrote: > On Tue, Dec 05, 2023 at 02:43:16PM +0300, Dmitry Osipenko wrote: >> On 12/4/23 15:55, Maxime Ripard wrote: Okay, that means s/_locked/_nolock/ in drm_gem_shmem_helpers.{c,h}, I guess. >> >> DRM subsys and majority of kernel uses common _locked

[PATCH] drm/display/dp: Update the name of bit#4 of DPCD TEST_REQUEST

2023-12-14 Thread Khaled Almahallawy
DP_TEST_LINK_FAUX_PATTERN is deprecated since DP1.3 Spec. Update to the latest definition in DP2.1 spec to reflect its true usage in the code. Cc: Jani Nikula Cc: Rob Clark Cc: Abhinav Kumar Cc: Sean Paul Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/msm/dp/dp_link.c | 2 +-

Re: [PATCH v3 2/2] drm/bridge: ti-sn65dsi86: Never store more than msg->size bytes in AUX xfer

2023-12-14 Thread Guenter Roeck
On Thu, Dec 14, 2023 at 12:38 PM Douglas Anderson wrote: > > For aux reads, the value `msg->size` indicates the size of the buffer > provided by `msg->buffer`. We should never in any circumstances write > more bytes to the buffer since it may overflow the buffer. > > In the ti-sn65dsi86 driver

Re: [PATCH v3 1/2] drm/bridge: parade-ps8640: Never store more than msg->size bytes in AUX xfer

2023-12-14 Thread Guenter Roeck
On Thu, Dec 14, 2023 at 12:38 PM Douglas Anderson wrote: > > While testing, I happened to notice a random crash that looked like: > > Kernel panic - not syncing: stack-protector: > Kernel stack is corrupted in: drm_dp_dpcd_probe+0x120/0x120 > > Analysis of drm_dp_dpcd_probe() shows that we

Re: [PATCH v3] ASoC: hdmi-codec: drop drm/drm_edid.h include

2023-12-14 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on tiwai-sound/for-next tiwai-sound/for-linus drm-tip/drm-tip linus/master v6.7-rc5 next-20231214] [If your patch is applied to the wrong git tree, kindly drop

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-14 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Biju Das > Sent: Thursday, December 14, 2023 3:24 PM > Subject: RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > > > > > + > > > + for (i = 0; i < num_planes; ++i) { > > > + enum drm_plane_type type = i < num_crtcs > > >

[PATCH v3 2/2] drm/bridge: ti-sn65dsi86: Never store more than msg->size bytes in AUX xfer

2023-12-14 Thread Douglas Anderson
For aux reads, the value `msg->size` indicates the size of the buffer provided by `msg->buffer`. We should never in any circumstances write more bytes to the buffer since it may overflow the buffer. In the ti-sn65dsi86 driver there is one code path that reads the transfer length from hardware.

[PATCH v3 1/2] drm/bridge: parade-ps8640: Never store more than msg->size bytes in AUX xfer

2023-12-14 Thread Douglas Anderson
While testing, I happened to notice a random crash that looked like: Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: drm_dp_dpcd_probe+0x120/0x120 Analysis of drm_dp_dpcd_probe() shows that we pass in a 1-byte buffer (allocated on the stack) to the aux->transfer()

Re: [PATCH v2 1/2] drm/bridge: parade-ps8640: Never store more than msg->size bytes in AUX xfer

2023-12-14 Thread Doug Anderson
Hi, On Thu, Dec 14, 2023 at 12:32 PM Douglas Anderson wrote: > > While testing, I happened to notice a random crash that looked like: > > Kernel panic - not syncing: stack-protector: > Kernel stack is corrupted in: drm_dp_dpcd_probe+0x120/0x120 > > Analysis of drm_dp_dpcd_probe() shows that

[PATCH v2 2/2] drm/bridge: ti-sn65dsi86: Never store more than msg->size bytes in AUX xfer

2023-12-14 Thread Douglas Anderson
For aux reads, the value `msg->size` indicates the size of the buffer provided by `msg->buffer`. We should never in any circumstances write more bytes to the buffer since it may overflow the buffer. In the ti-sn65dsi86 driver there is one code path that reads the transfer length from hardware.

[PATCH v2 1/2] drm/bridge: parade-ps8640: Never store more than msg->size bytes in AUX xfer

2023-12-14 Thread Douglas Anderson
While testing, I happened to notice a random crash that looked like: Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: drm_dp_dpcd_probe+0x120/0x120 Analysis of drm_dp_dpcd_probe() shows that we pass in a 1-byte buffer (allocated on the stack) to the aux->transfer()

Re: [PATCH v3 2/2] drm/amdgpu: Enable clear page functionality

2023-12-14 Thread Felix Kuehling
On 2023-12-14 08:42, Arunpravin Paneer Selvam wrote: Add clear page support in vram memory region. v1:(Christian) - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. - Make a specialized version of amdgpu_fill_buffer() which only

RE: [PATCH] drm/amd/display: fix documentation for dm_crtc_additional_color_mgmt()

2023-12-14 Thread Deucher, Alexander
[Public] > -Original Message- > From: Melissa Wen > Sent: Thursday, December 14, 2023 2:45 PM > To: Wentland, Harry ; Li, Sun peng (Leo) > ; Siqueira, Rodrigo ; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch > Cc: kernel test robot ;

Re: [net-next v1 08/16] memory-provider: dmabuf devmem memory provider

2023-12-14 Thread Mina Almasry
On Mon, Dec 11, 2023 at 12:37 PM Pavel Begunkov wrote: ... > >> If you remove the branch, let it fall into ->release and rely > >> on refcounting there, then the callback could also fix up > >> release_cnt or ask pp to do it, like in the patch I linked above > >> > > > > Sadly I don't think this

[PATCH v1 0/2] backlight: mp3309c: Allow to use on non-OF platforms

2023-12-14 Thread Andy Shevchenko
Allow to use driver on non-OF platforms and other cleanups. Andy Shevchenko (2): backlight: mp3309c: Make use of device properties backlight: mp3309c: Utilise temporary variable for struct device drivers/video/backlight/mp3309c.c | 76 +-- 1 file changed, 31

[PATCH v1 2/2] backlight: mp3309c: Utilise temporary variable for struct device

2023-12-14 Thread Andy Shevchenko
We have a temporary variable to keep pointer to struct device. Utilise it where it makes sense. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 38 +-- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git

[PATCH v1 1/2] backlight: mp3309c: Make use of device properties

2023-12-14 Thread Andy Shevchenko
Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Add mod_devicetable.h include. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 38 --- 1 file changed, 15 insertions(+), 23 deletions(-) diff

[PATCH] drm/amd/display: fix documentation for dm_crtc_additional_color_mgmt()

2023-12-14 Thread Melissa Wen
warning: expecting prototype for drm_crtc_additional_color_mgmt(). Prototype was for dm_crtc_additional_color_mgmt() instead Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312141801.o9ebcxt9-...@intel.com/ Signed-off-by: Melissa Wen ---

Re: [PATCH v2 2/8] arm64: dts: qcom: sm8150: make dispcc cast minimal vote on MMCX

2023-12-14 Thread Dmitry Baryshkov
On Thu, 14 Dec 2023 at 20:17, Konrad Dybcio wrote: > > > > On 12/11/23 16:44, Dmitry Baryshkov wrote: > > Add required-opps property to the display clock controller. This makes > > it cast minimal vote on the MMCX lane and prevents further 'clock stuck' > > errors when enabling the display. > > >

[PATCH v6] drm/msm/dpu: improve DSC allocation

2023-12-14 Thread Kuogee Hsieh
At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd index and another one has an even index. Each encoder can work independently. But only two DSC encoders from same DCE can be paired to work together to support

Re: [PATCH v5 6/6] drm/imx: Add drm_panic support

2023-12-14 Thread Maxime Ripard
On Thu, Dec 14, 2023 at 04:03:04PM +0100, Jocelyn Falempe wrote: > > > +static int imx_drm_get_scanout_buffer(struct drm_device *dev, > > > + struct drm_scanout_buffer *sb) > > > +{ > > > + struct drm_plane *plane; > > > + struct drm_gem_dma_object *dma_obj; > > > + >

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-14 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Biju Das > Sent: Thursday, December 14, 2023 3:24 PM > Subject: RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > . > > > + > > > + vsp->planes = kcalloc(num_planes, sizeof(*vsp->planes), GFP_KERNEL); > > > + if (!vsp->planes) > > >

Re: [PATCH v2 4/5] drm/atomic: Make the drm_atomic_state documentation less ambiguous

2023-12-14 Thread Hamza Mahfooz
On 12/14/23 05:09, Maxime Ripard wrote: The current documentation of drm_atomic_state says that it's the "global state object". This is confusing since, while it does contain all the objects affected by an update and their respective states, if an object isn't affected by this update it won't be

Re: [PATCH v2 2/8] arm64: dts: qcom: sm8150: make dispcc cast minimal vote on MMCX

2023-12-14 Thread Konrad Dybcio
On 12/11/23 16:44, Dmitry Baryshkov wrote: Add required-opps property to the display clock controller. This makes it cast minimal vote on the MMCX lane and prevents further 'clock stuck' errors when enabling the display. Fixes: 2ef3bb17c45c ("arm64: dts: qcom: sm8150: Add DISPCC node")

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-12-14 Thread Maxime Ripard
On Tue, Dec 05, 2023 at 02:43:16PM +0300, Dmitry Osipenko wrote: > On 12/4/23 15:55, Maxime Ripard wrote: > >> Okay, that means s/_locked/_nolock/ in drm_gem_shmem_helpers.{c,h}, I > >> guess. > > DRM subsys and majority of kernel uses common _locked postfix. We should > retain the old naming

Re: [PATCH v5] drm/msm/dpu: improve DSC allocation

2023-12-14 Thread Dmitry Baryshkov
On Thu, 14 Dec 2023 at 19:34, Kuogee Hsieh wrote: > > > On 12/13/2023 3:00 PM, Dmitry Baryshkov wrote: > > On Wed, 13 Dec 2023 at 20:58, Kuogee Hsieh wrote: > >> At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. > >> However, at DSC V1.2 DCE consists of two DSC encoders, one

Re: [PATCH 0/6] drm/tegra: Fix some error handling paths

2023-12-14 Thread Thierry Reding
On Sat, Sep 02, 2023 at 05:22:07PM +0200, Christophe JAILLET wrote: > Most of the patches are retated to tegra_output_probe() and missing > tegra_output_remove(). Others are things spotted while writting the serie. > > > Patches 1, 3, 4 are verbose, but some functions called in the probe can >

Re: [PATCH] drm/amd/pm: fix a double-free in amdgpu_parse_extended_power_table

2023-12-14 Thread Alex Deucher
Applied. Thanks! On Thu, Dec 14, 2023 at 12:20 PM Zhipeng Lu wrote: > > The amdgpu_free_extended_power_table is called in every error-handling > paths of amdgpu_parse_extended_power_table. However, after the following > call chain of returning: > > amdgpu_parse_extended_power_table > |->

Re: [PATCH v5] drm/msm/dpu: improve DSC allocation

2023-12-14 Thread Kuogee Hsieh
On 12/13/2023 3:00 PM, Dmitry Baryshkov wrote: On Wed, 13 Dec 2023 at 20:58, Kuogee Hsieh wrote: At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd index and another one has an even index. Each encoder

Re: [PATCH] drm/tegra: dpaux: Fix PM disable depth imbalance in tegra_dpaux_probe

2023-12-14 Thread Thierry Reding
On Wed, Oct 04, 2023 at 10:10:55PM +0800, Zhang Shurong wrote: > The pm_runtime_enable function increases the power disable depth, > which means that we must perform a matching decrement on the error > handling path to maintain balance within the given context. > Additionally, we need to address

Re: [PATCH v2] drm/tegra: include drm/drm_edid.h only where needed

2023-12-14 Thread Thierry Reding
On Wed, Dec 13, 2023 at 12:19:51PM +0200, Jani Nikula wrote: > Reduce the need for rebuilds when drm_edid.h is modified by including it > only where needed. > > v2: Fix build (kernel test robot ) > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/tegra/drm.h| 2 +- >

Re: [PATCH] drm/tegra: dsi: Add missing check for of_find_device_by_node

2023-12-14 Thread Thierry Reding
On Tue, Oct 24, 2023 at 08:07:38AM +, Chen Ni wrote: > Add check for the return value of of_find_device_by_node() and return > the error if it fails in order to avoid NULL pointer dereference. > > Fixes: e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support") > Signed-off-by: Chen Ni > ---

Re: [PATCH v5] drm/msm/dpu: improve DSC allocation

2023-12-14 Thread Kuogee Hsieh
On 12/13/2023 3:00 PM, Dmitry Baryshkov wrote: On Wed, 13 Dec 2023 at 20:58, Kuogee Hsieh wrote: At DSC V1.1 DCE (Display Compression Engine) contains a DSC encoder. However, at DSC V1.2 DCE consists of two DSC encoders, one has an odd index and another one has an even index. Each encoder

Re: [PATCH] gpu/drm/radeon: fix two memleaks in radeon_vm_init

2023-12-14 Thread Alex Deucher
Applied. Thanks! On Thu, Dec 14, 2023 at 11:59 AM Zhipeng Lu wrote: > > When radeon_bo_create and radeon_vm_clear_bo fail, the vm->page_tables > allocated before need to be freed. However, neither radeon_vm_init > itself nor its caller have done such deallocation. > > Fixes: 6d2f2944e95e

Re: [PATCH] drivers/amd/pm: fix a use-after-free in kv_parse_power_table

2023-12-14 Thread Alex Deucher
Applied. Thanks! On Thu, Dec 14, 2023 at 11:57 AM Zhipeng Lu wrote: > > When ps allocated by kzalloc equals to NULL, kv_parse_power_table > frees adev->pm.dpm.ps that allocated before. However, after the control > flow goes through the following call chains: > > kv_parse_power_table > |->

Re: [PATCH] drm/amd/pm: fix a double-free in si_dpm_init

2023-12-14 Thread Alex Deucher
Applied. Thanks! On Thu, Dec 14, 2023 at 10:59 AM Zhipeng Lu wrote: > > When the allocation of > adev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries fails, > amdgpu_free_extended_power_table is called to free some fields of adev. > However, when the control flow returns to si_dpm_sw_init,

[PATCH] drm/amd/pm: fix a double-free in amdgpu_parse_extended_power_table

2023-12-14 Thread Zhipeng Lu
The amdgpu_free_extended_power_table is called in every error-handling paths of amdgpu_parse_extended_power_table. However, after the following call chain of returning: amdgpu_parse_extended_power_table |-> kv_dpm_init / si_dpm_init (the only two caller of

[PATCH] gpu/drm/radeon: fix two memleaks in radeon_vm_init

2023-12-14 Thread Zhipeng Lu
When radeon_bo_create and radeon_vm_clear_bo fail, the vm->page_tables allocated before need to be freed. However, neither radeon_vm_init itself nor its caller have done such deallocation. Fixes: 6d2f2944e95e ("drm/radeon: use normal BOs for the page tables v4") Signed-off-by: Zhipeng Lu ---

[PATCH] drivers/amd/pm: fix a use-after-free in kv_parse_power_table

2023-12-14 Thread Zhipeng Lu
When ps allocated by kzalloc equals to NULL, kv_parse_power_table frees adev->pm.dpm.ps that allocated before. However, after the control flow goes through the following call chains: kv_parse_power_table |-> kv_dpm_init |-> kv_dpm_sw_init |-> kv_dpm_fini The

[PATCH] drm/mgag200: Fix gamma lut not initialized for G200ER, G200EV, G200SE

2023-12-14 Thread Jocelyn Falempe
When mgag200 switched from simple KMS to regular atomic helpers, the initialization of the gamma settings was lost. This leads to a black screen, if the bios/uefi doesn't use the same pixel color depth. This has been fixed with commit ad81e23426a6 ("drm/mgag200: Fix gamma lut not initialized.")

Re: [PATCH linux-next] drm/nouveau/disp: switch to use kmemdup() helper

2023-12-14 Thread Kees Cook
On Thu, Dec 14, 2023 at 08:03:22PM +0800, yang.gua...@zte.com.cn wrote: > From: Yang Guang > > Use kmemdup() helper instead of open-coding to > simplify the code. > > Signed-off-by: Chen Haonan Sure, good cleanup. Reviewed-by: Kees Cook -- Kees Cook

[PATCH] drm/amd/pm: fix a double-free in si_dpm_init

2023-12-14 Thread Zhipeng Lu
When the allocation of adev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries fails, amdgpu_free_extended_power_table is called to free some fields of adev. However, when the control flow returns to si_dpm_sw_init, it goes to label dpm_failed and calls si_dpm_fini, which calls

Re: [PATCH] drm/exynos: fix accidental on-stack copy of exynos_drm_plane

2023-12-14 Thread Marek Szyprowski
On 14.12.2023 13:32, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc rightfully complains about excessive stack usage in the > fimd_win_set_pixfmt() > function: > > drivers/gpu/drm/exynos/exynos_drm_fimd.c: In function 'fimd_win_set_pixfmt': > drivers/gpu/drm/exynos/exynos_drm_fimd.c:750:1:

Re: [RFC PATCH] dma-buf: Fix dma reservation with zero fences

2023-12-14 Thread Christian König
Am 14.12.23 um 13:08 schrieb Mika Kuoppala: Driver can initialize without any fences. If so roundup_power_of_two will overflow as it will try to subtract one from initial value before shift, (1 << fls_long(-1)). Ah, yes that reminds me that I wanted to take care of this as well. But solving

[PATCH v3 3/3] drm/panel-edp: Add some panels with conservative timings

2023-12-14 Thread Pin-yen Lin
These panels are used by Mediatek MT8173 Chromebooks, and they used to work with the downstream v4.19 kernel without any specified delay. Back in the v4.19 kernel, they used the "little white lie" approach, which is making the devicetree claim a specific panel's compatible string for many

[PATCH v3 2/3] drm/edp-panel: Add panels delay entries

2023-12-14 Thread Pin-yen Lin
Add panels used by Mediatek MT8173 Chromebooks. Signed-off-by: Pin-yen Lin Reviewed-by: Douglas Anderson --- Changes in v3: - Collect review tag. drivers/gpu/drm/panel/panel-edp.c | 39 +++ 1 file changed, 39 insertions(+) diff --git

[PATCH v3 1/3] drm/panel-edp: Add powered_on_to_enable delay

2023-12-14 Thread Pin-yen Lin
Add the support of powered_on_to_enable delay as the minimum time that needs to have passed between the panel powered on and enable may begin. This delay is seen in BOE panels as the minimum delay of T3+T4+T5+T6+T8 in the eDP timing diagrams. Signed-off-by: Pin-yen Lin Reviewed-by: Douglas

[PATCH v3 0/3] Support panels used by MT8173 Chromebooks in edp-panel

2023-12-14 Thread Pin-yen Lin
This series contains 4 patches: 1. Add a new panel delay to support some BOE panels 2. Add panel entries used by Mediatek MT8173 Chromebooks. 3. Add panels missing data sheets but used to work in older kernel version without any specified delays. Changes in v3: - Collect review tag. - Update

Re: [PATCH -next] drm/amd/pm: Remove unneeded semicolon

2023-12-14 Thread Alex Deucher
Applied. Thanks! On Wed, Dec 13, 2023 at 8:02 PM Yang Li wrote: > > ./drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c:1418:2-3: Unneeded semicolon > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7743 > Signed-off-by: Yang Li > --- >

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-14 Thread Biju Das
Hi Maxime Ripard, Thanks for the feedback. > -Original Message- > From: Maxime Ripard > Sent: Wednesday, December 13, 2023 3:47 PM > To: Biju Das > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > On Tue, Nov 28, 2023 at 10:51:27AM +, Biju Das wrote: > > The

Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2023-12-14 Thread Dave Stevenson
Hi Maxime On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > Now that we have all the infrastructure needed, we can add some code > that will, for a given connector state and mode, compute the best output > format and bpc. > > The algorithm is the same one than the one already found in i915

Re: [PATCH v5 14/44] drm/connector: hdmi: Add custom hook to filter TMDS character rate

2023-12-14 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > Most of the HDMI controllers have an upper TMDS character rate limit > they can't exceed. On "embedded"-grade display controllers, it will > typically be lower than what high-grade monitors can provide these days, > so drivers will filter the

Re: [PATCH v5 13/44] drm/connector: hdmi: Calculate TMDS character rate

2023-12-14 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > Most HDMI drivers have some code to calculate the TMDS character rate, > usually to adjust an internal clock to match what the mode requires. > > Since the TMDS character rates mostly depends on the resolution, whether > we need to repeat

Re: [PATCH v5 12/44] drm/connector: hdmi: Add HDMI compute clock helper

2023-12-14 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > A lot of HDMI drivers have some variation of the formula to calculate > the TMDS character rate from a mode, but few of them actually take all > parameters into account. > > Let's create a helper to provide that rate taking all parameters into

Re: [PATCH v5 6/6] drm/imx: Add drm_panic support

2023-12-14 Thread Jocelyn Falempe
On 14/12/2023 14:48, Maxime Ripard wrote: Hi, On Fri, Nov 03, 2023 at 03:53:30PM +0100, Jocelyn Falempe wrote: Proof of concept to add drm_panic support on an arm based GPU. I've tested it with X11/llvmpipe, because I wasn't able to have 3d rendering with etnaviv on my imx6 board.

Re: [PATCH v5 11/44] drm/connector: hdmi: Add support for output format

2023-12-14 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > Just like BPC, we'll add support for automatic selection of the output > format for HDMI connectors. > > Let's add the needed defaults and fields for now. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- >

Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-12-14 Thread Zhao Liu
On Thu, Dec 14, 2023 at 02:35:26PM +, Tvrtko Ursulin wrote: > Date: Thu, 14 Dec 2023 14:35:26 + > From: Tvrtko Ursulin > Subject: Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with > kmap_local_page() > > > On 14/12/2023 13:45, Tvrtko Ursulin wrote: > > > > Hi Zhao, > > > > On

Re: [PATCH v5 10/44] drm/connector: hdmi: Add output BPC to the connector state

2023-12-14 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > We'll add automatic selection of the output BPC in a following patch, > but let's add it to the HDMI connector state already. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/drm_atomic.c

Re: [PATCH v5 09/44] drm/connector: hdmi: Add RGB Quantization Range to the connector state

2023-12-14 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > HDMI controller drivers will need to figure out the RGB range they need > to configure based on a mode and property values. Let's expose that in > the HDMI connector state so drivers can just use that value. Again a mention that we're also

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2023-12-14 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > The i915 driver has a property to force the RGB range of an HDMI output. > The vc4 driver then implemented the same property with the same > semantics. KWin has support for it, and a PR for mutter is also there to > support it. > > Both

Re: [PATCH v5 07/44] drm/connector: hdmi: Create an HDMI sub-state

2023-12-14 Thread Dave Stevenson
On Thu, 7 Dec 2023 at 15:50, Maxime Ripard wrote: > > The next features we will need to share across drivers will need to > store some parameters for drivers to use, such as the selected output > format. > > Let's create a new connector sub-state dedicated to HDMI controllers, > that will

Re: [PATCH v5 06/44] drm/connector: Introduce an HDMI connector initialization function

2023-12-14 Thread Dave Stevenson
Hi Maxime As requested, I'm just going through patches 6-16. I will say that I've been less thorough in checking the kunit test code in this series than the core code changes, and I'm trusting that all the unit tests pass. I get a build failure on the complete series for arm64 with the standard

Re: [PATCH v5 6/6] drm/imx: Add drm_panic support

2023-12-14 Thread Maxime Ripard
On Thu, Dec 14, 2023 at 02:48:21PM +0100, Maxime Ripard wrote: > Hi, > > On Fri, Nov 03, 2023 at 03:53:30PM +0100, Jocelyn Falempe wrote: > > Proof of concept to add drm_panic support on an arm based GPU. > > I've tested it with X11/llvmpipe, because I wasn't able to have > > 3d rendering with

Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-12-14 Thread Tvrtko Ursulin
On 14/12/2023 13:45, Tvrtko Ursulin wrote: Hi Zhao, On 14/12/2023 13:19, Zhao Liu wrote: Hi maintainers, Just kindly ping. May I ask if this refresh version could be merged into the next tree of the i915? I certainly spotted your series last week or so but then it slipped my mind to go

[PATCH v9 6/8] drm/ttm/tests: Add eviction testing

2023-12-14 Thread Karolina Stolarek
Add tests for ttm_bo_validate that focus on BO eviction and swapout. Update device funcs definition with eviction-related callbacks. Add alternative funcs where evict_flags() routes eviction to a domain that can't allocate resources (dubbed "busy manager" in the tests). Extract the common path of

[PATCH v9 4/8] drm/ttm/tests: Add tests with mock resource managers

2023-12-14 Thread Karolina Stolarek
Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Reviewed-by: Christian König Tested-by:

[PATCH v9 7/8] drm/ttm/tests: Add tests for ttm_tt_populate

2023-12-14 Thread Karolina Stolarek
Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_tt_test.c | 119

[PATCH v9 8/8] drm/ttm/tests: Add TODO file

2023-12-14 Thread Karolina Stolarek
List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/TODO | 24 1 file changed, 24 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers/gpu/drm/ttm/tests/TODO

[PATCH v9 5/8] drm/ttm/tests: Add test cases dependent on fence signaling

2023-12-14 Thread Karolina Stolarek
Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 305

[PATCH v9 3/8] drm/ttm/tests: Test simple BO creation and validation

2023-12-14 Thread Karolina Stolarek
Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Christian

[PATCH v9 2/8] drm/ttm/tests: Use an init function from the helpers lib

2023-12-14 Thread Karolina Stolarek
Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 1 +

[PATCH v9 1/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

2023-12-14 Thread Karolina Stolarek
Remove a leftover definition of page order and pass an empty flag value in ttm_pool_pre_populated(). Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram Reviewed-by: Dominik Karol Piątkowski Acked-by: Christian König --- drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 3 +-- 1 file

[PATCH v9 0/8] Improve test coverage of TTM

2023-12-14 Thread Karolina Stolarek
Introduce tests for ttm_bo_validate()/ttm_bo_init_validate() that exercise simple BO placement as well as eviction (including the case where the evict domain also requires eviction to fit the incoming buffer). Prepare KUnit helpers to handle such scenarios and add a mock VRAM manager. This series

Re: [PATCH v8 0/8] Improve test coverage of TTM

2023-12-14 Thread Karolina Stolarek
On 14.12.2023 11:22, Christian König wrote: Am 14.12.23 um 09:20 schrieb Karolina Stolarek: Hi Christian, On 29.11.2023 13:02, Karolina Stolarek wrote: Karolina Stolarek (8):    drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man    drm/ttm/tests: Add tests for ttm_tt   

Re: [PATCH v5 6/6] drm/imx: Add drm_panic support

2023-12-14 Thread Maxime Ripard
Hi, On Fri, Nov 03, 2023 at 03:53:30PM +0100, Jocelyn Falempe wrote: > Proof of concept to add drm_panic support on an arm based GPU. > I've tested it with X11/llvmpipe, because I wasn't able to have > 3d rendering with etnaviv on my imx6 board. > > Signed-off-by: Jocelyn Falempe Like I said

Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-12-14 Thread Tvrtko Ursulin
Hi Zhao, On 14/12/2023 13:19, Zhao Liu wrote: Hi maintainers, Just kindly ping. May I ask if this refresh version could be merged into the next tree of the i915? I certainly spotted your series last week or so but then it slipped my mind to go through it. Should be able to go through it

[PATCH v3 2/2] drm/amdgpu: Enable clear page functionality

2023-12-14 Thread Arunpravin Paneer Selvam
Add clear page support in vram memory region. v1:(Christian) - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. - Make a specialized version of amdgpu_fill_buffer() which only clears the VRAM areas which are not already cleared -

[PATCH v3 1/2] drm/buddy: Implement tracking clear page feature

2023-12-14 Thread Arunpravin Paneer Selvam
- Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages size - If driver requests cleared memory we prefer cleared

Re: [RFC][PATCH v6 0/5] drm/panic: Add a drm panic handler

2023-12-14 Thread Maxime Ripard
Hi, Sorry for not taking a look at this sooner. On Tue, Dec 05, 2023 at 10:48:22AM +0100, Jocelyn Falempe wrote: > drm/panic: Add a drm panic handler > > This introduces a new drm panic handler, which displays a message when a > panic occurs. > So when fbcon is disabled, you can still see a

Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-12-14 Thread Zhao Liu
Hi maintainers, Just kindly ping. May I ask if this refresh version could be merged into the next tree of the i915? Thanks, Zhao On Sun, Dec 03, 2023 at 09:29:38PM +0800, Zhao Liu wrote: > Date: Sun, 3 Dec 2023 21:29:38 +0800 > From: Zhao Liu > Subject: [PATCH v3 0/9] drm/i915: Replace

[PATCH] drm/exynos: fix accidental on-stack copy of exynos_drm_plane

2023-12-14 Thread Arnd Bergmann
From: Arnd Bergmann gcc rightfully complains about excessive stack usage in the fimd_win_set_pixfmt() function: drivers/gpu/drm/exynos/exynos_drm_fimd.c: In function 'fimd_win_set_pixfmt': drivers/gpu/drm/exynos/exynos_drm_fimd.c:750:1: error: the frame size of 1032 bytes is larger than 1024

BUG [vmwgfx] kernel oops atomic cursors / vmw_du_cursor_plane_cleanup_fb / KDE Plasma 6

2023-12-14 Thread Stefan Hoffmeister
Previously reported at https://gitlab.freedesktop.org/drm/misc/-/issues/34 and https://bugs.kde.org/show_bug.cgi?id=478308 vmwgfx runs into kernel oops related to atomic cursors with KDE Plasma 6. I am able to reproduce this with * VMware Workstation 17.5 (on Windows 11 Professional)

[PATCH linux-next] drm/nouveau/disp: switch to use kmemdup() helper

2023-12-14 Thread yang.guang5
From: Yang Guang Use kmemdup() helper instead of open-coding to simplify the code. Signed-off-by: Chen Haonan --- drivers/gpu/drm/nouveau/nvif/outp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvif/outp.c

Re: [PATCH] MAINTAINERS: Remove Donald Robson from powervr driver maintainers

2023-12-14 Thread Maxime Ripard
Hi, On Thu, Dec 14, 2023 at 10:33:53AM +, Donald Robson wrote: > I will be leaving Imagination Technologies on 2023-12-15 and will no > longer be working on this driver. > > Signed-off-by: Donald Robson Applied, thanks Good luck on your next adventure :) Maxime signature.asc

Re: [PATCH] drm/ci: uprev mesa version: fix kdl commit fetch

2023-12-14 Thread Helen Koike
On 14/12/2023 05:00, Dmitry Baryshkov wrote: On Tue, 12 Dec 2023 at 18:04, Vignesh Raman wrote: build-kdl.sh was doing a `clone --depth 1` of the default branch, then checking out a commit that might not be the latest of that branch, resulting in container build error.

Re: [v5,02/16] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume"

2023-12-14 Thread Marek Szyprowski
ubsys_init+0x0/0x8  start_kernel+0x594/0x684  __primary_switched+0xbc/0xc4 Console: switching to colour frame buffer device 240x67 rockchip-drm display-subsystem: [drm] fb0: rockchipdrmfb frame buffer device Reverting it on top of next-20231214 and resolving a conflict fixes/hides the

[RFC PATCH] dma-buf: Fix dma reservation with zero fences

2023-12-14 Thread Mika Kuoppala
Driver can initialize without any fences. If so roundup_power_of_two will overflow as it will try to subtract one from initial value before shift, (1 << fls_long(-1)). Fix this using default (4) if num_fences is zero. Another more radical option would be to return error on zero but that would

Re: [PATCH] MAINTAINERS: Updates to Intel DRM

2023-12-14 Thread kernel test robot
Hi Rodrigo, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-tip/drm-tip linus/master v6.7-rc5 next-20231214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

  1   2   >