On 5/2/2023 4:54 PM, Dmitry Baryshkov wrote:
On 03/05/2023 02:51, Abhinav Kumar wrote:
On 4/30/2023 4:57 PM, Dmitry Baryshkov wrote:
The function dpu_encoder_get_wb() returns controller_id if the
corresponding WB is present in the catalog. We can inline this function
and rely on
On 5/2/2023 4:58 PM, Dmitry Baryshkov wrote:
On 03/05/2023 02:57, Abhinav Kumar wrote:
On 4/30/2023 4:57 PM, Dmitry Baryshkov wrote:
There is little sense to get intf index just to call dpu_rm_get_intf()
on it. Move dpu_rm_get_intf() call to dpu_encoder_get_intf() function.
Signed-off-by
On 5/2/2023 2:42 PM, Dmitry Baryshkov wrote:
On 03/05/2023 00:03, Kuogee Hsieh wrote:
From: Abhinav Kumar
Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and
feature flag information. Each display compression engine (DCE) contains
dual hard slice DSC encoders so both
Add writeback support for sc7280. This was validated with kms_writeback
test case in IGT.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h
b
it to my branch to test.
Validated writeback just in case with this, hence please use
Tested-by: Abhinav Kumar # sc7280
Dmitry Baryshkov (7):
drm/msm/dpu: merge dpu_encoder_init() and dpu_encoder_setup()
drm/msm/dpu: drop dpu_encoder_early_unregister
drm/msm/dpu: separate common
On 5/4/2023 11:23 AM, Marijn Suijten wrote:
On 2023-05-04 20:53:33, Dmitry Baryshkov wrote:
On Thu, 4 May 2023 at 20:49, Marijn Suijten
wrote:
PP_BLK_TE is no longer there.
marcos -> macros.
On 2023-05-04 09:46:41, Kuogee Hsieh wrote:
At legacy chipsets, it required DPU_PINGPONG_DSC bit
On 5/4/2023 12:36 PM, Marijn Suijten wrote:
On 2023-05-04 11:25:44, Abhinav Kumar wrote:
Sure, if you really prefer a split I'd go for two patches:
1. Add the flag to the enum and catalog;
2. Add the ops guard (functional change).
Then don't forget to reword the commit message,
On 5/4/2023 12:59 PM, Dmitry Baryshkov wrote:
On 04/05/2023 22:50, Abhinav Kumar wrote:
On 5/4/2023 12:36 PM, Marijn Suijten wrote:
On 2023-05-04 11:25:44, Abhinav Kumar wrote:
Sure, if you really prefer a split I'd go for two patches:
1. Add the flag to the enum and catalog;
2. Ad
On 5/4/2023 2:56 PM, Marijn Suijten wrote:
On 2023-04-12 16:25:20, Jessica Zhang wrote:
hdisplay for compressed images should be calculated as bytes_per_slice *
slice_count. Thus, use MSM DSC helper to calculate hdisplay for
dsi_timing_setup instead of directly using mode->hdisplay.
Changes
On 3/16/2023 9:16 AM, Dmitry Baryshkov wrote:
It is possible to use multirect feature and split source to use the SSPP
to output two consecutive rectangles. This commit brings in this
capability to support wider screen resolutions.
Tested-by: Abhinav Kumar # sc7280
Signed-off-by: Dmitry
On 3/29/2023 8:30 PM, Dmitry Baryshkov wrote:
On 30/03/2023 05:53, Abhinav Kumar wrote:
On 3/16/2023 9:16 AM, Dmitry Baryshkov wrote:
It is possible to use multirect feature and split source to use the SSPP
to output two consecutive rectangles. This commit brings in this
capability to
On 3/30/2023 6:25 PM, Dmitry Baryshkov wrote:
On 31/03/2023 04:12, Jessica Zhang wrote:
On 3/30/2023 5:16 PM, Dmitry Baryshkov wrote:
On Fri, 31 Mar 2023 at 03:07, Jessica Zhang
wrote:
On 3/30/2023 4:14 PM, Dmitry Baryshkov wrote:
On 31/03/2023 01:49, Jessica Zhang wrote:
On 3/29/
On 3/30/2023 5:16 PM, Dmitry Baryshkov wrote:
On Fri, 31 Mar 2023 at 03:07, Jessica Zhang wrote:
On 3/30/2023 4:14 PM, Dmitry Baryshkov wrote:
On 31/03/2023 01:49, Jessica Zhang wrote:
On 3/29/2023 4:48 PM, Dmitry Baryshkov wrote:
On 30/03/2023 02:18, Jessica Zhang wrote:
Use MSM an
On 3/30/2023 7:47 PM, Dmitry Baryshkov wrote:
On 31/03/2023 04:33, Abhinav Kumar wrote:
On 3/30/2023 5:16 PM, Dmitry Baryshkov wrote:
On Fri, 31 Mar 2023 at 03:07, Jessica Zhang
wrote:
On 3/30/2023 4:14 PM, Dmitry Baryshkov wrote:
On 31/03/2023 01:49, Jessica Zhang wrote:
On 3/29
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote:
From: Konrad Dybcio
These blocks are of variable length on different SoCs. Set the
correct values where I was able to retrieve it from downstream
DTs and leave the old defaults (0x1c8 for sspp and 0x280 for
intf) otherwise.
Signed-off-by: Konrad
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote:
DSC hw catalog data is not supposed to be changed, so mark it as const
data.
Reviewed-by: Konrad Dybcio
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote:
Fix several leftover _pp strutures and mark them as const, making all hw
catalog fit into the rodata section.
Reviewed-by: Konrad Dybcio
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
structure.
Reviewed-by: Konrad Dybcio
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote:
This huge series attempts to restructure the DPU HW catalog into a
manageable and reviewable data set. In order to ease review and testing
I merged all the necessary fixes into this series. Also I cherry-picked
& slightly fixed Konrad's patch addin
On 4/3/2023 11:48 AM, Dmitry Baryshkov wrote:
On 03/04/2023 21:06, Abhinav Kumar wrote:
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote:
This huge series attempts to restructure the DPU HW catalog into a
manageable and reviewable data set. In order to ease review and testing
I merged all the
On 4/1/2023 2:37 AM, Dmitry Baryshkov wrote:
On 01/04/2023 03:57, Abhinav Kumar wrote:
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote:
From: Konrad Dybcio
These blocks are of variable length on different SoCs. Set the
correct values where I was able to retrieve it from downstream
DTs and
On 4/4/2023 6:05 AM, Dmitry Baryshkov wrote:
On sm8450 platform the CTL_0 doesn't differ from the rest of CTL blocks,
so switch it to CTL_SC7280_MASK too.
Some background: original commit 100d7ef6995d ("drm/msm/dpu: add support
for SM8450") had all (relevant at that time) bit spelled individu
On 4/4/2023 6:05 AM, Dmitry Baryshkov wrote:
From: Konrad Dybcio
These blocks are of variable length on different SoCs. Set the
correct values where I was able to retrieve it from downstream
DTs and leave the old defaults (0x1c8) otherwise.
Signed-off-by: Konrad Dybcio
[DB: fixed some of l
On 4/4/2023 6:05 AM, Dmitry Baryshkov wrote:
From: Konrad Dybcio
These blocks are of variable length on different SoCs. Set the
correct values where I was able to retrieve it from downstream
DTs and leave the old defaults (0x280) otherwise.
Signed-off-by: Konrad Dybcio
[DB: fixed some leng
On 4/4/2023 6:06 AM, Dmitry Baryshkov wrote:
Duplicate sm8150 catalog entries to sc8180x to remove dependencies
between DPU instances.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
On 4/4/2023 6:06 AM, Dmitry Baryshkov wrote:
Duplicate sm8250 catalog entries to sc7180 to remove dependencies
between DPU instances.
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
On 4/4/2023 4:56 PM, Jessica Zhang wrote:
Introduce MSM-specific DSC helper methods, as some calculations are
common between DP and DSC.
Changes in v2:
- Moved files up to msm/ directory
- Dropped get_comp_ratio() helper
- Used drm_int2fixp() to convert to integers to fp
- Style changes to im
On 4/4/2023 4:56 PM, Jessica Zhang wrote:
hdisplay for compressed images should be calculated as bytes_per_slice *
slice_count. Thus, use MSM DSC helper to calculate hdisplay for
dsi_timing_setup instead of directly using mode->hdisplay.
Changes in v3:
- Split from previous patch
- Initialize
On 4/4/2023 5:33 PM, Dmitry Baryshkov wrote:
On 05/04/2023 01:12, Abhinav Kumar wrote:
On 4/4/2023 6:05 AM, Dmitry Baryshkov wrote:
On sm8450 platform the CTL_0 doesn't differ from the rest of CTL blocks,
so switch it to CTL_SC7280_MASK too.
Some background: original commit 100d7ef
On 4/4/2023 5:43 PM, Dmitry Baryshkov wrote:
On 05/04/2023 03:39, Abhinav Kumar wrote:
On 4/4/2023 5:33 PM, Dmitry Baryshkov wrote:
On 05/04/2023 01:12, Abhinav Kumar wrote:
On 4/4/2023 6:05 AM, Dmitry Baryshkov wrote:
On sm8450 platform the CTL_0 doesn't differ from the rest o
On 4/4/2023 5:37 PM, Dmitry Baryshkov wrote:
On 05/04/2023 01:30, Abhinav Kumar wrote:
On 4/4/2023 6:05 AM, Dmitry Baryshkov wrote:
From: Konrad Dybcio
These blocks are of variable length on different SoCs. Set the
correct values where I was able to retrieve it from downstream
DTs and
On 4/4/2023 6:06 AM, Dmitry Baryshkov wrote:
Duplicate qcm2290 catalog entries to sm6115 to remove dependencies
between DPU instances.
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
(-)
Reviewed-by: Abhinav Kumar
Reviewed-by: Abhinav Kumar
On 4/4/2023 6:06 AM, Dmitry Baryshkov wrote:
Theoretically since sm8150 we should be using a single CTL for the
source split case, but since we do not support it for now, fallback to
DPU_CTL_SPLIT_DISPLAY.
Did you mean split panel case?
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/d
On 4/5/2023 12:26 PM, Dmitry Baryshkov wrote:
On 05/04/2023 03:41, Jessica Zhang wrote:
Introduce MSM-specific DSC helper methods, as some calculations are
common between DP and DSC.
Changes in v2:
- Moved files up to msm/ directory
- Dropped get_comp_ratio() helper
- Used drm_int2fixp() to
On 4/4/2023 6:06 AM, Dmitry Baryshkov wrote:
Enable DSPP and DSC hardware blocks on sc8180x platform.
Signed-off-by: Dmitry Baryshkov
---
.../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 26 +--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/
On 4/7/2023 5:27 PM, Dmitry Baryshkov wrote:
Theoretically, since sm8150 we should be using a single CTL for the
split panel case, but since we do not support it for now, fallback to
DPU_CTL_SPLIT_DISPLAY.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
On 4/7/2023 5:27 PM, Dmitry Baryshkov wrote:
Mark DSPP_2 and DSPP_3 as used for LM_2 and LM_3
Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450")
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
On 4/7/2023 5:27 PM, Dmitry Baryshkov wrote:
Enable DSPP and DSC hardware blocks on sc8180x platform.
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
scheme), let's follow its usage as a least minimal
surprise. For example, sc8280xp, a close associate of sm8450, also uses
CTL_SC7280_MASK.
Signed-off-by: Dmitry Baryshkov
---
Although I dont totally agree with this, but because sc8280xp also uses
the same, I am fine.
Reviewed-by: Abhinav
5 DPU
support")
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
We usually have 12 chars of the hash. Other than that,
Reviewed-by: Abhinav Kumar
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 4 ++--
1 file changed, 2 insert
ne.
Fixes: f2803ee91a41 ("drm/msm/disp/dpu1: Add DSC support in RM")
Signed-off-by: Kuogee Hsieh
---
Otherwise, seems quite reasonable to me,
Reviewed-by: Abhinav Kumar
ITE(&ctx->hw, CTL_FLUSH, DSC_IDX);
- DPU_REG_WRITE(c, CTL_DSC_ACTIVE, cfg->dsc);
- }
+
+ DPU_REG_WRITE(&ctx->hw, CTL_FLUSH, DSC_IDX);
+ DPU_REG_WRITE(c, CTL_DSC_ACTIVE, cfg->dsc);
}
static void dpu_hw_ctl_intf_cfg(struct dpu_hw_ctl *ctx,
But, otherwise seems fine and a valid bug fix.
Reviewed-by: Abhinav Kumar
Hi Marijn
On 4/11/2023 3:24 PM, Marijn Suijten wrote:
Again, don't forget to include previous reviewers in cc, please :)
On 2023-04-11 14:09:40, Kuogee Hsieh wrote:
Perform DSC range checking to make sure correct DSC is requested before
reserve resource for it.
This isn't performing any rang
On 4/11/2023 3:17 PM, Dmitry Baryshkov wrote:
On 12/04/2023 00:04, Kuogee Hsieh wrote:
In current code, the dsc active bits are set only if the cfg->dsc is set.
However, for displays which are hot-pluggable, there can be a use-case
of disconnecting a DSC supported sink and connecting a non-DS
On 4/11/2023 3:14 PM, Marijn Suijten wrote:
Full-caps DSC in the title, as discussed previously.
On that note, don't forget to CC those who have reviewed your patches
previously, as also brought up in earlier review.
On 2023-04-11 14:04:55, Kuogee Hsieh wrote:
In current code, the dsc activ
On 4/11/2023 6:06 PM, Dmitry Baryshkov wrote:
On 12/04/2023 01:32, Abhinav Kumar wrote:
Hi Marijn
On 4/11/2023 3:24 PM, Marijn Suijten wrote:
Again, don't forget to include previous reviewers in cc, please :)
On 2023-04-11 14:09:40, Kuogee Hsieh wrote:
Perform DSC range checking to
On 4/12/2023 12:24 AM, Marijn Suijten wrote:
On 2023-04-11 16:45:34, Abhinav Kumar wrote:
[..]
Does this flush all DSCs programmed in CTL_DSC_FLUSH as set above? That
is currently still in `if (cfg->dsc)` and never overwritten if all DSCs
are disabled, should it be taken out of the `if`
On 4/12/2023 12:38 AM, Marijn Suijten wrote:
On 2023-04-11 18:50:24, Abhinav Kumar wrote:
On 4/11/2023 6:06 PM, Dmitry Baryshkov wrote:
On 12/04/2023 01:32, Abhinav Kumar wrote:
Hi Marijn
On 4/11/2023 3:24 PM, Marijn Suijten wrote:
Again, don't forget to include previous reviewe
On 4/12/2023 11:50 AM, Marijn Suijten wrote:
On 2023-04-12 10:48:18, Abhinav Kumar wrote:
[..]
The only way to trigger this newly introduced range check is by omitting
the DSC_x constants and manually writing e.g. an out-of-range value 10
here, or setting DSC_NONE. This is only allowed for
On 4/12/2023 12:24 PM, Dmitry Baryshkov wrote:
On 12/04/2023 22:09, Jessica Zhang wrote:
Add a check for valid dsc->slice_width value in dsi_timing_setup.
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers
---
For completeness,
Reviewed-by: Abhinav Kumar
On 4/14/2023 12:48 AM, Marijn Suijten wrote:
Capitalize DSC in the title, as discussed in v1.
On 2023-04-13 08:56:41, Kuogee Hsieh wrote:
In current code, the DSC active bits are written only if cfg->dsc is set.
However, for displays which are hot-pluggable, there can be a use-case
of discon
On 4/14/2023 12:35 AM, Marijn Suijten wrote:
On 2023-04-12 10:33:15, Abhinav Kumar wrote:
[..]
What happens if a device boots without DSC panel connected? Will
CTL_DSC_FLUSH be zero and not (unnecessarily, I assume) flush any of the
DSC blocks? Or could this flush uninitialized state to
On 4/14/2023 10:34 AM, Marijn Suijten wrote:
On 2023-04-14 08:48:43, Abhinav Kumar wrote:
On 4/14/2023 12:35 AM, Marijn Suijten wrote:
On 2023-04-12 10:33:15, Abhinav Kumar wrote:
[..]
What happens if a device boots without DSC panel connected? Will
CTL_DSC_FLUSH be zero and not
On 4/14/2023 10:28 AM, Marijn Suijten wrote:
On 2023-04-14 08:41:37, Abhinav Kumar wrote:
On 4/14/2023 12:48 AM, Marijn Suijten wrote:
Capitalize DSC in the title, as discussed in v1.
On 2023-04-13 08:56:41, Kuogee Hsieh wrote:
In current code, the DSC active bits are written only if cfg
On 4/14/2023 11:55 AM, Abhinav Kumar wrote:
On 4/14/2023 10:28 AM, Marijn Suijten wrote:
On 2023-04-14 08:41:37, Abhinav Kumar wrote:
On 4/14/2023 12:48 AM, Marijn Suijten wrote:
Capitalize DSC in the title, as discussed in v1.
On 2023-04-13 08:56:41, Kuogee Hsieh wrote:
In current
On 4/14/2023 1:58 PM, Dmitry Baryshkov wrote:
On Fri, 14 Apr 2023 at 21:55, Abhinav Kumar wrote:
On 4/14/2023 10:28 AM, Marijn Suijten wrote:
On 2023-04-14 08:41:37, Abhinav Kumar wrote:
On 4/14/2023 12:48 AM, Marijn Suijten wrote:
Capitalize DSC in the title, as discussed in v1.
On
On 4/14/2023 4:11 PM, Marijn Suijten wrote:
On 2023-04-14 10:57:45, Abhinav Kumar wrote:
On 4/14/2023 10:34 AM, Marijn Suijten wrote:
On 2023-04-14 08:48:43, Abhinav Kumar wrote:
On 4/14/2023 12:35 AM, Marijn Suijten wrote:
On 2023-04-12 10:33:15, Abhinav Kumar wrote:
[..]
What happens
On 4/14/2023 3:53 PM, Dmitry Baryshkov wrote:
On Sat, 15 Apr 2023 at 00:03, Abhinav Kumar wrote:
On 4/14/2023 1:58 PM, Dmitry Baryshkov wrote:
On Fri, 14 Apr 2023 at 21:55, Abhinav Kumar wrote:
On 4/14/2023 10:28 AM, Marijn Suijten wrote:
On 2023-04-14 08:41:37, Abhinav Kumar
On 4/14/2023 3:52 PM, Marijn Suijten wrote:
On 2023-04-14 14:03:23, Abhinav Kumar wrote:
[..]
Yes, ofcourse git send-email was used to send the patch, not any other
mail client.
Yes i am also aware that send-email converts rb to CC.
But if you keep working on the local branch, then you
updated on a per-frame basis.
To mitigate the performance impact of kvzalloc(), use it only when
the size of allocation is less than a page size when creating property
blobs
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_property.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion
On 3/3/2023 4:57 AM, Dmitry Baryshkov wrote:
Typically SSPP can support rectangle with width up to 2560. However it's
possible to use multirect feature and split source to use the SSPP to
output two consecutive rectangles. This commit brings in this capability
to support wider screen resolutio
Hi Ville
Thanks for the comments.
On 3/8/2023 4:10 PM, Ville Syrjälä wrote:
On Wed, Mar 08, 2023 at 03:33:48PM -0800, Rob Clark wrote:
On Wed, Mar 8, 2023 at 1:23 PM Ville Syrjälä
wrote:
On Wed, Mar 08, 2023 at 12:02:42PM -0800, Abhinav Kumar wrote:
For DRM property blobs created by user
this series.
[1]: https://patchwork.freedesktop.org/series/99909/
Abhinav Kumar (4):
drm/msm/dpu: avoid checking uninitialized plane format
drm/msm/dpu: remove unused dpu_plane_validate_multirect_v2 function
drm/msm/dpu: call _dpu_crtc_blend_setup_pipe for r_pipe
drm/msm/dpu: log the
: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index 06fbe5ef7ff2..9a03d1cad0ee 100644
--- a/drivers/gpu/drm/msm/disp/dpu1
Lets print the multirect_index as well in _dpu_crtc_blend_setup_pipe()
as it will give the complete information of the sw_pipe as well.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
was validated using a 2560x1440 DP monitor on sc7280 as
the max_linewidth is 2400 on sc7280.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
b/drivers/gpu/drm/msm
After cleaning up the older multirect support the function
dpu_plane_validate_multirect_v2() is unused. Lets remove it.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 111 --
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 7 --
2 files
Hi Adam
On 3/11/2023 9:28 AM, Adam Ford wrote:
On Thu, Oct 13, 2022 at 3:39 AM Robert Foss wrote:
On Tue, 11 Oct 2022 at 23:11, Abhinav Kumar wrote:
adv7533 bridge tries to dynamically switch lanes based on the
mode by detaching and attaching the mipi dsi device.
This approach is
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote:
As struct dpu_hw_sspp_cfg describes only the source and destination
rectangles, it is a software pipe configuration now. Rename it
accordingly.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote:
Move plane state updates from dpu_crtc_atomic_check() to the function
where they belong: to dpu_plane_atomic_check().
Signed-off-by: Dmitry Baryshkov
Can you please elaborate a bit on this comment?
https://patchwork.freedesktop.org/patch/521356
dpu_plane_atomic_check() uses unclipped rectangles, while
dpu_plane_atomic_update() uses clipped rectangles calculated by
drm_atomic_helper_check_plane_state()).
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
shkov
Reviewed-by: Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote:
Split pipe-dependent code from dpu_plane_sspp_atomic_update() into the
separate function dpu_plane_sspp_update_pipe(). This is one of
preparational steps to add r_pipe support.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote:
Split pipe-dependent code from dpu_plane_atomic_check() into the
separate function dpu_plane_atomic_check_pipe(). This is one of
preparational steps to add r_pipe support.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote:
Rework static color fill code to separate the pipe / pipe_cfg handling.
This is a preparation for the r_pipe support.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote:
Rework _dpu_crtc_blend_setup_mixer() to split away pipe handling to a
separate functon. This is a preparation for the r_pipe support.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote:
Typically SSPP can support rectangle with width up to 2560. However it's
Please change 2560 > max line width of SSPP as previously commented
possible to use multirect feature and split source to use the SSPP to
output two consecutive rectang
On 3/13/2023 9:14 PM, Dmitry Baryshkov wrote:
On 14/03/2023 06:02, Abhinav Kumar wrote:
On 3/9/2023 4:56 PM, Dmitry Baryshkov wrote:
Move plane state updates from dpu_crtc_atomic_check() to the function
where they belong: to dpu_plane_atomic_check().
Signed-off-by: Dmitry Baryshkov
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote:
From: Abhinav Kumar
Lets print the multirect_index as well in _dpu_crtc_blend_setup_pipe()
as it will give the complete information of the sw_pipe as well.
Signed-off-by: Abhinav Kumar
This needs your signed-off too
---
drivers/gpu/drm
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote:
From: Abhinav Kumar
After cleaning up the older multirect support the function
dpu_plane_validate_multirect_v2() is unused. Lets remove it.
Signed-off-by: Abhinav Kumar
this needs your signed-off too.
---
drivers/gpu/drm/msm/disp/dpu1
h.
Signed-off-by: Dmitry Baryshkov
Thanks for splitting this up.
Strictly on the basis of your validation of these chipsets, this is
Reviewed-by: Abhinav Kumar
with 1080P and without these changes, it should have no effect due
to this series.
2) I wanted to test some YUV overlay cases but I still cannot find one
on chrome. Its always using RGB. Will check with others.
With these two noted, this change and this series has my
Tested-by: Abhinav Kumar
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote:
The code doesn't use dpu_caps::smart_dma_rev field. It checks if the
corresponding feature is enabled in the SSPP features. Drop the
smart_dma_rev field completely.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
On 3/14/2023 3:58 AM, Dmitry Baryshkov wrote:
On 14/03/2023 07:08, Abhinav Kumar wrote:
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote:
Enable SmartDMA features for the rest of the platforms where it is
supposed to work.
Signed-off-by: Dmitry Baryshkov
I am so glad we split this. Without
On 3/14/2023 1:20 AM, Colin Ian King wrote:
There is a spelling mistake in a drm_dbg_dp message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
On 3/14/2023 9:43 AM, Dmitry Baryshkov wrote:
On 14/03/2023 18:35, Abhinav Kumar wrote:
On 3/14/2023 3:58 AM, Dmitry Baryshkov wrote:
On 14/03/2023 07:08, Abhinav Kumar wrote:
On 3/9/2023 4:57 PM, Dmitry Baryshkov wrote:
Enable SmartDMA features for the rest of the platforms where it
Ford wrote:
On Sat, Mar 11, 2023 at 3:40 PM Dmitry Baryshkov
wrote:
"Hi Abhinav,
On Sat, 11 Mar 2023 at 23:18, Abhinav Kumar
wrote:
Hi Adam
On 3/11/2023 9:28 AM, Adam Ford wrote:
On Thu, Oct 13, 2022 at 3:39 AM Robert Foss
wrote:
On Tue, 11 Oct 2022 at 23:11, Abhinav Kumar
On 3/14/2023 8:41 AM, Dmitry Baryshkov wrote:
On Tue, 14 Mar 2023 at 17:36, Dmitry Baryshkov
wrote:
It is possible to use multirect feature and split source to use the SSPP
to output two consecutive rectangles. This commit brings in this
capability to support wider screen resolutions.
Sign
commit info)
Best regards,
--
Abhinav Kumar
(no commit info)
Best regards,
--
Abhinav Kumar
Best regards,
--
Abhinav Kumar
CTRL_CURSORn for DMA SSPP clocks
https://gitlab.freedesktop.org/drm/msm/-/commit/d6181c18d55c
Best regards,
--
Abhinav Kumar
0xb4
> el0t_64_sync_handler+0xb8/0xbc
> el0t_64_sync+0x1a0/0x1a4
> Code: 52800016 52800017 52800018 17c7 (d4207d00)
>
> [...]
Applied, thanks!
[1/1] drm/msm/dpu: fix stack smashing in dpu_hw_ctl_setup_blendstage
https://gitlab.freedesktop.org/drm/msm/-/commit/1c1ded39bfb8
Best regards,
--
Abhinav Kumar
eedesktop.org/drm/msm/-/commit/ce68153edb5b
Best regards,
--
Abhinav Kumar
On 3/16/2023 9:03 AM, Dmitry Baryshkov wrote:
Hi,
[removed previous conversation]
Hi Dmitry and Abhinav,
Just wanted to follow up on this thread. I've gone over the MSM-specific
DSC params for DP and DSI and have found a few shared calculations and
variables between both DSI and DP paths:
On 3/16/2023 9:23 AM, Dmitry Baryshkov wrote:
On 16/03/2023 18:13, Abhinav Kumar wrote:
On 3/16/2023 9:03 AM, Dmitry Baryshkov wrote:
Hi,
[removed previous conversation]
Hi Dmitry and Abhinav,
Just wanted to follow up on this thread. I've gone over the
MSM-specific
DSC param
On 3/16/2023 9:36 AM, Abhinav Kumar wrote:
On 3/16/2023 9:23 AM, Dmitry Baryshkov wrote:
On 16/03/2023 18:13, Abhinav Kumar wrote:
On 3/16/2023 9:03 AM, Dmitry Baryshkov wrote:
Hi,
[removed previous conversation]
Hi Dmitry and Abhinav,
Just wanted to follow up on this thread. I&#x
1001 - 1100 of 2177 matches
Mail list logo
