changed, 17 insertions(+), 4 deletions(-)
This change itself is fine, hence
Reviewed-by: Abhinav Kumar
one note below for a future cleanup:
diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h
b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h
index 36ea1af10894
Hi Doug
On 6/13/2023 12:33 PM, Doug Anderson wrote:
Hi,
On Mon, Jun 12, 2023 at 3:40 PM Dmitry Baryshkov
wrote:
On 13/06/2023 01:01, Bjorn Andersson wrote:
Using devres to depopulate the aux bus made sure that upon a probe
deferral the EDP panel device would be destroyed and recreated upon
m/dpu: replace IRQ lookup with the data in hw
catalog")
Signed-off-by: Dmitry Baryshkov
---
Yes, was indeed a mistake
Reviewed-by: Abhinav Kumar
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote:
Each MERGE_3D block has just two registers. Correct the block length
accordingly.
Fixes: 4369c93cf36b ("drm/msm/dpu: initial support for merge3D hardware block")
Signed-off-by: Dmitry Baryshkov
---
LGTM,
Reviewed-by: Abhinav Kumar
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote:
sm6115 and qcm2290 do not have INTF_0. Drop corresponding interface
definitions.
And sm6375 as you are touching that too
Signed-off-by: Dmitry Baryshkov
---
You can fix that while applying.
Reviewed-by: Abhinav Kumar
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote:
Follow the DP example and define MSM_DSI_CONTROLLER_n enumeration.
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
On 6/13/2023 3:19 PM, Kuogee Hsieh wrote:
moving retrieving struct drm_dsc_cofnig from setup_display to
atomic_enable() and delete struct drm_dsc_config from
struct msm_display_info.
This needs re-wording.
Currently, struct drm_dsc_config is retrieved from DSI driver in
dpu_encoder_setup_
On 6/13/2023 3:19 PM, Kuogee Hsieh wrote:
ince struct drm_dsc_config is stored at atomic_enable() instead
S got cut off in since
of display setup time during boot up, saving struct drm_dsc_config
at struct msm_display_info is not necessary. Lets drop the dsc member
from struct msm_display_in
On 6/12/2023 5:09 PM, Dmitry Baryshkov wrote:
In several catalog entries we did not use existing MSM_DP_CONTROLLER_n
constants. Fill them in. Also use freshly defined MSM_DSI_CONTROLLER_n
for DSI interfaces.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_
n cases). Its used
only for the trace in dpu_encoder_helper_wait_event_timeout(). So this
was not really breaking writeback as such because the encoder kickoff /
wait mechanism largely relies on the kickoff_cnt increment/decrement.
Nonetheless, the patch LGTM and works fine, hence
Reviewed
On 6/4/2023 7:45 AM, Dmitry Baryshkov wrote:
The atomic_mode_set() callback only sets the phys_enc's IRQ data. As the
INTF and WB are statically allocated to each encoder/phys_enc, drop the
atomic_mode_set callback and set the IRQs during encoder init.
For the CMD panel usecase some of IRQ in
On 5/18/2023 7:30 PM, Dmitry Baryshkov wrote:
dpu_encoder_phys_wb is the only user of encoder's atomic_check callback.
Move corresponding checks to drm_writeback_connector's implementation
and drop the dpu_encoder_phys_wb_atomic_check() function.
Signed-off-by: Dmitry Baryshkov
---
I dont
Hi Neil
On 8/3/2023 10:19 AM, Jessica Zhang wrote:
On 7/31/2023 6:00 AM, Neil Armstrong wrote:
Hi,
On 26/07/2023 00:56, Jessica Zhang wrote:
Due to a recent introduction of the pre_enable_prev_first bridge flag
[1],
the panel driver will be probed before the DSI is enabled, causing the
DCS
/disp/dpu1/dpu_crtc.c | 2 +-
drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Abhinav Kumar
Hi Neil
On 8/14/2023 1:01 AM, neil.armstr...@linaro.org wrote:
Hi Abhinav,
On 10/08/2023 18:26, Abhinav Kumar wrote:
Hi Neil
On 8/3/2023 10:19 AM, Jessica Zhang wrote:
On 7/31/2023 6:00 AM, Neil Armstrong wrote:
Hi,
On 26/07/2023 00:56, Jessica Zhang wrote:
Due to a recent introduction
On 8/17/2023 11:50 AM, Dmitry Baryshkov wrote:
On 08/08/2023 02:49, Abhinav Kumar wrote:
On 6/4/2023 7:45 AM, Dmitry Baryshkov wrote:
The atomic_mode_set() callback only sets the phys_enc's IRQ data. As the
INTF and WB are statically allocated to each encoder/phys_enc, dro
this spam atleast
once per reboot but after this patch, I have not seen this for 5
consecutive reboots.
Hence,
Tested-by: Abhinav Kumar # sc7280
Looking at the code flow, the dp_ctrl_reinitialize_mainlink() certainly
looks redundant where it is, considering that the clks were enabled just
a
ak.
But thats a very minor comment, otherwise LGTM
Reviewed-by: Abhinav Kumar
return ret;
}
base-commit: 706a741595047797872e669b3101429ab8d378ef
+
6 files changed, 25 insertions(+), 2 deletions(-)
I am fine with this, thanks for working through the comments.
Reviewed-by: Abhinav Kumar
| 2 +-
drivers/gpu/drm/msm/dsi/dsi.h | 1 +
drivers/gpu/drm/msm/dsi/dsi_host.c | 31 +++
3 files changed, 29 insertions(+), 5 deletions(-)
Reviewed-by: Abhinav Kumar
On 7/4/2023 8:03 AM, Dmitry Baryshkov wrote:
Currently debugfs provides separate 'modes' to override calculated
MDP_CLK rate and interconnect bandwidth votes. Change that to allow
overriding individual values (e.g. one can override just clock or just
average bandwidth vote).
Signed-off-by: Dm
On 7/4/2023 8:03 AM, Dmitry Baryshkov wrote:
Move perf mode handling for the bandwidth to
_dpu_core_perf_crtc_update_bus() rather than overriding per-CRTC data
and then aggregating known values.
Note, this changes the fix_core_ab_vote. Previously it would be
multiplied per the CRTC number, no
On 7/4/2023 8:03 AM, Dmitry Baryshkov wrote:
This function does nothing, just clears several data pointers. Drop it
now.
Now, it doesnt even do that. Just resets the clk_rate to 0.
Acked-by: Konrad Dybcio
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.
On 7/4/2023 4:52 AM, Dmitry Baryshkov wrote:
On Tue, 4 Jul 2023 at 13:06, Dmitry Baryshkov
wrote:
On Tue, 4 Jul 2023 at 07:04, Abhinav Kumar wrote:
On 7/3/2023 7:20 PM, Dmitry Baryshkov wrote:
On 03/07/2023 05:01, Abhinav Kumar wrote:
On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote
eviewed-by: Abhinav Kumar
Will pick this up for -fixes
On 7/4/2023 10:28 AM, Dmitry Baryshkov wrote:
On Tue, 4 Jul 2023 at 19:10, Abhinav Kumar wrote:
On 7/4/2023 4:52 AM, Dmitry Baryshkov wrote:
On Tue, 4 Jul 2023 at 13:06, Dmitry Baryshkov
wrote:
On Tue, 4 Jul 2023 at 07:04, Abhinav Kumar wrote:
On 7/3/2023 7:20 PM, Dmitry
_tail" for FIFO queue behavior.
Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot")
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Ryan McCann
---
drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Abhinav Kumar
le changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Abhinav Kumar
/dpu1/dpu_hw_catalog.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Abhinav Kumar
; that results
in the redundant "0" suffix. Remove num parameter altogether from relevant
macros as a consequence of it no longer being used.
Signed-off-by: Ryan McCann
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 50 +++++-
1 file changed, 25 insertions(+), 25 deletions(-)
Reviewed-by: Abhinav Kumar
On 7/6/2023 5:07 PM, Dmitry Baryshkov wrote:
On 06/07/2023 23:48, Ryan McCann wrote:
Currently, the names of main blocks are hardcoded into the
msm_disp_snapshot_add_block function rather than using the name that
already exists in the catalog. Change this to take the name directly from
the ca
On 7/6/2023 7:19 PM, Dmitry Baryshkov wrote:
On 07/07/2023 03:16, Abhinav Kumar wrote:
On 7/6/2023 5:07 PM, Dmitry Baryshkov wrote:
On 06/07/2023 23:48, Ryan McCann wrote:
Currently, the names of main blocks are hardcoded into the
msm_disp_snapshot_add_block function rather than using
-by: Ryan McCann
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Abhinav Kumar
/dpu1/dpu_kms.c | 66 +++--
1 file changed, 54 insertions(+), 12 deletions(-)
Overall, I like this one.
Reviewed-by: Abhinav Kumar
On 7/7/2023 6:24 PM, Ryan McCann wrote:
The purpose of this patch series is to add support to print the registers
of sub-blocks in the DPU hardware catalog and fix the order in which all
hardware blocks are dumped for a device core dump. This involves:
Nice work on completing this feature a
("drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Abhinav Kumar
7_2_sc7280.h | 2 +-
.../gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 12 ++--
.../gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h | 8
.../gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h | 8
5 files changed, 19 insertions(+), 19 deletions(-)
Reviewed-b
On 7/7/2023 1:47 AM, Neil Armstrong wrote:
On 07/07/2023 09:18, Neil Armstrong wrote:
Hi,
On 06/07/2023 11:20, Amit Pundir wrote:
On Wed, 5 Jul 2023 at 11:09, Dmitry Baryshkov
wrote:
[Adding freedreno@ to cc list]
On Wed, 5 Jul 2023 at 08:31, Jagan Teki
wrote:
Hi Amit,
On Wed, Jul
On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
Since both pm_runtime_resume() and pm_runtime_suspend() are not
populated at dp_pm_ops. Those pm_runtime_get/put() functions within
dp_power.c will not have any effects in addition to increase/decrease
power
On 7/8/2023 7:34 PM, Bjorn Andersson wrote:
On Fri, Jul 07, 2023 at 04:52:19PM -0700, Kuogee Hsieh wrote:
Since both pm_runtime_resume() and pm_runtime_suspend() are not
populated at dp_pm_ops. Those pm_runtime_get/put() functions within
dp_power.c will not have any effects in addition to inc
On 7/9/2023 11:00 AM, Dmitry Baryshkov wrote:
On Sun, 9 Jul 2023 at 20:22, Abhinav Kumar wrote:
On 7/7/2023 5:06 PM, Dmitry Baryshkov wrote:
On 08/07/2023 02:52, Kuogee Hsieh wrote:
Since both pm_runtime_resume() and pm_runtime_suspend() are not
populated at dp_pm_ops. Those
On 7/7/2023 12:39 PM, Dmitry Baryshkov wrote:
The values in struct dpu_core_perf_tune are fixed per the core perf
mode. Drop the 'tune' values and substitute them with known values when
performing perf management.
Note: min_bus_vote was not used at all, so it is just silently dropped.
Inte
by: Torsten Krah
Tested-by: Paul Schyska
Cc: Daniel Vetter
Cc: David Airlie
Cc: Noralf Trønnes
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Javier Martinez Canillas
Cc: Russell King
Cc: Inki Dae
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Cc: Krzysztof Kozlowski
Cc: Patrik Jakobsson
Cc: Rob
On 7/11/2023 3:19 PM, Dmitry Baryshkov wrote:
On 12/07/2023 01:07, Jessica Zhang wrote:
On 7/10/2023 1:11 PM, Dmitry Baryshkov wrote:
On 10/07/2023 22:51, Jessica Zhang wrote:
On 6/30/2023 1:27 AM, Pekka Paalanen wrote:
On Fri, 30 Jun 2023 03:42:28 +0300
Dmitry Baryshkov wrote:
On 3
m6125 into this
- removed hex prefix from the revisions
- renamed enable_compression() to program_intf_cmd_cfg()
Abhinav Kumar (4):
drm/msm/dpu: re-introduce dpu core revision to the catalog
drm/msm/dpu: use dpu core's major version to enable data compress
drm/msm/dpu: rename ena
- rebased and added support for sm6125 into this
- introduce struct dpu_mdss_version to hold the core revision
Signed-off-by: Abhinav Kumar
---
.../drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 6 ++
.../drm/msm/disp/dpu1/catalog/dpu_4_0_sdm845.h | 6 ++
.../drm/msm/disp/dpu1/catal
s core revision
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 3 ++-
drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 2 +-
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu
Now that all usages of DPU_INTF_DATA_COMPRESS have been replaced
with the dpu core's major revision lets drop DPU_INTF_DATA_COMPRESS
from the catalog completely.
Signed-off-by: Abhinav Kumar
Reviewed-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +-
driver
Rename the intf's enable_compression() op to program_intf_cmd_cfg()
and allow it to accept a struct intf_cmd_mode_cfg to program
all the bits at once. This can be re-used by widebus later on as
well as it touches the same register.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp
On 7/4/2023 12:01 PM, Abhinav Kumar wrote:
On 7/4/2023 10:28 AM, Dmitry Baryshkov wrote:
On Tue, 4 Jul 2023 at 19:10, Abhinav Kumar
wrote:
On 7/4/2023 4:52 AM, Dmitry Baryshkov wrote:
On Tue, 4 Jul 2023 at 13:06, Dmitry Baryshkov
wrote:
On Tue, 4 Jul 2023 at 07:04, Abhinav Kumar
On 7/11/2023 5:42 PM, Dmitry Baryshkov wrote:
On 12/07/2023 03:33, Abhinav Kumar wrote:
Rename the intf's enable_compression() op to program_intf_cmd_cfg()
and allow it to accept a struct intf_cmd_mode_cfg to program
all the bits at once. This can be re-used by widebus later on as
well
checks for setting register bits based
on the dpu's core revision rather than catalog feature bits.
changes in v5:
- rename the structs in dpu_hw_intf to have the dpu_hw prefix
- remove a couple of comments
Abhinav Kumar (5):
drm/msm/dpu: re-introduce dpu core revision to th
t().
This will avoid defining feature bits for every bit level details of
registers.
changes in v5:
- none
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 3 ++-
drive
xxx && dpu_core_revision < x)
enable the bit;
changes in v5:
- fix the commit text to remove instances of DPU_HW_VER
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Abhinav Kumar
---
.../drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 6 ++
.../drm/msm/disp/dpu1/catalog/dpu_4_0_
Now that all usages of DPU_INTF_DATA_COMPRESS have been replaced
with the dpu core's major revision lets drop DPU_INTF_DATA_COMPRESS
from the catalog completely.
Signed-off-by: Abhinav Kumar
Reviewed-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +-
driver
dpu_hw_intf has a few instances of structs which do not have
the dpu_hw prefix. Lets fix this by renaming those structs
and updating the usage of those accordingly.
Signed-off-by: Abhinav Kumar
---
.../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 18 +-
drivers/gpu/drm/msm/disp
fg to dpu_hw_intf_cmd_mode_cfg
- remove couple of comments
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 8 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8 +---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 9 +++
On 7/10/2023 7:34 PM, Dmitry Baryshkov wrote:
On 11/07/2023 05:31, Abhinav Kumar wrote:
On 7/7/2023 12:39 PM, Dmitry Baryshkov wrote:
The values in struct dpu_core_perf_tune are fixed per the core perf
mode. Drop the 'tune' values and substitute them with known values when
perfo
/dpu1/dpu_core_perf.h | 6 --
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +-
3 files changed, 1 insertion(+), 10 deletions(-)
Reviewed-by: Abhinav Kumar
On 7/7/2023 12:39 PM, Dmitry Baryshkov wrote:
The dev_pm_opp_set_rate() already contains a call for clk_round_rate for
the passed value. Stop calling it manually from
_dpu_core_perf_get_core_clk_rate(). It is slightly incorrect to call it
this way, as we should round the final calculated clock
n for QCM2290")
Signed-off-by: Marijn Suijten
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Abhinav Kumar
On 7/12/2023 5:11 AM, Dmitry Baryshkov wrote:
The SM8550 platform employs newer UBWC decoder, which requires slightly
different programming.
Fixes: a2f33995c19d ("drm/msm: mdss: add support for SM8550")
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Do we also ne
_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Abhinav Kumar
On 7/12/2023 7:05 PM, Gaosheng Cui wrote:
The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should
use IS_ERR() to check the return value.
Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl")
Signed-off-by: Gaosheng Cui
Reviewed-by: Abhinav Kumar
---
Y
On 7/12/2023 10:41 AM, Marek Vasut wrote:
On 7/9/23 03:03, Abhinav Kumar wrote:
On 7/7/2023 1:47 AM, Neil Armstrong wrote:
On 07/07/2023 09:18, Neil Armstrong wrote:
Hi,
On 06/07/2023 11:20, Amit Pundir wrote:
On Wed, 5 Jul 2023 at 11:09, Dmitry Baryshkov
wrote:
[Adding freedreno
On 7/13/2023 11:28 AM, Marek Vasut wrote:
On 7/13/23 20:09, Abhinav Kumar wrote:
On 7/12/2023 10:41 AM, Marek Vasut wrote:
On 7/9/23 03:03, Abhinav Kumar wrote:
On 7/7/2023 1:47 AM, Neil Armstrong wrote:
On 07/07/2023 09:18, Neil Armstrong wrote:
Hi,
On 06/07/2023 11:20, Amit Pundir
ned-off-by: Gaosheng Cui
Reviewed-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
Reviewed-by: Akhil P Oommen
---
drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
b/drivers/gpu/drm/msm/adreno/a5xx_g
On 7/14/2023 12:10 PM, Abhinav Kumar wrote:
On 7/13/2023 6:48 PM, Gaosheng Cui wrote:
The msm_gem_get_vaddr() returns an ERR_PTR() on failure, we should
use IS_ERR() to check the return value.
use IS_ERR_OR_NULL()
I can even fix this while applying
Actually even subject line needs
msm/adreno: warn if chip revn is verified before being
set")
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
Tested-by: Abhinav Kumar # sc7280
clock rate rather than
rounding all the intermediate values.
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
| 6 --
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 -
3 files changed, 17 deletions(-)
Reviewed-by: Abhinav Kumar
dpu_core_perf.
With that,
Reviewed-by: Abhinav Kumar
: Abhinav Kumar
ly dropped.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 27 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 ---
2 files changed, 11 insertions(+), 20 deletions(-)
Reviewed-by: Abhinav Kumar
On 7/12/2023 3:11 PM, Dmitry Baryshkov wrote:
In preparation to refactoring the dpu_core_perf debugfs interface,
extract the bandwidth aggregation function from
_dpu_core_perf_crtc_update_bus().
Signed-off-by: Dmitry Baryshkov
---
Drop the core_perf tag from the subject line.
The debugfs
sable() balance be maintained by the
corresponding drm_bridge_connector_enable_hpd() /
drm_bridge_connector_disable_hpd() APIs.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_bridge_connector.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_bridge_connector.c
b/driver
top.org/drm/msm/-/commit/a85c238c5ccd
Best regards,
--
Abhinav Kumar
/DMA5 planes
https://gitlab.freedesktop.org/drm/msm/-/commit/ba7a94ea7312
Best regards,
--
Abhinav Kumar
t; - Fixed description for the last patch (Abhinav)
>
> [...]
Applied, thanks!
[01/11] drm/msm/dpu: drop enum dpu_core_perf_data_bus_id
https://gitlab.freedesktop.org/drm/msm/-/commit/e8383f5cf1b3
Best regards,
--
Abhinav Kumar
]
Applied, thanks!
[01/15] drm/msm/dsi: Drop unused regulators from QCM2290 14nm DSI PHY config
https://gitlab.freedesktop.org/drm/msm/-/commit/97368254a08e
Best regards,
--
Abhinav Kumar
Register the base address of various dpu sub-modules with the
dpu_dbg module so that it can be dumped out during error scenarios.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c | 4 +--
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c| 6 -
drivers/gpu/drm
atomic state and triggers a devcoredump.
Abhinav Kumar (4):
drm: allow drm_atomic_print_state() to accept any drm_printer
disp/msm/dpu: add support to dump dpu registers
drm/msm: register the base address with dpu_dbg module
drm/msm/dpu: add dpu_dbg points across dpu driver
drivers/gpu
Add dpu_dbg points across dpu driver to trigger dumps when critical
errors are hit.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 5 +++--
drivers/gpu/drm/msm/disp/dpu1
Currently drm_atomic_print_state() internally allocates and uses a
drm_info printer. Allow it to accept any drm_printer type so that
the API can be leveraged even for taking drm snapshot.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_atomic.c| 17 -
drivers/gpu
Add the dpu_dbg module which adds supports to dump dpu registers
which can be used in case of error conditions.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/Makefile | 2 +
drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c | 316 ++
drivers/gpu/drm/msm
For sinks that do not support audio, there is no need to notify
audio subsystem of the connection event.
This will make sure that audio routes only to the primary display
when connected to such sinks.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 12 ++--
1
better.
changes in v2:
- Rename the function drm_atomic_print_state to
drm_atomic_print_new_state and update the commit text
- Fix kbot errors
- Add kernel doc for the newly exported function
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_atomic.c
atomic state and triggers a devcoredump.
changes in v2:
- Fix kbot errors
- Rename drm_atomic_print_state function and add kernel doc for it
- Fix multiple dsi registration issue with dpu_dbg
Abhinav Kumar (4):
drm: allow drm_atomic_print_state() to accept any drm_printer
drm/msm/dpu: add
Add the dpu_dbg module which adds supports to dump dpu registers
which can be used in case of error conditions.
changes in v2: Fix kbot errors
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/Makefile | 2 +
drivers/gpu/drm/msm/disp/dpu1
Add dpu_dbg points across dpu driver to trigger dumps when critical
errors are hit.
changes in v2: none
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 5 +++--
drivers/gpu/drm/msm
Register the base address of various dpu sub-modules with the
dpu_dbg module so that it can be dumped out during error scenarios.
changes in v2:
- Fix an issue where the same dsi client was getting registered
multiple times to the dpu_dbg module
Signed-off-by: Abhinav Kumar
---
drivers/gpu
As per the documentation of drm_dev_register, all drivers should
call drm_dev_register after all the initialization is completed.
This also means that drm_mode_config_reset should be done before
drm_dev_register.
Change the sequence to align with this documentation.
Signed-off-by: Abhinav Kumar
Increase DRM_OBJECT_MAX_PROPERTY to accommodate for additional
DRM properties on MSM chipsets.
Signed-off-by: Abhinav Kumar
---
include/drm/drm_mode_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_mode_object.h b/include/drm/drm_mode_object.h
index
Fix the incorrect function prototype for dp_debug_get()
in the dp_debug module to address compilation warning.
Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to
/sys/kernel/debug/dri/*/")
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/
("drm/msm/dp: move debugfs node to
/sys/kernel/debug/dri/*/")
Reported-by: kernel test robot
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_debug.h | 2 +-
drivers/gpu/drm/msm/msm_drv.h | 5 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/
drm_atomic_get_***_state() APIs
which can be used to get snapshot of the drm atomic state of
display drivers.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_atomic.c| 154 ++--
drivers/gpu/drm/drm_atomic_helper.c | 28 -
include/drm/drm_atomic.h| 10
/11047883/
[2] https://patchwork.kernel.org/patch/11708677/
changes in v2:
- fix up a compilation issue on drm-next branch
changes in v3:
- add support to synchronize DP driver and audio during shutdown
changes in v4:
- rebase on top of latest patchset of dependency
Abhinav Kumar (5
Signal the hotplug disconnect event to the audio side in the
event handler so that they are notified earlier and have more
time to process the disconnect event.
Changes in v2: none
Changes in v3: none
Changes in v4: rebase on top of latest patchset of dependency
Signed-off-by: Abhinav Kumar
Store the dp_display in the platform driver data instead of the
dp_display_private.
This is required to allow other sub-modules to reuse the platform
driver data.
Changes in v3: none
Changes in v4: none
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 25
addition, audio side can open the sound card even if DP monitor
is not connected. Avoid programming hardware registers in this case
and bail out early.
Changes in v4: removed some leftover prints
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_audio.c | 32
1301 - 1400 of 2177 matches
Mail list logo
