On 6/16/2022 12:59 AM, Dmitry Baryshkov wrote:
Rather than having all resource allocation happen in the _bind function
(resulting in possible EPROBE_DEFER returns and component bind/unbind
cycles) allocate and check all resources in _probe function. While we
are at it, use platform_get_irq() t
clk_parent_data rather
parent_names to setup a link to the XO clock.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 25 +---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/msm/hdmi
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote:
The rest of the code expects that master's device drvdata is the
struct msm_drm_private instance. Do not override the mdp5's drvdata.
Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components")
Signed-off-by: Dmitry Baryshkov
Is th
Please fix the subject line .
It should be drm/msm/dpu: fix repeated words in comments
Also, you can add
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
On 8/23/2022 4:51 AM, Jilin Yuan wrote:
Delete the redundant word 'is'.
Signed-off-by: Jilin Yuan
---
drivers/gpu/drm/msm/disp
: 937f941ca06f "drm/msm/dp: Use qmp phy for DP PLL and PHY"
Signed-off-by: Kuogee Hsieh
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c
b/drivers/gpu/drm/msm/dp/dp_catal
On 8/24/2022 1:25 AM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:59, Abhinav Kumar wrote:
On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar wrote:
On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote:
On 22/08/2022 20:32, Abhinav Kumar wrote
On 8/24/2022 1:29 AM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 04:25, Abhinav Kumar wrote:
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote:
The rest of the code expects that master's device drvdata is the
struct msm_drm_private instance. Do not override the mdp5's drvda
)
Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning.
Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
Signed-off-by: YueHaibing
Reviewed-by: Abhinav Kumar
---
v2: fix this in DRM_DP_AUX_BUS dependencies
---
drivers/gpu/drm/display/Kc
Hi Jani
On 5/6/2022 4:16 AM, Jani Nikula wrote:
On Thu, 05 May 2022, Doug Anderson wrote:
Ville,
On Tue, Apr 26, 2022 at 1:21 PM Douglas Anderson wrote:
If we're unable to read the EDID for a display because it's corrupt /
bogus / invalid then we'll add a set of standard modes for the
disp
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
The funcitons _dpu_crtc_blend_setup() and _dpu_crtc_blend_setup_mixer()
have an intertwined mixture of CTL and LM-related code. Split these two
functions into LM-specific and CTL-specific parts, making both code
paths clean and observable.
I do s
On 5/6/2022 1:49 PM, Dmitry Baryshkov wrote:
On 25/04/2022 14:44, Sankeerth Billakanti wrote:
This patch adds support for generic eDP sink through aux_bus. The eDP/DP
controller driver should support aux transactions originating from the
panel-edp driver and hence should be initialized and re
On 5/6/2022 2:05 PM, Dmitry Baryshkov wrote:
On 07/05/2022 00:03, Abhinav Kumar wrote:
On 5/6/2022 1:49 PM, Dmitry Baryshkov wrote:
On 25/04/2022 14:44, Sankeerth Billakanti wrote:
This patch adds support for generic eDP sink through aux_bus. The
eDP/DP
controller driver should support
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
Wrap SSPP and multirect index/mode into a single structure that
represents software view on the pipe used.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 8 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h |
On 5/6/2022 2:39 PM, Dmitry Baryshkov wrote:
On 07/05/2022 00:30, Abhinav Kumar wrote:
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
Wrap SSPP and multirect index/mode into a single structure that
represents software view on the pipe used.
Signed-off-by: Dmitry Baryshkov
---
drivers
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
Where feasible, use dpu_sw_pipe rather than a combo of dpu_hw_pipe and
multirect_index/_mode arguments.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 59
On 5/6/2022 3:29 PM, Dmitry Baryshkov wrote:
On 07/05/2022 00:48, Abhinav Kumar wrote:
On 5/6/2022 2:39 PM, Dmitry Baryshkov wrote:
On 07/05/2022 00:30, Abhinav Kumar wrote:
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
Wrap SSPP and multirect index/mode into a single structure that
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
In preparation to reworking dpu_plane_sspp_atomic_update() inline the
_dpu_plane_set_scanout() function.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 41 ++-
1 file changed, 18 insertions(+
On 5/7/2022 4:40 AM, Dmitry Baryshkov wrote:
There is no need to check that kfree() argument is not NULL. Remove
extra check and call kfree() unconditionally.
Reported-by: kernel test robot
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1
ing at how other drm drivers handle this and they also have a
similar logic. So this is a good addition and thanks to the -EDEFER path
getting exposed we finally uncovered this.
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/msm_drv.c | 7 ++-
drivers/gpu/drm/msm/msm_kms.h | 1 +
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
There is no need to pass full dpu_hw_pipe_cfg instance to
_dpu_hw_sspp_setup_scaler3, pass just struct dpu_format pointer.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 9 -
drivers/gpu/drm/msm/disp/d
On 5/10/2022 9:52 AM, Rob Clark wrote:
From: Rob Clark
The offset got dropped by accident.
Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()")
Signed-off-by: Rob Clark
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/msm_fb.c | 2 +-
1 file changed, 1 insertion(+),
Hi Doug
On 5/10/2022 1:53 PM, Doug Anderson wrote:
Hi,
On Fri, May 6, 2022 at 9:33 AM Abhinav Kumar wrote:
Hi Jani
On 5/6/2022 4:16 AM, Jani Nikula wrote:
On Thu, 05 May 2022, Doug Anderson wrote:
Ville,
On Tue, Apr 26, 2022 at 1:21 PM Douglas Anderson wrote:
If we're unable to
and also
allow using writeback functionality for other use-cases as
necessary.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
b/drivers/gpu/drm/msm/disp/dpu1
ich mode to pick and it'll likely pick the highest
resolution one by default. That's probably not ideal because the modes
were purely guesses on the part of the Linux kernel.
Let's instead set 640x480 as the "preferred" mode when we have no EDID.
Signed-off-by: Douglas Anderson
Hi Doug
On 5/10/2022 2:41 PM, Doug Anderson wrote:
Hi,
On Tue, May 10, 2022 at 2:33 PM Abhinav Kumar wrote:
Hi Doug
On 5/10/2022 1:53 PM, Doug Anderson wrote:
Hi,
On Fri, May 6, 2022 at 9:33 AM Abhinav Kumar wrote:
Hi Jani
On 5/6/2022 4:16 AM, Jani Nikula wrote:
On Thu, 05 May 2022
previously passing.
Restore DRM_MODE_ROTATE_180 bit to the supported rotations
list.
Fixes: dabfdd89eaa92 ("add inline rotation support for sc7280")
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
host powerup to modeset
time")
Suggested-by: Rob Clark
Signed-off-by: Douglas Anderson
Reviewed-by: Dmitry Baryshkov
Yes, I think this is a better solution than a full revert
Reviewed-by: Abhinav Kumar
I am curious to know why this doesnt work for parade but will not hold
this patch
On 5/6/2022 6:00 PM, Dmitry Baryshkov wrote:
Afther the commit f026e431cf86 ("drm/msm: Convert to Linux IRQ
interfaces") converted MSM DRM driver to handle IRQs on it's own (rather
than using the DRM IRQ mid-layer), there is little point in keeping
irq wrapper in the msm_drv.c which just call
Hi,
On 5/12/2022 3:44 PM, Doug Anderson wrote:
Hi,
On Thu, May 12, 2022 at 3:34 PM Abhinav Kumar wrote:
On 5/12/2022 3:16 PM, Dmitry Baryshkov wrote:
On 13/05/2022 01:00, Douglas Anderson wrote:
Commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset
time") cau
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
Move stride programming to dpu_hw_sspp_setup_sourceaddress(), so that
dpu_hw_sspp_setup_rects() programs only source and destination
rectangles.
Signed-off-by: Dmitry Baryshkov
This separation is logically correct, but there is another codepath
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
Remove dpu_hw_fmt_layout instance from struct dpu_hw_fmt_layout, leaving
only src_rect and dst_rect.
I believe you meant "remove dpu_hw_fmt_layout instance from struct
dpu_hw_pipe_cfg" ?.
Otherwise nothing wrong with the change as such, but oth
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
Since layout is not cached anymore, drop comparison against previous
layout and corresponding EAGAIN handling.
Signed-off-by: Dmitry Baryshkov
Isnt this preventing the usermode from programming the same address again?
I thought that this check
th to allow
even compositors/clients which use only a single SSPP to
use writeback.
Fixes: 77b001acdcfeb ("drm/msm/dpu: add the writeback connector layer")
Reported-by: Jessica Zhang
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 4 +++-
1 file changed, 3 i
: Dmitry Baryshkov
This seems reasonable to me,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index
and bailing out earlier.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 2b9d931474e0..2fd1f5b70a06 100644
--- a
and bailing out earlier.
changes in v2:
- use pm_runtime_resume_and_get() instead of
pm_runtime_get_sync()
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1
On 5/18/2022 5:40 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2022-05-18 15:34:07)
If there are errors while trying to enable the pm in the
bind path, it will lead to unclocked access of hw revision
register thereby crashing the device.
This will not address why the pm_runtime_get_sync
-18 18:32:03 -0700)
5.19 fixes for msm-next
Signed-off-by: Abhinav Kumar
Abhinav Kumar (3):
drm/msm/dpu: limit writeback modes according to max_linewidth
On 5/23/2022 6:05 PM, Marek Vasut wrote:
Convert driver to use this new helper to standardize
OF "data-lanes" parsing.
Reviewed-by: Andrzej Hajda
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Marek Vasut
Reviewed-by: Abhinav Kumar
Cc: Abhinav Kumar
Cc: Andrzej Hajda
; superfluous
Other than that,
Reviewed-by: Abhinav Kumar
Fixes: 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder")
Reported-by: kernel test robot
Signed-off-by: Vinod Koul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 -
1 file changed, 1 deletion(-)
diff
On 5/13/2022 11:37 PM, Dmitry Baryshkov wrote:
On 04/05/2022 01:32, Abhinav Kumar wrote:
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
In preparation to adding fully virtualized planes, move struct
dpu_hw_pipe instance from struct dpu_plane to struct dpu_plane_state, as
it will become a
better way to utilize this, I am okay to drop this code.
When we do re-visit this implementation especially for src split,
atleast we have a reference of this PW link of what has been removed and
can take it from there.
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
Remove plane checks/state updates from dpu_crtc_atomic_check(). The
belong to dpu_plane_atomic_check().
The --> They
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 44 ---
drivers/gpu/drm/m
On 5/30/2022 12:33 AM, Haowen Bai wrote:
The ctx->hw is dereferencing before null checking, so move
it after checking.
Signed-off-by: Haowen Bai
Agree with Dmitry's comment. Adjust the patch subject to a different one
otherwise PW thinks they are same patches.
Reviewed-by:
On 5/29/2022 7:19 PM, Haowen Bai wrote:
The phys_enc->wb_idx is dereferencing before null checking, so move
it after checking.
Signed-off-by: Haowen Bai
Fixes: d7d0e73f7de33 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for
writeback")
Reviewed-by: Abhinav Kumar
---
m/msm/dpu: encoder: drop unused mode_fixup callback")
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 52
Hi Doug
On 5/31/2022 7:28 AM, Douglas Anderson wrote:
In commit a670ff578f1f ("drm/msm/dpu: always use mdp device to scale
bandwidth") we fully moved interconnect stuff to the DPU driver. This
had no change for sc7180 but _did_ have an impact for other SoCs. It
made them match the sc7180 scheme.
On 5/31/2022 5:18 AM, Dmitry Baryshkov wrote:
Replace magic register writes in msm_mdss_enable() with version that
contains less magic and more variable names that can be traced back to
the dpu_hw_catalog or the downstream dtsi files.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm
d to come and go with random factors. It's not terribly
surprising that the hang is gone after this patch since the line of
code that was failing is no longer present in the kernel.
Fixes: a670ff578f1f ("drm/msm/dpu: always use mdp device to scale bandwidth")
Fixes: c33b7c0389e1 ("
On 6/1/2022 3:04 AM, Dmitry Baryshkov wrote:
On Wed, 1 Jun 2022 at 02:01, Douglas Anderson wrote:
In commit a670ff578f1f ("drm/msm/dpu: always use mdp device to scale
bandwidth") we fully moved interconnect stuff to the DPU driver. This
had no change for sc7180 but _did_ have an impact for
On 6/1/2022 2:46 AM, Dmitry Baryshkov wrote:
On Wed, 1 Jun 2022 at 01:01, Abhinav Kumar wrote:
On 5/31/2022 5:18 AM, Dmitry Baryshkov wrote:
Replace magic register writes in msm_mdss_enable() with version that
contains less magic and more variable names that can be traced back to
the
On 6/1/2022 12:58 PM, Dmitry Baryshkov wrote:
On Wed, 1 Jun 2022 at 20:18, Abhinav Kumar wrote:
On 6/1/2022 3:04 AM, Dmitry Baryshkov wrote:
On Wed, 1 Jun 2022 at 02:01, Douglas Anderson wrote:
In commit a670ff578f1f ("drm/msm/dpu: always use mdp device to scale
bandwidth"
Hi Rob
Here is the second pull request for the fixes for 5.19.
This goes on top of the previous pull request.
Mainly it has the foll fixes:
- Fix to add minimum ICC vote in the msm_mdss pm_resume path to address
bootup splats
- Fix to avoid dereferencing without checking in WB encoder
- Fix
Hi Stephen / Dmitry
Let me try to explain the issue kuogee is trying to fix below:
On 6/24/2022 4:56 PM, Kuogee Hsieh wrote:
On 6/24/2022 4:45 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 16:30:59)
On 6/24/2022 4:12 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 15:53:
On 6/24/2022 5:23 PM, Stephen Boyd wrote:
Quoting Stephen Boyd (2022-06-24 17:11:01)
Quoting Abhinav Kumar (2022-06-24 17:03:37)
So let me try to explain this as this is what i understood from the
patch and how kuogee explained me.
The ordering of the array still matters here and thats
On 6/24/2022 5:11 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:03, Abhinav Kumar wrote:
Hi Stephen / Dmitry
Let me try to explain the issue kuogee is trying to fix below:
On 6/24/2022 4:56 PM, Kuogee Hsieh wrote:
On 6/24/2022 4:45 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh
goto.
Reviewed-by: Stephen Boyd
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
Changes since v1: fix the typo (noticed by Stephen)
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu
On 6/24/2022 5:28 PM, Stephen Boyd wrote:
We don't need to stash the encoder here. Instead we can simply pass it
around as an argument.
Cc: Kuogee Hsieh
Signed-off-by: Stephen Boyd
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 4 +---
drivers/gpu/drm/m
king at this a bit w/ Doug, I think the "glitch" is
simply just an un-renderered buffer being interpreted by the display
controller as UBWC (because userspace tells it to)
BR,
-R
Acked and agree with the comments both of you have stated and looking at
the corrupted buffers in th
On 7/4/2022 11:14 AM, Dmitry Baryshkov wrote:
On 30/06/2022 09:14, Dmitry Baryshkov wrote:
On 30 June 2022 04:57:35 GMT+03:00, Rob Clark
wrote:
On Wed, Jun 29, 2022 at 5:36 PM Doug Anderson
wrote:
Hi,
On Tue, Jun 28, 2022 at 1:14 PM Dmitry Baryshkov
wrote:
On 28 June 2022 18:20:06
_init()
Changes in v4:
-- move drm_helper_move_panel_connectors_to_head() to msm_drm_init()
Signed-off-by: Kuogee Hsieh
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/msm_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_
33e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 12 --
drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 29 +++-
2 files changed, 18 insertions(+), 23 delet
/0xb0
drm_atomic_check_only+0x4b0/0x8f4
drm_atomic_commit+0x68/0xe0
Fixes: d59be579fa93 ("drm/msm/mdp5: Return error code in mdp5_pipe_release when
deadlock is detected")
Signed-off-by: Rob Clark
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_
On 7/6/2022 12:14 PM, Stephen Boyd wrote:
Set the panel orientation in drm when the panel is directly connected,
i.e. we're not using an external bridge. The external bridge case is
already handled by the panel bridge code, so we only update the path we
take when the panel is directly connecte
On 7/7/2022 2:21 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2022-07-07 14:11:08)
On 7/6/2022 12:14 PM, Stephen Boyd wrote:
Set the panel orientation in drm when the panel is directly connected,
i.e. we're not using an external bridge. The external bridge case is
already handled b
On 7/7/2022 2:20 PM, Rob Clark wrote:
From: Rob Clark
Fixes `kms_cursor_crc --run-subtest cursor-offscreen`.. when the cursor
moves offscreen the plane becomes non-visible, so we need to skip over
it in crtc atomic test and mixer setup.
Signed-off-by: Rob Clark
Reviewed-by: Abhinav Kumar
On 7/8/2022 8:25 AM, Doug Anderson wrote:
Hi,
On Wed, Jul 6, 2022 at 12:14 PM Stephen Boyd wrote:
Set the panel orientation in drm when the panel is directly connected,
i.e. we're not using an external bridge. The external bridge case is
already handled by the panel bridge code, so we only
+ kuogee
On 7/8/2022 12:27 PM, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-07-07 20:46:43)
On 08/07/2022 04:28, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-07-07 14:31:56)
The p1 region was probably added by mistake, none of the DTS files
provides one (and the driver source code
On 7/8/2022 9:00 AM, Abhinav Kumar wrote:
On 7/8/2022 8:25 AM, Doug Anderson wrote:
Hi,
On Wed, Jul 6, 2022 at 12:14 PM Stephen Boyd wrote:
Set the panel orientation in drm when the panel is directly connected,
i.e. we're not using an external bridge. The external bridge ca
On 7/8/2022 12:51 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2022-07-08 12:38:09)
+ kuogee
On 7/8/2022 12:27 PM, Stephen Boyd wrote:
Yes I see the same address for P1 on sc7280. Maybe it's a typo? Abhinav,
can you confirm?
P1 block does exist on sc7280 and yes its address is sa
On 7/8/2022 1:58 PM, Dmitry Baryshkov wrote:
On Fri, 8 Jul 2022 at 22:42, Abhinav Kumar wrote:
On 7/8/2022 9:00 AM, Abhinav Kumar wrote:
On 7/8/2022 8:25 AM, Doug Anderson wrote:
Hi,
On Wed, Jul 6, 2022 at 12:14 PM Stephen Boyd wrote:
Set the panel orientation in drm when the
Hi Liviu
Thanks for the response.
Let me fix up and spin a new version.
Abhinav
On 3/31/2022 3:01 AM, Liviu Dudau wrote:
On Fri, Mar 25, 2022 at 09:31:35AM -0700, Abhinav Kumar wrote:
Hi Liviu
Hi Abhinav,
Sorry for the delay, got busy with other things at the beginning of the week
://patchwork.freedesktop.org/series/99724/
changes in v6:
- remove drm_writeback_connector_setup() and instead
directly call drm_writeback_connector_init_with_encoder()
- pass encoder as a parameter explicitly to the new API
for better readability
Abhinav Kumar (4):
drm: allow
.
changes in v6:
- None
Signed-off-by: Abhinav Kumar
Acked-by: Liviu Dudau
---
drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 3 +--
drivers/gpu/drm/arm/malidp_mw.c | 4 ++--
drivers/gpu/drm/drm_writeback.c | 6 +-
drivers/gpu/drm
:
- pass the encoder to drm_writeback_connector_init_with_encoder()
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/vc4/vc4_txp.c | 30 +++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c
-off-by: Kandpal Suraj
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_writeback.c | 18 --
drivers/gpu/drm/vc4/vc4_txp.c | 14 --
include/drm/drm_writeback.h | 21 +++--
3 files changed, 39 insertions(+), 14 deletions(-)
diff --git a/drivers
incorrectly shows that the function accepts enc_helper_funcs
- pass encoder as a parameter explicitly to the new API
for better readability
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_writeback.c | 72 +
include/drm
Hi Laurent
Thanks for the review.
One question below.
On 4/1/2022 8:38 AM, Laurent Pinchart wrote:
Hi Abhinav,
Thank you for the patch.
On Thu, Mar 31, 2022 at 05:12:13PM -0700, Abhinav Kumar wrote:
For some vendor driver implementations, display hardware can
be shared between the encoder
able to me,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index d51e70fab93d..8925f60fd9ec 100644
--- a/drivers/g
Hi Laurent
On 4/5/2022 9:47 AM, Laurent Pinchart wrote:
Hi Rob and Abhinav,
On Mon, Apr 04, 2022 at 11:43:37AM -0700, Rob Clark wrote:
On Fri, Apr 1, 2022 at 8:38 AM Laurent Pinchart wrote:
On Thu, Mar 31, 2022 at 05:12:13PM -0700, Abhinav Kumar wrote:
For some vendor driver implementations
Hi Laurent
On 4/5/2022 10:02 AM, Laurent Pinchart wrote:
Hi Abhinav,
On Tue, Apr 05, 2022 at 09:53:57AM -0700, Abhinav Kumar wrote:
On 4/5/2022 9:47 AM, Laurent Pinchart wrote:
On Mon, Apr 04, 2022 at 11:43:37AM -0700, Rob Clark wrote:
On Fri, Apr 1, 2022 at 8:38 AM Laurent Pinchart wrote
Hi Laurent
On 4/5/2022 10:08 AM, Abhinav Kumar wrote:
Hi Laurent
On 4/5/2022 10:02 AM, Laurent Pinchart wrote:
Hi Abhinav,
On Tue, Apr 05, 2022 at 09:53:57AM -0700, Abhinav Kumar wrote:
On 4/5/2022 9:47 AM, Laurent Pinchart wrote:
On Mon, Apr 04, 2022 at 11:43:37AM -0700, Rob Clark wrote
Hi Liviu
Thank you for your reviews. They were very useful to get this in shape.
Some comments below.
Abhinav
On 4/6/2022 7:55 AM, Liviu Dudau wrote:
Hi Abhinav,
On Thu, Mar 31, 2022 at 05:12:11PM -0700, Abhinav Kumar wrote:
For vendors drivers which pass an already allocated and
Hi Doug and Dmitry
Sorry, but I caught up on this email just now.
Some comments below.
Thanks
Abhinav
On 4/7/2022 10:07 AM, Doug Anderson wrote:
Hi,
On Thu, Apr 7, 2022 at 7:19 AM Sankeerth Billakanti (QUIC)
wrote:
Hi Dmitry and Doug,
Hi,
On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshko
Hi Doug
Thanks for the response, some comments below.
Abhinav
On 4/7/2022 1:47 PM, Doug Anderson wrote:
Hi,
On Thu, Apr 7, 2022 at 1:11 PM Abhinav Kumar wrote:
Hi Doug and Dmitry
Sorry, but I caught up on this email just now.
Some comments below.
Thanks
Abhinav
On 4/7/2022 10:07 AM
Hi Rob and Daniel
On 4/7/2022 3:51 PM, Rob Clark wrote:
On Wed, Apr 6, 2022 at 6:27 PM Jessica Zhang wrote:
On 3/31/2022 8:20 AM, Daniel Vetter wrote:
The stuff never really worked, and leads to lots of fun because it
out-of-order frees atomic states. Which upsets KASAN, among other
things
Hi Doug and Dmitry
On 4/8/2022 7:58 AM, Dmitry Baryshkov wrote:
On Fri, 8 Apr 2022 at 16:43, Doug Anderson wrote:
Hi,
On Fri, Apr 8, 2022 at 5:20 AM Dmitry Baryshkov
wrote:
I guess my thought was that in DP you could still create the AUX bus
at probe time. Then for DP you just return an
://patchwork.freedesktop.org/series/99724/
changes in v7:
- move the change to make drm_encoder a pointer ahead in the
series. This allows vendor changes to be kept at a minimum
in core API changes
- add a more detailed change log for some of the changes
Abhinav Kumar (4
style of existing drivers
- Fix indentation and remove parenthesis where not needed
- use u32 instead of uint32_t for possible_crtcs
Signed-off-by: Abhinav Kumar
Acked-by: Liviu Dudau
---
drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 ++--
drivers/gpu/drm/arm
which
incorrectly shows that the function accepts enc_helper_funcs
- pass encoder as a parameter explicitly to the new API
for better readability
changes in v7:
- fix the function doc slightly as suggested by Liviu
Reviewed-by: Liviu Dudau
Signed-off-by: Abhinav
:
- remove the drm core changes to previous patch in the series
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/vc4/vc4_txp.c | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c
changes to vendor drivers in drm core
changes
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/drm_writeback.c | 18 --
drivers/gpu/drm/vc4/vc4_txp.c | 4 ++--
include/drm/drm_writeback.h | 22 --
3 files changed, 34 insertions(+), 10
On 4/7/2022 4:12 PM, Rob Clark wrote:
On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar wrote:
Hi Rob and Daniel
On 4/7/2022 3:51 PM, Rob Clark wrote:
On Wed, Apr 6, 2022 at 6:27 PM Jessica Zhang wrote:
On 3/31/2022 8:20 AM, Daniel Vetter wrote:
The stuff never really worked, and leads
connector' which is what was intended.
Cc: Dmitry Baryshkov
Cc: Sean Paul
Fixes: 6d5e78406991 ("drm/msm/dsi: Move dsi panel init into modeset init path")
Signed-off-by: Stephen Boyd
Reviewed-by: Abhinav Kumar
---
I don't know if this is superseeded by something else but I f
On 4/11/2022 5:22 PM, Dmitry Baryshkov wrote:
On 12/04/2022 03:21, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-04-11 17:08:49)
Current DP driver implementation, event thread is kept running
after DP display is unbind. This patch fix this problem by disabling
DP irq and stop event thread t
Hi Daniel
On 4/8/2022 9:04 PM, Abhinav Kumar wrote:
On 4/7/2022 4:12 PM, Rob Clark wrote:
On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar
wrote:
Hi Rob and Daniel
On 4/7/2022 3:51 PM, Rob Clark wrote:
On Wed, Apr 6, 2022 at 6:27 PM Jessica Zhang
wrote:
On 3/31/2022 8:20 AM, Daniel
Hi Dmitry
On 4/14/2022 12:43 PM, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-04-14 12:20:31)
On 14/04/2022 19:40, Doug Anderson wrote:
Hi,
On Thu, Apr 14, 2022 at 5:19 AM Sankeerth Billakanti
wrote:
This series adds support for generic eDP panel over aux_bus.
These changes are depe
On 3/16/2022 9:31 AM, Sankeerth Billakanti (QUIC) wrote:
Subject: [RFC PATCH v2 5/5] drm/msm/dp: remove extra wrappers and
public functions
Date: Sat, 12 Feb 2022 01:40:06 +0300
From: Dmitry Baryshkov
To: Bjorn Andersson , Rob Clark
, Sean Paul , Abhinav Kumar
, Kuogee Hsieh
CC: Stephen
On 3/16/2022 9:45 AM, Sankeerth Billakanti (QUIC) wrote:
Subject: Re: [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with
drm_bridge_connector
Date: Wed, 23 Feb 2022 16:40:56 -0800
From: Kuogee Hsieh
To: Stephen Boyd , Dmitry Baryshkov
CC: Abhinav Kumar , Bjorn Andersson
, Rob Clark
On 4/14/2022 1:03 PM, Dmitry Baryshkov wrote:
On 14/04/2022 23:00, Abhinav Kumar wrote:
Hi Dmitry
On 4/14/2022 12:43 PM, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-04-14 12:20:31)
On 14/04/2022 19:40, Doug Anderson wrote:
Hi,
On Thu, Apr 14, 2022 at 5:19 AM Sankeerth Billakanti
501 - 600 of 2222 matches
Mail list logo
