On 5/2/2022 1:45 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2022-05-01 22:39:41)
Add missing break statement for dpu_hw_ctl_update_pending_flush_wb().
Otherwise this leads to below build warning.
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c:273:2:
warning: unannotated fall-through between
0xc996400 is the correct PHY address of DSI1.
0xc996000 which was previously used here is the controller start address
of DSI1.
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_
On 2/9/2022 9:24 AM, Dmitry Baryshkov wrote:
As SSPP blocks are now visible through dpu_kms->rm.sspp_blocks, move
SSPP debugfs creation from dpu_plane to dpu_kms.
Change is fine by itself, but is it really needed?
Wouldnt it be better to keep dpu_debugfs_sspp_init in dpu_plane.c?
update_pending_flush_*** ops which we
have so this is fine.
This change can go in independent of this series. no need to wait.
Apart from a minor comments nit below,
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 25 ++-
drivers/gpu/drm/msm
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
In preparation to adding fully virtualized planes, move struct
dpu_hw_pipe instance from struct dpu_plane to struct dpu_plane_state, as
it will become a part of state (allocated during atomic check) rather
than part of a plane (allocated during
On 5/3/2022 3:11 PM, Dmitry Baryshkov wrote:
On 04/05/2022 00:34, Abhinav Kumar wrote:
On 2/9/2022 9:24 AM, Dmitry Baryshkov wrote:
As SSPP blocks are now visible through dpu_kms->rm.sspp_blocks, move
SSPP debugfs creation from dpu_plane to dpu_kms.
Change is fine by its
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
There is no need to keep a separate function for calling into the ctl if
we already know all the details. Inline this function in the dpu_crtc.c
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
There no more need for the dpu_plane_pipe() function, crtc code can
access pstate->pipe_hw.idx directly.
Signed-off-by: Dmitry Baryshkov
Perhaps this can be squashed with the previous change.
Otherwise,
Reviewed-by: Abhinav Ku
On 5/10/2022 9:52 AM, Rob Clark wrote:
From: Rob Clark
The offset got dropped by accident.
Fixes: d413e6f97134 ("drm/msm: Drop msm_gem_iova()")
Signed-off-by: Rob Clark
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/msm_fb.c | 2 +-
1 file changed, 1 insertion(+),
Hi Doug
On 5/10/2022 1:53 PM, Doug Anderson wrote:
Hi,
On Fri, May 6, 2022 at 9:33 AM Abhinav Kumar wrote:
Hi Jani
On 5/6/2022 4:16 AM, Jani Nikula wrote:
On Thu, 05 May 2022, Doug Anderson wrote:
Ville,
On Tue, Apr 26, 2022 at 1:21 PM Douglas Anderson wrote:
If we're unable to read
Hi Doug
On 5/10/2022 2:41 PM, Doug Anderson wrote:
Hi,
On Tue, May 10, 2022 at 2:33 PM Abhinav Kumar wrote:
Hi Doug
On 5/10/2022 1:53 PM, Doug Anderson wrote:
Hi,
On Fri, May 6, 2022 at 9:33 AM Abhinav Kumar wrote:
Hi Jani
On 5/6/2022 4:16 AM, Jani Nikula wrote:
On Thu, 05 May 2022
and also
allow using writeback functionality for other use-cases as
necessary.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
b/drivers/gpu/drm/msm/disp/dpu1
and it'll likely pick the highest
resolution one by default. That's probably not ideal because the modes
were purely guesses on the part of the Linux kernel.
Let's instead set 640x480 as the "preferred" mode when we have no EDID.
Signed-off-by: Douglas Anderson
Reviewed-by: Abhinav Kumar
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote:
There is no need to pass full dpu_hw_pipe_cfg instance to
_dpu_hw_sspp_setup_scaler3, pass just struct dpu_format pointer.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 9 -
On 5/4/2022 4:30 PM, Dmitry Baryshkov wrote:
On Thu, 5 May 2022 at 02:29, Abhinav Kumar wrote:
On 5/4/2022 3:49 PM, Douglas Anderson wrote:
When rebooting on my sc7280-herobrine based device, I got a
crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
"
On 5/4/2022 3:49 PM, Douglas Anderson wrote:
When rebooting on my sc7280-herobrine based device, I got a
crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
"pdev" was the one associated with mdss_probe().
From source, I found that mdss_probe() has the line:
sing some historical context on why this is not
already done.
But apart from that, LGTM. Hence,
Reviewed-by: Abhinav Kumar
[1]
https://lore.kernel.org/r/20220426132121.RFC.1.I31ec454f8d4ffce51a7708a8092f8a6f9c929092@changeid
-Doug
it was previously passing.
Restore DRM_MODE_ROTATE_180 bit to the supported rotations
list.
Fixes: dabfdd89eaa92 ("add inline rotation support for sc7280")
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
be wrongly set at tps4.
Changes in v2:
-- fix Fixes tag
Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")
Signed-off-by: Kuogee Hsieh
This is a good catch !
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 2 +-
1 file changed, 1 insertion(+),
Please fix the subject line .
It should be drm/msm/dpu: fix repeated words in comments
Also, you can add
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
On 8/23/2022 4:51 AM, Jilin Yuan wrote:
Delete the redundant word 'is'.
Signed-off-by: Jilin Yuan
---
On 8/24/2022 1:25 AM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:59, Abhinav Kumar wrote:
On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar wrote:
On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote:
On 22/08/2022 20:32, Abhinav Kumar wrote
On 8/24/2022 1:29 AM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 04:25, Abhinav Kumar wrote:
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote:
The rest of the code expects that master's device drvdata is the
struct msm_drm_private instance. Do not override the mdp5's drvdata.
Fixes
: 937f941ca06f "drm/msm/dp: Use qmp phy for DP PLL and PHY"
Signed-off-by: Kuogee Hsieh
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c
b/drivers/gpu/drm/msm/dp/dp_catal
On 6/16/2022 12:59 AM, Dmitry Baryshkov wrote:
Use devm_pm_runtime_enable() to enable runtime PM. This way its effect
will be reverted on device unbind/destruction.
Fixes: 6ed9ed484d04 ("drm/msm/hdmi: Set up runtime PM for HDMI")
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abh
On 6/16/2022 12:59 AM, Dmitry Baryshkov wrote:
All MSM HDMI devices use "core_physical" and "qfprom_physical" names for
register areas. Drop them from the platform config.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm
t;drm/msm/dp: skip checking LINK_STATUS_UPDATED bit")
Reported-by: kernel test robot
Signed-off-by: Stephen Boyd
Reviewed-by: Abhinav Kumar
---
Changes from v1
(https://lore.kernel.org/r/20220823024356.783318-1-swb...@chromium.org)
* Roll in extra whitespace fix
drivers/gpu/
directly.
Signed-off-by: Dmitry Baryshkov
With DRM_CONNECTOR_POLL_HPD removed as part of the PANEL_BRIDGE change,
this change makes sense and LGTM, hence
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 14 --
1 file changed, 14 deletions(-)
diff --git
Hi Stephen
On 8/22/2022 7:43 PM, Stephen Boyd wrote:
Build robots complain
smatch warnings:
drivers/gpu/drm/msm/dp/dp_link.c:969 dp_link_process_link_status_update()
warn: inconsistent indenting
Fix it.
Cc: Kuogee Hsieh
Fixes: ea530388e64b ("drm/msm/dp: skip checking
Sorry missed one response,
On 8/23/2022 3:07 PM, Abhinav Kumar wrote:
On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote:
On 22/08/2022 20:32, Abhinav Kumar wrote:
On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote:
On 22/08/2022 19:38, Abhinav Kumar wrote:
Hi Dmitry
On 8/22/2022 9:18 AM, Dmitry
merge base_off with blk_off in struct
dpu_hw_blk_reg_map")
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.
On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote:
On 22/08/2022 20:32, Abhinav Kumar wrote:
On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote:
On 22/08/2022 19:38, Abhinav Kumar wrote:
Hi Dmitry
On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote:
On 17/08/2022 21:01, Kuogee Hsieh wrote:
DRM
On 6/16/2022 12:59 AM, Dmitry Baryshkov wrote:
Rather than having all resource allocation happen in the _bind function
(resulting in possible EPROBE_DEFER returns and component bind/unbind
cycles) allocate and check all resources in _probe function. While we
are at it, use platform_get_irq()
On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar wrote:
On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote:
On 22/08/2022 20:32, Abhinav Kumar wrote:
On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote:
On 22/08/2022 19:38, Abhinav Kumar wrote:
Hi Dmitry
clk_parent_data rather
parent_names to setup a link to the XO clock.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 25 +---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/msm/hdmi
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote:
The rest of the code expects that master's device drvdata is the
struct msm_drm_private instance. Do not override the mdp5's drvdata.
Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components")
Signed-off-by: Dmitry Baryshkov
Is
On 8/26/2022 1:19 AM, Dmitry Baryshkov wrote:
On 24/08/2022 22:16, Abhinav Kumar wrote:
On 8/24/2022 1:25 AM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:59, Abhinav Kumar
wrote:
On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar
wrote
Hi Laurent
On 8/26/2022 4:55 AM, Laurent Pinchart wrote:
Hello,
On Fri, Aug 26, 2022 at 01:17:43PM +0300, Dmitry Baryshkov wrote:
On 22/08/2022 19:31, Dmitry Baryshkov wrote:
On 09/08/2022 22:40, Laurent Pinchart wrote:
On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote:
adv7533
ce RFC:
- Fix commit text and add TODO comment
Fixes: 62b2f026cd8e ("drm/bridge: adv7533: Change number of DSI lanes
dynamically")
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/16
Suggested-by: Dmitry Baryshkov
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/bridge/a
be accommodated into msm_dsi_modeset_init()
by passing an extra parameter but this will also affect non-dpu
targets. Till we add the same logic for non-dpu chipsets, lets
have this as a separate call.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 11 +++--
drivers
/documents/prod_brief_qcom_sd7c.pdf
[2]:
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/prod_brief_qcom_sd7c_gen2.pdf
[3]:
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/prod_brief_qcom_sd8cx_gen2.pdf
Abhinav Kumar (3):
drm/msm/dpu: add max
Filter out DP/eDP modes having an unsupported pixel clock by
replacing the current hard-coded limit with the per chipset advertised
value.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 7 ---
drivers/gpu/drm/msm/dp/dp_display.c | 16
Add maximum external pixel clock for all targets based on
the advertised limits for each of them.
The pixel clock has been calculated from the timings mentioned
in the CEA specification for CEA modes and according to
the VESA CVT standard for the others.
Signed-off-by: Abhinav Kumar
Hi Stephen
On 8/15/2022 10:08 AM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-08-11 08:20:01)
On 8/10/2022 6:00 PM, Abhinav Kumar wrote:
Even then, you do have a valid point. DRM framework should not have
caused the disable path to happen without an enable.
I went through the stack
Hi Dmitry
On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote:
On 17/08/2022 21:01, Kuogee Hsieh wrote:
DRM commit_tails() will disable downstream crtc/encoder/bridge if
both disable crtc is required and crtc->active is set before pushing
a new frame downstream.
There is a rare case that user space
specific reason to replace this?
Signed-off-by: Dmitry Baryshkov
With those two addressed,
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 62 +
1 file changed, 32 insertions(+), 30 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1
art from that, this one LGTM,
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 97 +++-
1 file changed, 45 insertions(+), 52 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
b/drivers/gpu/drm/
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote:
To let the probe function bail early if any of the resources is
unavailable, move resource allocattion from kms_init directly to the
probe callback. While we are at it, replace irq_of_parse_and_map() with
platform_get_irq().
Signed-off-by: Dmitry
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote:
Rather than having all resource allocation happen in the _bind function
(resulting in possible EPROBE_DEFER returns and component bind/unbind
cycles) allocate and check all resources in _probe function. While we
are at it, use platform_get_irq()
and then failing the
bind() with -EPROBE_DEFER.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 40 ++---
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm
On 9/7/2022 10:21 AM, Kuogee Hsieh wrote:
DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an
upstream device disconnect. This patch will enforce this rule by always
cleared DOWNPREAD_CTRL register to 0 before start link training. At rare
case that DP MSA timing parameters
On 9/7/2022 11:54 AM, Abhinav Kumar wrote:
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote:
Rather than having all resource allocation happen in the _bind function
(resulting in possible EPROBE_DEFER returns and component bind/unbind
cycles) allocate and check all resources in _probe function
On 9/7/2022 12:09 PM, Abhinav Kumar wrote:
On 9/7/2022 11:54 AM, Abhinav Kumar wrote:
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote:
Rather than having all resource allocation happen in the _bind function
(resulting in possible EPROBE_DEFER returns and component bind/unbind
cycles
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote:
The of_find_device_by_node() already increments the device's usage
count, so there is no need to increment it again using get_device().
Drop this extra get_device().
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu
msm: use kthread_create_worker instead of
kthread_run")
Signed-off-by: Dmitry Baryshkov
the change itself LGTM,
Reviewed-by: Abhinav Kumar
One minor nit below
---
drivers/gpu/drm/msm/msm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/dr
On 8/22/2022 10:53 AM, Dmitry Baryshkov wrote:
On 15/07/2022 00:54, Abhinav Kumar wrote:
On 7/12/2022 6:22 AM, Dmitry Baryshkov wrote:
Currently the DSI driver has two separate paths: one if the next device
in a chain is a bridge and another one if the panel is connected
directly
Chancellor
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 57a4c0fa614b..7fbf391c024f 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_ho
On 8/26/2022 7:23 AM, Dmitry Baryshkov wrote:
On 24/08/2022 20:20, Abhinav Kumar wrote:
On 8/24/2022 1:29 AM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 04:25, Abhinav Kumar
wrote:
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote:
The rest of the code expects that master's device
Reported-by: Dan Carpenter
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catal
Hi Doug
On 8/17/2022 1:48 PM, Doug Anderson wrote:
Hi,
On Wed, Jul 20, 2022 at 3:42 PM Doug Anderson wrote:
Hi,
On Wed, Jul 20, 2022 at 1:46 PM Rob Clark wrote:
On Fri, Jul 8, 2022 at 8:25 AM Doug Anderson wrote:
Hi,
On Wed, Jul 6, 2022 at 12:14 PM Stephen Boyd wrote:
Set the
On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote:
On 22/08/2022 19:38, Abhinav Kumar wrote:
Hi Dmitry
On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote:
On 17/08/2022 21:01, Kuogee Hsieh wrote:
DRM commit_tails() will disable downstream crtc/encoder/bridge if
both disable crtc is required and crtc
On 9/28/2022 5:24 AM, Johan Hovold wrote:
On Tue, Sep 27, 2022 at 11:42:53AM -0700, Abhinav Kumar wrote:
On 9/27/2022 12:14 AM, Johan Hovold wrote:
On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote:
On 9/13/2022 1:53 AM, Johan Hovold wrote:
Drop the overly defensive modeset
On 9/27/2022 12:14 AM, Johan Hovold wrote:
On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote:
On 9/13/2022 1:53 AM, Johan Hovold wrote:
Drop the overly defensive modeset sanity checks of function parameters
which have already been checked or used by the callers.
Reviewed
On 9/27/2022 12:16 AM, Johan Hovold wrote:
On Mon, Sep 26, 2022 at 11:21:38AM -0700, Abhinav Kumar wrote:
On 9/13/2022 1:53 AM, Johan Hovold wrote:
Drop the overly defensive modeset sanity checks of function parameters
which have already been checked or used by the callers.
Reviewed
On 10/17/2022 6:37 AM, Caleb Connolly wrote:
On 17/10/2022 09:59, Marijn Suijten wrote:
On 2022-10-13 09:02:44, Abhinav Kumar wrote:
On 10/13/2022 2:36 AM, Marijn Suijten wrote:
On 2022-10-12 16:03:06, Abhinav Kumar wrote:
[..]
But I would like to hold back this change till Vinod
Hi Doug
On 10/24/2022 1:28 PM, Doug Anderson wrote:
Hi,
On Fri, Oct 21, 2022 at 2:18 PM Abhinav Kumar wrote:
Hi Doug
On 10/21/2022 1:07 PM, Douglas Anderson wrote:
If we fail to get a valid panel ID in drm_edid_get_panel_id() we'd
like to see the EDID that was read so we have a chance
On 10/28/2022 1:09 PM, Marijn Suijten wrote:
Hi Abhinav,
On 2022-10-28 11:33:21, Abhinav Kumar wrote:
Hi Marijn
On 10/26/2022 11:28 AM, Marijn Suijten wrote:
Various removals of complex yet unnecessary math, fixing all uses of
drm_dsc_config::bits_per_pixel to deal with the fact
Hi Marijn
On 10/26/2022 11:28 AM, Marijn Suijten wrote:
Various removals of complex yet unnecessary math, fixing all uses of
drm_dsc_config::bits_per_pixel to deal with the fact that this field
includes four fractional bits, and finally making sure that
range_bpg_offset contains values 6-bits
On 10/27/2022 10:35 AM, Dmitry Baryshkov wrote:
On 22/09/2022 03:49, Abhinav Kumar wrote:
Re-arrange the dsi_calc_pclk method to two helpers, one to
compute the DSI byte clk and the other to compute the pclk.
This makes the separation of the two clean and also allows
clients to compute
On 10/24/2022 8:26 AM, Dmitry Baryshkov wrote:
The rest of the code expects that master's device drvdata is the
struct msm_drm_private instance. Do not override the mdp5's drvdata.
Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components")
Signed-off-by: Dmitry Baryshkov
---
On 10/27/2022 12:56 PM, Dmitry Baryshkov wrote:
On 27/10/2022 21:30, Abhinav Kumar wrote:
On 10/24/2022 8:26 AM, Dmitry Baryshkov wrote:
The rest of the code expects that master's device drvdata is the
struct msm_drm_private instance. Do not override the mdp5's drvdata.
Fixes
Hi Johan
On 10/20/2022 11:27 PM, Johan Hovold wrote:
On Tue, Sep 20, 2022 at 11:06:30AM +0200, Johan Hovold wrote:
On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote:
The MSM DRM driver is currently broken in multiple ways with respect to
probe deferral. Not only does the driver
Hi Doug
On 10/21/2022 1:07 PM, Douglas Anderson wrote:
If we fail to get a valid panel ID in drm_edid_get_panel_id() we'd
like to see the EDID that was read so we have a chance of
understanding what's wrong. There's already a function for that, so
let's call it in the error case.
NOTE:
nents")
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
Abhinav, Rob, please pick this for -fixes.
This is an updated version of [1]. Fixed the read_mdp_hw_revision()
function. PM runtime isn't available at the moment, as priv->kms is not
set.
Can you split them into two
l access to it should be
forbidden.
+* After that this piece of code can be removed."
+*/
You have left an extra " here. Please drop that. Otherwise, this LGTM
Reviewed-by: Abhinav Kumar
+ if (bridge->ops & DRM_BRIDGE_OP_HPD)
+ return (dp->
/ClangBuiltLinux/linux/issues/1703
Cc: l...@lists.linux.dev
Signed-off-by: Nathan Huckleberry
From what I can see this one has been this way since lvds support was
added. Hence this should have
Fixes: 3e87599b68e7 ("drm/msm/mdp4: add LVDS panel support")
Reviewed-by: Abh
On 9/9/2022 10:16 AM, Kuogee Hsieh wrote:
DRM commit_tails() will disable downstream crtc/encoder/bridge if
both disable crtc is required and crtc->active is set before pushing
a new frame downstream.
There is a rare case that user space display manager issue an extra
screen update
Adding kuogee to this series
Hi Johan
Thanks for posting this.
We will take a look at this, re-validate and give our reviews/tested-bys.
Thanks
Abhinav
On 9/12/2022 8:40 AM, Johan Hovold wrote:
The MSM DRM is currently broken in multiple ways with respect to probe
deferral. Not only does
Hi Fabien
Thanks for the patch.
I believe this issue should get resolved with
https://patchwork.freedesktop.org/patch/490326/ as this avoids the override.
I have acked that change and will pick it up for the next fixes.
Thanks
Abhinav
On 9/9/2022 8:28 AM, Fabien Parent wrote:
The kernel
Hi Dmitry
On 9/8/2022 7:46 AM, Dmitry Baryshkov wrote:
On 30/08/2022 06:33, Abhinav Kumar wrote:
DSI interface used with a bridge chip connected to an external
display is subject to the same pixel clock limits as one
which is natively pluggable like DisplayPort.
Hence filter out DSI modes
Hi Stephen
On 9/7/2022 6:06 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2022-08-29 20:33:08)
diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c
index 39bbabb5daf6..3a06a157d1b1 100644
--- a/drivers/gpu/drm/msm/dsi/dsi.c
+++ b/drivers/gpu/drm/msm/dsi/dsi.c
@@ -265,6
On 9/7/2022 6:12 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2022-08-29 20:33:09)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
b/drivers/gpu/drm/msm/dp/dp_display.c
index bfd0aeff3f0d..8b91d8adf921 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp
On 9/13/2022 1:53 AM, Johan Hovold wrote:
Drop the overly defensive modeset sanity checks of function parameters
which have already been checked or used by the callers.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Johan Hovold
The change LGTM, hence
Reviewed-by: Abhinav Kumar
I think
On 9/13/2022 1:53 AM, Johan Hovold wrote:
Drop the overly defensive modeset sanity checks of function parameters
which have already been checked or used by the callers.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Johan Hovold
The change LGTM, hence
Reviewed-by: Abhinav Kumar
I think
On 9/22/2022 7:21 AM, Liu Shixin wrote:
Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.
No functional change.
Signed-off-by: Liu Shixin
Looks reasonable to me
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +++---
1 file changed
this check otherwise it will break bootup on those devices.
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/15
Reported-by: Rob Clark
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_manager.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers
Re-arrange the dsi_calc_pclk method to two helpers, one to
compute the DSI byte clk and the other to compute the pclk.
This makes the separation of the two clean and also allows
clients to compute and use the dsi byte clk separately.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi
On 10/1/2022 12:08 PM, Marijn Suijten wrote:
Multiplying a value by 2 and adding 1 to it always results in a value
that is uneven, and that 1 gets truncated immediately when performing
integer division by 2 again. There is no "rounding" possible here.
Fixes: b9080324d6ca ("drm/msm/dsi: add
On 10/1/2022 12:08 PM, Marijn Suijten wrote:
slice_per_intf is already computed for intf_width, which holds the same
value as hdisplay.
Fixes: 08802f515c3c ("drm/msm/dsi: Add support for DSC configuration")
Signed-off-by: Marijn Suijten
LGTM,
Reviewed-by: Abhinav Kumar
---
On 9/12/2022 12:25 PM, Dmitry Baryshkov wrote:
On 12/09/2022 22:21, Kuogee Hsieh wrote:
On 9/12/2022 11:39 AM, Dmitry Baryshkov wrote:
On 12/09/2022 19:23, Kuogee Hsieh wrote:
DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an
upstream device disconnect. This patch
On 10/9/2022 7:40 PM, Chen Zhongjin wrote:
'commit 1e5df24b996c ("drm/msm/dpu: drop length from struct
dpu_hw_blk_reg_map")'
'commit 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct
dpu_hw_blk_reg_map")'
These commits had merged hw.blk_off and hw.blk_off to mdp.
So we don't
.
That being said, this patch LGTM
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c
index f2ddcfb
On 10/1/2022 12:08 PM, Marijn Suijten wrote:
msm's dsi_host specifies negative BPG offsets which fill the full 8 bits
of a char thanks to two's complement: this however results in those bits
bleeding into the next parameter when the field is only expected to
contain 6-bit wide values.
As a
On 10/4/2022 2:57 PM, Marijn Suijten wrote:
On 2022-10-04 13:22:25, Abhinav Kumar wrote:
On 10/1/2022 12:08 PM, Marijn Suijten wrote:
msm's dsi_host specifies negative BPG offsets which fill the full 8 bits
of a char thanks to two's complement: this however results in those bits
bleeding
to be correct across multiple bpc's).
Yes, this seems to hard-code it to 8bpc/10bpc. So your code-change is fine.
Reviewed-by: Abhinav Kumar
Fixes: b9080324d6ca ("drm/msm/dsi: add support for dsc data")
Signed-off-by: Marijn Suijten
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
1 fi
On 10/9/2022 11:50 AM, Marijn Suijten wrote:
As per the FIXME this code is entirely duplicate with what is already
provided inside drm_dsc_compute_rc_parameters(), and it is yet unknown
why this comment was put in place instead of resolved from the get-go.
Not only does it save on
On 10/9/2022 11:51 AM, Marijn Suijten wrote:
According to the `/* bpc 8 */` comment below only values for a
bits_per_component of 8 are currently hardcoded in place. This is
further confirmed by downstream sources [1] containing different
constants for other BPC values (and different
bitshift to get at this integer value.
Fixes: b9080324d6ca ("drm/msm/dsi: add support for dsc data")
Signed-off-by: Marijn Suijten
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/d
: b9080324d6ca ("drm/msm/dsi: add support for dsc data")
Signed-off-by: Marijn Suijten
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/
On 10/13/2022 2:36 AM, Marijn Suijten wrote:
On 2022-10-12 16:03:06, Abhinav Kumar wrote:
On 10/9/2022 11:50 AM, Marijn Suijten wrote:
As per the FIXME this code is entirely duplicate with what is already
provided inside drm_dsc_compute_rc_parameters(), and it is yet unknown
why
16 is used to store a multiplication of
bits_per_pixel by 16 which is only ever read to immediately be divided
by 16 again, and is elided in much the same way.
Fixes: b9080324d6ca ("drm/msm/dsi: add support for dsc data")
Signed-off-by: Marijn Suijten
Reviewed-by: Abhinav Kumar
---
dri
801 - 900 of 2136 matches
Mail list logo
