Re: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

2022-03-29 Thread Alex Deucher
e crtc on the 3250c is 3, but on the 3500c is 4. > On the source code, we can see that number of the crtc has been fixed at 4. > Needs to set the num_crtc to 3 for 3250c platform. > > v2: >- remove unnecessary comments and Id > > Signed-off-by: Ryan Lin Reviewed-by:

Re: [PATCH 2/8] drm: Rename dp/ to display/

2022-03-30 Thread Alex Deucher
naming scheme > by putting code for video-output standards into a local display/ > directory. The new directory's name is aligned with that policy. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Alex Deucher
On Fri, Feb 18, 2022 at 7:13 AM Simon Ser wrote: > > On Friday, February 18th, 2022 at 12:54, Hans de Goede > wrote: > > > On 2/18/22 12:39, Simon Ser wrote: > > > On Friday, February 18th, 2022 at 11:38, Hans de Goede > > > wrote: > > > > > >> What I'm reading in the above is that it is being

Re: [PATCH 1/4] drm/amdgpu: Fix compilation under UML

2022-02-18 Thread Alex Deucher
On Fri, Feb 18, 2022 at 11:39 AM Felix Kuehling wrote: > > > Am 2022-02-18 um 02:57 schrieb David Gow: > > From: Randy Dunlap > > > > cpuinfo_x86 and its associated macros are not available under ARCH=um, > > even though CONFIG_X86_64 is defined. > > > > This patch (and discussion) were originall

[pull] amdgpu, amdkfd, radeon drm-next-5.18

2022-02-18 Thread Alex Deucher
dling - GC 10.3.6 updates amdkfd: - SPDX header cleanups - SDMA queue handling fixes - Misc fixes radeon: - iMac backlight fix ---- Alex Deucher (3): drm/amdgpu/sdma5.2: Adjust the name string for firmware drm/amdgpu: make cyan

Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

2022-02-21 Thread Alex Deucher
On Mon, Feb 21, 2022 at 3:29 AM Eric Valette wrote: > > On 20/02/2022 16:48, Dominique Dumont wrote: > > On Monday, 14 February 2022 22:52:27 CET Alex Deucher wrote: > >> Does the system actually suspend? > > > > Not really. The screens looks like it's going

Re: [PATCH] drm/amdgpu: Fix typo in *whether* in comment

2022-02-21 Thread Alex Deucher
Applied. Thanks! On Fri, Feb 18, 2022 at 11:56 PM Paul Menzel wrote: > > Signed-off-by: Paul Menzel > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > b/drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH 01/10] drm/amdgpu: Change amdgpu_ras_block_late_init_default function scope

2022-02-22 Thread Alex Deucher
Applied. Thanks! On Tue, Feb 22, 2022 at 8:17 AM Maíra Canal wrote: > > Turn previously global function into a static function to avoid the > following Clang warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2459:5: warning: no previous prototype > for function 'amdgpu_ras_block_late_init_def

Re: [PATCH 02/10] drm/amdgpu: Remove tmp unused variable

2022-02-22 Thread Alex Deucher
On Tue, Feb 22, 2022 at 8:17 AM Maíra Canal wrote: > > The variable tmp is not used in the dce_v6_0_hpd_fini and > dce_v8_0_hpd_fini functions. Therefor, the variable is removed in order to > avoid the following Clang warnings: > > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:331:6: warning: variable 'tm

Re: [PATCH 03/10] drm/amdgpu: Remove unused get_umc_v8_7_channel_index function

2022-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 22, 2022 at 8:17 AM Maíra Canal wrote: > > Remove get_umc_v8_7_channel_index function, which is not used > in the codebase. > > This was pointed by clang with the following warning: > > drivers/gpu/drm/amd/amdgpu/umc_v8_7.c:50:24: warning: unused function > 'ge

Re: [PATCH 04/10] drm/amd/display: Remove unused temp variable

2022-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote: > > Remove unused temp variable from the dmub_rb_flush_pending function by > using arithmetic to remove the loop. > > The -Wunused-but-set-variable warning was pointed out by Clang with the > following warning: > > drivers

Re: [PATCH 05/10] drm/amd/display: Remove unused dcn316_smu_set_voltage_via_phyclk function

2022-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote: > > Remove dcn316_smu_set_voltage_via_phyclk function, which is not used in the > codebase. > > This was pointed by clang with the following warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_smu.c

Re: [PATCH 06/10] drm/amd/display: Remove vupdate_int_entry definition

2022-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote: > > Remove the vupdate_int_entry definition and utilization to avoid the > following warning by Clang: > > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:410:2: > warning: initializer overrides prio

Re: [PATCH 07/10] drm/amd/display: Remove unused dmub_outbox_irq_info_funcs variable

2022-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote: > > Remove the unused struct irq_source_info_funcs > dmub_outbox_irq_info_funcs from the file, which was declared but never > hooked up. > > This was pointed by clang with the following warning: > > drivers/gpu/drm/amd/amd

Re: [PATCH 08/10] drm/amd/display: Remove unused variable

2022-02-22 Thread Alex Deucher
Applied. Thanks! On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote: > > Remove the variable clamshell_closed from the function > dcn10_align_pixel_clocks. > > This was pointed by clang with the following warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2063:7: > w

Re: [PATCH 09/10] drm/amd/display: Add missing prototypes to dcn201_init

2022-02-22 Thread Alex Deucher
Applied. Thanks! On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote: > > Include the header with the prototype to silence the following clang > warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_init.c:127:6: > warning: no previous prototype for function 'dcn201_hw_sequencer_cons

Re: [PATCH 10/10] drm/amd/display: Turn global functions into static functions

2022-02-22 Thread Alex Deucher
On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal wrote: > > Turn previously global functions into static functions to avoid > -Wmissing-prototype warnings, such as: > > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50:20: > warning: no previous prototype for function 'to_dal_ir

Re: [PATCH] drm/sched: Add device pointer to drm_gpu_scheduler

2022-02-23 Thread Alex Deucher
On Wed, Feb 23, 2022 at 2:42 AM Christian König wrote: > > Well that's bad. This should not be pushed to amd-staging-drm-next at all. > > This patch is touching multiple drivers and therefore needs to go > upstream through drm-misc-next. > > Alex can you drop that one before you send out a pull re

[pull] amdgpu drm-fixes-5.17

2022-02-23 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.17. The following changes since commit cfb92440ee71adcc2105b0890bb01ac3cddb8507: Linux 5.17-rc5 (2022-02-20 13:07:20 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.17-2022-02-23 for you to fe

Re: [PATCH 0/4] Address a few compilation warnings

2022-02-24 Thread Alex Deucher
Applied with some minor modifications to patches 3 and 4 to avoid adding new warnings. Alex On Thu, Feb 24, 2022 at 2:44 PM Harry Wentland wrote: > > Series is > Reviewed-by: Harry Wentland > > Harry > > On 2022-02-24 14:15, Magali Lemes wrote: > > This patchset addresses a few warnings reporte

Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-25 Thread Alex Deucher
On Thu, Feb 24, 2022 at 8:23 PM Bjorn Helgaas wrote: > > On Thu, Feb 24, 2022 at 03:51:12PM -0600, Mario Limonciello wrote: > > The `is_thunderbolt` attribute originally had a well defined list of > > quirks that it existed for, but it has been overloaded with more > > meaning. > > > > Instead use

Re: [PATCH][next] drm/amdgpu: Fix missing assignment to variable r

2022-02-25 Thread Alex Deucher
Already fixed. Thanks for the patch. Alex On Thu, Feb 24, 2022 at 5:43 PM Colin Ian King wrote: > > Currently the call to function amdgpu_benchmark_move should be > assigning the return value to variable r as this is checked in > the next statement, however, this assignment is missing. Fix > th

[pull] amdgpu, amdkfd drm-next-5.18

2022-02-25 Thread Alex Deucher
Alex Deucher (13): drm/amdkfd: make CRAT table missing message informational only drm/amdgpu/benchmark: use dev_info rather than DRM macros for logging drm/amdgpu: plumb error handling though amdgpu_benchmark() drm/amdgpu: print the selected

Re: [PATCH] gpu/amd: vega10_hwmgr: fix inappropriate private variable name

2022-02-25 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 25, 2022 at 8:04 AM Quan, Evan wrote: > > [AMD Official Use Only] > > Thanks! > The patch is reviewed-by: Evan Quan > > > -Original Message- > > From: Meng Tang > > Sent: Friday, February 25, 2022 5:47 PM > > To: airl...@linux.ie; dan...@ffwll.ch > >

Re: [pull] amdgpu, amdkfd drm-next-5.18

2022-02-28 Thread Alex Deucher
On Mon, Feb 28, 2022 at 1:55 AM Dave Airlie wrote: > > On Sat, 26 Feb 2022 at 04:35, Alex Deucher wrote: > > > > Hi Dave, Daniel, > > > > New stuff for 5.18. > > > > The following changes since commit b63c54d978236dd6014cf2ffba96d626e97c915c

Re: [PATCH v2] drm/amdgpu: Fix realloc of ptr

2022-02-28 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Feb 28, 2022 at 5:55 AM Christian König wrote: > > Am 27.02.22 um 16:33 schrieb t...@redhat.com: > > From: Tom Rix > > > > Clang static analysis reports this error > > amdgpu_debugfs.c:1690:9: warning: 1st function call > >argument is an uninitialized value >

Re: [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-02 Thread Alex Deucher
On Wed, Mar 2, 2022 at 10:55 AM Michael Cheng wrote: > > Thanks for the feedback Robin! > > Sorry my choices of word weren't that great, but what I meant is to > understand how ARM flushes a range of dcache for device drivers, and not > an equal to x86 clflush. > > I believe the concern is if the

[pull] amdgpu drm-fixes-5.17

2022-03-02 Thread Alex Deucher
Hi Dave, Daniel, Just one small fix for 5.17. The following changes since commit e7c470a4b543375d50d88a4c5abd4b9e0f5adcea: Merge tag 'exynos-drm-fixes-v5.17-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes (2022-02-28 14:05:44 +1000) are available in t

Re: [PATCH][next] drm/amd/display: Fix Wstringop-overflow warnings in dc_link_dp.c

2022-03-04 Thread Alex Deucher
On Thu, Mar 3, 2022 at 3:37 PM Gustavo A. R. Silva wrote: > > On Thu, Mar 03, 2022 at 12:19:57PM -0600, Gustavo A. R. Silva wrote: > > On Thu, Mar 03, 2022 at 09:43:28AM -0800, Kees Cook wrote: > > > On Thu, Mar 03, 2022 at 11:25:03AM -0600, Gustavo A. R. Silva wrote: > > > > Fix the following Wst

[pull] amdgpu, amdkfd drm-next-5.18

2022-03-04 Thread Alex Deucher
ode2 reset refactor - Aldebaran fixes - Add VCN fwlog feature for VCN debugging - CS code cleanup amdkfd: - SVM fixes - SMI event fixes and cleanups - vmid_pasid mapping fix for gfx10.3 ---- Alex Deucher (4): drm/amdgpu: Use IP v

[pull] amdgpu, amdkfd drm-next-5.18

2022-03-07 Thread Alex Deucher
onger used - Mode2 reset refactor - Aldebaran fixes - Add VCN fwlog feature for VCN debugging - CS code cleanup amdkfd: - SVM fixes - SMI event fixes and cleanups - vmid_pasid mapping fix for gfx10.3 ---- Alex Deucher (4): drm/amdg

Re: [PATCH v3] drm/amd/pm: And destination bounds checking to struct copy

2021-08-27 Thread Alex Deucher
> Cc: Likun Gao > Cc: Jiawei Gu > Cc: Evan Quan > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Lijo Lazar > Acked-by: Alex Deucher > Signed-off-by: Kees Cook > --- > v3: rename amdgpu_memcpy_trailing() to smu_memcp

[pull] amdgpu, amdkfd drm-next-5.15

2021-08-27 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.15. The following changes since commit 90a9266269eb9f71af1f323c33e1dca53527bd22: drm/amdgpu: Cancel delayed work when GFXOFF is disabled (2021-08-20 12:09:44 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/am

Re: [PATCH] drm/radeon: Make use of the helper macro SET_RUNTIME_PM_OPS()

2021-08-30 Thread Alex Deucher
On Sat, Aug 28, 2021 at 4:51 AM Cai Huoqing wrote: > > Use the helper macro SET_RUNTIME_PM_OPS() instead of the verbose > operators ".runtime_suspend/.runtime_resume/.runtime_idle", because > the SET_RUNTIME_PM_OPS() is a nice helper macro that could be brought > in to make code a little clearer,

Re: [PATCH] drm/amdgpu: Make use of the helper macro SET_RUNTIME_PM_OPS()

2021-08-30 Thread Alex Deucher
On Sat, Aug 28, 2021 at 4:41 AM Cai Huoqing wrote: > > Use the helper macro SET_RUNTIME_PM_OPS() instead of the verbose > operators ".runtime_suspend/.runtime_resume/.runtime_idle", because > the SET_RUNTIME_PM_OPS() is a nice helper macro that could be brought > in to make code a little clearer,

Re: [PATCH] drm/amdgpu/swsmu: fix spelling mistake "minimun" -> "minimum"

2021-08-30 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Aug 27, 2021 at 2:59 PM Colin King wrote: > > From: Colin Ian King > > There are three identical spelling mistakes in dev_err messages. > Fix these. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- > drivers/

Re: [PATCH][next] drm/amd/display: Fix unused initialization of pointer sink

2021-08-30 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Aug 29, 2021 at 12:46 PM Colin King wrote: > > From: Colin Ian King > > Pointer sink is being inintialized with a value that is never read, > it is later being re-assigned a new value. Remove the redundant > initialization. > > Addresses-Coverity: ("Unused value")

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

2021-09-01 Thread Alex Deucher
On Wed, Sep 1, 2021 at 6:19 AM Liu, Monk wrote: > > [AMD Official Use Only] > > Daniel > > From the link you share it looks you(or someone else) have quite a bunch > patches that changes DRM_SCHED or even amdgpu, by that case before they are > merged to kernel tree I'm wondering if any AMD devel

Re: [git pull] drm for 5.15-rc1

2021-09-01 Thread Alex Deucher
On Wed, Sep 1, 2021 at 2:33 PM Linus Torvalds wrote: > > On Wed, Sep 1, 2021 at 10:57 AM Linus Torvalds > wrote: > > > > No worries. I enjoyed seeing the AMD code-names in the conflicts, they > > are using positively kernel-level naming. > > Oh, I spoke too soon. > > The conflict in amdgpu_ras_ee

Re: [PATCH 1/2] drm/sched: fix the bug of time out calculation(v4)

2021-09-01 Thread Alex Deucher
On Wed, Sep 1, 2021 at 2:50 AM Christian König wrote: > > Am 01.09.21 um 02:46 schrieb Monk Liu: > > issue: > > in cleanup_job the cancle_delayed_work will cancel a TO timer > > even the its corresponding job is still running. > > > > fix: > > do not cancel the timer in cleanup_job, instead do the

[pull] amdgpu, amdkfd drm-next-5.15

2021-09-01 Thread Alex Deucher
ron Liu (1): drm/amd/display: setup system context for APUs Alex Deucher (1): drm/amdgpu: add some additional RDNA2 PCI IDs Alex Sierra (1): drm/amdkfd: drop process ref count when xnack disable Angus Wang (1): drm/amd/display: cleanup idents after a revert Anson Jacob (1):

Re: [diagnostic TDR mode patches] unify our solution opinions/suggestions in one thread

2021-09-02 Thread Alex Deucher
c. that would affect other drivers. When we send out the patches we cc the relevant maintainers, but ultimately the ones who participate in the discussion set the direction. That's why participation is important. Alex > Thanks > > ---------- > Monk

Re: [PATCH 2/8] drm/ttm: add some general module kerneldoc

2021-09-07 Thread Alex Deucher
On Tue, Sep 7, 2021 at 4:01 AM Christian König wrote: > > For now just a brief description of what TTM is all about. > > Signed-off-by: Christian König > --- > Documentation/gpu/drm-mm.rst | 3 ++- > drivers/gpu/drm/ttm/ttm_module.c | 12 > 2 files changed, 14 insertions(+), 1

Re: [PATCH 3/8] drm/ttm: add kerneldoc for enum ttm_caching

2021-09-07 Thread Alex Deucher
On Tue, Sep 7, 2021 at 4:01 AM Christian König wrote: > > Briefly describe what this is all about. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > Documentation/gpu/drm-mm.rst | 3 +++ > include/drm/ttm/ttm_caching.h | 17 + &

Re: [PATCH 4/8] drm/ttm: enable TTM device object kerneldoc

2021-09-07 Thread Alex Deucher
On Tue, Sep 7, 2021 at 4:01 AM Christian König wrote: > > Fix the remaining warnings, switch to inline structure documentation > and finally enable this. > > Signed-off-by: Christian König > Reviewed-by: Matthew Auld > --- > Documentation/gpu/drm-mm.rst | 9 + > include/drm/ttm/ttm_device.

Re: [PATCH 6/8] drm/ttm: enable TTM placement kerneldoc

2021-09-07 Thread Alex Deucher
On Tue, Sep 7, 2021 at 4:01 AM Christian König wrote: > > Fix the last remaining warning and finally enable this. > > Signed-off-by: Christian König > Reviewed-by: Matthew Auld Reviewed-by: Alex Deucher > --- > Documentation/gpu/drm-mm.rst| 6 ++ > include

Re: [PATCH 5/8] drm/ttm: enable TTM resource object kerneldoc v2

2021-09-07 Thread Alex Deucher
On Tue, Sep 7, 2021 at 4:01 AM Christian König wrote: > > Fix the last two remaining warnings and finally enable this. > > v2: add caching enum link > > Signed-off-by: Christian König > Reviewed-by: Matthew Auld Reviewed-by: Alex Deucher > --- > Documen

Re: [PATCH 7/8] drm/ttm: enable TTM TT object kerneldoc v2

2021-09-07 Thread Alex Deucher
On Tue, Sep 7, 2021 at 4:01 AM Christian König wrote: > > Fix the remaining warnings and finally enable this. > > v2: add caching enum link > > Signed-off-by: Christian König > Reviewed-by: Matthew Auld Reviewed-by: Alex Deucher > --- > Documentation/gpu/drm-mm.rs

Re: [PATCH 8/8] drm/ttm: enable TTM page pool kerneldoc

2021-09-07 Thread Alex Deucher
On Tue, Sep 7, 2021 at 4:01 AM Christian König wrote: > > Fix the remaining warnings and finally enable this. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > Documentation/gpu/drm-mm.rst | 9 + > include/drm/ttm/ttm_pool.h | 5 +++-- &

Re: [PATCH][next] drm/amdgpu: clean up inconsistent indenting

2021-09-07 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Sep 3, 2021 at 2:31 AM Christian König wrote: > > Am 02.09.21 um 23:45 schrieb Colin King: > > From: Colin Ian King > > > > There are a couple of statements that are indented one character > > too deeply, clean these up. > > > > Signed-off-by: Colin Ian King > >

Re: [PATCH][next] drm/amdgpu: sdma: clean up identation

2021-09-07 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Sep 3, 2021 at 2:31 AM Christian König wrote: > > Am 02.09.21 um 23:51 schrieb Colin King: > > From: Colin Ian King > > > > There is a statement that is indented incorrectly. Clean it up. > > > > Signed-off-by: Colin Ian King > > Reviewed-by: Christian König > >

Re: [PATCH] drm/radeon: Prefer kcalloc over open coded arithmetic

2021-09-07 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Sep 4, 2021 at 11:41 AM Len Baker wrote: > > As noted in the "Deprecated Interfaces, Language Features, Attributes, > and Conventions" documentation [1], size calculations (especially > multiplication) should not be performed in memory allocator (or similar) > func

Re: [PATCH] drm/radeon/ci_dpm: Remove redundant initialization of variables hi_sidd, lo_sidd

2021-09-07 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Sep 7, 2021 at 7:09 AM Colin King wrote: > > From: Colin Ian King > > The variables hi_sidd and lo_sidd are being initialized with a values > that are never read, they are being updated later on. The assignments > are redundant and can be removed. > > Addresses-Co

Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0

2021-09-07 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Sep 6, 2021 at 5:23 AM Jiapeng Chong wrote: > > From: chongjiapeng > > Fix the following coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c:643:35-36: > WARNING comparing pointer to 0. > > Reported-by: Abaci Robot > Signed-off-

Re: [PATCH] drm/amd/display: make configure_lttpr_mode_transparent and configure_lttpr_mode_non_transparent static

2021-09-07 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Sep 6, 2021 at 5:42 AM Jiapeng Chong wrote: > > From: chongjiapeng > > This symbols is not used outside of dc_link_dp.c, so marks it static. > > Fix the following sparse warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1766:16: > warning: sy

Re: [RFC][PATCH] drm/amdgpu/powerplay/smu10: Add custom profile

2021-09-07 Thread Alex Deucher
On Tue, Sep 7, 2021 at 4:53 AM Daniel Gomez wrote: > > Add custom power profile mode support on smu10. > Update workload bit list. > --- > > Hi, > > I'm trying to add custom profile for the Raven Ridge but not sure if > I'd need a different parameter than PPSMC_MSG_SetCustomPolicy to > configure t

Re: [PATCH 1/8] drm/ttm: remove the outdated kerneldoc section

2021-09-09 Thread Alex Deucher
On Wed, Sep 8, 2021 at 9:29 AM Christian König wrote: > > Clean up to start over with new and more accurate documentation. > > Signed-off-by: Christian König > Reviewed-by: Matthew Auld Series is: Reviewed-by: Alex Deucher > --- > Documentatio

Re: [RFC][PATCH] drm/amdgpu/powerplay/smu10: Add custom profile

2021-09-13 Thread Alex Deucher
On Wed, Sep 8, 2021 at 3:23 AM Daniel Gomez wrote: > > On Tue, 7 Sept 2021 at 19:23, Alex Deucher wrote: > > > > On Tue, Sep 7, 2021 at 4:53 AM Daniel Gomez wrote: > > > > > > Add custom power profile mode support on smu10. > > > Updat

Re: [PATCH 1/1] drm/amdkfd: Add sysfs bitfields and enums to uAPI

2021-09-13 Thread Alex Deucher
On Fri, Sep 10, 2021 at 3:54 PM Felix Kuehling wrote: > > These bits are de-facto part of the uAPI, so declare them in a uAPI header. > Please include a link to the userspace that uses this in the commit message. Alex > Signed-off-by: Felix Kuehling > --- > MAINTAINERS

Re: [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info

2021-09-13 Thread Alex Deucher
Applied. Thanks. Alex On Mon, Sep 13, 2021 at 4:46 AM Paul Menzel wrote: > > As the user cannot do anything about the unsupported Trusted Memory Zone > (TMZ) feature, do not warn about it, but make it informational, so > demote the log level from warning to info. > > Signed-off-by: Paul Menzel

Re: [PATCH 00/14] drm/hdcp: Pull HDCP auth/exchange/check into

2021-09-13 Thread Alex Deucher
On Mon, Sep 13, 2021 at 1:57 PM Sean Paul wrote: > > From: Sean Paul > > Hello, > This patchset pulls the HDCP protocol auth/exchange/check logic out from > i915 into a HDCP helper library which drivers can use to implement the > proper protocol and UAPI interactions for achieving HDCP. > > Origi

Re: [PATCH 1/2] drm/sched: fix the bug of time out calculation(v4)

2021-09-14 Thread Alex Deucher
Was this fix independent of the other discussions? Should this be applied to drm-misc? Alex On Wed, Sep 1, 2021 at 4:42 PM Alex Deucher wrote: > > On Wed, Sep 1, 2021 at 2:50 AM Christian König > wrote: > > > > Am 01.09.21 um 02:46 schrieb Monk Liu: > > > i

Re: [PATCH] drm/ttm: fix the type mismatch error on sparc64

2021-09-14 Thread Alex Deucher
On Tue, Sep 7, 2021 at 6:25 AM Christian König wrote: > > Am 07.09.21 um 12:03 schrieb Huang Rui: > > __fls() on sparc64 return "int", but here it is expected as "unsigned > > long" (x86). It will cause the build errors because the warning becomes > > fatal while it is using sparc configuration. A

Re: [PATCH] drm/radeon: make array encoded_lanes static

2021-09-15 Thread Alex Deucher
On Wed, Sep 15, 2021 at 7:36 AM Colin King wrote: > > From: Colin Ian King > > Don't populate the read-only array encoded_lanes on the stack but instead it > static. Also makes the object code smaller by 97 bytes: > > Before: >textdatabss dechex filename > 388998064

[pull] amdgpu, amdkfd, radeon drm-fixes-5.15

2021-09-16 Thread Alex Deucher
orientation fixes - Display GPUVM fix for yellow carp - Add missing license amdkfd: - Drop PCI atomics requirement if proper firmware is available - Suspend/resume fixes for IOMMUv2 cases radeon: - AGP fix Alex Deucher (1): drm/amdgpu

[PATCH 1/2] MAINTAINERS: fix up entry for AMD Powerplay

2021-09-17 Thread Alex Deucher
Fix the path to cover both the older powerplay infrastructure and the newer SwSMU infrastructure. Signed-off-by: Alex Deucher --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 851255b71ccc..379092f34fff 100644 --- a

[PATCH 2/2] MAINTAINERS: add Andrey as the DRM GPU scheduler maintainer

2021-09-17 Thread Alex Deucher
Now that the scheduler is being used by more and more drivers, we need someone to maintain it. Andrey has stepped up to maintain the scheduler. Cc: Andrey Grodzovsky Cc: airl...@gmail.com Cc: daniel.vet...@ffwll.ch Signed-off-by: Alex Deucher --- MAINTAINERS | 8 1 file changed, 8

[pull] amdgpu, amdkfd drm-next-5.16

2021-10-08 Thread Alex Deucher
GPU driver ---- Alex Deucher (69): drm/amdgpu: move headless sku check into harvest function drm/amdgpu: add debugfs access to the IP discovery table drm/amdgpu: store HW IP versions in the driver structure drm/amdgpu:

[pull] amdgpu, amdkfd drm-next-5.16

2021-10-14 Thread Alex Deucher
ential out of bounds write in debugfs amdkfd: - SVM fixes ---- Alex Deucher (5): drm/amdgpu/nbio7.4: don't use GPU_HDP_FLUSH bit 12 drm/amdgpu/nbio2.3: don't use GPU_HDP_FLUSH bit 12 drm/amdgpu/smu11: fix firmwa

Re: [PATCH] amdgpu: replace snprintf in show functions with sysfs_emit

2021-10-19 Thread Alex Deucher
Applied. thanks! On Fri, Oct 15, 2021 at 2:48 AM Qing Wang wrote: > > show() must not use snprintf() when formatting the value to be > returned to user space. > > Fix the following coccicheck warning: > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c:427: > WARNING: use scnprintf or sprintf. > > Signe

Re: [PATCH] drm/ttm: fix memleak in ttm_transfered_destroy

2021-10-20 Thread Alex Deucher
On Wed, Oct 20, 2021 at 1:32 PM Christian König wrote: > > We need to cleanup the fences for ghost objects as well. > > Signed-off-by: Christian König > CC: Does this fix this bug? https://bugzilla.kernel.org/show_bug.cgi?id=214029 Alex > --- > drivers/gpu/drm/ttm/ttm_bo_util.c | 1 + > 1 fi

Re: [PATCH 3/4] drm/amd/display: Add DP 2.0 MST DC Support

2021-10-20 Thread Alex Deucher
On Wed, Oct 20, 2021 at 3:50 PM Bhawanpreet Lakha wrote: > > From: Fangzhi Zuo Please include a patch description. Alex > > Signed-off-by: Fangzhi Zuo > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 14 + > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 280 ++ > ..

Re: [PATCH] dma-buf: fix kerneldoc for renamed members

2021-10-21 Thread Alex Deucher
On Thu, Oct 21, 2021 at 10:19 AM Christian König wrote: > > Those members where renamed, update the kerneldoc as well. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > include/linux/dma-buf.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletion

[pull] amdgpu drm-fixes-5.15

2021-10-21 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.15. The following changes since commit 519d81956ee277b4419c723adfb154603c2565ba: Linux 5.15-rc6 (2021-10-17 20:00:13 -1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.15-2021-10-21 for you to fe

[pull] amdgpu, amdkfd drm-next-5.16

2021-10-22 Thread Alex Deucher
rrez (2): Revert "drm/amd/display: Fix error in dmesg at boot" Revert "drm/amd/display: Add helper for blanking all dp displays" Alex Deucher (15): drm/amdgpu/pm: properly handle sclk for profiling modes on vangogh drm/amdgpu/gfx10: fix typo in gfx_v10_0

Re: [PATCH] dma-buf: fix uninitialized variable usage in selftests

2021-10-25 Thread Alex Deucher
On Mon, Oct 25, 2021 at 3:28 AM Christian König wrote: > > "i" can be used uninitialized in one of the error branches. Fix this. > > Signed-off-by: Christian König > Reported-by: kernel test robot Acked-by: Alex Deucher > --- > drivers/dma-buf/st-dma-resv

Re: [PATCH] drm/amd/display: fix empty debug macros

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 8:16 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Using an empty macro expansion as a conditional expression > produces a W=1 warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c: In function > 'dce_aux_transfer_with_retries': > drivers/gpu/drm/amd/a

Re: [PATCH] drm/radeon: fix uninitialized bool variable

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:44 AM Christian König wrote: > > > > Am 18.09.21 um 11:41 schrieb Zhiwei Yang: > > The bool variable detected_hpd_without_ddc in struct radeon_connector > > is uninitialized when first used, that may cause unnecessary ddc ops. > > Make it as false when a new connector is

Re: [PATCH 1/2] Enable buddy memory manager support

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: Please prefix the patch subject with drm. E.g., drm: Enable buddy memory manager support Same for the second patch, but make it drm/amdgpu instead. Alex > > Port Intel buddy system manager to drm root folder > Add CPU mappable/non-mappable reg

Re: [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: > > Replace drm_mm with drm buddy manager for > VRAM memory management Would be good to document why we are doing this and what advantages it brings over the old drm_mm code. Alex > > Signed-off-by: Arunpravin > --- > .../gpu/drm/amd/amdgpu/a

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

2021-09-22 Thread Alex Deucher
+ Harry, Leo Can you guys get someone to clean this up? Alex On Wed, Sep 22, 2021 at 7:10 AM Jani Nikula wrote: > > On Tue, 21 Sep 2021, Nathan Chancellor wrote: > > On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: > >> DP 2.0 brings some new DPCD addresses for PHY repeaters. > >>

Re: [PATCH] drm/amd/display: Fix randomly flicking on overlay with enabled ABM

2021-09-23 Thread Alex Deucher
On Thu, Sep 23, 2021 at 5:03 AM wrote: > > From: "Yipeng Chen (Jasber)" > > [Why] > Enabled ABM (level != 0) would raise short pluse irq DC_IRQ_SOURCE_HPD1RX > randomly with PSR error LINK_CRC_ERROR. Actually there is no hot plugging > on EDP panel. After correcting CRC error, there is no need to

Re: [PATCH 1/1] drm: This patch fixes colour banding caused by wrong information passed by the Lenovo Thinkpad L540 panel.

2021-09-23 Thread Alex Deucher
On Thu, Sep 23, 2021 at 2:15 PM Francesco Paolo Lovergine wrote: > > Hi, The patch title is a little long. How about something like: drm: fix colour banding on Lenovo Thinkpad L540 panel > > there is an issue with Lenovo Thinkpad L540 very similar to those described > here: > https://bugs.lau

[pull] amdgpu, amdkfd drm-fixes-5.15

2021-09-23 Thread Alex Deucher
- SI DPM fix amdkfd: - SVM fixes - DMA mapping fix Alex Deucher (1): MAINTAINERS: fix up entry for AMD Powerplay Arnd Bergmann (1): drm/amd/display: fix empty debug macros Lijo Lazar (1): drm/amd/pm: Update

Re: [PATCH] dma-buf: move dma-buf symbols into the DMA_BUF module namespace

2021-09-27 Thread Alex Deucher
t;> $ modinfo drivers/misc/fastrpc.ko | grep import >> import_ns: DMA_BUF >> >> Cc: Sumit Semwal >> Cc: "Christian König" >> Cc: Alex Deucher >> Cc: "Pan, Xinhui" >> Cc: David Airlie >> Cc: Daniel Vetter >> Cc: Ma

Re: [PATCH] drm/amdgpu: fix warning for overflow check

2021-09-27 Thread Alex Deucher
Applied. Thanks! On Mon, Sep 27, 2021 at 9:07 AM Christian König wrote: > > Am 27.09.21 um 14:58 schrieb Arnd Bergmann: > > From: Arnd Bergmann > > > > The overflow check in amdgpu_bo_list_create() causes a warning with > > clang-14 on 64-bit architectures, since the limit can never be > > exce

Re: [PATCH] drm/amdkfd: fix resource_size.cocci warnings

2021-09-27 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Sep 26, 2021 at 3:10 PM Amos Jianjun Kong wrote: > > On Sun, Sep 26, 2021 at 3:17 PM Yang Li wrote: >> >> Use resource_size function on resource object >> instead of explicit computation. >> >> Clean up coccicheck warning: >> ./drivers/gpu/drm/amd/amdkfd/kfd_migra

Re: [PATCH] gpu: amd: replace open-coded offsetof() with builtin

2021-09-27 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Sep 27, 2021 at 8:21 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The two AMD drivers have their own custom offsetof() implementation > that now triggers a warning with recent versions of clang: > > drivers/gpu/drm/radeon/radeon_atombios.c:133:14: error: pe

[pull] amdgpu, amdkfd, radeon drm-next-5.16

2021-09-27 Thread Alex Deucher
- AGP fix Aaron Liu (1): drm/amd/display: setup system context for APUs Alex Deucher (4): drm/amdgpu: add some additional RDNA2 PCI IDs drm/amdgpu/display: add a proper license to dc_link_dp.c MAINTAINERS: fix up entry for AMD Powerplay

[pull] amdgpu drm-fixes-5.15

2021-09-29 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.15. The following changes since commit 05812b971c6d605c00987750f422918589aa4486: Merge tag 'drm/tegra/for-5.15-rc3' of ssh://git.freedesktop.org/git/tegra/linux into drm-fixes (2021-09-28 17:08:44 +1000) are available in the Git repository at: https://gitlab.

Re: [PATCH] drm/amdgpu: use generic fb helpers instead of setting up AMD own's.

2021-09-30 Thread Alex Deucher
@Christian Koenig Have you had a chance to look at this yet? Alex On Mon, Sep 20, 2021 at 4:44 AM Thomas Zimmermann wrote: > > Hi > > Am 20.09.21 um 10:41 schrieb Thomas Zimmermann: > > (cc'ing dri-devel) > > > > Hi > > > > Am 13.09.21 um 16:36 sc

Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer()

2021-09-30 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor wrote: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_resource.c:1017:10: > error: expression which evaluates to zero treated as a null pointer constant > of type 'struct pipe_ctx *' [-Werror

Re: [PATCH] drm/amd: Initialize remove_mpcc in dcn201_update_mpcc()

2021-09-30 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Sep 30, 2021 at 12:16 PM Nathan Chancellor wrote: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_hwseq.c:505:6: error: > variable 'remove_mpcc' is used uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialize

Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer()

2021-09-30 Thread Alex Deucher
On Thu, Sep 30, 2021 at 1:23 PM Nick Desaulniers wrote: > > On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher wrote: > > > > Applied. Thanks! > > > > Alex > > > > On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor > > wrote: > > > >

Re: [PATCH] drm/amd: Guard IS_OLD_GCC assignment with CONFIG_CC_IS_GCC

2021-09-30 Thread Alex Deucher
On Thu, Sep 30, 2021 at 12:02 PM Nathan Chancellor wrote: > > cc-ifversion only works for GCC, as clang pretends to be GCC 4.2.1 for > glibc compatibility, which means IS_OLD_GCC will get set and unsupported > flags will be passed to clang when building certain code within the DCN > files: > > cla

Re: [PATCH] drm/amdkfd: match the signatures of the real and stub kgd2kfd_probe()

2021-09-30 Thread Alex Deucher
On Thu, Sep 30, 2021 at 4:35 PM wrote: > > From: Tom Rix > > When CONFIG_HSA_AMD=n this there is this error > amdgpu_amdkfd.c:75:56: error: incompatible type for > argument 2 of ‘kgd2kfd_probe’ >75 | adev->kfd.dev = kgd2kfd_probe((struct kgd_dev *)adev, vf); > > amdgpu_amdkfd.h:349:17: not

Re: [PATCH] drm/amdgpu: remove some repeated includings

2021-10-01 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Oct 1, 2021 at 6:16 AM Christian König wrote: > > Am 01.10.21 um 12:13 schrieb Guo Zhengkui: > > Remove two repeated includings in line 46 and 47. > > > > Signed-off-by: Guo Zhengkui > > Acked-by: Christian König > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH v2] drm/fbdev: Clamp fbdev surface size if too large

2021-10-05 Thread Alex Deucher
g > Cc: Daniel Vetter > Cc: Maxime Ripard > Cc: dri-devel@lists.freedesktop.org > Cc: # v5.14+ Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_fb_helper.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers

[pull] amdgpu, amdkfd drm-fixes-5.15

2021-10-06 Thread Alex Deucher
DRM_AMD_DC_SI dependencies - PCIe DPC handling fix - DCN 3.1 scaling fix - Documentation fix amdkfd: - Fix potential memory leak - IOMMUv2 init fixes Alex Deucher (2): Documentation/gpu: remove spurious "+" in

Re: [PATCH] drm/msm: fix compilation when COMMON_CLK is disabled

2021-10-07 Thread Alex Deucher
On Thu, Oct 7, 2021 at 5:13 AM Christian König wrote: > > We can't even compile test without this > > Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > drivers/gpu/drm/msm/Kconfig |

<    3   4   5   6   7   8   9   10   11   12   >