Re: [PATCH 3/4] drm/bridge: Drivers for megachips-stdpxxxx-ge-b850v3-fw (LVDS-DP++)

2017-02-28 Thread Archit Taneja
On 02/27/2017 07:10 PM, Peter Senna Tschudin wrote: On Wed, Feb 01, 2017 at 04:17:21PM +0530, Archit Taneja wrote: Hi Archit, Hi, Some minor comments: Thank you for the review! On 01/28/2017 07:51 PM, Peter Senna Tschudin wrote: The video processing pipeline on the second output

Re: [PATCH] drm/doc: Fix up some kms function names

2017-02-26 Thread Archit Taneja
On 02/27/2017 03:17 AM, Daniel Vetter wrote: On Sun, Feb 26, 2017 at 07:14:07PM +0530, Archit Taneja wrote: On 2/24/2017 7:11 PM, Eric Engestrom wrote: On Wednesday, 2017-02-22 14:17:41 +0530, Archit Taneja wrote: A couple of the kms functions didn't have the correct/newest names

Re: [PATCH 0/5 v3] adv7511 EDID probing improvements

2017-01-11 Thread Archit Taneja
On 01/12/2017 05:36 AM, John Stultz wrote: On Wed, Jan 11, 2017 at 12:48 AM, Archit Taneja <arch...@codeaurora.org> wrote: Hi, On 01/04/2017 01:11 AM, John Stultz wrote: Hope everyone had a good newyears! Wanted to re-send out v3 of this patch set improving the EDID probing on the a

[PATCH v3 4/7] drm/i2c: adv7511: Create a MIPI DSI device

2016-04-22 Thread Archit Taneja
Hi Laurent, On 04/22/2016 03:59 AM, Laurent Pinchart wrote: > Hi Archit, > > Thank you for the patch. > > On Wednesday 09 Mar 2016 16:27:15 Archit Taneja wrote: >> In order to pass DSI specific parameters to the DSI host, we need the >> driver to create a mipi_dsi_devi

[PATCH v3 7/7] dt-bindings: drm/bridge: Update bindings for ADV7533

2016-04-22 Thread Archit Taneja
On 04/22/2016 04:02 AM, Laurent Pinchart wrote: > Hi Archit, > > Thank you for the patch. > > On Wednesday 09 Mar 2016 16:27:18 Archit Taneja wrote: >> Add description of ADV7533. Add the required and optional properties that >> are specific to it. >> >>

[PATCH v3 0/7] drm/i2c: adv7511: ADV7533 support

2016-04-22 Thread Archit Taneja
On 04/22/2016 04:06 AM, Laurent Pinchart wrote: > Hi Archit, > > On Monday 18 Apr 2016 15:18:30 Archit Taneja wrote: >> On 04/17/2016 05:01 PM, Xinliang Liu wrote: >>> On 9 March 2016 at 18:57, Archit Taneja wrote: >>>> ADV7533 is a DSI to

[PATCH v3 0/7] drm/i2c: adv7511: ADV7533 support

2016-04-22 Thread Archit Taneja
On 04/22/2016 04:03 AM, Laurent Pinchart wrote: > Hi Archit, > > On Thursday 14 Apr 2016 20:26:11 Archit Taneja wrote: >> On 3/9/2016 4:27 PM, Archit Taneja wrote: >>> ADV7533 is a DSI to HDMI encoder chip. It's like ADV7511, but with an >>> additional DSI RX b

[PATCH v2 0/3] drm/msm: Remove drm_driver load/unload ops

2016-04-25 Thread Archit Taneja
created drm_connector_register_all and drm_connector_unregister_all helpers instead of writing it ourselves Archit Taneja (3): drm/msm/hdmi: Prevent gpio_free related kernel warnings drm/msm: Centralize connector registration/unregistration drm/msm: Drop load/unload drm_driver ops drivers

[PATCH v2 1/3] drm/msm/hdmi: Prevent gpio_free related kernel warnings

2016-04-25 Thread Archit Taneja
Calling the legacy gpio_free on an invalid GPIO (a GPIO numbered -1) results in kernel warnings. This causes a lot of backtraces when we try to unload the drm/msm module. Call gpio_free only on valid GPIOs. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 19

[PATCH v2 2/3] drm/msm: Centralize connector registration/unregistration

2016-04-25 Thread Archit Taneja
of devm_kzalloc to ensure that that the connectors can be successfully unregistered when the msm driver module is removed. The memory for the connectors is unallocated when drm_mode_config_cleanup() is called during either during an error or during driver remove. Signed-off-by: Archit Taneja --- drivers/gpu

[PATCH v2 3/3] drm/msm: Drop load/unload drm_driver ops

2016-04-25 Thread Archit Taneja
insertions/removals. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/msm_drv.c | 125 -- 1 file changed, 71 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 8c5b257..a6db6e6 100644

[PATCH v2 1/3] drm/msm/hdmi: Prevent gpio_free related kernel warnings

2016-04-27 Thread Archit Taneja
On 04/25/2016 11:18 PM, twp at codeaurora.org wrote: > On 2016-04-25 03:16, Archit Taneja wrote: >> Calling the legacy gpio_free on an invalid GPIO (a GPIO numbered -1) >> results in kernel warnings. This causes a lot of backtraces when >> we try to unload the drm/m

[PATCH 0/3] drm/msm: Remove regulator_set_voltage calls

2016-04-29 Thread Archit Taneja
. The first patch adds some more clean up code to Mark's original patch. Archit Taneja (3): drm/msm/dsi: Fix regulator API abuse drm/msm/edp: Drop regulator_set_voltage call drm/msm/mdp4: Don't manage DSI PLL regulators in MDP driver drivers/gpu/drm/msm/dsi/dsi.h | 2

[PATCH 1/3] drm/msm/dsi: Fix regulator API abuse

2016-04-29 Thread Archit Taneja
any more. Mention in comments the voltages that each regulator expects. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi.h | 2 -- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 34 - drivers/gpu/drm/msm/dsi/dsi_host.c | 12

[PATCH 2/3] drm/msm/edp: Drop regulator_set_voltage call

2016-04-29 Thread Archit Taneja
to change the voltage during runtime. Drop the regulator_set_voltage call. Mention in a comment the voltage that the regulator expects. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/edp/edp_ctrl.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 3/3] drm/msm/mdp4: Don't manage DSI PLL regulators in MDP driver

2016-04-29 Thread Archit Taneja
be specified on the regulator via DT and managed by the regulator core. Remove all the DSI PLL regulator related code from the MDP4 driver. It's managed in the DSI driver for MSM8960/APQ8064 already. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 34

[GIT PULL] drm bridge drivers for 4.8 (updated)

2016-08-09 Thread Archit Taneja
On 8/4/2016 1:36 AM, Laurent Pinchart wrote: > Hi Archit, > > On Tuesday 19 Jul 2016 12:06:41 Archit Taneja wrote: >> Hi Dave, >> >> This is an update to the previous drm bridge pull request. The ADV7511 >> driver's conversion from slave encoder to bridge meant t

[PATCH V5 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2016-08-16 Thread Archit Taneja
Hi, On 08/09/2016 10:11 PM, Peter Senna Tschudin wrote: > Add a driver that create a drm_bridge and a drm_connector for the LVDS > to DP++ display bridge of the GE B850v3. > > There are two physical bridges on the video signal pipeline: a > STDP4028(LVDS to DP) and a STDP2690(DP to DP++). The

[PATCH v2] drm/bridge: analogix_dp: Ensure the panel is properly prepared/unprepared

2016-08-17 Thread Archit Taneja
, > so: > Tested-by: Yakir Yang > > Also add Archit into CC list, guess this patch should go through his > drm_bridge's tree. Reviewed-by: Archit Taneja > > Thanks, > - Yakir > >> --- >> >> Changes in v2: >> - Added panel_is_modeset

[PATCH v5 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-08-17 Thread Archit Taneja
platform driver to implement > the PSR function in hardware side: > - analogix_dp_active_psr() > - analogix_dp_inactive_psr() Could this in any way mess things up if the dev_type is EXYNOS_DP? Otherwise, Reviewed-by: Archit Taneja > > Signed-off-by: Yakir Yang > Reviewed-by:

[PATCH] drm/msm: Fix error handling crashes seen when VRAM allocation fails

2016-11-03 Thread Archit Taneja
>funcs is also non-NULL. This is needed for MDP5, since during msm_drm_int(), priv->kms becomes non-NULL early, but msm_kms_init() is called on it only later in mdp5_kms_init(). Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/msm_drv.c | 2 +- drivers/gpu/drm/msm/msm_gem_sh

[PATCH 3/5] drm/msm/mdp5: add skeletal mdp5_state

2016-11-07 Thread Archit Taneja
drm_modeset_lock_init(_kms->state_lock); > + mdp5_kms->state = kzalloc(sizeof(*mdp5_kms->state), GFP_KERNEL); > + if (!mdp5_kms->state) { > + ret = -ENOMEM; > + goto fail; > + } > + This would probably be better in mdp5_kms_init(

[PATCH 4/5] drm/msm/mdp5: dynamically assign hw pipes to planes

2016-11-07 Thread Archit Taneja
Hi, Minor comments below. LGTM otherwise. On 11/05/2016 09:56 PM, Rob Clark wrote: > (re)assign the hw pipes to planes based on required caps, and to handle > situations where we could not modify an in-use plane (ie. SMP block > reallocation). > > This means all planes advertise the superset of

[PATCH 1/5] drm/msm/mdp5: introduce mdp5_hw_pipe

2016-11-07 Thread Archit Taneja
he N layer-mixers (LM). The first N planes become primary > + * planes for the CRTCs, with the remainder as overlay planes: > + */ Jfyi, we might need to change this a bit in the future. It'll be better to get the max number of displays connected on our platform via parsing DT, et

[PATCH 1/5] drm/msm/mdp5: introduce mdp5_hw_pipe

2016-11-07 Thread Archit Taneja
On 11/7/2016 8:18 PM, Rob Clark wrote: > On Mon, Nov 7, 2016 at 5:38 AM, Archit Taneja > wrote: >> >> >> On 11/05/2016 09:55 PM, Rob Clark wrote: >>> >>> Split out the hardware pipe specifics from mdp5_plane. To start, the hw >>> pip

[v17 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2016-11-11 Thread Archit Taneja
Hi Jitao, I couldn't locate the original mail, so posting on this thread instead. Some comments below. On 11/10/2016 10:09 PM, Enric Balletbo Serra wrote: > Hi Jitao, > > 2016-08-27 8:44 GMT+02:00 Jitao Shi : >> This patch adds drm_bridge driver for parade DSI to eDP bridge chip. >> >>

[PATCH v18 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2016-11-15 Thread Archit Taneja
Hi, On 11/14/2016 07:11 PM, Jitao Shi wrote: > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Thanks for the incorporating the fixes. I have commented on one issue below. The only thing that seems to be left now is the firmware update bits, right? Can we get the firmware

[PATCH] drm/bridge: analogix_dp: return error if transfer none byte

2016-11-16 Thread Archit Taneja
On 11/15/2016 10:39 PM, Sean Paul wrote: > On Thu, Nov 3, 2016 at 3:17 AM, Jianqun Xu wrote: >> Reference from drm_dp_aux description (about transfer): >> Upon success, the implementation should return the number of payload bytes >> that were transferred, or a negative error-code on failure.

[linux-sunxi] Re: [PATCH v3 1/2] drm/bridge: dumb-vga-dac: Support a VDD regulator supply

2016-11-16 Thread Archit Taneja
Hi, On 11/15/2016 08:29 AM, Chen-Yu Tsai wrote: > Hi, > > On Wed, Nov 2, 2016 at 9:33 AM, Chen-Yu Tsai wrote: >> On Mon, Oct 31, 2016 at 2:28 PM, Rob Herring wrote: >>> On Sat, Oct 29, 2016 at 07:06:10PM +0800, Chen-Yu Tsai wrote: Some dumb VGA DACs are active components which require

[PATCH 3/3] MAINTAINERS: Add Archit as drm bridge maintainer

2016-11-17 Thread Archit Taneja
On 11/16/2016 07:38 PM, Daniel Vetter wrote: > Again something that's in the drm-misc fold. Acked-by: Archit Taneja > > Cc: Archit Taneja > Signed-off-by: Daniel Vetter > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/MAINTA

[PATCH] drm/msm: Remove bad calls to of_node_put()

2016-11-17 Thread Archit Taneja
. Remove the extra of_node_put calls. This fixes warnings seen when we try to insert the driver as a module on IFC6410. Reported-by: Ilia Mirkin Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/msm_drv.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v4 1/2] drm/bridge: dumb-vga-dac: Support a VDD regulator supply

2016-11-17 Thread Archit Taneja
Hi, Thanks for the patch. On 11/16/2016 09:12 PM, Chen-Yu Tsai wrote: > Some dumb VGA DACs are active components which require external power. > Add support for specifying a regulator as its power supply. > > Signed-off-by: Chen-Yu Tsai > Acked-by: Rob Herring > --- >

[PATCH] drm: document standard connector properties

2016-11-17 Thread Archit Taneja
On 11/17/2016 01:08 PM, Daniel Vetter wrote: > There's a really big pile of additional connector properties, a lot of > them standardized. But they're all for specific outputs (panels, TV, > scaling, ...) so I left them out for now since this is enough for a > start. > > I typed this to give

[PATCH v4 1/2] drm/bridge: dumb-vga-dac: Support a VDD regulator supply

2016-11-17 Thread Archit Taneja
On 11/17/2016 01:25 PM, Chen-Yu Tsai wrote: > On Thu, Nov 17, 2016 at 3:48 PM, Archit Taneja > wrote: >> Hi, >> >> Thanks for the patch. >> >> >> On 11/16/2016 09:12 PM, Chen-Yu Tsai wrote: >>> >>> Some dumb VGA DACs are act

[PATCH] drm: document standard connector properties

2016-11-17 Thread Archit Taneja
typed this to give Manasi a place to add her new link status > property documentation. Reviewed-by: Archit Taneja > > v2: forgot to git add all the bits (Manasi). > > v3: Be more epxlicit about integrated tiled panels (Archit) > > Cc: Manasi Navare > Cc: Arc

[RFC][PATCH 1/3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally

2016-11-23 Thread Archit Taneja
On 11/23/2016 01:16 AM, John Stultz wrote: > On Tue, Nov 22, 2016 at 9:38 AM, Laurent Pinchart > wrote: >> Hi John, >> >> On Tuesday 22 Nov 2016 09:25:22 John Stultz wrote: >>> On Tue, Nov 22, 2016 at 12:14 AM, Laurent Pinchart wrote: On Monday 21 Nov 2016 16:37:30 John Stultz wrote: >>>

[PATCH v4] drm: bridge: add DesignWare HDMI I2S audio support

2016-11-24 Thread Archit Taneja
Hi, On 11/24/2016 10:43 AM, Kuninori Morimoto wrote: > > Hi Archit, David, and DRM ML > > I had heared that Archit is the maintainer of dw-hdmi driver, but am I wrong > ?? > I'm posting this patch series since half year ago, but no response > from him, and nothing happen (I got review from

[PATCH] drm: bridge: dw-hdmi: add ASoC dependency

2016-11-28 Thread Archit Taneja
On 11/28/2016 06:37 AM, Kuninori Morimoto wrote: > > Hi > >> The newly added sound driver depends on SND_SOC_HDMI_CODEC, which in >> turn only makes sense when ASoC is enabled, as shown by this warning: >> >> warning: (DRM_MSM && DRM_STI && DRM_MEDIATEK_HDMI && DRM_I2C_NXP_TDA998X && >>

[PATCH v3 0/2] drm/bridge: adv7511: Enable regulators

2016-11-29 Thread Archit Taneja
supply for ADV7511 too in the binding docs. - Update the driver to manage regulators for both ADV7511 and ADV7533. - Have separate supply entries for AVDD, DVDD, PVDD, A2VDD pins. - Use regulator_bulk_* API to configure regulators. Archit Taneja (2): dt-bindings: drm/bridge: adv7511: Add regulator

[PATCH v3 2/2] drm/bridge: adv7511: Initialize regulators

2016-11-29 Thread Archit Taneja
Maintain a table of regulator names expect by ADV7511 and ADV7533. Use regulator_bulk_* api to configure these. Initialize and enable the regulators during probe itself. Controlling these dynamically is left for later. Signed-off-by: Archit Taneja --- v3: - Drop the additional 1.8V supply names

[PATCH v3 1/2] dt-bindings: drm/bridge: adv7511: Add regulator bindings

2016-11-29 Thread Archit Taneja
-by: Rob Herring Signed-off-by: Archit Taneja --- v3: - Revert back to having a common avdd-supply property for the 1.8V supplies Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v3 1/2] dt-bindings: drm/bridge: adv7511: Add regulator bindings

2016-11-29 Thread Archit Taneja
On 11/29/2016 12:03 PM, Laurent Pinchart wrote: > Hi Archit, > > Thank you for the patch. > > On Tuesday 29 Nov 2016 11:37:41 Archit Taneja wrote: >> Add the regulator supply properties needed by ADV7511 and ADV7533. >> >> The regulators are specified as op

[PATCH v3 03/13] drm: bridge: Link encoder and bridge in core code

2016-11-29 Thread Archit Taneja
On 11/29/2016 02:34 PM, Laurent Pinchart wrote: > Instead of linking encoders and bridges in every driver (and getting it > wrong half of the time, as many drivers forget to set the drm_bridge > encoder pointer), do so in core code. The drm_bridge_attach() function > needs the encoder and

[PATCH v3 04/13] drm: bridge: Detach bridge from encoder at encoder cleanup time

2016-11-29 Thread Archit Taneja
On 11/29/2016 02:34 PM, Laurent Pinchart wrote: > Most drivers that use bridges forgot to detach them at cleanup time. > Instead of fixing them one by one, detach the bridge in the core > drm_encoder_cleanup() function. > > Signed-off-by: Laurent Pinchart

[RFC][PATCH 5/5 v2] drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID

2016-11-30 Thread Archit Taneja
etting lost. Using the logic > in __adv7511_power_on/off() which syncs and dirtys the cache > avoids this issue. > > Thus this patch changes the EDID probing logic so that we > re-use the __adv7511_power_on/off() calls. > > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolf

[PATCH v3 03/13] drm: bridge: Link encoder and bridge in core code

2016-11-30 Thread Archit Taneja
On 11/29/2016 11:27 PM, Laurent Pinchart wrote: > Hi Archit, > > On Tuesday 29 Nov 2016 15:57:06 Archit Taneja wrote: >> On 11/29/2016 02:34 PM, Laurent Pinchart wrote: >>> Instead of linking encoders and bridges in every driver (and getting it >>> wrong half of

[PATCH v3 03/13] drm: bridge: Link encoder and bridge in core code

2016-11-30 Thread Archit Taneja
On 11/30/2016 03:53 PM, Laurent Pinchart wrote: > Hi Archit, > > On Wednesday 30 Nov 2016 10:35:02 Archit Taneja wrote: >> On 11/29/2016 11:27 PM, Laurent Pinchart wrote: >>> On Tuesday 29 Nov 2016 15:57:06 Archit Taneja wrote: >>>> On 11/29/2016 02:34 PM, L

[PATCH] drm/dsi: Add uevent callback

2016-06-08 Thread Archit Taneja
On 06/03/2016 08:58 PM, Thierry Reding wrote: > From: Thierry Reding > > Implement a uevent callback for devices on the MIPI DSI bus. This > callback will append MODALIAS information to the uevent and allow > modules to be loaded when devices are added to the bus. Reviewed-by

[PATCH v5 0/7] drm/i2c: adv7511: ADV7533 support

2016-06-08 Thread Archit Taneja
://lists.freedesktop.org/archives/dri-devel/2015-July/087088.html Archit Taneja (7): drm/i2c: adv7511: Convert to drm_bridge drm/i2c: adv7511: Fix mutex deadlock when interrupts are disabled drm/i2c: adv7511: Initial support for ADV7533 drm/i2c: adv7533: Create a MIPI DSI device drm/i2c

[PATCH v5 1/7] drm/i2c: adv7511: Convert to drm_bridge

2016-06-08 Thread Archit Taneja
when CONFIG_OF is enabled. The driver anyway only works only when OF is available. Make the driver depend on OF in its Kconfig. Signed-off-by: Archit Taneja --- Changes in v5: - Make the driver depend on CONFIG_OF - Remove best_encoder connector helper drivers/gpu/drm/i2c/Kconfig | 1

[PATCH v5 2/7] drm/i2c: adv7511: Fix mutex deadlock when interrupts are disabled

2016-06-08 Thread Archit Taneja
again) In adv7511_irq_process, don't call drm_helper_hpd_irq_event when not called from the interrupt handler. It doesn't serve any purpose there anyway. Signed-off-by: Archit Taneja --- drivers/gpu/drm/i2c/adv7511.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/d

[PATCH v5 3/7] drm/i2c: adv7511: Initial support for ADV7533

2016-06-08 Thread Archit Taneja
that enables ADV7533 support. Use DT compatible strings to populate the ADV7533 type enum. Add minimal register configurations belonging to the DSI/CEC register map. Keep the ADV7533 code in a separate file. Originally worked on by Lars-Peter Clausen Signed-off-by: Archit Taneja --- drivers/gpu/drm/i2c

[PATCH v5 7/7] dt-bindings: drm/bridge: Update bindings for ADV7533

2016-06-08 Thread Archit Taneja
Add description of ADV7533. Add the required and optional properties that are specific to it. Cc: devicetree at vger.kernel.org Acked-by: Rob Herring Signed-off-by: Archit Taneja --- .../bindings/display/bridge/adi,adv7511.txt| 26 +- 1 file changed, 21 insertions

[PATCH v5 4/7] drm/i2c: adv7533: Create a MIPI DSI device

2016-06-08 Thread Archit Taneja
parameters (number of data lanes for now) that are required for DSI RX to work correctly. Hardcode few other parameters (rgb, embedded_sync) for now. Select DRM_MIPI_DSI config option only when ADV7533 support is enabled. Signed-off-by: Archit Taneja --- drivers/gpu/drm/i2c/Kconfig | 1 + drivers

[PATCH v5 5/7] drm/i2c: adv7533: Use internal timing generator

2016-06-08 Thread Archit Taneja
-by: Archit Taneja --- drivers/gpu/drm/i2c/adv7511.c | 2 ++ drivers/gpu/drm/i2c/adv7511.h | 3 +++ drivers/gpu/drm/i2c/adv7533.c | 60 +-- 3 files changed, 63 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c

[PATCH v5 6/7] drm/i2c: adv7533: Change number of DSI lanes dynamically

2016-06-08 Thread Archit Taneja
Lower modes on ADV7533 require lower number of DSI lanes for correct operation. If ADV7533 is being used with 4 DSI lanes, then switch the lanes to 3 when the target mode's pixel clock is less than 80 Mhz. Based on patch by Andy Green Signed-off-by: Archit Taneja --- drivers/gpu/drm/i2c

[PATCH v2 08/20] drm: msm: Rely on the default ->best_encoder() behavior where appropriate

2016-06-08 Thread Archit Taneja
ncoder() for us. Works fine with msm. Tested-by: Archit Taneja Thanks, Archit > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/msm/edp/edp_connector.c| 10 -- > drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 8 &g

[PATCH v7 1/2] drm/bridge: Add sii902x driver

2016-06-09 Thread Archit Taneja
Hi Boris, On 6/8/2016 6:00 PM, Boris Brezillon wrote: > Add basic support for the sii902x RGB -> HDMI bridge. > This driver does not support audio output yet. > > Signed-off-by: Boris Brezillon > Tested-by: Nicolas Ferre > --- > Hi Archit, > > I recently learned you were the drm/bridge

[PATCH v2 00/10] drm/msm: Fix issues with DT bindings

2016-06-10 Thread Archit Taneja
in the common PHY binding names for the examples. - Add some DT related fixes for MDP4/5 clocks. Original revision: https://lists.freedesktop.org/archives/dri-devel/2016-May/106653.html Archit Taneja (10): drm/msm/mdp5: Don't get source of MDP core clock drm/msm/mdp4: Clean up some MDP4 clocks dt

[PATCH v2 01/10] drm/msm/mdp5: Don't get source of MDP core clock

2016-06-10 Thread Archit Taneja
The driver expects DT to provide the parent to MDP core clock. The only operation done to the parent clock is to set a rate. This can be achieved by setting the rate on the core clock itsef. Don't try to get the parent clock anymore. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5

[PATCH v2 02/10] drm/msm/mdp4: Clean up some MDP4 clocks

2016-06-10 Thread Archit Taneja
as the TV_SRC as its parent. Setting rate/enabling the "mdp_clk" will eventually configure "src_clk", which is what we want. - Rename "mdp_clk" to "tv_clk" because that's slightly less confusing. - Rename "mdp_axi_clk" to "bus_clk" becaus

[PATCH v2 03/10] dt-bindings: msm/mdp: Fix up clock related bindings

2016-06-10 Thread Archit Taneja
MDP5: - Don't ask for source clock MDP4: - Give a better name for MDP_TV_CLK - Remove TV_SRC - Add MDP_AXI_CLK Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/mdp.txt | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/Documentation

[PATCH v2 05/10] drm/msm/dsi: Use generic PHY bindings

2016-06-10 Thread Archit Taneja
The DSI host links to the DSI PHY device using a custom binding. Switch to the generic PHY bindings. The DSI PHY driver itself doesn't use the common PHY framework for now. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 07/10] dt-bindings: msm/dsi: Use standard data lanes binding

2016-06-10 Thread Archit Taneja
;data-lanes" binding uses logical to physical data lane mappings. Update the docs to reflect this change. The example had the property incorrectly named as "lanes", update this too. The MSM DSI DT bindings aren't used anywhere at the moment, so it's okay to update this

[PATCH v2 09/10] dt-bindings: msm/dsi: Add assigned clocks bindings

2016-06-10 Thread Archit Taneja
to set up the MMCC RCGs that feed to the DSI host. Use the DSI PHY provided clocks to set up the parents of these assigned clocks. Acked-by: Rob Herring Signed-off-by: Archit Taneja --- Documentation/devicetree/bindings/display/msm/dsi.txt | 16 +++- 1 file changed, 15 insertions

[PATCH v2 10/10] dt-bindings: msm/dsi: Some binding doc cleanups

2016-06-10 Thread Archit Taneja
Some cleanups: - Use simpler names for DT nodes in the example - Use references instead of dumping Document links everywhere Signed-off-by: Archit Taneja --- .../devicetree/bindings/display/msm/dsi.txt| 45 +++--- 1 file changed, 22 insertions(+), 23 deletions(-) diff

[PATCH v2 04/10] drm/msm/dsi: Modify port parsing

2016-06-10 Thread Archit Taneja
: - - --- | MDP | --> | DSI | --> | Panel | - - --- (Port 0) (Port 1) Until now, there was only one Port representing the output. Update the DSI host driver such that it parses Port #1 for a connected device. Signed-off-by: Archit

[PATCH v2 06/10] drm/msm/dsi: Use a standard DT binding for data lanes

2016-06-10 Thread Archit Taneja
o physical mapping instead of the other way round. Tweak the code to translate the data the way we want it. The MSM DSI DT bindings aren't used anywhere at the moment, so it's okay to update this property. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_host.c | 17 ++--- 1 fi

[PATCH v2 08/10] dt-bindings: msm/dsi: Modify port and PHY bindings

2016-06-10 Thread Archit Taneja
-by: Archit Taneja --- v2: - Use hyphen for dsi phy name .../devicetree/bindings/display/msm/dsi.txt| 45 -- 1 file changed, 34 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display

[PATCH v8 1/2] drm/bridge: Add sii902x driver

2016-06-15 Thread Archit Taneja
On 06/14/2016 01:12 PM, Boris Brezillon wrote: > Add basic support for the sii902x RGB -> HDMI bridge. > This driver does not support audio output yet. > Thanks for incorporating the comments. Acked-by: Archit Taneja > Signed-off-by: Boris Brezillon > Tested

[PATCH v2 03/10] dt-bindings: msm/mdp: Fix up clock related bindings

2016-06-16 Thread Archit Taneja
On 06/14/2016 12:33 AM, Rob Herring wrote: > On Fri, Jun 10, 2016 at 04:16:33PM +0530, Archit Taneja wrote: >> MDP5: >> - Don't ask for source clock >> >> MDP4: >> - Give a better name for MDP_TV_CLK >> - Remove TV_SRC >> - Add MDP_AXI_CLK > > T

[PATCH 00/22] drm/msm: Enable DT support

2016-06-16 Thread Archit Taneja
it running with these changes. This series depends on two patchsets posted before: drm/msm DT prep work: http://www.spinics.net/lists/dri-devel/msg110197.html ADV7533 support+DT bindings: http://www.spinics.net/lists/linux-arm-msm/msg21085.html Archit Taneja (22): drm/msm: Drop the id_table

[PATCH 01/22] drm/msm: Drop the id_table in platform_driver

2016-06-16 Thread Archit Taneja
This isn't needed as we only support OF. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 9788989..aada291 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b

[PATCH 02/22] drm/msm: Remove unused fields

2016-06-16 Thread Archit Taneja
These aren't used. Probably left overs when driver was refactored to support both MDP4 and MDP5. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/msm_kms.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h index e3c

[PATCH 03/22] drm/msm: Get irq number within kms driver itself

2016-06-16 Thread Archit Taneja
hierarchy it uses. While we're at it, call drm_irq_install only when we have a valid KMS driver. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 11 ++- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 11 ++- drivers/gpu/drm/msm/msm_drv.c | 14

[PATCH 05/22] drm/msm/mdp5: Create a separate MDP5 device

2016-06-16 Thread Archit Taneja
give out identical version info. The older mdp5_kms_init code is left as is for now, this would be removed later when we have all the pieces to support the new device hierarchy. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 185

[PATCH 09/22] drm/msm/mdp5: Use updated MDP5 register names

2016-06-16 Thread Archit Taneja
event breaking build. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5.xml.h | 203 +++- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c | 14 +- drivers/gpu/drm/msm/mdp/mdp5/mdp5_ctl.c | 26 +-- drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c

[PATCH 04/22] drm/msm/mdp5: Add MDSS top level driver

2016-06-16 Thread Archit Taneja
is that the resources allocated by this helper are tied to the top level platform_device (the one that allocates the drm_device struct too). This device would be the parent to MDSS sub-blocks like MDP5, DSI, eDP etc. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm

[PATCH 06/22] drm/msm/mdp5: Prepare new kms_init funcs

2016-06-16 Thread Archit Taneja
corresponding to the new MDP5 platform_device. The new change here is that the irq is now retrieved using irq_of_parse_and_map(), since MDP5 is a child interrupt of the MDSS interrupt controller. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 115

[PATCH 07/22] drm/msm/mdp5: Use the new hierarchy and drop old irq management

2016-06-16 Thread Archit Taneja
instead of the one tied to the drm_device/MDSS. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c | 105 +--- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 17 ++ drivers/gpu/drm/msm/msm_drv.c | 15 - 3 files changed, 18 insertions

[PATCH 08/22] drm/msm/mdp5: Remove old kms init/destroy funcs

2016-06-16 Thread Archit Taneja
With the new kms_init/destroy funcs in place for MDP5, we can get rid of the old kms funcs. Some members of the mdp5_kms struct also become redundant, so we remove those too. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 228 +--- drivers

[PATCH 10/22] drm/msm/mdp5: Update the register offsets of MDP5 sub-blocks

2016-06-16 Thread Archit Taneja
-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c | 113 +++- 1 file changed, 54 insertions(+), 59 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_cfg.c index 57f73f0..ac9e4cd 100644 --- a/drivers/gpu/drm/msm

[PATCH 11/22] drm/msm: Call pm_runtime_enable/disable for newly created devices

2016-06-16 Thread Archit Taneja
become a bit tricky when we call these runtime PM funcs. There doesn't seem to be any helper that checks if runtime PM is enabled already. Add bool variables in mdp4_kms/mdp5_kms structs to check if the driver had managed to call pm_runtime_enable before bailing out. Signed-off-by: Archit Taneja

[PATCH 12/22] drm/msm/mdp5: Add missing mdp5_enable/disable calls

2016-06-16 Thread Archit Taneja
Since runtime PM isn't implemented yet, we need to call mdp5_enable/disable in a few more places. These would later be replaced by runtime PM get/put calls. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c | 2 ++ drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 2 ++ 2 files

[PATCH 13/22] drm/msm: Create separate funcs for adding display/gpu components

2016-06-16 Thread Archit Taneja
Simplifies some of the code that we'll add later. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/msm_drv.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index bc2c371..e623dc5

[PATCH 17/22] drm/msm/mdp5: Update compatible strings for MDSS/MDP5

2016-06-16 Thread Archit Taneja
ese strings are used to match the MDP5 platform device. Use "qcom,mdss" as the compatible string for top level MDSS device. This is now used to match the top level platform_device (which is tied to the drm_device struct). Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_

[PATCH 18/22] dt-bindings: msm/mdp4: Create a separate binding doc for MDP4

2016-06-16 Thread Archit Taneja
MDP4 and MDP5 vary a bit in terms of device hierarchy and the properties they require. Rename the binding doc to mdp4.txt and remove MDP5 specific pieces. A separate document will be created for MDP5 Cc: Rob Herring Cc: devicetree at vger.kernel.org Signed-off-by: Archit Taneja

[PATCH 19/22] dt-bindings: msm/mdp5: Add MDP5 display bindings

2016-06-16 Thread Archit Taneja
-by: Archit Taneja --- .../devicetree/bindings/display/msm/mdp5.txt | 114 + 1 file changed, 114 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/msm/mdp5.txt diff --git a/Documentation/devicetree/bindings/display/msm/mdp5.txt b/Documentation

[PATCH 20/22] dt-bindings: msm/mdp: Provide details on MDP interface ports

2016-06-16 Thread Archit Taneja
. The GPU phandle is removed too until we figure out what's the right way to specify it in DT. Cc: Rob Herring Cc: devicetree at vger.kernel.org Signed-off-by: Archit Taneja --- .../devicetree/bindings/display/msm/mdp4.txt | 68 -- .../devicetree/bindings/display/msm/mdp5

[PATCH 22/22] arm64: dts: apq8016-sbc: Add HDMI display support

2016-06-16 Thread Archit Taneja
to the ADV7533's input port. Cc: Andy Gross Cc: Rob Herring Cc: devicetree at vger.kernel.org Signed-off-by: Archit Taneja --- arch/arm64/boot/dts/qcom/apq8016-sbc-soc-pins.dtsi | 48 + arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 82 ++ 2 files changed, 130

[PATCH 14/22] drm/msm: Add display components by parsing MDP ports

2016-06-16 Thread Archit Taneja
. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/msm_drv.c | 56 ++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index e623dc5..eb7a8a1 100644 --- a/drivers/gpu/drm/msm

[PATCH 15/22] drm/msm: Add components for MDP5

2016-06-16 Thread Archit Taneja
, and then parse its ports to get the display interfaces. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/msm_drv.c | 61 +-- 1 file changed, 59 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index

[PATCH 16/22] drm/msm: Drop the gpu binding

2016-06-16 Thread Archit Taneja
the kms and gpu drivers, we'll drop this method and use the correct binding. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/msm_drv.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu

[PATCH 21/22] arm64: dts: msm8916: Add display support

2016-06-16 Thread Archit Taneja
Signed-off-by: Archit Taneja --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 120 ++ 1 file changed, 120 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 9681200..d8cccfc 100644 --- a/arch/arm64/boot/dts

[PATCH v6 0/8] drm/i2c: adv7511: ADV7533 support

2016-06-17 Thread Archit Taneja
for ADV7533. The original plan was to stub out the drm_mipi_dsi funcs, but that seemed like an overkill since it helped just this driver. It seems better to stub out the ADV7533 functionality altogether instead. - Some minor DT binding corrections suggested by Laurent. Archit Taneja (8

[PATCH v6 4/8] drm/bridge: adv7533: Initial support for ADV7533

2016-06-17 Thread Archit Taneja
that enables ADV7533 support. Use DT compatible strings to populate the ADV7533 type enum. Add minimal register configurations belonging to the DSI/CEC register map. Keep the ADV7533 code in a separate file. Originally worked on by Lars-Peter Clausen Signed-off-by: Archit Taneja --- drivers/gpu/drm

[PATCH v6 2/8] drm/i2c: adv7511: Move to bridge folder

2016-06-17 Thread Archit Taneja
in handy later when the driver module will need to be built from multiple object files. Signed-off-by: Archit Taneja --- v6: - New patch drivers/gpu/drm/bridge/Kconfig |2 + drivers/gpu/drm/bridge/Makefile |1 + drivers/gpu/drm/bridge/adv7511/Kconfig |7

[PATCH v6 5/8] drm/bridge: adv7533: Create a MIPI DSI device

2016-06-17 Thread Archit Taneja
parameters (number of data lanes for now) that are required for DSI RX to work correctly. Hardcode few other parameters (rgb, embedded_sync) for now. Select DRM_MIPI_DSI config option only when ADV7533 support is enabled. Signed-off-by: Archit Taneja --- drivers/gpu/drm/bridge/adv7511/Kconfig

[PATCH v6 6/8] drm/bridge: adv7533: Use internal timing generator

2016-06-17 Thread Archit Taneja
-by: Archit Taneja --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 3 ++ drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 + drivers/gpu/drm/bridge/adv7511/adv7533.c | 60 +++- 3 files changed, 63 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge

[PATCH v6 1/8] drm/i2c: adv7511: Convert to drm_bridge

2016-06-17 Thread Archit Taneja
when CONFIG_OF is enabled. The driver anyway only works only when OF is available. Make the driver depend on OF in its Kconfig. Signed-off-by: Archit Taneja --- drivers/gpu/drm/i2c/Kconfig | 1 + drivers/gpu/drm/i2c/adv7511.c | 213 +++--- 2 files changed

<    1   2   3   4   5   6   7   8   9   10   >