Re: [PATCH] fbcon: Don't reset logo_shown when logo is currently shown

2019-05-06 Thread Bartlomiej Zolnierkiewicz
504d647 ("fbcon: Silence fbcon logo on 'quiet' boots") > Signed-off-by: Andreas Schwab Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing

Re: [PATCH 13/57] docs: fb: convert documentation to ReST format

2019-05-06 Thread Bartlomiej Zolnierkiewicz
On 04/16/2019 04:55 AM, Mauro Carvalho Chehab wrote: > Convert all documents here from plain txt to ReST format, in > order to allow parsing them with the documentation build > system. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Bartlomiej Zolnierkiewicz Best regards

Re: [PATCH v3 14/26] compat_ioctl: move ATYFB_CLK handling to atyfb driver

2019-05-06 Thread Bartlomiej Zolnierkiewicz
On 04/16/2019 10:25 PM, Arnd Bergmann wrote: > These are two obscure ioctl commands, in a driver that only > has compatible commands, so just let the driver handle this > itself. > > Signed-off-by: Arnd Bergmann Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej

Re: [PATCH v2 13/79] docs: fb: convert docs to ReST and rename to *.rst

2019-05-06 Thread Bartlomiej Zolnierkiewicz
its new index.rst, let's add a :orphan: while this is not linked to > the main index.rst file, in order to avoid build warnings. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&

Re: [PATCH v2 45/79] docs: console.txt: convert docs to ReST and rename to *.rst

2019-05-06 Thread Bartlomiej Zolnierkiewicz
Mauro Carvalho Chehab Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH next 25/25] video: fbdev: Use dev_get_drvdata()

2019-05-06 Thread Bartlomiej Zolnierkiewicz
On 04/23/2019 09:50 AM, Kefeng Wang wrote: > Using dev_get_drvdata directly. > > Cc: Wan ZongShun > Cc: Kukjin Kim > Cc: Bartlomiej Zolnierkiewicz > Cc: Krzysztof Kozlowski > Cc: Michal Januszewski > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger

[GIT PULL] fbdev changes for v5.2

2019-05-10 Thread Bartlomiej Zolnierkiewicz
details. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics The following changes since commit 79a3aaa7b82e3106be97842dedfd8429248896e6: Linux 5.1-rc3 (2019-03-31 14:39:29 -0700) are available in the git repository at: https://github.com/bzol

[PATCH v2] video: fbdev: imxfb: add COMPILE_TEST support

2019-05-21 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to imxfb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: add missing HAVE_CLK && HAS IOMEM dependencies (noted by Uwe) drivers/video/fbdev/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b

[PATCH v2] video: fbdev: pxa168fb: add COMPILE_TEST support

2019-05-21 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to pxa168fb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: add missing HAVE_CLK && HAS IOMEM dependencies drivers/video/fbdev/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/vid

[PATCH v2] video: fbdev: atmel_lcdfb: add COMPILE_TEST support

2019-05-21 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to atmel_lcdfb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: add missing HAVE_CLK && HAS IOMEM dependencies drivers/video/fbdev/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drive

[PATCH v2] video: fbdev: da8xx-fb: add COMPILE_TEST support

2019-05-21 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to da8xx-fb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: add missing HAVE_CLK && HAS IOMEM dependencies drivers/video/fbdev/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/vid

[PATCH v2] video: fbdev: gbefb: add COMPILE_TEST support

2019-05-21 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to gbefb driver for better compile testing coverage. While at it convert bogus udelay() calls to mdelay() (needed to build driver on ARM) and remove dead x86 specific code. Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: - add missing HAS_IOMEM dependency - fix build

[PATCH] video: fbdev: cyber2000fb: remove superfluous CONFIG_PCI ifdef

2019-05-21 Thread Bartlomiej Zolnierkiewicz
This is a PCI driver and FB_CYBER2000 depends on PCI in Kconfig so there is no need to check for PCI inside the driver code. Cc: Russell King Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/cyber2000fb.c |5 - 1 file changed, 5 deletions(-) Index: b/drivers/video

[PATCH] video: fbdev: atafb: remove superfluous function prototypes

2019-05-21 Thread Bartlomiej Zolnierkiewicz
No need for them. Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/atafb.c | 21 - 1 file changed, 21 deletions(-) Index: b/drivers/video/fbdev/atafb.c === --- a

Re: [PATCH] fbcon: Remove fbcon_has_exited

2019-05-22 Thread Bartlomiej Zolnierkiewicz
. > > Also, I think info_idx == -1 is impossible in fbcon_init - we > unregister the fbcon in that case. So catch&warn about that. > > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Bartlomiej Zolnierkiewicz > Cc: Daniel Vetter &g

[PATCH 1/2] video: fbdev: pvr2fb: remove function prototypes

2019-05-22 Thread Bartlomiej Zolnierkiewicz
Reorder code a bit and then remove no longer needed function prototypes. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/pvr2fb.c | 141 ++- 1 file changed, 61 insertions(+), 80 deletions(-) Index: b/drivers/video/fbdev/pvr2fb.c

[PATCH 2/2] video: fbdev: pvr2fb: add COMPILE_TEST support

2019-05-22 Thread Bartlomiej Zolnierkiewicz
7;unsigned long' (needed to silence build warnings on ARM). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |3 ++- drivers/video/fbdev/pvr2fb.c | 26 +- 2 files changed, 15 insertions(+), 14 deletions(-) Index: b/drivers

[PATCH v2 2/2] video: fbdev: pvr2fb: add COMPILE_TEST support

2019-05-24 Thread Bartlomiej Zolnierkiewicz
'unsigned long' (needed to silence build warnings on ARM). - split pvr2_get_param() on pvr2_get_param_name() and pvr2_get_param_val() (needed to silence build warnings on x86). Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: fix build warnings on x86 reported by kbuild test

[PATCH v3 2/2] video: fbdev: pvr2fb: add COMPILE_TEST support

2019-05-24 Thread Bartlomiej Zolnierkiewicz
'unsigned long' (needed to silence build warnings on ARM). - split pvr2_get_param() on pvr2_get_param_name() and pvr2_get_param_val() (needed to silence build warnings on x86). Signed-off-by: Bartlomiej Zolnierkiewicz --- v3: fix 'space prohibited before that close paren

Re: [PATCH 24/33] Revert "backlight/fbcon: Add FB_EVENT_CONBLANK"

2019-05-27 Thread Bartlomiej Zolnierkiewicz
con and direct fbdev usage. Given >>> that the entire notifier maze is getting in the way anyway I figured >>> it's simplest to revert this not well justified commit. >>> >>> v2: Add static inline to the dummy version. >>> >>> Cc: Richard

Re: [PATCH] video: amba-clcd: Decomission Versatile and Nomadik

2019-04-11 Thread Bartlomiej Zolnierkiewicz
his code around. > > There are a few minor machines in arch/arm/ such as > mach-netx still using the old driver, so we need to keep > the core fbdev driver around for some time. > > Cc: Russell King > Cc: Bartlomiej Zolnierkiewicz > Signed-off-by: Linus Walleij Patch

Re: [PATCH -next] video: fbdev: remove set but not used variable 'size'

2019-04-11 Thread Bartlomiej Zolnierkiewicz
set-variable] > > It's not used since commit 9cd1c6743454 ("pvr2fb: Fix oops when > pseudo_palette is written") > > Signed-off-by: YueHaibing Patch queued for v5.2 with minor change in the patch summary ("video: fbdev: pvr2fb: remove set but not used va

Re: [PATCH -next] fbdev: mxsfb: remove set but not used variable 'line_count'

2019-04-11 Thread Bartlomiej Zolnierkiewicz
bdev: mxsfb: remove set but not used variable 'line_count'"), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next] video: fbdev: atmel_lcdfb: remove set but not used variable 'pdata'

2019-04-11 Thread Bartlomiej Zolnierkiewicz
t;) >> >> Signed-off-by: YueHaibing > > Indeed: > Acked-by: Nicolas Ferre Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: remove redundant 'default n' from Kconfig

2019-04-12 Thread Bartlomiej Zolnierkiewicz
n With this change, neither of these will generate a '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied). That might make it clearer to people that a bare 'default n' is redundant. ... Signed-off-by: Bartlomiej Zolnierkiewicz ---

[PATCH] video: fbdev: imxfb: add COMPILE_TEST support

2019-04-12 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to imxfb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/Kconfig

[PATCH] video: fbdev: pxa168fb: add COMPILE_TEST support

2019-04-12 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to pxa168fb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/Kconfig

[PATCH] video: fbdev: atmel_lcdfb: add COMPILE_TEST support

2019-04-12 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to atmel_lcdfb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/Kconfig

[PATCH] video: fbdev: gbefb: add COMPILE_TEST support

2019-04-12 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to gbefb driver for better compile testing coverage. While at it remove dead x86 specific code. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |2 +- drivers/video/fbdev/gbefb.c |9 ++--- 2 files changed, 3 insertions(+), 8

[PATCH] video: fbdev: da8xx-fb: add COMPILE_TEST support

2019-04-12 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to da8xx-fb driver for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/Kconfig

Re: [PATCH] fbdev/via: fix spelling mistake "Expandsion" -> "Expansion"

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 10/13/2018 12:47 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in MODULE_PARM_DESC text > > Signed-off-by: Colin Ian King Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland

Re: [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size'

2019-02-08 Thread Bartlomiej Zolnierkiewicz
sfb.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) > > Looks good, thanks. > > Should I merge this? Or otherwise: > > Acked-by: Michael Ellerman I've queued the patch to fbdev tree for v5.1 w/ slightly modified patch summary ("fbdev: chi

Re: [PATCH] fbcon: use kvmalloc() for scrollback buffer

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 12/21/2018 11:58 AM, Konstantin Khorenko wrote: > Hi Bartlomiej, > > On 12/20/2018 07:21 PM, Bartlomiej Zolnierkiewicz wrote: >> On 11/26/2018 11:02 AM, Konstantin Khorenko wrote: >>> Scrollback frame buffer is rather big - 32K, >>> so it requires 3rd

Re: [PATCH] fbdev: Use of_node_name_eq for node name comparisons

2019-02-08 Thread Bartlomiej Zolnierkiewicz
ns. This should not matter for any FDT based > system which omap is. > > Cc: Benjamin Herrenschmidt > Cc: Bartlomiej Zolnierkiewicz > Cc: linux-fb...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-o...@vger.kernel.org > Signed-off-by: Rob Herring Patch

Re: [PATCH] omapfb: fix typo

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 01/04/2019 10:43 PM, Matteo Croce wrote: > Fix spelling mistake: "lenght" -> "length" > > Signed-off-by: Matteo Croce Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D

Re: [PATCH] video: offb: annotate implicit fall throughs

2019-02-08 Thread Bartlomiej Zolnierkiewicz
igned-off-by: Mathieu Malaterre > > Acked-by: Gustavo A. R. Silva Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol

2019-02-08 Thread Bartlomiej Zolnierkiewicz
HT_LCD_SUPPORT option >> and converts LCD_CLASS_DEVICE into a menu. >> >> Signed-off-by: Alexander Shiyan > > A cover letter with the v1 -> v2 changelog would be nice... but > nevertheless: > Acked-by: Daniel Thompson Also: Acked-by: Bartlomiej Zolnierkiewicz

Re: [PATCH v2 2/2] video: lcd: Remove useless BACKLIGHT_CLASS_DEVICE dependencies

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 01/17/2019 02:33 PM, Alexander Shiyan wrote: > This patch removes dependencies on BACKLIGHT_CLASS_DEVICE for items > that are already placed under #if BACKLIGHT_CLASS_DEVICE. > > Signed-off-by: Alexander Shiyan Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zo

Re: [PATCH] fbdev: omap2: no need to check return value of debugfs_create functions

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 01/22/2019 04:21 PM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Bartlomiej Zolnierkiewicz >

Re: [PATCH] fbdev: mbx: fix up debugfs file creation

2019-02-08 Thread Bartlomiej Zolnierkiewicz
e file dentries was never freed when the device shut down, as well as > making the logic of the code a lot simpler. > > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Patch queue

Re: [PATCH] video/fbdev: refactor video= cmdline parsing

2019-02-08 Thread Bartlomiej Zolnierkiewicz
ed-off-by: Jani Nikula >> >> Reviewed-by: Daniel Vetter > > Thanks. > > Just to be clear, I expect Bartlomiej to queue this via the fb tree > (provided he agrees with the change, of course). Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung

Re: [PATCH] fbdev: fbmem: fix memory access if logo is bigger than the screen

2019-02-08 Thread Bartlomiej Zolnierkiewicz
valid > memory access. > > Signed-off-by: Manfred Schlaegl > Signed-off-by: Martin Kepplinger Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 0/2] Do not output logo on quiet boots

2019-02-08 Thread Bartlomiej Zolnierkiewicz
t; v4: move console_printk change to separate patch, and drop logo cleanup > v5: Only set FBCON_LOGO_DONTSHOW for console loglevel > > > Signed-off-by: Prarit Bhargava Patches #1-2 queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland

Re: [PATCH -next] video: fbdev: Fix potential NULL pointer dereference

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 01/30/2019 11:16 AM, YueHaibing wrote: > There is a potential NULL pointer dereference in case > fb_create_modedb() fails and returns NULL. > > Signed-off-by: YueHaibing Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institut

Re: [PATCH] udlfb: fix some inconsistent NULL checking

2018-12-20 Thread Bartlomiej Zolnierkiewicz
;fb_device_attrs[i]); > - device_remove_bin_file(info->dev, &edid_attr); > - } > + /* remove udlfb's sysfs interfaces */ > + for (i = 0; i < ARRAY_SIZE(fb_device_attrs); i++) > + device_remove_file(info->dev, &fb_device_attrs[i]); > + device_remove_bin

Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-12-20 Thread Bartlomiej Zolnierkiewicz
cularly good reason for this, so >> switch FB_BACKLIGHT over to tristate. >> >> Signed-off-by: Rob Clark >> Tested-by: Arnd Bergmann > > bump Patch queued for 4.21, thanks (also sorry for the delay). Best regards, -- Bartlomiej Z

Re: [PATCH] fbcon: use kvmalloc() for scrollback buffer

2018-12-20 Thread Bartlomiej Zolnierkiewicz
kvfree((void *) softback_buf); > softback_buf = 0; > softback_top = 0; > } > @@ -3665,7 +3665,7 @@ static void fbcon_exit(void) > } > #endif > > - kfree((void *)softback_buf); > + kvfree((vo

Re: [PATCH v3] fbcon: Silence fbcon logo on 'quiet' boots

2018-12-20 Thread Bartlomiej Zolnierkiewicz
module so export > console_printk > > Signed-off-by: Prarit Bhargava > Cc: Hans de Goede > Cc: Marko Myllynen > Cc: Steven Rostedt (VMware) > Cc: Bartlomiej Zolnierkiewicz > Cc: Kees Cook > Cc: Daniel Vetter > Cc: Thierry Reding > Cc: Yisheng Xi

Re: [PATCH] video: clps711x-fb: release disp device node in probe()

2018-12-20 Thread Bartlomiej Zolnierkiewicz
_invert = of_property_read_bool(disp, "cmap-invert"); > > ret = of_property_read_u32(disp, "bits-per-pixel", > &info->var.bits_per_pixel); > + of_node_put(disp); > if (ret) > goto out_fb_release; >

Re: [REGRESSION PATCH] fbdev: fbmem: behave better with small rotated displays and many CPUs

2018-12-20 Thread Bartlomiej Zolnierkiewicz
On 11/26/2018 10:19 PM, Peter Rosin wrote: > On 2018-11-26 15:33, Bartlomiej Zolnierkiewicz wrote: >> On 11/26/2018 03:16 PM, Peter Rosin wrote: >>> Ping?! >> >> Hi, >> >> Thank you for your patch, it will be considered for 4.21 (as it is not >>

Re: [PATCH -next] video: fbdev: pxafb: Fix "WARNING: invalid free of devm_ allocated data"

2018-12-20 Thread Bartlomiej Zolnierkiewicz
-by: YueHaibing Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next] video: fbdev: pxafb: Fix "WARNING: invalid free of devm_ allocated data"

2018-12-20 Thread Bartlomiej Zolnierkiewicz
On 12/20/2018 05:55 PM, Bartlomiej Zolnierkiewicz wrote: > > On 11/16/2018 12:02 PM, YueHaibing wrote: >> 'info->modes' got allocated with devm_kcalloc in of_get_pxafb_display. >> >> This gives this error message: >> ./drivers/video/fbdev/pxafb

Re: [PATCH v2 -next] video: fbdev: pxafb: Fix "WARNING: invalid free of devm_ allocated data"

2018-12-20 Thread Bartlomiej Zolnierkiewicz
8f96304ec8b4 ("video: fbdev: pxafb: switch to devm_* API") > Cc: sta...@kernel.org [v4.19+] > Signed-off-by: YueHaibing > Reviewed-by: Daniel Mack Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH 1/2] fbdev: fbmem: make fb_show_logo_line return the end instead of the height

2018-12-20 Thread Bartlomiej Zolnierkiewicz
or 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] fbdev: fbmem: add config option to center the bootup logo

2018-12-20 Thread Bartlomiej Zolnierkiewicz
On 11/26/2018 10:57 PM, Peter Rosin wrote: > If there are extra logos (CONFIG_FB_LOGO_EXTRA) the heights of these > extra logos are not considered when centering the first logo vertically. > > Signed-off-by: Peter Rosin Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zo

Re: [PATCH] fbdev: uvesafb: fix spelling mistake "memoery" -> "memory"

2018-12-20 Thread Bartlomiej Zolnierkiewicz
On 11/28/2018 04:37 PM, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in the module parameter description, fix it. > > Signed-off-by: Colin Ian King Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Insti

Re: [PATCH v2] media: omap2: omapfb: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-20 Thread Bartlomiej Zolnierkiewicz
On 12/02/2018 05:14 AM, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Patch queued for 4.21, thanks. [ subject line was fixed to "fbdev" from "media" while applying ] Best regards, -- Bartlomiej Zolnier

Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap

2018-12-20 Thread Bartlomiej Zolnierkiewicz
f-by: Wen Yang > > Acked-by: Timur Tabi Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] pxa168fb: trivial typo fix

2018-12-20 Thread Bartlomiej Zolnierkiewicz
"Try smaller resolution\n"); > divider_int = 2; > } Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5] fbdev: Remove depends on HAS_DMA in case of platform dependency

2018-12-20 Thread Bartlomiej Zolnierkiewicz
ff-by: Geert Uytterhoeven > Reviewed-by: Mark Brown > Acked-by: Robin Murphy > Acked-by: Bartlomiej Zolnierkiewicz Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___

Re: [PATCH] fbdev: fbcon: Fix unregister crash when more than one framebuffer

2018-12-20 Thread Bartlomiej Zolnierkiewicz
ation from >>> unregister_framebuffer") >>> Signed-off-by: Noralf Trønnes >>> Reviewed-by: Mikulas Patocka >>> --- >>> >>> Mikulas, >>> If you have forgotten about this, here's where you gave your r-b: >>

[PATCH] drm/nouveau: fix incorrect FB_BACKLIGHT usage in Kconfig

2018-12-28 Thread Bartlomiej Zolnierkiewicz
AU select BACKLIGHT_CLASS_DEVICE and BACKLIGHT_LCD_SUPPORT instead of FB_BACKLIGHT. Fixes: b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") Reported-by: Randy Dunlap Cc: Rob Clark Cc: Arnd Bergmann Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: Stephen Rothwell Signed-

Re: [PATCH] drm/nouveau: fix incorrect FB_BACKLIGHT usage in Kconfig

2019-01-02 Thread Bartlomiej Zolnierkiewicz
On 12/28/2018 07:03 PM, Randy Dunlap wrote: > On 12/28/18 7:15 AM, Bartlomiej Zolnierkiewicz wrote: >> Making FB_BACKLIGHT tristate by commit b4a1ed0cd18b ("fbdev: >> make FB_BACKLIGHT a tristate") caused unmet dependencies in >> some configurations: >>

[GIT PULL] fbdev changes for v4.21

2019-01-04 Thread Bartlomiej Zolnierkiewicz
FB_BACKLIGHT config option tristate (which in turn uncovered incorrect FB_BACKLIGHT usage by DRM's nouveau driver). Please see the signed tag description for details. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics The following changes sin

Re: [PATCH] fbdev: offb: Fix OF node name handling

2019-01-11 Thread Bartlomiej Zolnierkiewicz
o using %pOFn instead of >> device_node.name") > > Looks good to me: > > ... > [0.00] Linux version 5.0.0-rc1+ (ma...@debian.org) (gcc > version 6.3.0 20170516 (Debian 6.3.0-18)) #21 Mon Jan 7 21:03:53 CET > 2019 > ... > > So here is my : >

Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option

2019-01-16 Thread Bartlomiej Zolnierkiewicz
d line of logos is centered >>>>>>>> + as a whole. >>>>>>>> + >>>>>>> >>>>>>> Isn't a kernel command line option more suitable to configure the >>>>>>> position >>>>&g

Re: [PATCH v2] fbdev: fbmem: convert CONFIG_FB_LOGO_CENTER into a cmd, line option

2019-01-17 Thread Bartlomiej Zolnierkiewicz
On 01/17/2019 02:40 PM, Peter Rosin wrote: > On 2019-01-16 17:45, Bartlomiej Zolnierkiewicz wrote: >> On 01/07/2019 11:35 AM, Peter Rosin wrote: >>> Right. So, here's an update... >>> >>> Again, it would probably be best if this went in before

[GIT PULL] fbdev fixes for v5.0-rc3

2019-01-18 Thread Bartlomiej Zolnierkiewicz
Hi Linus, Please pull fbdev fixes for v5.0-rc3 (please see the signed tag description for details). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics The following changes since commit 399382f8018204407174f0229b4087d40e1cdc82: drm/nouveau:

Re: [PATCH] fbdev: omap2: fix warnings in dss core

2019-03-01 Thread Bartlomiej Zolnierkiewicz
turn 0' and remove the declaration of the unused variable > 'r'. > > Signed-off-by: Anders Roxell Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next] fbdev: omap2: omapfb: trivial code cleanup

2019-03-01 Thread Bartlomiej Zolnierkiewicz
ruct platform_device *pdev) > { > - int r; > - > core.pdev = pdev; > > dss_features_init(omapdss_get_version()); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] fbdev: mbx: fix a misspelled variable name

2019-03-05 Thread Bartlomiej Zolnierkiewicz
mbx: fix up debugfs file creation") > Signed-off-by: Arnd Bergmann Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3] video: fbdev: atmel_lcdfb: add COMPILE_TEST support

2019-05-30 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to atmel_lcdfb driver for better compile testing coverage. While at it fix improper use of UL (to silence build warnings on x86_64). Cc: Alexandre Belloni Cc: Ludovic Desroches Signed-off-by: Bartlomiej Zolnierkiewicz --- v3: fix build warnings on x86_64 v2: add

Re: [PATCH 00/33] fbcon notifier begone v3!

2019-06-07 Thread Bartlomiej Zolnierkiewicz
m-misc, or as a > separate tree, depending what you want. > > Thoughts? I would like to handle fbdev changes for v5.3 merge window using fbdev tree but after that everything (including changes to fbdev drivers) can go through drm-misc tree. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D I

Re: [PATCH] video: fbdev: mxsfb: Remove driver

2019-06-07 Thread Bartlomiej Zolnierkiewicz
the fbdev mxsfb driver in favour of the DRM version. >> >> Signed-off-by: Fabio Estevam > > Acked-by: Marek Vasut Patch queued for v5.3, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _

Re: [PATCH 3/8] drivers: (video|gpu): fix warning same module names

2019-06-07 Thread Bartlomiej Zolnierkiewicz
XS) += mxsfb.o >> +obj-$(CONFIG_FB_MXS) += fb-mxs.o >> +fb-mxs-objs := mxsfb.o >> obj-$(CONFIG_FB_SSD1307) += ssd1307fb.o >> obj-$(CONFIG_FB_SIMPLE) += simplefb.o >> >> -- >> 2.20.1 Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH] video: fbdev: atafb: remove superfluous function prototypes

2019-06-07 Thread Bartlomiej Zolnierkiewicz
On 5/21/19 4:12 PM, Geert Uytterhoeven wrote: > On Tue, May 21, 2019 at 4:02 PM Bartlomiej Zolnierkiewicz > wrote: >> No need for them. >> >> Cc: Geert Uytterhoeven >> Signed-off-by: Bartlomiej Zolnierkiewicz > > Reviewed-by: Geert Uytterhoeven Thanks

Re: [PATCH v3] video: fbdev: atmel_lcdfb: add COMPILE_TEST support

2019-06-07 Thread Bartlomiej Zolnierkiewicz
On 6/1/19 11:06 PM, Alexandre Belloni wrote: > On 30/05/2019 14:30:19+0200, Bartlomiej Zolnierkiewicz wrote: >> Add COMPILE_TEST support to atmel_lcdfb driver for better compile >> testing coverage. >> >> While at it fix improper use of UL (to silence build warni

Re: [PATCH v2] video: fbdev: imxfb: add COMPILE_TEST support

2019-06-07 Thread Bartlomiej Zolnierkiewicz
On 5/21/19 12:47 PM, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to imxfb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz I queued the patch for v5.3. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institut

Re: [PATCH v2] video: fbdev: pxa168fb: add COMPILE_TEST support

2019-06-07 Thread Bartlomiej Zolnierkiewicz
On 5/21/19 12:49 PM, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to pxa168fb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz I queued the patch for v5.3. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institut

Re: [PATCH v2] video: fbdev: gbefb: add COMPILE_TEST support

2019-06-07 Thread Bartlomiej Zolnierkiewicz
On 5/21/19 1:51 PM, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to gbefb driver for better compile > testing coverage. > > While at it convert bogus udelay() calls to mdelay() (needed to > build driver on ARM) and remove dead x86 specific code. > > Sign

Re: [PATCH v2] video: fbdev: da8xx-fb: add COMPILE_TEST support

2019-06-07 Thread Bartlomiej Zolnierkiewicz
On 5/21/19 12:53 PM, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to da8xx-fb driver for better compile > testing coverage. > > Signed-off-by: Bartlomiej Zolnierkiewicz I queued the patch for v5.3. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institut

Re: [PATCH] video: fbdev: cyber2000fb: remove superfluous CONFIG_PCI ifdef

2019-06-07 Thread Bartlomiej Zolnierkiewicz
On 5/21/19 3:44 PM, Bartlomiej Zolnierkiewicz wrote: > This is a PCI driver and FB_CYBER2000 depends on PCI in Kconfig so > there is no need to check for PCI inside the driver code. > > Cc: Russell King > Signed-off-by: Bartlomiej Zolnierkiewicz I queued the patch for v5.3

Re: [PATCH 1/2] video: fbdev: pvr2fb: remove function prototypes

2019-06-07 Thread Bartlomiej Zolnierkiewicz
On 5/22/19 12:15 PM, Bartlomiej Zolnierkiewicz wrote: > Reorder code a bit and then remove no longer needed function > prototypes. > > Signed-off-by: Bartlomiej Zolnierkiewicz I queued the patch for v5.3. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institut

Re: [PATCH v3 2/2] video: fbdev: pvr2fb: add COMPILE_TEST support

2019-06-07 Thread Bartlomiej Zolnierkiewicz
On 5/24/19 1:58 PM, Bartlomiej Zolnierkiewicz wrote: > Add COMPILE_TEST support to pvr2fb driver for better compile > testing coverage. > > While at it: > > - mark pvr2fb_interrupt() and pvr2fb_common_init() with > __maybe_unused tag (to silence build warnings w

[PATCH] video: fbdev: pvr2fb: fix build warning when compiling as module

2019-06-14 Thread Bartlomiej Zolnierkiewicz
Add missing #ifndef MODULE around pvr2_get_param_val(). Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support") Reported-by: Stephen Rothwell Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/pvr2fb.c |2 ++ 1 file changed, 2 insertions(+) Index:

[PATCH] video: fbdev: imxfb: fix sparse warnings about using incorrect types

2019-06-14 Thread Bartlomiej Zolnierkiewicz
Cc: Uwe Kleine-König Cc: NXP Linux Team Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/imxfb.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) Index: b/drivers/video/fbdev/imxfb.c === --- a/dri

[PATCH] video: fbdev: s3c-fb: add COMPILE_TEST support

2019-06-14 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to s3c-fb driver for better compile testing coverage. Cc: Jingoo Han Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/video/fbdev/Kconfig

[PATCH 1/3] video: fbdev: s3c-fb: return -ENOMEM on framebuffer_alloc() failure

2019-06-14 Thread Bartlomiej Zolnierkiewicz
Fix error code from -ENOENT to -ENOMEM. Cc: Jingoo Han Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/s3c-fb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/s3c-fb.c

[PATCH 2/3] video: fbdev: intelfb: return -ENOMEM on framebuffer_alloc() failure

2019-06-14 Thread Bartlomiej Zolnierkiewicz
Fix error code from -ENODEV to -ENOMEM. Cc: Maik Broemme Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/intelfb/intelfbdrv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/video/fbdev/intelfb/intelfbdrv.c

[PATCH 3/3] video: fbdev: don't print error message on framebuffer_alloc() failure

2019-06-14 Thread Bartlomiej Zolnierkiewicz
Cc: Jiri Kosina Cc: Benjamin Tissoires Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/hid/hid-picolcd_fb.c |4 +--- drivers/video/fbdev/amifb.c|4 +--- drivers/video/fbdev/arkfb.c|4 +--- drivers/video/fbdev/atm

Re: [PULL] topic/remove-fbcon-notifiers for v5.3

2019-06-18 Thread Bartlomiej Zolnierkiewicz
dev driver) but it seems that all patches miss your "S-o-B:" line (there is only "Reviewed-by:" tag which is OK but has a different meaning)? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > >> topic/remove-fbcon-notifiers-20

Re: [PULL] topic/remove-fbcon-notifiers for v5.3

2019-06-19 Thread Bartlomiej Zolnierkiewicz
On 6/18/19 1:46 PM, Maarten Lankhorst wrote: > Op 18-06-2019 om 13:17 schreef Bartlomiej Zolnierkiewicz: >> Hi, >> >> On 6/18/19 11:20 AM, Maarten Lankhorst wrote: >>> Op 14-06-2019 om 11:25 schreef Maarten Lankhorst: >>>> Hi all, >>>> >>

Re: [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit

2019-06-21 Thread Bartlomiej Zolnierkiewicz
text' of > drivers/video/fbdev/pvr2fb.o > > Just remove the __exit annotation as the easiest workaround. Don't we also need to fix pvr2fb_dc_exit() for CONFIG_SH_DREAMCAST=y case? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics &

Re: [PATCH] video: fbdev: pvr2fb: fix build warning when compiling as module

2019-06-21 Thread Bartlomiej Zolnierkiewicz
On 6/14/19 12:43 PM, Bartlomiej Zolnierkiewicz wrote: > Add missing #ifndef MODULE around pvr2_get_param_val(). > > Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support") > Reported-by: Stephen Rothwell > Signed-off-by: Bartlomiej Zolnierkiewicz I

Re: [PATCH] video: fbdev: imxfb: fix sparse warnings about using incorrect types

2019-06-21 Thread Bartlomiej Zolnierkiewicz
On 6/14/19 1:53 PM, Bartlomiej Zolnierkiewicz wrote: > Use ->screen_buffer instead of ->screen_base to fix sparse warnings. > > [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base > pointer") for details. ] > > Reported-by: kbuild test ro

Re: [PATCH] video: fbdev: s3c-fb: add COMPILE_TEST support

2019-06-21 Thread Bartlomiej Zolnierkiewicz
On 6/18/19 8:12 AM, Jingoo Han wrote: > On 6/14/19, 11:46 PM, Bartlomiej Zolnierkiewicz wrote: >> >> Add COMPILE_TEST support to s3c-fb driver for better compile >> testing coverage. >> >> Cc: Jingoo Han > Acked-by: Jingoo Han >> Signed-off-by: Bartlo

Re: [PATCH] video: fbdev: pvr2fb: fix compile-testing as module

2019-06-21 Thread Bartlomiej Zolnierkiewicz
b_imageblit, > }; > > -static int pvr2_get_param_val(const struct pvr2_params *p, const char *s, > - int size) > +static int __maybe_unused pvr2_get_param_val(const struct pvr2_params *p, > + const char *s, int si

Re: [PATCH] video: fbdev: pvr2fb: fix link error for pvr2fb_pci_exit

2019-06-21 Thread Bartlomiej Zolnierkiewicz
On 6/21/19 1:05 PM, Arnd Bergmann wrote: > On Fri, Jun 21, 2019 at 12:58 PM Bartlomiej Zolnierkiewicz > wrote: >> >> On 6/17/19 3:16 PM, Arnd Bergmann wrote: >>> When the driver is built-in for PCI, we reference the exit function >>> after discarding it: >

Re: [PATCH] efifb: BGRT: Add check for new BGRT status field rotation bits

2019-06-21 Thread Bartlomiej Zolnierkiewicz
{ >     pr_info("efifb: BGRT rotation bits set, not showing boot > graphics\n"); >     return; >     } > > Instead. So at least on the one machine I know of this is 99% cosmetic. > >> Or is it relevant for userland in some other way? > > No. > > Regards, > > Hans Patch queued for v5.3, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] video: fbdev: Fix Warning comparing pointer to 0 reported by coccicheck

2019-06-21 Thread Bartlomiej Zolnierkiewicz
(same for the others above). Maybe > checkpatch with --strict would warn for those (can't remember from top > of my head). > > Anyway: > > Reviewed-by: Mathieu Malaterre > >> + return -ENOMEM; >> control_fb = p; /* save it for clean

  1   2   3   4   5   6   7   >