Re: [PATCH][next] video: fbdev: atmel_lcdfb: remove redundant initialization to variable ret

2019-06-21 Thread Bartlomiej Zolnierkiewicz
y: Colin Ian King >> >> Indeed: >> Acked-by: Nicolas Ferre > > Acked-by: Ludovic Desroches Patch queued for v5.3, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev-MMP: Use struct_size() in devm_kzalloc()

2019-06-21 Thread Bartlomiej Zolnierkiewicz
) helper: > > instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL); > > Notice that, in this case, variable size is not necessary, hence it > is removed. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R

Re: [PATCH] video: fbdev: omap2: remove rfbi

2019-06-21 Thread Bartlomiej Zolnierkiewicz
l patches needed. It has been over a year now and not much has happened in the case of fixing rfbi driver so I've queued the old patch removing it (with updated patch description, please see below) for v5.3 (please note that it can be trivially reverted using kernel git repository if ever ne

Re: [PULL] topic/remove-fbcon-notifiers for v5.3, fixes

2019-06-26 Thread Bartlomiej Zolnierkiewicz
: Depend upon fbcon being built-in, if enabled > > drivers/gpu/vga/Kconfig | 1 + > drivers/video/fbdev/core/fbcon.c | 1 + > 2 files changed, 2 insertions(+) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _

[PATCH] video: fbdev: s3c-fb: fix sparse warnings about using incorrect types

2019-06-27 Thread Bartlomiej Zolnierkiewicz
Use ->screen_buffer instead of ->screen_base to fix sparse warnings. [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base pointer") for details. ] Reported-by: kbuild test robot Cc: Jingoo Han Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/vide

[PATCH 1/3] video: fbdev: mmp: remove duplicated MMP_DISP dependency

2019-06-27 Thread Bartlomiej Zolnierkiewicz
This dependency is already present in higher level Kconfig file (drivers/video/fbdev/mmp/Kconfig). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/mmp/fb/Kconfig |4 drivers/video/fbdev/mmp/hw/Kconfig |4 2 files changed, 8 deletions(-) Index: b/drivers/video

[PATCH 2/3] video: fbdev: mmp: add COMPILE_TEST support

2019-06-27 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to mmp display subsystem for better compile testing coverage. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/mmp/Kconfig|2 +- drivers/video/fbdev/mmp/hw/Kconfig |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) Index: b/drivers

[PATCH 3/3] video: fbdev: mmp: fix sparse warnings about using incorrect types

2019-06-27 Thread Bartlomiej Zolnierkiewicz
Use ->screen_buffer instead of ->screen_base in mmpfb driver. [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base pointer") for details. ] Also fix all other sparse warnings about using incorrect types in mmp display subsystem. Signed-off-by: Bartlomie

Re: [PATCH 1/3] video: fbdev: s3c-fb: return -ENOMEM on framebuffer_alloc() failure

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/18/19 8:13 AM, Jingoo Han wrote: > On 6/14/19, 11:47 PM, Bartlomiej Zolnierkiewicz wrote: >> >> Fix error code from -ENOENT to -ENOMEM. >> >> Cc: Jingoo Han > Acked-by: Jingoo Han Thanks, I queued the patch for v5.3. Best regards, -- Bartlomiej Zolnierkiewic

Re: [PATCH 2/3] video: fbdev: intelfb: return -ENOMEM on framebuffer_alloc() failure

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/14/19 4:48 PM, Bartlomiej Zolnierkiewicz wrote: > Fix error code from -ENODEV to -ENOMEM. > > Cc: Maik Broemme > Signed-off-by: Bartlomiej Zolnierkiewicz I queued the patch for v5.3. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH 3/3] video: fbdev: don't print error message on framebuffer_alloc() failure

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/14/19 4:51 PM, Bartlomiej Zolnierkiewicz wrote: > framebuffer_alloc() can fail only on kzalloc() memory allocation > failure and since kzalloc() will print error message in such case > we can omit printing extra error message in drivers (which BTW is > what the majority of frame

Re: [PATCH] video: fbdev: s3c-fb: fix sparse warnings about using incorrect types

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/28/19 7:50 AM, Jingoo Han wrote: > On 6/27/19, 9:58 PM, Bartlomiej Zolnierkiewicz wrote: >> >> Use ->screen_buffer instead of ->screen_base to fix sparse warnings. >> >> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base >>

Re: [PATCH 11/43] docs: console.txt: convert docs to ReST and rename to *.rst

2019-06-28 Thread Bartlomiej Zolnierkiewicz
Mauro Carvalho Chehab > Acked-by: Greg Kroah-Hartman Acked-by: Bartlomiej Zolnierkiewicz > --- > .../console/{console.txt => console.rst} | 63 ++- > Documentation/fb/fbcon.rst| 4 +- > drivers/tty/Kconfig | 2 +- &

Re: [PATCH 28/39] docs: admin-guide: add a series of orphaned documents

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/28/19 2:30 PM, Mauro Carvalho Chehab wrote: > There are lots of documents that belong to the admin-guide but > are on random places (most under Documentation root dir). > > Move them to the admin guide. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Bartlom

Re: [PATCH 37/39] docs: adds some directories to the main documentation index

2019-06-28 Thread Bartlomiej Zolnierkiewicz
re not split yet. > > For the others, well... I'm too lazy to do the move. Also, it > seems to make sense to keep at least some of those at the main > dir (like kbuild, for example). In any case, a latter patch > could do the move. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH 01/12] backlight: gpio: allow to probe non-pdata devices from board files

2019-06-28 Thread Bartlomiej Zolnierkiewicz
instead > of OF specific helpers. Reverse the logic checking the presence of > platform data in probe(). This way we can probe devices() registered > from machine code that neither have a DT node nor use platform data. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Bartlomiej

dri-devel@lists.freedesktop.org

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Instead of dereferencing pdev each time, use a helper variable for > the associated device pointer. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Bartlomiej Zolnierkiewicz Best rega

Re: [PATCH 03/12] backlight: gpio: pull the non-pdata device probing code into probe()

2019-06-28 Thread Bartlomiej Zolnierkiewicz
. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH 07/12] fbdev: da8xx: add support for a regulator

2019-06-28 Thread Bartlomiej Zolnierkiewicz
uent > patch on da850-evm. > > Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel

Re: [PATCH 09/12] fbdev: da8xx: remove panel_power_ctrl() callback from platform data

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > There are no more users of panel_power_ctrl(). Remove it from the > driver. > > Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierk

Re: [PATCH 10/12] fbdev: da8xx-fb: use devm_platform_ioremap_resource()

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Shrink the code a bit by using the new helper wrapping the calls to > platform_get_resource() and devm_ioremap_resource() together. > > Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zol

Re: [PATCH 11/12] fbdev: da8xx-fb: drop a redundant if

2019-06-28 Thread Bartlomiej Zolnierkiewicz
osz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH 12/12] fbdev: da8xx: use resource management for dma

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use managed variants of dma alloc functions in the da8xx fbdev driver. > > Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsun

Re: [PATCH 3/3] video: fbdev: don't print error message on framebuffer_alloc() failure

2019-07-01 Thread Bartlomiej Zolnierkiewicz
On 7/1/19 10:37 AM, Benjamin Tissoires wrote: > Hi Bartlomiej, Hi Benjamin, > On Fri, Jun 14, 2019 at 4:52 PM Bartlomiej Zolnierkiewicz > wrote: >> >> framebuffer_alloc() can fail only on kzalloc() memory allocation >> failure and since kzalloc() will print error

Re: [PATCH 07/11] video: fbdev: wm8505fb: convert platform driver to use dev_groups

2019-07-05 Thread Bartlomiej Zolnierkiewicz
On 7/4/19 4:26 PM, Greg Kroah-Hartman wrote: > Platform drivers now have the option to have the platform core create > and remove any needed sysfs attribute files. So take advantage of that > and do not register "by hand" a sysfs file. > > Cc: Tony Prisk > Cc: Bar

Re: [PATCH 08/11] video: fbdev: w100fb: convert platform driver to use dev_groups

2019-07-05 Thread Bartlomiej Zolnierkiewicz
y Prisk > Cc: Bartlomiej Zolnierkiewicz > Cc: linux-arm-ker...@lists.infradead.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH 09/11] video: fbdev: sm501fb: convert platform driver to use dev_groups

2019-07-05 Thread Bartlomiej Zolnierkiewicz
On 7/4/19 10:46 AM, Greg Kroah-Hartman wrote: > Platform drivers now have the option to have the platform core create > and remove any needed sysfs attribute files. So take advantage of that > and do not register "by hand" a bunch of sysfs files. > > Cc: Bartlomiej

Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs

2019-07-05 Thread Bartlomiej Zolnierkiewicz
> This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva Patch queued for v5.3, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next] video: fbdev: imxfb: fix a typo in imxfb_probe()

2019-07-05 Thread Bartlomiej Zolnierkiewicz
er) { > dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret); > ret = -ENOMEM; > goto failed_map; Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[GIT PULL] fbdev changes for v5.3

2019-07-09 Thread Bartlomiej Zolnierkiewicz
;ivtvfb_restore = NULL; ivtvfb_blank(FB_BLANK_VSYNC_SUSPEND, &oi->ivtvfb_info); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics The following changes since commit d1fdb6d8f6a4109a4263176c84b899076a5f8008: Linux 5.2-rc4

[GIT PULL] fbdev changes for v5.1

2019-03-15 Thread Bartlomiej Zolnierkiewicz
Hi Linus, Please pull fbdev changes for v5.1. Just a couple of small fixes and cleanups (please see the signed tag description for details). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics The following changes since co

Re: [PATCH] xen, fbfront: mark expected switch fall-through

2019-03-21 Thread Bartlomiej Zolnierkiewicz
Hi, On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > Who can take this? I'll take this for v5.2. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > Thanks > -- > Gustavo &

Re: [PATCH] fbdev: mxsfb: implement FB_PRE_INIT_FB option

2019-04-01 Thread Bartlomiej Zolnierkiewicz
option available for the mxsfb driver. > > Signed-off-by: Melchior Franz > Signed-off-by: Martin Kepplinger > Signed-off-by: Manfred Schlaegl Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D

Re: [PATCH] video: fbdev: vesafb: fix indentation issue

2019-04-01 Thread Bartlomiej Zolnierkiewicz
eued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: savage: fix indentation issue

2019-04-01 Thread Bartlomiej Zolnierkiewicz
On 02/12/2019 02:34 PM, Colin King wrote: > From: Colin Ian King > > The indentation in the if statement is not indented correctly, fix > this with extra level of indentation. > > Signed-off-by: Colin Ian King Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zoln

Re: [PATCH] video/macfb: Remove redundant code

2019-04-01 Thread Bartlomiej Zolnierkiewicz
Tested-by: Stan Johnson >> Signed-off-by: Finn Thain > > Reviewed-by: Geert Uytterhoeven Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing

Re: [PATCH 0/4] fbdev: atafb: Fix after kexec, misc. cleanups

2019-04-01 Thread Bartlomiej Zolnierkiewicz
, 119 deletions(-) Patches #1-4 queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video/macfb: Call fb_invert_cmaps()

2019-04-01 Thread Bartlomiej Zolnierkiewicz
On 02/18/2019 12:25 AM, Finn Thain wrote: > The 'inverse' parameter has no effect otherwise. Remove set-but-unused > variable. > > Cc: linux-m...@lists.linux-m68k.org > Signed-off-by: Finn Thain Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiew

Re: [PATCH] video/macfb: Always initialize DAFB colour table pointer register

2019-04-01 Thread Bartlomiej Zolnierkiewicz
-by: Finn Thain Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 06/12] omapfb: add missing of_node_put after of_device_is_available

2019-04-01 Thread Bartlomiej Zolnierkiewicz
> } > // > > Fixes: f76ee892a99e6 ("omapfb: copy omapdss & displays for omapfb") > Signed-off-by: Julia Lawall Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [PATCH] video: fbdev: atmel_lcdfb: drop AVR and platform_data support

2019-04-01 Thread Bartlomiej Zolnierkiewicz
On 02/25/2019 10:25 PM, Alexandre Belloni wrote: > Make the driver OF only as since AVR32 has been removed from the kernel, > there are only OF enabled platform using it. > > Signed-off-by: Alexandre Belloni Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz

Re: [PATCH] xen, fbfront: mark expected switch fall-through

2019-04-01 Thread Bartlomiej Zolnierkiewicz
On 03/21/2019 12:03 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote: >> Hi all, >> >> Friendly ping: >> >> Who can take this? > > I'll take this for v5.2. Patch queued for v5.2, thanks. B

Re: [PATCH] omapfb: Fix potential NULL pointer dereference in kmalloc

2019-04-01 Thread Bartlomiej Zolnierkiewicz
On 03/02/2019 09:40 PM, Aditya Pakki wrote: > Memory allocated, using kmalloc, for new_compat may fail. This patch > checks for such an error and prevents potential NULL pointer > dereference. > > Signed-off-by: Aditya Pakki Patch queued for v5.2, thanks. Best regards

Re: [PATCH] drivers: video: fbdev: Kconfig: pedantic cleanups

2019-04-01 Thread Bartlomiej Zolnierkiewicz
patch description, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] fbdev: list all pci memory bars as conflicting apertures

2019-04-01 Thread Bartlomiej Zolnierkiewicz
ameter, use it for sanity-checking and warn on inconsistencies. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Daniel Vetter Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___

Re: [PATCH] video: hgafb: fix a NULL pointer dereference

2019-04-01 Thread Bartlomiej Zolnierkiewicz
ix potential NULL pointer dereference"), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: fix potential NULL pointer dereferences

2019-04-01 Thread Bartlomiej Zolnierkiewicz
tial NULL pointer dereference"), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/8] fbdev: sm712fb: fix a series of lockups, crashes and gliches.

2019-04-01 Thread Bartlomiej Zolnierkiewicz
tasheet and also tested the full > series (separate test for individual patches) with SM712 on little endian > for any regression. Patches #1-8 queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [PATCH] fbdev: fix divide error in fb_var_to_videomode

2019-04-01 Thread Bartlomiej Zolnierkiewicz
struct fb_var_screeninfo var = {.activate = 0x100, .pixclock = >> 60}; >>int fd = open("/dev/fb0", O_RDWR); >>if (fd < 0) >> return 1; >> >>if (ioctl(fd, FBI

Re: [PATCH 3/7] gbefb: switch to managed version of the DMA allocator

2019-04-01 Thread Bartlomiej Zolnierkiewicz
On 03/21/2019 11:52 PM, Christoph Hellwig wrote: > gbefb uses managed resources, so it should do the same for DMA > allocations. > > Signed-off-by: Christoph Hellwig Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institut

Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol

2019-04-01 Thread Bartlomiej Zolnierkiewicz
On 03/20/2019 11:07 AM, Lee Jones wrote: >>>> On 02/12/2019 09:42 AM, Lee Jones wrote: >>>>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote: >>>>> >>>>>> >>>>>> On 01/17/2019 05:19 PM, Daniel Thompson w

Re: [PATCH] video: fbdev: sis: fix a missing-check bug

2019-04-02 Thread Bartlomiej Zolnierkiewicz
-4156,24 +4155,17 @@ static unsigned char *sisfb_find_rom(struct pci_dev >> *pdev) >> rom_base = ioremap(temp, 65536); >> if (!rom_base) >> continue; >> - >> - if (!sisf

Re: [PATCH v2 7/7] MAINTAINERS: sm712fb: list myself as one maintainer.

2019-04-03 Thread Bartlomiej Zolnierkiewicz
eddy Wang M: Sudip Mukherjee +M: Yifeng Li L: linux-fb...@vger.kernel.org S: Maintained F: drivers/video/fbdev/sm712* Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/7] da8xx-fb: pass struct device to DMA API functions

2019-04-03 Thread Bartlomiej Zolnierkiewicz
ristoph Hellwig Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/7] pxa3xx-gcu: pass struct device to dma_mmap_coherent

2019-04-03 Thread Bartlomiej Zolnierkiewicz
On 03/21/2019 11:52 PM, Christoph Hellwig wrote: > Just like we do for all other DMA operations. > > Signed-off-by: Christoph Hellwig Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsun

Re: [PATCH] video: radeon.h Fix Shifting signed 32 bit value by 31 bits problem

2019-07-15 Thread Bartlomiej Zolnierkiewicz
ORZ_FP_LOOP_STRETCH(0x7 << 28) > -#define HORZ_AUTO_RATIO_INC (1 << 31) > +#define HORZ_AUTO_RATIO_INC (1U << 31) > > > /* FP_VERT_STRETCH bit constants */ Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&

Re: [PATCH 02/10] video: sa1100fb: Remove cpufreq policy notifier

2019-07-16 Thread Bartlomiej Zolnierkiewicz
inting a debug message on CPUFREQ_ADJUST notification. There is > no point in keeping an otherwise empty callback and registering the > notifier. > > Remove it. > > Signed-off-by: Viresh Kumar Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsu

Re: [PATCH 03/10] video: pxafb: Remove cpufreq policy notifier

2019-07-16 Thread Bartlomiej Zolnierkiewicz
n. There is > no point in keeping an otherwise empty callback and registering the > notifier. > > Remove it. > > Signed-off-by: Viresh Kumar Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH] fbdev: Ditch fb_edid_add_monspecs

2019-07-22 Thread Bartlomiej Zolnierkiewicz
On 7/21/19 10:38 PM, Linus Torvalds wrote: > On Sun, Jul 21, 2019 at 1:20 PM Daniel Vetter wrote: >> >> It's dead code ever since > > Lovely. Ack. Good catch indeed. Thanks Daniel, I'll queue it for v5.4 later. Best regards, -- Bartlomiej Zolnierkiewicz Samsu

Re: [PATCH] fbdev: Ditch fb_edid_add_monspecs

2019-07-23 Thread Bartlomiej Zolnierkiewicz
On 7/22/19 3:52 PM, Bartlomiej Zolnierkiewicz wrote: > > On 7/21/19 10:38 PM, Linus Torvalds wrote: >> On Sun, Jul 21, 2019 at 1:20 PM Daniel Vetter wrote: >>> >>> It's dead code ever since >> >> Lovely. Ack. > > Good catch indeed. >

[PATCH] MAINTAINERS: handle fbdev changes through drm-misc tree

2019-07-23 Thread Bartlomiej Zolnierkiewicz
Zolnierkiewicz --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/MAINTAINERS === --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6389,7 +6389,7 @@ FRAMEBUFFER LAYER M: Bartlomiej Zolnierkiewicz L: dri

Re: [PATCH] fbmem: remove redundant assignment to err

2019-07-23 Thread Bartlomiej Zolnierkiewicz
ned-off-by: Colin Ian King Patch queued for v5.4, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: nvidia: Remove extra return

2019-07-23 Thread Bartlomiej Zolnierkiewicz
queued for v5.4, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH] video: fbdev: nvidia: Remove dead code

2019-07-23 Thread Bartlomiej Zolnierkiewicz
t;> Signed-off-by: Souptick Joarder Patch queued for v5.4, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH v3 24/24] video: fbdev-MMP: Remove call to memset after dma_alloc_coherent

2019-07-23 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Fuqian Huang >> --- >> Changes in v3: >> - Use actual commit rather than the merge commit in the commit message >> >> drivers/video/fbdev/mmp/fb/mmpfb.c | 1 - >> 1 file changed, 1 deletion(-) >> > > Reviewed-by: Emil Velikov

Re: [PATCH 0/6] video: ssd1307fb: Support more displays

2019-07-23 Thread Bartlomiej Zolnierkiewicz
sd1307fb.txt | 10 ++ > drivers/video/fbdev/ssd1307fb.c | 130 -- > 2 files changed, 101 insertions(+), 39 deletions(-) Patch series queued for v5.4, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics __

Re: [RFC PATCH] fbcon: fix ypos over boundary issue

2019-07-23 Thread Bartlomiej Zolnierkiewicz
Ye > Signed-off-by: Feng Tiantian > Signed-off-by: Zenghui Yu > --- > > Hi Bartlomiej, Hi Zenghui, > Zengruan had reported this issue [1] but received no reply. Does it make Sorry about that (at that time it seemed like a workaround for DRM issue so I have not followed

Re: [PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing()

2019-07-26 Thread Bartlomiej Zolnierkiewicz
Sam Ravnborg > > You could consider silencing display_timing as the last patch, but thats > a very small detail. > > How do we apply these fixes - to drm-misc-next? Bartlomiej? > > No need to go in via drm-misc-fixes as the offending commit is only in > drm-misc-next. I've merged the whole series to drm-misc-next, thanks! Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH] video: Demote panel timing not found error message

2019-07-26 Thread Bartlomiej Zolnierkiewicz
(the patchset has been posted just few days ago and the issue addressed is not critical). PS When I go on holidays I set automatic out of office reply and also announce it on the mailing-list (for longer holidays). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung

Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support

2019-07-26 Thread Bartlomiej Zolnierkiewicz
iver set any of: > > lcd_ops.early_set_power() > lcd_ops.r_early_set_power() > > Noticed while browsing backlight code for other reasons. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Bartlomiej Zolnierkiewicz > Cc: Daniel

Re: [PATCH] video: Demote panel timing not found error message

2019-07-26 Thread Bartlomiej Zolnierkiewicz
On 7/26/19 5:32 PM, Sam Ravnborg wrote: > Hi Bartlomiej Zolnierkiewicz >> >> Hi Sam, >> >> On 7/26/19 1:36 PM, Sam Ravnborg wrote: >>> Hi Thierry. >>> >>> On Fri, Jul 26, 2019 at 12:18:49PM +0200, Thierry Reding wrote: >>>> From

Re: [PATCH 06/46] ARM: pxa: stop using mach/bitfield.h

2019-11-08 Thread Bartlomiej Zolnierkiewicz
On 10/18/19 5:41 PM, Arnd Bergmann wrote: > There are two identical copies of mach/bitfield.h, one for > mach-sa1100 and one for mach-pxa. The pxafb driver only > makes use of two macros, which can be trivially open-coded > in the header. > > Cc: Bartlomiej Zolnierkiewic

Re: [PATCH 08/46] ARM: pxa: move regs-lcd.h into driver

2019-11-08 Thread Bartlomiej Zolnierkiewicz
On 10/18/19 5:41 PM, Arnd Bergmann wrote: > Only the pxafb driver uses this header, so move it into the > same directory. The SMART_* macros are required by some > platform data definitions and can go into the > linux/platform_data/video-pxafb.h header. > > Cc: Bartlomiej Zo

Re: [PATCH v6 47/57] video: Remove dev_err() usage after platform_get_irq()

2020-01-03 Thread Bartlomiej Zolnierkiewicz
patch. This patch changes handling of -EPROBE_DEFER in the modified drivers (most don't support it and error message will no longer be printed). I cannot apply it as it is (seems that -EPROBE_DEFER handling should be audited/fixed in the affected drivers first). Best regards, -- Bartlomiej Zo

Re: [PATCH 1/3] video: fbdev: mmp: remove duplicated MMP_DISP dependency

2020-01-03 Thread Bartlomiej Zolnierkiewicz
On 8/20/19 11:55 AM, Andrzej Hajda wrote: > On 27.06.2019 16:07, Bartlomiej Zolnierkiewicz wrote: >> This dependency is already present in higher level Kconfig file >> (drivers/video/fbdev/mmp/Kconfig). >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > > >

Re: [PATCH 2/3] video: fbdev: mmp: add COMPILE_TEST support

2020-01-03 Thread Bartlomiej Zolnierkiewicz
On 8/20/19 11:56 AM, Andrzej Hajda wrote: > On 27.06.2019 16:07, Bartlomiej Zolnierkiewicz wrote: >> Add COMPILE_TEST support to mmp display subsystem for better compile >> testing coverage. >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > > > Reviewed-by:

Re: [PATCH 3/3] video: fbdev: mmp: fix sparse warnings about using incorrect types

2020-01-03 Thread Bartlomiej Zolnierkiewicz
On 8/20/19 1:07 PM, Andrzej Hajda wrote: > On 27.06.2019 16:08, Bartlomiej Zolnierkiewicz wrote: >> Use ->screen_buffer instead of ->screen_base in mmpfb driver. >> >> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base >> pointer&quo

Re: [PATCH v3 1/3] fbdev: fix numbering of fbcon options

2020-01-03 Thread Bartlomiej Zolnierkiewicz
e documentation") > Signed-off-by: Peter Rosin Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > Documentation/fb/fbcon.rst | 8 > 1 file changed, 4

Re: [PATCH v3 2/3] fbdev: fbmem: allow overriding the number of bootup logos

2020-01-03 Thread Bartlomiej Zolnierkiewicz
On 8/27/19 1:09 PM, Peter Rosin wrote: > Probably most useful if you want no logo at all, or if you only want one > logo regardless of how many CPU cores you have. > > Signed-off-by: Peter Rosin Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -

Re: [PATCH v3 3/3] fbdev: fbmem: avoid exporting fb_center_logo

2020-01-03 Thread Bartlomiej Zolnierkiewicz
in include/linux/fb.h? Sounds like a good idea. > Feels like that could be done later, after these other cleanups you mention, > so that the new file has a few more things to declare. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] pxa168fb: Fix the function used to release some memory in an error handling path

2020-01-03 Thread Bartlomiej Zolnierkiewicz
gt; >> Fixes: 638772c7553f ("fb: add support of LCD display controller on >> pxa168/910 (base layer)") >> Signed-off-by: Christophe JAILLET > > Reviewed-by: Lubomir Rintel Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomi

Re: [PATCH] video/fbdev/68328fb: Remove dead code

2020-01-03 Thread Bartlomiej Zolnierkiewicz
On 9/2/19 2:49 PM, Souptick Joarder wrote: > This is dead code since 3.15. If their is no plan to > use it further, these can be removed forever. > > Signed-off-by: Souptick Joarder Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewi

Re: [PATCH -next] fbdev: da8xx-fb: use devm_platform_ioremap_resource() to simplify code

2020-01-03 Thread Bartlomiej Zolnierkiewicz
_resource() and devm_ioremap_resource() together. Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Signed-off-by: Sekhar Nori Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/da8x

Re: [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code

2020-01-03 Thread Bartlomiej Zolnierkiewicz
On 9/4/19 1:54 PM, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Thanks, patch queued for v5.6 (also sorry for the delay). Best regards

Re: [PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code

2020-01-03 Thread Bartlomiej Zolnierkiewicz
>> > Acked-by: Jingoo Han Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics >> --- >> drivers/video/fbdev/s3c-fb.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 del

Re: [PATCH -next] fbdev/sa1100fb: use devm_platform_ioremap_resource() to simplify code

2020-01-03 Thread Bartlomiej Zolnierkiewicz
On 9/4/19 1:57 PM, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Thanks, patch queued for v5.6 (also sorry for the delay). Best regards

Re: [PATCH] fbdev: matrox: make array wtst_xlat static const, makes object smaller

2020-01-03 Thread Bartlomiej Zolnierkiewicz
t_xlat[] = { 0, 1, 5, 6, 7, 5, 2, 3 }; >> +static const u_int32_t wtst_xlat[] = { >> +0, 1, 5, 6, 7, 5, 2, 3 > > All of those would easily fit in u8 as well. Good idea, I've converted the table to u8 while

Re: [PATCH] video: fbdev: fsl-diu-fb: mark expected switch fall-throughs

2020-01-03 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Gustavo A. R. Silva Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/fsl-diu-fb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH] video: ocfb: Use devm_platform_ioremap_resource() in ocfb_probe()

2020-01-03 Thread Bartlomiej Zolnierkiewicz
Markus Elfring Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/ocfb.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a

Re: [PATCH] video: pxafb: Use devm_platform_ioremap_resource() in pxafb_probe()

2020-01-03 Thread Bartlomiej Zolnierkiewicz
Markus Elfring Thanks, patch queued for v5.6 (also sorry for the delay). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/pxafb.c | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --

Re: [PATCH] omapfb: reduce stack usage

2020-01-03 Thread Bartlomiej Zolnierkiewicz
lso simplify the driver by just accessing dsi->irq_stats directly before cleaning it (we would also need to extend coverage of spinlock but the code is debug only so this should not be a problem). Care to try this approach? Best regards, -- Bartlomiej Zolnierkiewicz Samsung

Re: [PATCH] fbdev: potential information leak in do_fb_ioctl()

2020-01-03 Thread Bartlomiej Zolnierkiewicz
quot;info->fix") comes from framebuffer_alloc() (which is called by fbdev device drivers prior to registering "info" with register_framebuffer()). framebuffer_alloc() does kzalloc() on "info". Therefore shouldn't memcpy() (as suggested by Jeo Perches) be enough?

Re: [PATCH v2 1/3] fbdev/g364fb: Fix build failure

2020-02-07 Thread Bartlomiej Zolnierkiewicz
g364fb.c:234:24: error: 'xres' undeclared (first use in > this function) > drivers/video/fbdev/g364fb.c:201:14: warning: unused variable 'j' > [-Wunused-variable] > drivers/video/fbdev/g364fb.c:197:25: warning: unused variable 'pal_ptr' > [-Wunused

Re: [PATCH] fbdev: c2p: Use BUILD_BUG() instead of custom solution

2020-02-11 Thread Bartlomiej Zolnierkiewicz
again. I don't mind, lets keep it m68k tree (it should not cause any conflicts with other fbdev changes). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] video: fbdev: sh_mobile_lcdcfb: fix sparse warnings about using incorrect types

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 3:08 PM, Geert Uytterhoeven wrote: > On Thu, Jan 16, 2020 at 3:51 PM Bartlomiej Zolnierkiewicz > wrote: >> Use ->screen_buffer instead of ->screen_base to fix sparse warnings. >> >> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate scr

Re: [PATCH 1/2] video: fbdev: w100fb: fix sparse warnings

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 7:57 PM, Sam Ravnborg wrote: > On Thu, Jan 16, 2020 at 03:53:20PM +0100, Bartlomiej Zolnierkiewicz wrote: >> * Add missing __iomem annotations where needed. >> * Make w100fb_probe() static. >> * Return NULL pointer (instead of using plain integer) in &g

Re: [PATCH 2/2] video: fbdev: sh_mobile_lcdcfb: add COMPILE_TEST support

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 3:08 PM, Geert Uytterhoeven wrote: > On Thu, Jan 16, 2020 at 3:52 PM Bartlomiej Zolnierkiewicz > wrote: >> Add COMPILE_TEST support to sh_mobile_lcdcfb driver for better compile >> testing coverage. >> >> Signed-off-by: Bartlomiej Zolnierkiewicz >

Re: [PATCH] video: fbdev: arcfb: add COMPILE_TEST support

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 7:57 PM, Sam Ravnborg wrote: > On Thu, Jan 16, 2020 at 03:49:07PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Add COMPILE_TEST support to arcfb driver for better compile >> testing coverage. >> >> Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-by: Sam R

Re: [PATCH -next] video: fbdev: pxa168fb: remove unnecessary platform_get_irq

2020-03-02 Thread Bartlomiej Zolnierkiewicz
On 1/17/20 4:22 AM, YueHaibing wrote: > commit 640ba2444fa9 ("drivers/video/pxa168fb.c: use devm_ functions") > left behind this, it can be removed. > > Signed-off-by: YueHaibing Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&

Re: [PATCH 4/4] video: fbdev: remove set but not used variable 'bytpp'

2020-03-02 Thread Bartlomiej Zolnierkiewicz
but-set-variable] > > It is never used, and so can be removed. > > Signed-off-by: yu kuai Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/radeon_base.c | 3

<    1   2   3   4   5   6   7   >