Re: [PATCH 0/8] video: fbdev: au1200fb: Fix error handling path of 'au1200fb_drv_probe()'

2017-11-09 Thread Bartlomiej Zolnierkiewicz
- perhaps 'successful'? #4: 'au1200fb_drv_probe()' can not fail after a succesful call to ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 1630d85a8312 ("au1200fb: fix hardcoded IRQ")

Re: [PATCH] video: fbdev: remove dead igafb driver

2017-11-09 Thread Bartlomiej Zolnierkiewicz
On Wednesday, October 18, 2017 04:45:31 PM Ondrej Zary wrote: > On Wednesday 18 October 2017, David Miller wrote: > > From: John Paul Adrian Glaubitz > > Date: Wed, 18 Oct 2017 15:14:27 +0200 > > > > > Hi Bartlomiej! > > > > > > On 10/1

Re: [PATCH v8 3/5] Documentation: Add device tree binding for Goldfish FB driver

2017-11-09 Thread Bartlomiej Zolnierkiewicz
inic > Signed-off-by: Goran Ferenc > Signed-off-by: Aleksandar Markovic > Acked-by: Rob Herring Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mai

Re: [PATCH] video/fbdev/dnfb: Use common error handling code in dnfb_probe()

2017-11-09 Thread Bartlomiej Zolnierkiewicz
using the Coccinelle software. > > Signed-off-by: Markus Elfring Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.or

Re: [PATCH] video: fbdev: intelfb: remove redundant variables

2017-11-09 Thread Bartlomiej Zolnierkiewicz
to > 'f_best' is never read > > Signed-off-by: Colin Ian King Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt

2017-11-09 Thread Bartlomiej Zolnierkiewicz
On Monday, November 06, 2017 04:31:18 PM Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zo

Re: [PATCH] video: fbdev: aty: radeon_pm: mark expected switch fall-throughs

2017-11-09 Thread Bartlomiej Zolnierkiewicz
On Monday, November 06, 2017 04:40:01 PM Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zo

Re: [PATCH] video: fbdev: cirrusfb: mark expected switch fall-throughs

2017-11-09 Thread Bartlomiej Zolnierkiewicz
ine, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dr

Re: [PATCH] video: fbdev: sis_main: mark expected switch fall-throughs

2017-11-09 Thread Bartlomiej Zolnierkiewicz
115027 > Addresses-Coverity-ID: 115028 > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel

Re: [PATCH] video: fbdev: Convert timers to use timer_setup()

2017-11-09 Thread Bartlomiej Zolnierkiewicz
u_debug_timedout, 0); > + pxa3xx_gcu_debug_timedout(NULL); > } > #else > static inline void pxa3xx_gcu_init_debug_timer(void) {} Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: pxa3xx_gcu: Convert timers to use timer_setup()

2017-11-10 Thread Bartlomiej Zolnierkiewicz
se of the "priv" variable in QERROR(), since it was > pointing to struct timer_list, not struct pxa3xx_gcu_priv. > > Cc: Bartlomiej Zolnierkiewicz > Cc: "Gustavo A. R. Silva" > Cc: Himanshu Jha > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger.k

Re: [PATCH] video: fbdev: Convert timers to use timer_setup()

2017-11-10 Thread Bartlomiej Zolnierkiewicz
On Thursday, November 09, 2017 10:40:13 AM Kees Cook wrote: > On Thu, Nov 9, 2017 at 9:08 AM, Bartlomiej Zolnierkiewicz [...] > > [ Please compile these timer changes with PXA3XX_GCU_DEBUG and > > PXA3XX_GCU_DEBUG_TIMER defined. ] > > Hm, these appear to be manual kno

Re: [PATCH] fbcon: Initialize ops->info early

2017-11-13 Thread Bartlomiej Zolnierkiewicz
early, but keep the additional assignment > in con2fb_acquire_newinfo() to support console remapping at runtime. > > Cc: Kees Cook > Signed-off-by: Thierry Reding Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electr

Re: Regression in Linux next-20171113 with fbdev timer conversion

2017-11-13 Thread Bartlomiej Zolnierkiewicz
> 1fa0: 005280ea 005280eb 005f > 1fc0: 005280e4 004f9511 00517830 005169a0 00517240 005169a0 > 1fe0: 0001 bed595c0 bed595e0 b6f2e9bc 2010 > Code: e1a002a0 e0811100 e1a03312 ee070fba (e1912

Re: [PATCH] video: fbdev: sm501fb: fix potential null pointer dereference on fbi

2017-11-17 Thread Bartlomiej Zolnierkiewicz
nce after the null > pointer check. > > Detected by CoverityScan, CID#1461301 ("Dereference before null check") > > Signed-off-by: Colin Ian King Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsu

Re: [PATCH] OMAPFB: prevent buffer underflow in omapfb_parse_vram_param()

2017-11-17 Thread Bartlomiej Zolnierkiewicz
On Tuesday, November 14, 2017 09:12:28 AM Dan Carpenter wrote: > We cap the upper bound of "fbnum" but we also need to check for > negatives or make the type unsigned. > > Signed-off-by: Dan Carpenter Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zoln

[GIT PULL] fbdev changes for v4.15

2017-11-20 Thread Bartlomiej Zolnierkiewicz
(the resolution is trivial, just remove the file). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the

Re: [PATCH v3 0/4] Fixes for omapdrm on OpenPandora and GTA04

2017-12-01 Thread Bartlomiej Zolnierkiewicz
> 3 can be applied when 1 & 2 are in. The change in 4 could be applied > independently, but it conflicts with 3. > > Tony, how do you want to handle 3 and 4? I will push 1 and 2 to v4.16. I > don't think they are real issues, so I don't see a reason to push them > as

Re: [PATCH v7 0/7] drm/fbdev: Panel orientation connector property support

2017-12-01 Thread Bartlomiej Zolnierkiewicz
panels without needing quirks (like we do for 90 degree rotated screens). > > Bartlomiej, can we please have your Acked-by for merging patches 1, > 6 and 7 through the drm tree? Acked-by: Bartlomiej Zolnierkiewicz Given that you add (can be in a incremental patch) a

Re: [PATCH] video: fbdev: atmel_lcdfb: fix display-timings lookup

2017-12-29 Thread Bartlomiej Zolnierkiewicz
ort") > Cc: stable # 3.13 > Cc: Jean-Christophe PLAGNIOL-VILLARD > Signed-off-by: Johan Hovold Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ d

Re: [PATCH] video: fbdev: remove redundant self assignment of 'height'

2017-12-29 Thread Bartlomiej Zolnierkiewicz
On Thursday, November 23, 2017 10:55:53 AM Colin King wrote: > From: Colin Ian King > > The assignment of height to itself is redundant and can be removed. > Detected with Coccinelle. > > Signed-off-by: Colin Ian King Patch queued for 4.16, thanks. Best regards, -- Bartlom

Re: [PATCH] video/fbdev/wm8505fb: Delete an error message for a failed memory allocation in wm8505fb_probe()

2017-12-29 Thread Bartlomiej Zolnierkiewicz
one wm8505fb device in the system this change is okay). Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video/fbdev/vt8500lcdfb: Delete an error message for a failed memory allocation in vt8500lcd_probe()

2017-12-29 Thread Bartlomiej Zolnierkiewicz
there can be only one vt8500lcdfb device in the system this change is okay). Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/4] video-UDLFB: Adjustments for five function implementations

2017-12-29 Thread Bartlomiej Zolnierkiewicz
changed, 5 insertions(+), 18 deletions(-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

2017-12-29 Thread Bartlomiej Zolnierkiewicz
t; fb = kzalloc(sizeof(*fb), GFP_ATOMIC); > > - if (!fb) { > > - printk(KERN_ERR "stifb: Could not allocate stifb structure\n"); > > + if (!fb) > > return -ENODEV; > > - } > > > > info = &fb->info; &

Re: [PATCH 0/2] video: ssd1307fb: Adjustments for ssd1307fb_probe()

2017-12-29 Thread Bartlomiej Zolnierkiewicz
sage for a failed memory allocation This patch removes the information about the device for which the allocation fails. > Improve a size determination This patch depends on the earlier patch (which is not being merged) so please re-base it if you want it to be applied. Best regards, -- Bartlomiej

Re: [PATCH 0/5] video-SMSC UFX: Adjustments for five function implementations

2017-12-29 Thread Bartlomiej Zolnierkiewicz
ich should be dropped. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH V4 22/26] video: fbdev: intelfb: deprecate pci_get_bus_and_slot()

2018-01-03 Thread Bartlomiej Zolnierkiewicz
he remaining patches have the ACK except these. Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH V4 23/26] video: fbdev: nvidia: deprecate pci_get_bus_and_slot()

2018-01-03 Thread Bartlomiej Zolnierkiewicz
t; > pci_get_domain_bus_and_slot() function. > > > > Signed-off-by: Sinan Kaya > > Any feedback here ? most of the remaining patches have the ACK except these. Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland S

Re: [PATCH V4 24/26] video: fbdev: riva: deprecate pci_get_bus_and_slot()

2018-01-03 Thread Bartlomiej Zolnierkiewicz
Sinan Kaya > > Any feedback here, most of the remaining patches have the ACK except these? Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3] Fix loading of module radeonfb on PowerMac

2018-01-03 Thread Bartlomiej Zolnierkiewicz
printk( KERN_ERR "radeonfb (%s): cannot request region 2.\n", > pci_name(rinfo->pdev)); > goto err_release_pci0; > +#endif > } > > /* map the regions */ > @@ -2509,10 +2533,12 @@ static int radeonfb_pci_register(struct pci

Re: [PATCH 00/13] remove_conflicting_framebuffers() cleanup

2018-01-03 Thread Bartlomiej Zolnierkiewicz
maintainers had a chance to look at it. Also needs and ack from Bart for > the fbdev sides. For fbdev changes: Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2018-01-03 Thread Bartlomiej Zolnierkiewicz
| 4 ++-- > lib/test_firmware.c | 14 +--- > lib/test_kmod.c | 14 +--- > sound/soc/omap/mcbsp.c | 4 ++-- > 15 files changed, 49 insertions(+), 80 deletions(-) For fbdev changes: Acked-by: Bartlomiej Zolnierk

Re: [PATCH 2/2] fbdev: radeon: stop use ktime_get() for HZ calibration

2018-01-04 Thread Bartlomiej Zolnierkiewicz
clocksource cannot go backwards, but I'm > adding a check for zero-division in case of a bad clocksource. > > Signed-off-by: Arnd Bergmann Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Instit

Re: [PATCH v2] fbdev: pxa3xx: use ktime_get_ts64 for time stamps

2018-01-04 Thread Bartlomiej Zolnierkiewicz
hanging it to monotonic > time makes this more robust, the correct accessor for this is > ktime_get_ts64(). > > Signed-off-by: Arnd Bergmann Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___

Re: [PATCH] fbdev: au1200fb: delete duplicate header contents

2018-01-04 Thread Bartlomiej Zolnierkiewicz
for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] video: fbdev: omap2: Use PTR_ERR_OR_ZERO()

2018-01-04 Thread Bartlomiej Zolnierkiewicz
cripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-de

Re: [PATCH] fbdev: arm64 use __raw I/O memory api

2018-01-04 Thread Bartlomiej Zolnierkiewicz
On Thursday, November 30, 2017 04:17:22 PM Ji Zhang wrote: > Since arm64 also has __raw I/O accessors, add __aarch64__ in fb.h. > This is a supplement for commmit > 981409b25e2a99409b26daa67293ca1cfd5ea0a0 > > Signed-off-by: Ji Zhang Patch queued for 4.16, thanks. Best regards

Re: [PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset

2018-01-04 Thread Bartlomiej Zolnierkiewicz
oc-simple.cocci I've changed it to "Generate-by" to silence checkpatch.pl. > 0-day tested with no failures. > > Suggested-by: Luis R. Rodriguez > Signed-off-by: Himanshu Jha Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Z

Re: [0/4] video-UDLFB: Adjustments for five function implementations

2018-01-04 Thread Bartlomiej Zolnierkiewicz
ivers that support hardware that can have only one instance in the system (but it needs to be explicitly stated in the patch description and the patch needs to be reviewed by a someone else than the author). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&am

Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol

2019-02-13 Thread Bartlomiej Zolnierkiewicz via dri-devel
On 02/12/2019 09:42 AM, Lee Jones wrote: > On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote: > >> >> On 01/17/2019 05:19 PM, Daniel Thompson wrote: >>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote: >>>> We have two *_CLASS_DEVICE

Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol

2019-02-13 Thread Bartlomiej Zolnierkiewicz via dri-devel
On 02/13/2019 04:19 PM, Daniel Vetter wrote: > On Wed, Feb 13, 2019 at 4:04 PM Bartlomiej Zolnierkiewicz via > dri-devel wrote: >> >> >> On 02/12/2019 09:42 AM, Lee Jones wrote: >>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote: >>> >>>&

<    2   3   4   5   6   7