Re: [PATCH] drm/mediatek: dpi: fix NULL dereference in mtk_dpi_bridge_atomic_check

2021-07-21 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2021年7月12日 週一 下午4:08寫道: > > From: Frank Wunderlich > > bridge->driver_private is not set (NULL) so use bridge_to_dpi(bridge) > like it's done in bridge_atomic_get_output_bus_fmts Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/

Re: [PATCH] drm/mediatek: mtk-dpi: Set out_fmt from config if not the last bridge

2021-07-22 Thread Chun-Kuang Hu
Hi, Hsin-yi: Hsin-Yi Wang 於 2021年7月12日 週一 下午5:47寫道: > > atomic_get_output_bus_fmts() is only called when the bridge is the last > element in the bridge chain. > > If mtk-dpi is not the last bridge, the format of output_bus_cfg is > MEDIA_BUS_FMT_FIXED, and mtk_dpi_dual_edge() will fail to write c

Re: [PATCH v4] drm/mediatek: Fix cursor plane didn't update

2021-07-22 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月22日 週四 上午9:47寫道: > > The cursor plane should use the current plane state in atomic_async_update > because it would not be the new plane state in the global atomic state > since _swap_state happened when those hook are run. > > Fix cursor plane issue by below modif

Re: [PATCH v3, 1/3] drm/mediatek: Separate aal module

2021-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月16日 週五 下午2:32寫道: > > mt8183 aal has no gamma function Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu > -

Re: [PATCH v3, 2/3] drm/mediatek: add mt8183 aal support

2021-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月16日 週五 下午2:32寫道: > > This patch add mt8183 private data Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu >

Re: [PATCH 13/14] drm/mediatek: add pseudo ovl support for MT8195

2021-07-24 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年7月22日 週四 下午5:46寫道: > > Add pseudo ovl module files: My English is not good. The word 'pseudo' seems like 'looks like but indeed not the same'. I think the 'real' ovl also has rdma and mixer inside it, so I prefer to treat these two ovl as different kind of ovl, not a

Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-25 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2021年7月25日 週日 上午1:06寫道: > > >On 12.07.21 19:16, Frank Wunderlich wrote: > >> Hi, > >> > >> it turns out that problem is the read+or of the new value > >> > >> i reverted my patch and changed > >> > >> reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val;

Re: [PATCH v2 13/14] drm/mediatek: add ETHDR support for MT8195

2021-07-27 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年7月22日 週四 下午5:46寫道: > > Add ETHDR module files: > ETHDR is designed for HDR video and graphics conversion in the external > display path. It handles multiple HDR input types and performs tone > mapping, color space/color format conversion, and then combines > different

Re: [PATCH 7/9] phy: phy-mtk-hdmi: convert to devm_platform_ioremap_resource

2021-07-30 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2021年7月28日 週三 下午3:59寫道: > > Use devm_platform_ioremap_resource to simplify code Acked-by: Chun-Kuang Hu > > Signed-off-by: Chunfeng Yun > --- > drivers/phy/mediatek/phy-mtk-hdmi.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletion

Re: [PATCH 8/9] phy: phy-mtk-mipi-dsi: remove dummy assignment of error number

2021-07-30 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2021年7月28日 週三 下午3:59寫道: > > Return the error number directly without assignment Acked-by: Chun-Kuang Hu > > Signed-off-by: Chunfeng Yun > --- > drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletion

Re: [PATCH 9/9] phy: phy-mtk-mipi-dsi: convert to devm_platform_ioremap_resource

2021-07-30 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2021年7月28日 週三 下午3:59寫道: > > Use devm_platform_ioremap_resource to simplify code Acked-by: Chun-Kuang Hu > > Signed-off-by: Chunfeng Yun > --- > drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deleti

Re: [PATCH v5 5/6] drm/mediatek: add DSC support for mt8195

2021-07-30 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月30日 週五 上午1:07寫道: > > Add DSC into mtk_drm_ddp_comp to support for mt8195. > > DSC is designed for real-time systems with real-time compression, > transmission, decompression and display. > The DSC standard is a specification of the algorithms used for > compressin

Re: [PATCH v5 6/6] drm/mediatek: add MERGE support for mt8195

2021-07-31 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月30日 週五 上午1:07寫道: > > Add MERGE module file: > > MERGE module is used to merge two slice-per-line inputs > into one side-by-side output. > > Signed-off-by: jason-jh.lin > --- > This patch is base on [1] > > [1]add mt8195 SoC DRM binding > - https://patchwork.kerne

Re: [PATCH v5 1/6] arm64: dts: mt8195: add display node for vdosys0

2021-07-31 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月30日 週五 上午1:07寫道: > > Add display node for vdosys0. > > Signed-off-by: jason-jh.lin > --- > This patch is based on [1][2][3][4] > > [1]arm64: dts: Add Mediatek SoC MT8195 and evaluation board dts and Makefile > - > https://patchwork.kernel.org/project/linux-media

Re: [PATCH v2 2/5] dt-bindings: mediatek: display: Change format to yaml

2021-07-31 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月29日 週四 下午11:49寫道: > > Change mediatek,dislpay.txt to mediatek,display.yaml > > Signed-off-by: jason-jh.lin > --- > .../display/mediatek/mediatek,disp.txt| 219 - > .../display/mediatek/mediatek,disp.yaml | 432 ++ > 2 files

Re: [PATCH v4 2/2] dt-bindings: mediatek: add force_dsi_end_without_null

2021-08-01 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年8月1日 週日 下午12:06寫道: Move this patch before the patch "drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift", and this patch's title should be "dt-bindings: drm/bridge: anx7625: add force_dsi_end_without_null" Regards, Chun-Kuang. > > The

Re: [PATCH v5] drm/mediatek: add dither 6 setting

2021-08-02 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月20日 週二 下午2:30寫道: > > dither 6 setting is missed in a6b7c98afdca > bit 1 is lfsr_en( "Enables LFSR-type dithering"), need enable > bit 2 is rdither_en(Enables running order dithering), need disable > > Fixes: a6b7c98afdca(drm/mediatek: add mtk_dither_set_commo

Re: [PATCH v3] drm/mediatek: clear pending flag when cmdq packet is done.

2021-08-02 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年8月2日 週一 下午3:11寫道: > > In cmdq mode, packet may be flushed before it is executed, so > the pending flag should be cleared after cmdq packet is done. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 51 > ++

Re: [PATCH v2 7/7] drm/mediatek: mtk_dsi: Reset the dsi0 hardware

2021-08-02 Thread Chun-Kuang Hu
ption, also is not needed on all of them, the reset is optional, > so the change is compatible with all boards. Acked-by: Chun-Kuang Hu > > Cc: Jitao Shi > Suggested-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > (no changes since v1) > > driver

Re: [PATCH] drm/mediatek: force hsa hsa hfp packets multiple of line num to avoid screen shift

2021-04-07 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年4月7日 週三 下午10:37寫道: > > The bridge chip ANX7625 require the line packets ending at the sametime > or ANX7625 will shift the screen. > > Change-Id: Ia324ad28fbff54140feedb9a1d6bfb2b246d0447 > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 12

Re: [PATCH] gpu/drm: mediatek: hdmi: check for valid modes on MT8167

2021-04-09 Thread Chun-Kuang Hu
Hi, Neil: Neil Armstrong 於 2021年4月9日 週五 下午4:43寫道: > > On MT8167, only CEA modes and anything using a clock below 148500 is > supported for HDMI. This change adds some checks to make sure the > video format is OK for MT8167. I think this patch should be separated to 3 patches. check CEA mode, che

Re: [PATCH -next] drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init()

2021-04-12 Thread Chun-Kuang Hu
viewed-by: Chun-Kuang Hu > > Reported-by: Hulk Robot > Signed-off-by: Wang Li > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/me

Re: [PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"

2021-04-13 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年4月12日 週一 下午7:19寫道: > > This reverts commit f83b03fc727ab56a77e68713d6e40299698f3c9f. > > Signed-off-by: Yongqiang Niu > --- > Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Docume

Re: [PATCH 1/2] drm/mediatek: set panel orientation before drm_dev_register().

2021-04-20 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年4月20日 週二 下午5:05寫道: > > On Fri, Apr 9, 2021 at 12:53 PM Hsin-Yi Wang wrote: > > > > drm_dev_register() sets connector->registration_state to > > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > > drm_connector_set_panel_orientation() is first called afte

Re: [PATCH 3/4] drm/mediatek: fine tune the dsi panel's power sequence

2021-04-23 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年4月20日 週二 下午9:26寫道: > > Add the drm_panel_prepare_power and drm_panel_unprepare_power control. > Turn on panel power(drm_panel_prepare_power) and control before dsi > enable. And then dsi enable, send dcs cmd in drm_panel_prepare, last > turn on backlight. Please descr

Re: [PATCH 4/4] drm/mediatek: add dsi module reset driver

2021-04-23 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年4月20日 週二 下午9:26寫道: > > Reset dsi HW to default when power on. Prevent the setting differet > between bootloader and kernel. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 36 +- > 1 file changed, 35 insertions(+)

Re: [PATCH v3 3/5] gpu/drm: mediatek: hdmi: add check for CEA modes only

2021-04-23 Thread Chun-Kuang Hu
Hi, Neil: Neil Armstrong 於 2021年4月19日 週一 下午3:33寫道: > > Some SoCs like the MT8167 are not validated and supported for HDMI modes > out of HDMI CEA modes, so add a configuration boolean to filter out > non-CEA modes. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Fabien Paren

Re: [PATCH v3 4/5] gpu/drm: mediatek: hdmi: add optional limit on maximal HDMI mode clock

2021-04-23 Thread Chun-Kuang Hu
Hi, Neil: Neil Armstrong 於 2021年4月19日 週一 下午3:33寫道: > > Some SoCs like the MT8167 have a hard limit on the maximal supported HDMI TMDS > clock, so add a configuration value to filter out those modes. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Fabien Parent > Signed-off-

Re: [PATCH v3 5/5] gpu/drm: mediatek: hdmi: add MT8167 configuration

2021-04-23 Thread Chun-Kuang Hu
Hi, Neil: Neil Armstrong 於 2021年4月19日 週一 下午3:33寫道: > > The MT8167 SoC have a hard limit on the maximal supported HDMI TMDS clock, > and is not validated and supported for HDMI modes out of HDMI CEA modes, > so add a configuration entry linked to the MT8167 compatible. Reviewed-by: C

Re: [PATCH v3 2/3] drm/mediatek: init panel orientation property

2021-04-27 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年4月27日 週二 下午12:49寫道: > > Init panel orientation property after connector is initialized. Let the > panel driver decides the orientation value later. > > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH 1/2] drm/mediatek: move page flip handle into cmdq cb

2021-04-30 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年5月1日 週六 上午11:13寫道: > > move page flip handle into cmdq cb > irq callback will before cmdq flush ddp register > into hardware, that will cause the display frame page > flip event before it realy display out time After apply patch [1], we don't need to care abou

Re: [PATCH 2/2] drm/mediatek: clear pending flag when cmdq packet is done.

2021-04-30 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年5月1日 週六 上午11:13寫道: > > In cmdq mode, packet may be flushed before it is executed, so > the pending flag should be cleared after cmdq packet is done. > > Signed-off-by: CK Hu > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 57

Re: [PATCH v6 5/7] drm/mediatek: add DSC support for mediatek-drm

2021-08-06 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月6日 週五 上午4:52寫道: > > DSC is designed for real-time systems with real-time compression, > transmission, decompression and display. > The DSC standard is a specification of the algorithms used for > compressing and decompressing image display streams, including > the

Re: [PATCH v6 7/7] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

2021-08-06 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月6日 週五 上午4:52寫道: > > Add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: jason-jh.lin > --- > This patch is base on [1] > > [1] dt-bindings: mediatek: display: add mt

Re: [PATCH v6 6/7] drm/mediatek: add MERGE support for mediatek-drm

2021-08-06 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月6日 週五 上午4:52寫道: > > Add MERGE engine file: > MERGE module is used to merge two slice-per-line inputs > into one side-by-side output. > > Signed-off-by: jason-jh.lin > --- > This patch is base on [1] > > [1] dt-bindings: mediatek: display: add mt8195 SoC binding >

[PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-08-08 Thread Chun-Kuang Hu
These refinements include using standard mailbox callback interface, timeout detection, and a fixed cmdq_handle. Changes in v2: 1. Define mtk_drm_cmdq_pkt_create() and mtk_drm_cmdq_pkt_destroy() when CONFIG_MTK_CMDQ is reachable. Chun-Kuang Hu (4): drm/mediatek: Use mailbox rx_callback

[PATCH v2 1/4] drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb

2021-08-08 Thread Chun-Kuang Hu
rx_callback is a standard mailbox callback mechanism and could cover the function of proprietary cmdq_task_cb, so use the standard one instead of the proprietary one. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 16 +--- 1 file changed, 13 insertions

[PATCH v2 2/4] drm/mediatek: Remove struct cmdq_client

2021-08-08 Thread Chun-Kuang Hu
mbox_client to get struct mtk_drm_crtc. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 80 +++-- 1 file changed, 62 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index

[PATCH v2 3/4] drm/mediatek: Detect CMDQ execution timeout

2021-08-08 Thread Chun-Kuang Hu
CMDQ is used to update display register in vblank period, so it should be execute in next vblank. If it fail to execute in next 2 vblank, tiemout happen. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions

[PATCH v2 4/4] drm/mediatek: Add cmdq_handle in mtk_crtc

2021-08-08 Thread Chun-Kuang Hu
One mtk_crtc need just one cmdq_handle, so add one cmdq_handle in mtk_crtc to prevent frequently allocation and free of cmdq_handle. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 28 - 1 file changed, 18 insertions(+), 10 deletions(-) diff

Re: [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled

2021-08-09 Thread Chun-Kuang Hu
Hi, Thomas: Thomas Zimmermann 於 2021年6月25日 週五 下午4:22寫道: > > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in mediatek. > Acked-by: Chun-Kuang Hu > Signed-off-by: Thomas Zimmermann > Reviewed-by: Laurent Pinch

Re: [PATCH] drm/mediatek: Implement mmap as GEM object function

2021-08-09 Thread Chun-Kuang Hu
Hi, Thomas: Thomas Zimmermann 於 2021年6月24日 週四 下午5:01寫道: > > Moving the driver-specific mmap code into a GEM object function allows > for using DRM helpers for various mmap callbacks. > > The respective mediatek functions are being removed. The file_operations > structure fops is now being created

Re: [PATCH v2 5/5] drm/mediatek: Add support for main DDP path on MT8167

2021-08-09 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > Add the main (DSI) drm display path for MT8167. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Fabie

Re: [PATCH v2 2/5] dt-bindings: display: mediatek: dsi: add documentation for MT8167 SoC

2021-08-09 Thread Chun-Kuang Hu
Hi, Fabien: Fabien Parent 於 2020年10月23日 週五 下午9:31寫道: > > Add binding documentation for the MT8167 SoC. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Fabien

Re: [PATCH] drm/mediatek: Test component initialization earlier in the function mtk_drm_crtc_create

2021-08-09 Thread Chun-Kuang Hu
Hi, Dafna: Dafna Hirschfeld 於 2021年7月13日 週二 上午2:12寫道: > > The initialization is currently tested in a later stage in > the function for no reason. > In addition, the test '!comp' will never fail since comp is > set with the '&' operator. Instead, test if a comp was not > initialized by testing "!

Re: [PATCH v6 4/7] drm/mediatek: adjust to the alphabetic order for mediatek-drm

2021-08-09 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月6日 週五 上午4:52寫道: > > 1. Adjust to the alphabetic order for the define, function, struct >and array in mediatek-drm driver > 2. Remove the unsed define in mtk_drm_ddp_comp.c Separate the 2nd part to another patch. > > Signed-off-by: jason-jh.lin > --- > driv

Re: [PATCH v6 1/1] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift

2021-08-09 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年8月8日 週日 下午9:41寫道: > > The bridge chip ANX7625 requires the packets on lanes aligned at the end, > or ANX7625 will shift the screen. In anx7625_attach_dsi(), it call mipi_dsi_attach(), and it call into mtk_dsi_host_attach(). I would like to pass this information from a

[GIT PULL] mediatek drm fixes for 5.14

2021-08-09 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Fix dpi bridge bug. 2. Fix cursor plane no update. Regards, Chun-Kuang. The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3: Linux 5.14-rc1 (2021-07-11 15:07:40 -0700) are available in the Git repository at: https://git.kernel.

Re: [PATCH v2] drm/mediatek: add AAL output size configuration

2021-08-11 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月10日 週二 上午10:55寫道: > > To avoid the output width and height is incorrect, > AAL_OUTPUT_SIZE configuration should be set. Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fix

Re: [PATCH v2] drm/mediatek: Add component_del in OVL and COLOR remove function

2021-08-11 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月10日 週二 下午12:02寫道: > > Add component_del in OVL and COLOR remove function. Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang. > > Fixes: ff1395609

Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-08-11 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2021年8月9日 週一 上午7:47寫道: > > These refinements include using standard mailbox callback interface, > timeout detection, and a fixed cmdq_handle. For this series, applied to mediatek-drm-next [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.g

Re: [PATCH v4] drm/mediatek: clear pending flag when cmdq packet is done.

2021-08-11 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年8月11日 週三 上午9:48寫道: > > In cmdq mode, packet may be flushed before it is executed, so > the pending flag should be cleared after cmdq packet is done. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/li

[GIT PULL] mediatek drm next for 5.15

2021-08-15 Thread Chun-Kuang Hu
p as GEM object function. 3. Add support for MT8167. 4. Test component initialization earlier in the function mtk_drm_crtc_create. 5. CMDQ refinement. ---- Chun-Kuang Hu (4): drm/mediatek: Use mailbox rx_callback instead of cmdq_tas

[GIT PULL v2] mediatek drm next for 5.15

2021-08-16 Thread Chun-Kuang Hu
p as GEM object function. 3. Add support for MT8167. 4. Test component initialization earlier in the function mtk_drm_crtc_create. 5. CMDQ refinement. ---- Chun-Kuang Hu (4): drm/mediatek: Use mailbox rx_callback instead of cmdq_tas

Re: [GIT PULL] mediatek drm next for 5.15

2021-08-16 Thread Chun-Kuang Hu
t; that and resend? I've resent the v2 request. Sorry for the inconvenient. Regards, Chun-Kuang. > > Dave. > > On Mon, 16 Aug 2021 at 09:55, Chun-Kuang Hu wrote: > > > > Hi, Dave & Daniel: > > > > This includes: > > > > 1. MT8133 AAL su

[GIT PULL] mediatek drm fixes for 5.14-2

2021-08-18 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Fix AAL output size setting. 2. Delete component in remove function. Regards, Chun-Kuang. The following changes since commit 1a64a7aff8da352c9419de3d5c34343682916411: drm/mediatek: Fix cursor plane no update (2021-07-22 22:57:52 +0800) are available in t

Re: [PATCH v8 01/13] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding

2021-08-19 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月19日 週四 上午10:23寫道: > > 1. There are 2 mmsys, namely vdosys0 and vdosys1 in mt8195. >Each of them is bound to a display pipeline, so add their >definition in mtk-mmsys documentation with 2 compatibles. > > 2. Add description for power-domain property. > > Si

Re: [PATCH v8 07/13] soc: mediatek: add mtk-mutex support for mt8195 vdosys0

2021-08-19 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月19日 週四 上午10:23寫道: > > Add mtk-mutex support for mt8195 vdosys0. > > Signed-off-by: jason-jh.lin > --- > drivers/soc/mediatek/mtk-mutex.c | 98 +++- > 1 file changed, 95 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/mediat

Re: [PATCH v8 08/13] drm/mediatek: remove unused define in mtk_drm_ddp_comp.c

2021-08-19 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月19日 週四 上午10:23寫道: > > Remove the unsed define in mtk_drm_ddp_comp.c Reviewed-by: Chun-Kuang Hu > > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 10 -- > 1 file changed, 10 deletions(-) > &g

Re: [PATCH v8 09/13] drm/mediatek: rename the define of register offset

2021-08-19 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月19日 週四 上午10:23寫道: > > Add DISP_REG prefix for the define of register offset to > make the difference from the define of register value. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mt

Re: [PATCH v8 10/13] drm/mediatek: adjust to the alphabetic order for mediatek-drm

2021-08-19 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月19日 週四 上午10:24寫道: > > Adjust to the alphabetic order for the define, function, struct > and array in mediatek-drm driver > > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 133 ++-- > drivers/gpu/drm/mediatek/mt

Re: [PATCH v8 11/13] drm/mediatek: add DSC support for mediatek-drm

2021-08-19 Thread Chun-Kuang Hu
eams, including > the specification of the syntax and semantics of the compressed > video bit stream. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 46 + > drivers/gpu/drm/mediatek/mtk_drm_

Re: [PATCH v3 02/15] dt-bindings: mediatek: add vdosys1 MERGE definition for mt8195

2021-08-19 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年8月18日 週三 下午5:18寫道: > > Add vdosys1 MERGE definition. > > Signed-off-by: Nancy.Lin > --- > .../devicetree/bindings/display/mediatek/mediatek,merge.yaml| 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/

Re: [PATCH v8 12/13] drm/mediatek: add MERGE support for mediatek-drm

2021-08-20 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年8月19日 週四 上午10:23寫道: > > Add MERGE engine file: > MERGE module is used to merge two slice-per-line inputs > into one side-by-side output. > > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/Makefile | 1 + > drivers/gpu/drm/mediatek/mtk_dis

Re: [PATCH v3 15/15] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

2021-08-20 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年8月18日 週三 下午5:18寫道: > > Add driver data of mt8195 vdosys1 to mediatek-drm and modify drm for > multi-mmsys support. The two mmsys (vdosys0 and vdosys1) will bring > up two drm drivers, only one drm driver register as the drm device. > Each drm driver binds its own compo

Re: [PATCH v8 03/13] dt-bindings: mediatek: add mediatek, dsc.yaml for mt8195 SoC binding

2021-08-21 Thread Chun-Kuang Hu
$id: http://devicetree.org/schemas/display/mediatek/mediatek,dsc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: mediatek display DSC controller > + > +maintainers: > + - CK Hu According to [1], the maintainer should be Chun-Kuang H

Re: [PATCH v3 13/15] drm/mediatek: add ovl_adaptor support for MT8195

2021-08-21 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年8月18日 週三 下午5:19寫道: > > Add ovl_adaptor driver for MT8195. > Ovl_adaptor is an encapsulated module and designed for simplified > DRM control flow. This module is composed of 8 RDMAs, 4 MERGEs and > an ETHDR. Two RDMAs merge into one layer, so this module support 4 > lay

Re: [PATCH v3 15/15] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

2021-08-21 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年8月18日 週三 下午5:18寫道: > > Add driver data of mt8195 vdosys1 to mediatek-drm and modify drm for > multi-mmsys support. The two mmsys (vdosys0 and vdosys1) will bring > up two drm drivers, only one drm driver register as the drm device. > Each drm driver binds its own compo

Re: [PATCH v3 3/7] dt-bindings: display: mediatek: add dsi reset optional property

2021-08-25 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2021年8月25日 週三 下午6:26寫道: > > Update device tree binding documentation for the dsi to add the optional > property to reset the dsi controller. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Rob Herring >

[PATCH] drm/mediatek: crtc: Make config-updating atomic

2021-03-13 Thread Chun-Kuang Hu
While updating config, the irq would occur and get the partial config, so use variable config_updating to make updating atomic. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a

Re: [PATCH] gpu: drm: mediatek: delete redundant printing of return value

2021-03-13 Thread Chun-Kuang Hu
Hi, Wang: Wang Qing 於 2021年3月13日 週六 下午3:48寫道: > > platform_get_irq() has already checked and printed the return value, > the printing here is nothing special, it is not necessary at all. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/

Re: [PATCH] drm/mediatek: fine tune the data lane trail by project dts

2021-03-17 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年2月1日 週一 上午11:48寫道: > > Some panels or bridges require customized hs_da_trail time. > So add a property in devicetree for this panels and bridges. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 10 +- > 1 file changed, 9 insertions(+

Re: [PATCH v3, 4/8] soc: mediatek: mmsys: add component OVL_2L2

2021-03-22 Thread Chun-Kuang Hu
Hi, Matthias: Chun-Kuang Hu 於 2020年12月29日 週二 下午11:23寫道: > > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月28日 週一 下午4:37寫道: > > > > This patch add component OVL_2L2 > > Reviewed-by: Chun-Kuang Hu How do you think about this patch? One drm patch [1] depe

Re: [PATCH v4, 08/10] soc: mediatek: mmsys: add component RDMA4

2021-03-22 Thread Chun-Kuang Hu
Hi, Matthias: Yongqiang Niu 於 2021年1月5日 週二 上午11:07寫道: > > This patch add component RDMA4 > > Signed-off-by: Yongqiang Niu > Reviewed-by: Chun-Kuang Hu How do you think about this patch? One drm patch [1] depends on this patch. [1] https://patchwork.kernel.org/project/linux

Re: [PATCH] MAINTAINERS: Add linux-mediatek ML for drm Mediatek drivers

2021-03-25 Thread Chun-Kuang Hu
> Signed-off-by: Dafna Hirschfeld > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9e876927c60d..8260bc5afe66 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5963,6 +5963,7 @@ DRM DRIVERS FOR

Re: [PATCH] drm/mediatek: crtc: Make config-updating atomic

2021-03-29 Thread Chun-Kuang Hu
Applied to mediatek-drm-next [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. Chun-Kuang Hu 於 2021年3月13日 週六 下午5:43寫道: > > While updating config, the irq would occur and get the partial > config, so use

Re: [PATCH] drm/mediatek: Add missing MODULE_DEVICE_TABLE()

2021-03-31 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2021年3月30日 週二 下午5:43寫道: > > Hi, > > On 3/2/21 12:07, Enric Balletbo i Serra wrote: > > From: Boris Brezillon > > > > This patch adds the missing MODULE_DEVICE_TABLE definitions on different > > Mediatek drivers which generates correct modalias for automatic lo

Re: [PATCH v3 0/2] drm/mediatek: Don't support hdmi connector creation

2021-04-01 Thread Chun-Kuang Hu
Hi, Dafna: Dafna Hirschfeld 於 2021年3月30日 週二 下午7:09寫道: > > commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") > broke the display support for elm device since mtk_dpi calls > drm_bridge_attach with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR > while mtk_hdmi does not yet suppo

[GIT PULL] mediatek drm next for 5.13

2021-04-05 Thread Chun-Kuang Hu
connector creation. Boris Brezillon (1): drm/mediatek: Add missing MODULE_DEVICE_TABLE() Chun-Kuang Hu (1): drm/mediatek: crtc: Make config-updating atomic Dafna Hirschfeld (3): MAINTAINERS: Add linux-mediatek ML for drm Mediatek drivers

Re: [PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-14 Thread Chun-Kuang Hu
Rob Herring 於 2021年1月15日 週五 上午3:11寫道: > > On Mon, 11 Jan 2021 15:43:37 +0800, Yongqiang Niu wrote: > > add description for postmask > > postmask is used control round corner for display frame > > > > Signed-off-by: Yongqiang Niu > > --- > > Documentation/devicetree/bindings/display/mediatek/medi

Re: [PATCH v3, 11/15] drm/mediatek: fix aal size config

2021-01-14 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年1月11日 週一 下午3:48寫道: > > the orginal setting is not correct, fix it follow hardware data sheet. > if keep this error setting, mt8173/mt8183 display ok > but mt8192 display abnormal. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm

Re: [PATCH v9, 05/11] drm/mediatek: add fifo_size into rdma private data

2021-01-14 Thread Chun-Kuang Hu
Hi, Yongqiang: Chun-Kuang Hu 於 2021年1月7日 週四 下午6:05寫道: > > Hi, Yongqiang: > > Yongqiang Niu 於 2021年1月7日 週四 上午11:12寫道: > > > > Get the fifo size from device tree > > because each rdma in the same SoC may have different fifo size > > Reviewed-by: Chun-Kuang

Re: [PATCH v2 0/5] Share mtk mutex driver for both DRM and MDP

2021-01-19 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2021年1月7日 週四 上午7:17寫道: > > mtk mutex is a driver used by DRM and MDP [1], so this series move > mtk mutex driver from DRM folder to soc folder, so it could be used > by DRM and MDP. Applied [1/5] ~ [4/5] to mediatek-drm-next [1]. [1] https://git.kernel.org/pub/scm/

Re: [PATCH v2 5/5] soc / drm: mediatek: Move mtk mutex driver to soc folder

2021-01-20 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2021年1月21日 週四 上午2:33寫道: > > On Thu, Jan 07, 2021 at 07:17:29AM +0800, Chun-Kuang Hu wrote: > > From: CK Hu > > > > mtk mutex is used by DRM and MDP driver, and its function is SoC-specific, > > so move it to soc folder. > >

Re: [PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

2021-01-20 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2021年1月21日 週四 上午2:27寫道: > > On Thu, Jan 07, 2021 at 07:17:27AM +0800, Chun-Kuang Hu wrote: > > From: CK Hu > > > > mtk mutex is used by both drm and mdp driver, so change disp/ddp term to > > mutex to show that it

Re: [PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

2021-01-21 Thread Chun-Kuang Hu
Matthias Brugger 於 2021年1月21日 週四 下午4:19寫道: > > On Thu, Jan 21, 2021 at 07:46:44AM +0800, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2021年1月21日 週四 上午2:27寫道: > > > > > > On Thu, Jan 07, 2021 at 07:17:27AM +0800, Chun-Kuang Hu wrote

Re: [PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

2021-01-30 Thread Chun-Kuang Hu
Hi, Matthias: Chun-Kuang Hu 於 2021年1月10日 週日 上午6:59寫道: > > Hi, Matthias: > > Chun-Kuang Hu 於 2020年12月3日 週四 上午7:59寫道: > > > > rx_callback is a standard mailbox callback mechanism and could > > cover the function of proprietary cmdq_task_cb, so it is better > >

Re: [PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > Current implementation of mtk_dither_set() cast dev data to > struct mtk_ddp_comp_dev. But other devices with different dev data > would also call this function. > > Separate necessary parameters out so other device components (dither, > gam

Re: [PATCH v13 4/8] drm/mediatek: separate gamma module

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > From: Yongqiang Niu > > mt8183 gamma module will different with mt8173 > separate gamma for add private data After I clean up all checkpatch error, applied to mediatek-drm-next [1]. Remember to clean up all checkpatch error before send out

Re: [PATCH v13 5/8] drm/mediatek: add has_dither private data for gamma

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > From: Yongqiang Niu > > Not all SoC has dither function in gamma module. > Add private data to control this function setting. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linu

Re: [PATCH v13 8/8] drm/mediatek: add support for mediatek SOC MT8183

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > From: Yongqiang Niu > > 1. add ovl private data > 2. add rdma private data > 3. add gamma privte data > 4. add main and external path module for crtc create Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/lin

Re: [PATCH v13 6/8] drm/mediatek: enable dither function

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午5:23寫道: > > From: Yongqiang Niu > > Enable dither function to improve the display quality for dither > supported bpc 4, 6, 8. For not supported bpc, use relay mode. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/d

Re: [PATCH v4 4/8] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: CK Hu 於 2021年1月29日 週五 下午4:21寫道: > > Hi, Hsin-Yi: > > On Fri, 2021-01-29 at 15:34 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase, without this patch, > > ovl will hang up when more than 1 layer enabled. > > Reviewed-by: C

Re: [PATCH v4 5/8] drm/mediatek: separate ccorr module

2021-01-30 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月29日 週五 下午3:35寫道: > > From: Yongqiang Niu > > ccorr ctm matrix bits will be different in mt8192 > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/Makefile | 3 +- > drivers/gpu/drm/mediatek/mtk_disp_cc

Re: [PATCH] drm/mediatek: enable dither function

2021-01-31 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年1月31日 週日 下午1:11寫道: > > From: Yongqiang Niu > > Enable dither function to improve the display quality. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > Previous version: > https:

Re: [PATCH] drm/mediatek: enable dither function

2021-02-01 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Chun-Kuang Hu 於 2021年2月1日 週一 上午12:20寫道: > > Hi, Hsin-Yi: > > Hsin-Yi Wang 於 2021年1月31日 週日 下午1:11寫道: > > > > From: Yongqiang Niu > > > > Enable dither function to improve the display quality. > > Reviewed-by: Chun-Kuang Hu > Applied

Re: [PATCH v6 4/8] drm/mediatek: separate ccorr module

2021-02-03 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月2日 週二 下午4:13寫道: > > From: Yongqiang Niu > > ccorr ctm matrix bits will be different in mt8192 Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang.

Re: [PATCH v6 5/8] drm/mediatek: Fix ccorr size config

2021-02-03 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月2日 週二 下午4:13寫道: > > From: Yongqiang Niu > > Fix setting to follow hardware datasheet. The original error setting > affects mt8192 display. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/

Re: [PATCH v6 6/8] drm/mediatek: add matrix_bits private data for ccorr

2021-02-03 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2021年2月2日 週二 下午4:14寫道: > > From: Yongqiang Niu > > Add matrix_bits and coeffs_precision to ccorr private data: > - matrix bits of mt8183 is 10 > - matrix bits of mt8192 is 11 Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/

[GIT PULL] mediatek drm next for 5.12

2021-02-03 Thread Chun-Kuang Hu
ex driver drm/mediatek: Automatically search unclaimed mtk mutex in mtk_mutex_get() soc / drm: mediatek: Move mtk mutex driver to soc folder Chun-Kuang Hu (2): drm/mediatek: Get CMDQ client register for all ddp component drm/mediatek: Use correct device pointer to get CM

  1   2   3   4   5   6   7   8   >