Re: [PATCH v6 03/16] dt-bindings: mediatek: add ethdr definition for mt8195

2021-10-15 Thread Chun-Kuang Hu
+$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek Ethdr Device Tree Bindings > + > +maintainers: > + - Chun-Kuang Hu > + - Philipp Zabel > + > +description: | > + ETHDR is designed for HDR video and graphics conversion in the external &g

Re: [PATCH v5 15/16] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support

2021-09-28 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年9月6日 週一 下午3:15寫道: > > MT8195 have two mmsys. Modify drm for MT8195 multi-mmsys support. > The two mmsys (vdosys0 and vdosys1) will bring up two drm drivers, > only one drm driver register as the drm device. > Each drm driver binds its own component. The first bind drm

Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-09-29 Thread Chun-Kuang Hu
+Jason: Hi, Enric: Please test Jason's series [1], [2]. Does these series fixes your problem? [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=554759 [2] https://patchwork.kernel.org/project/linux-mediatek/list/?series=554767 Regards, Chun-Kuang. Chun-Kuang Hu 於 2021年9月24

Re: [PATCH 1/3] drm/mediatek: Fix crash at using pkt->cl->chan in cmdq_pkt_finalize

2021-09-29 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月29日 週三 下午3:02寫道: > > Because mtk_drm_crtc_create_pkt didn't assign pkt->cl, it will > crash at using pkt->cl->chan in cmdq_pkt_finalize. > > So add struct cmdq_client and let mtk_drm_crtc instance define > cmdq_client as: > > struct mtk_drm_crtc { > /*

Re: [PATCH 2/3] drm/mediatek: Fix pkt buf alloc once but free many times

2021-09-29 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月29日 週三 下午3:02寫道: > > Because mtk_drm_crt_cmdq_pkt_create is called once > in mtk_drm_crtc_create, the pkt should not be destroy > at ddp_cmdq_cb. > > So move mtk_drm_crtc_pkt_destroy to mtk_drm_crtc_destroy. Reviewed-by: Chun-Kuang Hu >

Re: [PATCH 3/3] drm/mediatek: Fix cursor plane is not config when primary is updating

2021-09-29 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月29日 週三 下午3:02寫道: > > If cursor plane has updated but primary plane config task is not > finished, mtk_drm_crtc_update_config will call mbox_flush() to clear > all task in current GCE thread and let cursor plane re-send a new > GCE task with cursor + primary plane

Re: [PATCH v7 2/3] drm/mediatek: implment the dsi hs packets aligned

2021-09-29 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年9月16日 週四 上午6:31寫道: > > Some dsi devices require the packets on lanes aligned at the end, > or the screen will shift or scroll. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 10 ++

Re: [PATCH v11 13/16] drm/mediatek: adjust to the alphabetic order for mediatek-drm

2021-09-29 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月21日 週二 下午11:52寫道: > > Adjust to the alphabetic order for the define, function, struct > and array in mediatek-drm driver Reviewed-by: Chun-Kuang Hu > > Signed-off-by: jason-jh.lin > --- > rebase on series [1] > > [1] drm/mediatek: a

Re: [PATCH v11 12/16] drm/mediatek: rename the define of register offset

2021-09-29 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年9月21日 週二 下午11:52寫道: > > Add DISP_REG prefix for the define of register offset to > make the difference from the define of register value. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: jason-jh.lin > --- > rebase on series [1] > > [1

Re: [PATCH v11 14/16] drm/mediatek: add DSC support for mediatek-drm

2021-09-29 Thread Chun-Kuang Hu
eams, including > the specification of the syntax and semantics of the compressed > video bit stream. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: jason-jh.lin > --- > rebase on series [1] > > [1] drm/mediatek: add support for mediatek SOC MT8192 > - https://patchw

Re: [PATCH v1 4/4] drm/mediatek: add mt8195 hdmi TX support

2021-09-30 Thread Chun-Kuang Hu
Hi, Guillaume: This is a big patch, and I'm not familiar with this driver, so the review process would be long. So I tell you about how I review this patch, and if you could process according to my way, the process would be more short. 1. Find the common part of all hdmi driver. Even though

Re: [v2 PATCH 3/3] drm/mediatek: Fix cursor plane is not config when primary is updating

2021-09-30 Thread Chun-Kuang Hu
ursor + primary plane config to replace the unfinished > GCE task. > > So the plane config flag should not be cleared when mailbox callback > with a error status. Reviewed-by: Chun-Kuang Hu > > Fixes: 9efb16c2fdd6 ("drm/mediatek: Clear pending flag when cmdq packet is

Re: [v2 PATCH 1/3] drm/mediatek: Fix crash at using pkt->cl->chan in cmdq_pkt_finalize

2021-09-30 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2021年9月30日 週四 下午3:12寫道: > > Hi Jason, > > > Missatge de jason-jh.lin del dia dj., 30 > de set. 2021 a les 4:47: > > > > Because mtk_drm_crtc_create_pkt didn't assign pkt->cl, it will > > crash at using pkt->cl->chan in cmdq_pkt_finalize. > > > > So add struct

Re: [PATCH v3 6/6] drm/mediatek: Add mt8195 DisplayPort driver

2021-10-01 Thread Chun-Kuang Hu
Hi, Markus: Markus Schneider-Pargmann 於 2021年10月1日 週五 下午5:44寫道: > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC and a > according phy driver mediatek-dp-phy. > > It supports both functional units on the mt8195, the embedded > DisplayPort as well as the external DisplayPort

Re: [v2 PATCH 1/3] drm/mediatek: Fix crash at using pkt->cl->chan in cmdq_pkt_finalize

2021-10-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2021年9月30日 週四 下午9:48寫道: > > Hi Chun-Kuang, > > Missatge de Chun-Kuang Hu del dia dj., 30 de > set. 2021 a les 15:11: > > > > Hi, Enric: > > > > Enric Balletbo Serra 於 2021年9月30日 週四 下午3:12寫道: > > > > > >

Re: [PATCH 4/4] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2021-09-22 Thread Chun-Kuang Hu
Hi, Guillaume: Rob Herring 於 2021年9月7日 週二 下午10:51寫道: > > On Tue, 07 Sep 2021 10:37:21 +0200, Guillaume Ranquet wrote: > > Add Mediatek HDMI and HDMI-DDC bindings for MT8195 SoC. Move this patch before the driver patch which refer to this patch. > > > > Signed-off-by: Guillaume Ranquet > > ---

Re: [PATCH 3/4] dt-bindings: phy: Add binding for Mediatek MT8195 HDMI PHY

2021-09-22 Thread Chun-Kuang Hu
http://devicetree.org/schemas/phy/mediatek,hdmi-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek High Definition Multimedia Interface (HDMI) PHY binding for > mt8195 > + > +maintainers: > + - Chun-Kuang Hu > + - Philipp Zabe

Re: [PATCH v2, 1/1] mailbox: cmdq: add instruction time-out interrupt support

2021-10-04 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年9月30日 週四 下午9:18寫道: > > add time-out cycle setting to make sure time-out interrupt irq > will happened when instruction time-out for wait and poll > > Signed-off-by: Yongqiang Niu > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++ > 1 file changed,

Re: [PATCH v7 1/3] drm/dsi: transer dsi hs packet aligned

2021-10-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2021年9月16日 週四 上午6:31寫道: > > Some DSI devices reqire the hs packet starting and ending > at same time on all dsi lanes. So use a flag to those devices. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao Shi > --- > include/drm/drm_mipi_dsi.h | 2

Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-09-23 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2021年9月24日 週五 上午12:36寫道: > > Hi Chun-Kuang, > > Missatge de Chun-Kuang Hu del dia dt., 21 de > set. 2021 a les 15:15: > > > > Hi, Enric: > > > > Enric Balletbo Serra 於 2021年9月21日 週二 下午4:36寫道: > > > > > &

Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-09-21 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2021年9月21日 週二 下午4:36寫道: > > Hi Chun-Kuang, > > (again without html format, sorry for the noise) > > Missatge de Chun-Kuang Hu del dia dj., 12 > d’ag. 2021 a les 2:13: > > > > Chun-Kuang Hu 於 2021年8月9日 週一 上午7:47寫道: > >

[GIT PULL] mediatek drm fixes for 5.16

2021-12-19 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Perform NULL pointer check for mtk_hdmi_conf. Regards, Chun-Kuang. The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf: Linux 5.16-rc1 (2021-11-14 13:56:52 -0800) are available in the git repository at:

Re: [PATCH v2] drm/mediatek: Set default value for Panel Orientation connector prop.

2022-01-03 Thread Chun-Kuang Hu
Hi, Mark: Mark Yacoub 於 2021年12月30日 週四 上午2:44寫道: > > [Why] > Creating the prop uses UNKNOWN as the initial value, which is not a > supported value if the prop is to be supported. > > [How] > Set the panel orientation default value to NORMAL right after creating > the prop if no DSI panel exists.

Re: [PATCH] phy: mediatek: Fix missing check in mtk_mipi_tx_probe

2021-12-30 Thread Chun-Kuang Hu
Hi, Miaoqian: Miaoqian Lin 於 2021年12月24日 週五 下午4:21寫道: > > The of_device_get_match_data() function may return NULL. > Add check to prevent potential null dereference. > > Signed-off-by: Miaoqian Lin > --- > drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [PATCH v4] drm/mediatek: Fix mtk_cec_mask()

2022-01-03 Thread Chun-Kuang Hu
to the register. Reviewed-by: Chun-Kuang Hu > > Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") > > Cc: Zhiqiang Lin > Cc: CK Hu > Cc: Matthias Brugger > > Signed-off-by: Miles Chen > > --- > > Change since v1: > add Fixes tag > > Ch

Re: [PATCH 2/3] mailbox: add cmdq_mbox_flush to clear all task before suspend

2021-11-18 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年11月17日 週三 下午2:42寫道: > > CMDQ driver will occupy GCE clock to execute the task in GCE thread. > > So call cmdq_mbox_flush to clear all task in GCE thread before > CMDQ suspend. > > Signed-off-by: jason-jh.lin > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 9

Re: [PATCH v6 0/5] CMDQ refinement of Mediatek DRM driver

2021-11-17 Thread Chun-Kuang Hu
inter of >struct cmdq_client. > 3. Fix pkt buf alloc once but free many times. > > Changes in v2: > 1. Define mtk_drm_cmdq_pkt_create() and mtk_drm_cmdq_pkt_destroy() >when CONFIG_MTK_CMDQ is reachable. > > Chun-Kuang Hu (4): > drm/mediatek: Use mailbox rx_callback in

Re: [PATCH v7 20/20] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

2021-11-11 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > Add driver data of mt8195 vdosys1 to mediatek-drm and the sub driver. > > Signed-off-by: Nancy.Lin > --- > drivers/gpu/drm/mediatek/mtk_disp_merge.c | 4 ++ > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 13 ++--- >

Re: [PATCH v7 19/20] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support

2021-11-10 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > MT8195 have two mmsys. Modify drm for MT8195 multi-mmsys support. > The two mmsys (vdosys0 and vdosys1) will bring up two drm drivers, > only one drm driver register as the drm device. > Each drm driver binds its own component. The last bind

Re: [PATCH v10, 2/5] drm/mediatek: add component POSTMASK

2021-11-15 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年9月30日 週四 下午11:52寫道: > > This patch add component POSTMASK. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu

Re: [PATCH v10, 5/5] drm/mediatek: add support for mediatek SOC MT8192

2021-11-15 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年9月30日 週四 下午11:52寫道: > > add support for mediatek SOC MT8192 Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu

Re: [PATCH v10, 3/5] drm/mediatek: add component RDMA4

2021-11-15 Thread Chun-Kuang Hu
ongqiang Niu > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.

Re: [PATCH v10, 1/5] drm/mediatek: add component OVL_2L2

2021-11-15 Thread Chun-Kuang Hu
ongqiang Niu > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.

Re: [PATCH v6 7/7] drm/mediatek: Add mt8195 DisplayPort driver

2021-11-25 Thread Chun-Kuang Hu
Hi, Guillaume: This is a big patch, so I give some comment first. Guillaume Ranquet 於 2021年11月10日 週三 下午9:06寫道: > > From: Markus Schneider-Pargmann > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC and a > according phy driver mediatek-dp-phy. > > It supports both functional

Re: [PATCH v5 3/6] drm/mediatek: Detect CMDQ execution timeout

2021-11-17 Thread Chun-Kuang Hu
Hi, Fei: Fei Shao 於 2021年10月28日 週四 上午11:19寫道: > > Hi Chun-Kuang, > > On Thu, Oct 28, 2021 at 7:47 AM Chun-Kuang Hu wrote: > > > > Hi, Fei: > > > > Fei Shao 於 2021年10月27日 週三 下午5:32寫道: > > > > > > Hi Jason, > > > &g

Re: [PATCH v7 15/20] drm/mediatek: add display merge mute/unmute support for MT8195

2021-11-02 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > Add merge mute/unmute setting for MT8195. > MT8195 Vdosys1 merge1~merge4 support HW mute function. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > drivers/gpu/drm/mediatek/mtk_disp_merge.c | 23 +++

Re: [PATCH v7 12/20] drm/mediatek: add display MDP RDMA support for MT8195

2021-11-02 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > Add MDP_RDMA driver for MT8195. MDP_RDMA is the DMA engine of > the ovl_adaptor component. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > drivers/gpu/drm/mediatek/Makefile | 3 +- >

Re: [PATCH v7 14/20] drm/mediatek: add display merge start/stop API for cmdq support

2021-11-02 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > Add merge start/stop API for cmdq support. The ovl_adaptor merges > are configured with each drm plane update. Need to enable/disable > merge with cmdq making sure all the settings taken effect in the > same vblank. Reviewed-by

Re: [PATCH v7 13/20] drm/mediatek: add display merge advance config API for MT8195

2021-11-02 Thread Chun-Kuang Hu
l_adaptor merge control. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 ++ > drivers/gpu/drm/mediatek/mtk_disp_merge.c | 52 --- > 2 files changed, 48 insertions(+), 7 deletions(-) > >

Re: [PATCH v4 3/5] drm/mediatek: Detect CMDQ execution timeout

2021-10-26 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年10月26日 週二 下午1:29寫道: > > From: Chun-Kuang Hu > > CMDQ is used to update display register in vblank period, so > it should be execute in next 2 vblank. One vblank interrupt > before send message (occasionally) and one vblank interrupt > after

Re: [PATCH v4 1/5] drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb

2021-10-26 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年10月26日 週二 下午1:29寫道: > > From: Chun-Kuang Hu > > rx_callback is a standard mailbox callback mechanism and could cover the > function of proprietary cmdq_task_cb, so use the standard one instead of > the proprietary one. Reviewed-by: Chun-Kuang H

Re: [PATCH v4 5/5] drm/mediatek: Clear pending flag when cmdq packet is done

2021-10-26 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年10月26日 週二 下午1:29寫道: > > From: Yongqiang Niu > > In cmdq mode, packet may be flushed before it is executed, so > the pending flag should be cleared after cmdq packet is done. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Yongqiang Niu &

Re: [PATCH v4 2/5] drm/mediatek: Remove the pointer of struct cmdq_client

2021-10-26 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年10月26日 週二 下午1:29寫道: > > From: Chun-Kuang Hu > > In mailbox rx_callback, it pass struct mbox_client to callback > function, but it could not map back to mtk_drm_crtc instance > because struct cmdq_client use a pointer to struct mbox_client: >

Re: [PATCH v4 4/5] drm/mediatek: Add cmdq_handle in mtk_crtc

2021-10-26 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年10月26日 週二 下午1:29寫道: > > From: Chun-Kuang Hu > > One mtk_crtc need just one cmdq_handle, so add one cmdq_handle > in mtk_crtc to prevent frequently allocation and free of > cmdq_handle. > > Signed-off-by: Chun-Kuang Hu >

Re: [PATCH v5 4/6] drm/mediatek: Add cmdq_handle in mtk_crtc

2021-10-27 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年10月27日 週三 上午10:19寫道: > > From: Chun-Kuang Hu > > One mtk_crtc need just one cmdq_handle, so add one cmdq_handle > in mtk_crtc to prevent frequently allocation and free of > cmdq_handle. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Chu

Re: [PATCH v5 3/6] drm/mediatek: Detect CMDQ execution timeout

2021-10-27 Thread Chun-Kuang Hu
Hi, Fei: Fei Shao 於 2021年10月27日 週三 下午5:32寫道: > > Hi Jason, > > On Wed, Oct 27, 2021 at 10:19 AM jason-jh.lin > wrote: > > > > From: Chun-Kuang Hu > > > > CMDQ is used to update display register in vblank period, so > > it should be execute in n

Re: [PATCH v5 5/6] drm/mediatek: Add mbox_free_channel in mtk_drm_crtc_destroy

2021-10-27 Thread Chun-Kuang Hu
mtk_crtc->cmdq_client.chan = NULL; Except the indent, Reviewed-by: Chun-Kuang Hu > #endif > drm_crtc_cleanup(crtc); > } > -- > 2.18.0 >

Re: [PATCH v7 17/20] drm/mediatek: add mediatek-drm plane color encoding info

2021-11-04 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > Add plane color encoding information for color space conversion. > It's a preparation for adding support for mt8195 ovl_adaptor mdp_rdma > csc control. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > -

Re: [PATCH v7 16/20] drm/mediatek: add ETHDR support for MT8195

2021-11-04 Thread Chun-Kuang Hu
vdata(dev); > + > + ret = clk_bulk_prepare_enable(ETHDR_CLK_NUM, priv->ethdr_clk); > + if (ret) > + dev_err(dev, > + "ethdr_clk prepare enable failed\n"); > + return ret; > +} > + &g

Re: [PATCH v7 18/20] drm/mediatek: add ovl_adaptor support for MT8195

2021-11-04 Thread Chun-Kuang Hu
gt; + > +static void mtk_disp_ovl_adaptor_comp_unbind(struct device *dev, struct > device *master, > +void *data) > +{ > +} > + > +static const struct component_ops mtk_disp_ovl_adaptor_comp_ops = { > + .bind = mtk_disp_ovl_adaptor_comp_bind, &

Re: [PATCH v7 03/20] dt-bindings: mediatek: add ethdr definition for mt8195

2021-11-01 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月29日 週五 下午3:52寫道: > > Add vdosys1 ETHDR definition. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Nancy.Lin > --- > .../display/mediatek/mediatek,ethdr.yaml | 147 ++ > 1 file changed, 147 insertions(+)

Re: [PATCH v6 14/16] drm/mediatek: add ovl_adaptor support for MT8195

2021-10-25 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年10月4日 週一 下午2:21寫道: > > Add ovl_adaptor driver for MT8195. > Ovl_adaptor is an encapsulated module and designed for simplified > DRM control flow. This module is composed of 8 RDMAs, 4 MERGEs and > an ETHDR. Two RDMAs merge into one layer, so this module support 4 >

Re: [PATCH v4 2/2] drm/mediatek: add devlink to cmdq dev

2021-12-02 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年12月2日 週四 下午2:41寫道: > > Add devlink to cmdq to make sure the order of suspend and resume > is correct. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 43 ++

Re: [PATCH v4 1/2] drm/mediatek: add wait_for_event for crtc disable by cmdq

2021-12-02 Thread Chun-Kuang Hu
cmd is done before cmdq_suspend. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/me

Re: [PATCH] drm/mediatek: Set the default value of rotation to DRM_MODE_ROTATE_0

2021-12-09 Thread Chun-Kuang Hu
Hi Mark: Mark Yacoub 於 2021年10月28日 週四 上午12:28寫道: > > From: Mark Yacoub > > At the reset hook, call __drm_atomic_helper_plane_reset which is > called at the initialization of the plane and sets the default value of > rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1. This patch

Re: [PATCH] drm/mediatek: hdmi: Perform NULL pointer check for mtk_hdmi_conf

2021-12-13 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2021年12月13日 週一 下午6:02寫道: > > Il 28/10/21 09:43, AngeloGioacchino Del Regno ha scritto: > > In commit 41ca9caaae0b ("drm/mediatek: hdmi: Add check for CEA modes only") > > a check for CEA modes was added to function mtk_hdmi_bridge_mode_valid() > > in

Re: [PATCH v7 1/3] drm/dsi: transer dsi hs packet aligned

2021-12-10 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This patch looks good to me, how do you think about it? Regards, Chun-Kuang. Jitao Shi 於 2021年11月4日 週四 上午11:36寫道: > > Hi sirs > > Pls help to review this change. > > Best Regards > Jitao. > > On Tue, 2021-10-05 at 07:53 +0800, Chu

Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop.

2021-12-16 Thread Chun-Kuang Hu
Hi, Mark: Mark Yacoub 於 2021年12月16日 週四 上午1:25寫道: > > On Wed, Dec 15, 2021 at 11:14 AM Chun-Kuang Hu > wrote: > > > > Hi, Mark: > > > > Mark Yacoub 於 2021年12月14日 週二 下午11:13寫道: > > > > > > Hey CK, can we have this merged? > > > Than

[GIT PULL] mediatek drm next for 5.17

2021-12-16 Thread Chun-Kuang Hu
TE_0 ---- Chun-Kuang Hu (4): drm/mediatek: Use mailbox rx_callback instead of cmdq_task_cb drm/mediatek: Remove the pointer of struct cmdq_client drm/mediatek: Detect CMDQ execution timeout drm/mediatek: Add cmdq_handle in mtk_

Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop.

2021-12-15 Thread Chun-Kuang Hu
Hi, Mark: Mark Yacoub 於 2021年12月14日 週二 下午11:13寫道: > > Hey CK, can we have this merged? > Thank you! > > On Mon, Oct 25, 2021 at 9:13 PM Sean Paul wrote: > > > > On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote: > > > From: Mark Yacoub > > > > > > [Why] > > > Creating the prop uses

Re: [PATCH v2] drm/mediatek: Set the default value of rotation to DRM_MODE_ROTATE_0

2021-12-13 Thread Chun-Kuang Hu
Hi, Mark: Mark Yacoub 於 2021年12月14日 週二 上午12:08寫道: > > At the reset hook, call __drm_atomic_helper_plane_reset which is > called at the initialization of the plane and sets the default value of > rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1. Applied to mediatek-drm-next [1],

Re: [PATCH v1 01/10] dt-bindings: mediatek: add pseudo-ovl definition for mt8195

2021-07-18 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年7月17日 週六 下午5:04寫道: > > 1. Add pseudo-ovl definition file for mt8195 display. > 2. Add mediatek,pseudo-ovl.yaml to decribe pseudo-ovl module in details. > > Signed-off-by: Nancy.Lin > --- > .../display/mediatek/mediatek,disp.yaml | 5 + >

Re: [PATCH v1 06/10] drm/mediatek: add ETHDR support for MT8195

2021-07-18 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年7月17日 週六 下午5:04寫道: > > Add ETHDR module files: > ETHDR is designed for HDR video and graphics conversion in the external > display path. It handles multiple HDR input types and performs tone > mapping, color space/color format conversion, and then combines > different

Re: [PATCH] drm/mediatek: dpi: fix NULL dereference in mtk_dpi_bridge_atomic_check

2021-07-21 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2021年7月12日 週一 下午4:08寫道: > > From: Frank Wunderlich > > bridge->driver_private is not set (NULL) so use bridge_to_dpi(bridge) > like it's done in bridge_atomic_get_output_bus_fmts Applied to mediatek-drm-fixes [1], thanks. [1]

Re: [PATCH v4] drm/mediatek: Fix cursor plane didn't update

2021-07-22 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月22日 週四 上午9:47寫道: > > The cursor plane should use the current plane state in atomic_async_update > because it would not be the new plane state in the global atomic state > since _swap_state happened when those hook are run. > > Fix cursor plane issue by below

Re: [PATCH] drm/mediatek: mtk-dpi: Set out_fmt from config if not the last bridge

2021-07-22 Thread Chun-Kuang Hu
Hi, Hsin-yi: Hsin-Yi Wang 於 2021年7月12日 週一 下午5:47寫道: > > atomic_get_output_bus_fmts() is only called when the bridge is the last > element in the bridge chain. > > If mtk-dpi is not the last bridge, the format of output_bus_cfg is > MEDIA_BUS_FMT_FIXED, and mtk_dpi_dual_edge() will fail to write

Re: [PATCH v1] mailbox: cmdq: add instruction time-out interrupt support

2021-07-16 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月16日 週五 下午2:58寫道: > > add time-out cycle setting to make sure time-out interrupt irq > will happened when instruction time-out for wait and poll > > Signed-off-by: Yongqiang Niu > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 11 +++ > 1 file changed,

Re: [PATCH v3, 1/3] drm/mediatek: Separate aal module

2021-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月16日 週五 下午2:32寫道: > > mt8183 aal has no gamma function Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu >

Re: [PATCH v3, 2/3] drm/mediatek: add mt8183 aal support

2021-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月16日 週五 下午2:32寫道: > > This patch add mt8183 private data Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu

Re: [PATCH 13/14] drm/mediatek: add pseudo ovl support for MT8195

2021-07-24 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年7月22日 週四 下午5:46寫道: > > Add pseudo ovl module files: My English is not good. The word 'pseudo' seems like 'looks like but indeed not the same'. I think the 'real' ovl also has rdma and mixer inside it, so I prefer to treat these two ovl as different kind of ovl, not

Re: [PATCH v2 13/14] drm/mediatek: add ETHDR support for MT8195

2021-07-27 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年7月22日 週四 下午5:46寫道: > > Add ETHDR module files: > ETHDR is designed for HDR video and graphics conversion in the external > display path. It handles multiple HDR input types and performs tone > mapping, color space/color format conversion, and then combines > different

Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-25 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2021年7月25日 週日 上午1:06寫道: > > >On 12.07.21 19:16, Frank Wunderlich wrote: > >> Hi, > >> > >> it turns out that problem is the read+or of the new value > >> > >> i reverted my patch and changed > >> > >> reg = readl_relaxed(mmsys->regs + routes[i].addr) |

Re: [PATCH 2/3] dt-bindings: display: mediatek,ovl: Fix 'iommu' required property typo

2022-03-04 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年3月4日 週五 下午5:55寫道: > > The property is called 'iommus' and not 'iommu'. Fix this typo. Acked-by: Chun-Kuang Hu > > Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block > to individual

Re: [PATCH 3/3] dt-bindings: display: mediatek: Fix examples on new bindings

2022-03-04 Thread Chun-Kuang Hu
aders, required to parse some of the values assigned to various > properties. Acked-by: Chun-Kuang Hu > > Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block > to individual yaml") > Signed-off-by: AngeloGioacchino Del Regno > > --- > .

Re: [PATCH 1/3] dt-bindings: display: mediatek, mutex: Fix mediatek, gce-events type

2022-03-04 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年3月4日 週五 下午5:55寫道: > > The mediatek,gce-events property needs as value an array of uint32 > corresponding to the CMDQ events to listen to, and not any phandle. Acked-by: Chun-Kuang Hu > > Fixes: 4ed545e7d100 ("dt-bindings: dis

Re: [PATCH 0/3] Fix MediaTek display dt-bindings issues

2022-03-04 Thread Chun-Kuang Hu
Hi, Rob: Would you like to take this series into your tree, or I take this series into my tree? Regards, Chun-Kuang. AngeloGioacchino Del Regno 於 2022年3月4日 週五 下午5:55寫道: > > The vdosys0 series carried a nice dt-bindings conversion of the old > txt documentation for the entire mediatek-drm

Re: [PATCH 1/2] drm: mediatek: mtk_drm_plane: Use kmalloc in mtk_plane_duplicate_state

2022-03-16 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年3月16日 週三 下午6:40寫道: > > Il 25/01/22 17:36, Chun-Kuang Hu ha scritto: > > Hi, AngeloGioacchino: > > > > AngeloGioacchino Del Regno 於 > > 2022年1月18日 週二 下午9:38寫道: > >> > >> There is no need t

[GIT PULL] mediatek drm fixes for 5.17

2022-02-16 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Avoid EPROBE_DEFER loop with external bridge Regards, Chun-Kuang. The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07: Linux 5.17-rc1 (2022-01-23 10:12:53 +0200) are available in the git repository at:

Re: [PATCH v4] drm/mediatek: allow commands to be sent during video mode

2022-02-17 Thread Chun-Kuang Hu
[1Hi, Julien: AngeloGioacchino Del Regno 於 2022年2月14日 週一 下午5:43寫道: > > Il 14/02/22 10:27, Julien STEPHAN ha scritto: > > Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() > > to request backlight changes. > > > > This can be done during panel initialization (dsi is in

Re: [PATCH v4 2/2] drm/mediatek: add devlink to cmdq dev

2022-02-26 Thread Chun-Kuang Hu
Hi, Jason: Build error: ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c: In function ‘mtk_drm_crtc_create’: ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:902:26: error: ‘struct mtk_drm_private’ has no member named ‘dev’ mtk_crtc->drm_dev = priv->dev; ^

Re: [PATCH v4 1/2] drm/mediatek: add wait_for_event for crtc disable by cmdq

2022-02-26 Thread Chun-Kuang Hu
Hi, Jason: Chun-Kuang Hu 於 2021年12月3日 週五 上午7:21寫道: > > Hi, Jason: > > jason-jh.lin 於 2021年12月2日 週四 下午2:41寫道: > > > > mtk_drm_crtc_atomic_disable will send an async cmd to cmdq driver, > > so it may not finish when cmdq_suspend is called sometimes. > > > &

[GIT PULL] mediatek drm next for 5.18

2022-02-26 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Transfer display binding document to yaml format. 2. Add mt8195 display device binding. 3. Allow commands to be sent during video mode. 4. Add wait_for_event for crtc disable by cmdq. Regards, Chun-Kuang. The following changes since commit

Re: [PATCH v8 10/19] drm/mediatek: dpi: move swap_shift to board config

2022-02-20 Thread Chun-Kuang Hu
Hi, Guillaume: Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > Add flexibility by moving the swap shift value to board config > > Signed-off-by: Guillaume Ranquet > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v8 11/19] drm/mediatek: dpi: move the yuv422_en_bit to board config

2022-02-20 Thread Chun-Kuang Hu
Hi, Guillaume: Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > Add flexibility by moving the yuv422 en bit to board config After replace 'board' with 'SoC', Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Guillaume Ranquet > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 8

Re: [PATCH v8 12/19] drm/mediatek: dpi: move the csc_enable bit to board config

2022-02-20 Thread Chun-Kuang Hu
Hi, Guillaume: Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > Add flexibility by moving the csc_enable bit to board config After replace 'board' with 'SoC', Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Guillaume Ranquet > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 8

Re: [PATCH v8 13/19] drm/mediatek: dpi: Add dpintf support

2022-02-20 Thread Chun-Kuang Hu
'.Hi, Guillaume: Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > dpintf is the displayport interface hardware unit. This unit is similar > to dpi and can reuse most of the code. > > This patch adds support for mt8195-dpintf to this dpi driver. Main > differences are: > - Some

Re: [PATCH v8 07/19] drm/mediatek: dpi: implement a swap_input toggle in board config

2022-02-20 Thread Chun-Kuang Hu
Hi, Guillaume: Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > Adds a bit of flexibility to support boards without swap_input support > > Signed-off-by: Guillaume Ranquet > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > >

Re: [PATCH v8 08/19] drm/mediatek: dpi: move dimension mask to board config

2022-02-20 Thread Chun-Kuang Hu
Hi, Guillaume: Chun-Kuang Hu 於 2022年2月21日 週一 上午10:40寫道: > > HI, Guillaume: > > Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > > > Add flexibility by moving the dimension mask to the board config > > After change 'board' to 'SoC', > > Reviewed-by:

Re: [PATCH v8 05/19] drm/mediatek: dpi: move dpi limits to board config

2022-02-20 Thread Chun-Kuang Hu
Hi, Guillaume: Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > Add flexibility by moving the dpi limits to the board config This patch looks good to me. But I would like to know what's this limit and why it vary in different SoC. If possible, would you please provide more description for this?

Re: [PATCH v8 06/19] drm/mediatek: dpi: implement a CK/DE pol toggle in board config

2022-02-20 Thread Chun-Kuang Hu
HI, Guillaume: Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > Adds a bit of flexibility to support boards without CK/DE pol support I'm not sure what the term 'board' mean. Do you mean different board with different panel but all with mt8195-dpintf? If so, you should get CK/DE support from

Re: [PATCH v8 08/19] drm/mediatek: dpi: move dimension mask to board config

2022-02-20 Thread Chun-Kuang Hu
HI, Guillaume: Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > Add flexibility by moving the dimension mask to the board config After change 'board' to 'SoC', Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Guillaume Ranquet > --- > drivers/gpu/drm/media

Re: [PATCH v8 09/19] drm/mediatek: dpi: move dimension_mask to board config

2022-02-20 Thread Chun-Kuang Hu
Hi, Guillaume: Guillaume Ranquet 於 2022年2月18日 週五 下午10:56寫道: > > Add flexibility by moving the dimension mask to board config Replace 'board' with 'SoC'. > > Signed-off-by: Guillaume Ranquet > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 12 ++-- > 1 file changed, 10 insertions(+), 2

Re: [PATCH] dt-bindings: display: mediatek: Add includes on examples

2022-03-24 Thread Chun-Kuang Hu
Hi, Corentin: I've applied Jason's series [1] to my tree [2], does that series fix your problem? [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=621899 [2] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang.

[GIT PULL] mediatek drm fixes - 20220325

2022-03-24 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Fix dt-binding issue. Regards, Chun-Kuang. The following changes since commit 71941773e143369a73c9c4a3b62fbb60736a1182: Add linux-next specific files for 20220310 (2022-03-10 20:04:36 +1100) are available in the git repository at:

Re: [PATCH v3] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-28 Thread Chun-Kuang Hu
AngeloGioacchino Del Regno 於 2022年1月28日 週五 下午5:13寫道: > > Il 27/01/22 16:46, AngeloGioacchino Del Regno ha scritto: > > Il 27/01/22 16:21, Chun-Kuang Hu ha scritto: > >> Hi, Angelo: > >> > >> AngeloGioacchino Del Regno 於 > >> 2022年1月27日 週四 下

Re: [PATCH v1, 4/4] drm/mediatek: add mt8186 display support

2022-01-28 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2022年1月28日 週五 下午8:07寫道: > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 39 ++ > 1 file changed, 39 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >

Re: [PATCH v1, 3/4] drm/mediatek: split postmask component

2022-01-28 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2022年1月28日 週五 下午8:07寫道: > > add postmask private data for differnt soc support > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/Makefile| 1 + > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + >

Re: [PATCH v1, 1/4] soc: mediatek: mmsys: Add mt8186 mmsys routing table

2022-01-28 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2022年1月28日 週五 下午8:07寫道: > > mt8186 routing registers is different with other Soc > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mt8186-mmsys.h | 113 > drivers/soc/mediatek/mtk-mmsys.c| 11 +++ > 2 files changed,

Re: [PATCH v1, 2/4] soc: mediatek: add mtk mutex support for MT8186

2022-01-28 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2022年1月28日 週五 下午8:07寫道: > > Add mtk mutex support for MT8186 SoC. > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mtk-mutex.c | 45 > 1 file changed, 45 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c

Re: [PATCH v11 03/22] dt-bindings: mediatek: add ethdr definition for mt8195

2022-02-09 Thread Chun-Kuang Hu
> Reviewed-by: Chun-Kuang Hu > --- > .../display/mediatek/mediatek,ethdr.yaml | 147 ++ > 1 file changed, 147 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.yaml > > diff --git > a/Documentati

<    1   2   3   4   5   6   7   8   >