Re: [PATCH v11 02/22] dt-bindings: mediatek: add vdosys1 MERGE property for mt8195

2022-02-09 Thread Chun-Kuang Hu
iatek-drm-next Regards, Chun-Kuang > > Signed-off-by: Nancy.Lin > Reviewed-by: Chun-Kuang Hu > Acked-By: AngeloGioacchino Del Regno > --- > .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 4 > 1 file changed, 4 insertions(+) > > diff --git &

Re: [PATCH v4] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-02-09 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年1月31日 週一 下午4:55寫道: > > DRM bridge drivers are now attaching their DSI device at probe time, > which requires us to register our DSI host in order to let the bridge > to probe: this recently started producing an endless -EPROBE_DEFER > loop on some

Re: [PATCH v2] drm/mediatek: allow commands to be sent during video mode

2022-02-10 Thread Chun-Kuang Hu
. > > When the DSI is in Video Mode, all commands are rejected. > > Detect current DSI mode in mtk_dsi_host_transfer() and switch modes > temporarily to allow commands to be sent. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Julien STEPHAN > Signed-off-by: Mattijs Korper

Re: [PATCH v2] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-27 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年1月27日 週四 下午6:32寫道: > > Il 12/01/22 08:09, Jagan Teki ha scritto: > > On Tue, Jan 4, 2022 at 3:30 PM AngeloGioacchino Del Regno > > wrote: > >> > >> DRM bridge drivers are now attaching their DSI device at probe time, > >> which requires us to

Re: [PATCH v3] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-27 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2022年1月27日 週四 下午10:36寫道: > > DRM bridge drivers are now attaching their DSI device at probe time, > which requires us to register our DSI host in order to let the bridge > to probe: this recently started producing an endless -EPROBE_DEFER > loop on some

Re: [PATCH] drm/mediatek: DP HPD Detect with debounce

2022-01-25 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2022年1月12日 週三 下午11:01寫道: > > DP Spec 1.4a 3.3 requires dp detect the hpd with debounce. > > Upstream implementations should implement HPD signal de-bouncing on > an external connection. A period of 100ms should be used for > detecting an HPD connect event (i.e., the event,

Re: [PATCH 1/2] drm: mediatek: mtk_drm_plane: Use kmalloc in mtk_plane_duplicate_state

2022-01-25 Thread Chun-Kuang Hu
Hi, AngeloGioacchino: AngeloGioacchino Del Regno 於 2022年1月18日 週二 下午9:38寫道: > > There is no need to zero out the newly allocated memory because we are > duplicating all members of struct mtk_plane_state: switch to kmalloc > to save some overhead. Reviewed-by: Chun-Kuang Hu &g

Re: [PATCH 2/2] drm: mediatek: mtk_drm_crtc: Use kmalloc in mtk_drm_crtc_duplicate_state

2022-01-25 Thread Chun-Kuang Hu
se, then all of > the remaining variables will only ever be set, but not read - so, also > set `pending_config` to false. > This saves us some small overhead. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: AngeloGioacchino Del Regno > > --- > drivers/gpu/drm/mediatek/mtk_drm

[GIT PULL] mediatek drm fixes 20231017

2023-10-16 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Correctly free sg_table in gem prime vmap Regards, Chun-Kuang. The following changes since commit 58720809f52779dc0f08e53e54b014209d13eebb: Linux 6.6-rc6 (2023-10-15 13:34:39 -0700) are available in the Git repository at:

Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection

2023-09-24 Thread Chun-Kuang Hu
a > >> > wrote: > >> >> > >> >> The sads returned by drm_edid_to_sad() needs to be freed. > >> >> > >> >> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195") > >> >> Cc: Guillaume Ra

Re: [PATCH v6,0/4] Add compatible to increase MT8188 audio control

2023-09-24 Thread Chun-Kuang Hu
Hi, Shuijing: Shuijing Li 於 2023年8月22日 週二 上午10:41寫道: > > Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC. > Mainly add the following two flag: > > 1.The audio packet arrangement function is to only arrange audio > packets into the Hblanking area. In order to align with the HW >

Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path

2023-09-24 Thread Chun-Kuang Hu
97a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") > Cc: Markus Schneider-Pargmann > Cc: Guillaume Ranquet > Cc: Bo-Chen Chen > Cc: CK Hu > Cc: AngeloGioacchino Del Regno > Cc: Dmitry Osipenko > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Cc: Matthi

[GIT PULL] mediatek drm next for 6.7

2023-10-18 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Add support MT8188 dsi function 2. Fix coverity issue with unintentional integer overflow 3. Add support MT8188 dp/edp function 4. Fix memory leak on ->get_edid callback audio detection and error path. 5. Add connector dynamic selection capability 6.

Re: [PATCH] drm: mediatek: mtk_dsi: Fix NO_EOT_PACKET settings/handling

2023-10-18 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2023年10月18日 週三 下午6:21寫道: > > Il 15/09/23 12:11, Michael Walle ha scritto: > >> Due to the initial confusion about MIPI_DSI_MODE_EOT_PACKET, properly > >> renamed to MIPI_DSI_MODE_NO_EOT_PACKET, reflecting its actual meaning, > >> both the DSI_TXRX_CON

Re: [PATCH 3/5] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-04-19 Thread Chun-Kuang Hu
ma: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek MDP RDMA > > + > > +maintainers: > > + - Matthias Brugger > > I don't think I would be the correct person to maintain this. This should be > the > person that is maintaining the d

Re: [PATCH v17 11/21] drm/mediatek: add display merge start/stop API for cmdq support

2022-04-25 Thread Chun-Kuang Hu
q making sure all the settings taken effect in the > > same vblank. > > > > Signed-off-by: Nancy.Lin > > Reviewed-by: Chun-Kuang Hu > > Reviewed-by: AngeloGioacchino Del Regno > > > > --- > > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 2 ++ > >

Re: [PATCH v20 8/8] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

2022-05-14 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2022年5月13日 週五 下午3:42寫道: > > Hi Chun-Kuang, > > On 02/05/2022 00:54, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2022年4月22日 週五 下午8:42寫道: > >> > >> > >> > >> On 19/04/2022

Re: [PATCH] drm/mediatek: ensure bridge disable happends before suspend

2022-07-04 Thread Chun-Kuang Hu
Hi, Hsin-yi: Hsin-Yi Wang 於 2022年6月30日 週四 凌晨3:06寫道: > > Make sure bridge_disable will be called before suspend by calling > drm_mode_config_helper_suspend() in .prepare callback. Applied to mediatek-drm-next [1], thanks. [1]

[GIT PULL] mediatek drm next for 5.20

2022-07-09 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Add Mediatek Soc DRM (vdosys0) support for mt8195 2. Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to cooperate with panel sequence 3. Add mt8186 dsi compatible and convert dsi_dtbinding to .yaml 4. Add MediaTek SoC DRM (vdosys1)

Re: [PATCH v20 8/8] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

2022-05-01 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2022年4月22日 週五 下午8:42寫道: > > > > On 19/04/2022 11:41, jason-jh.lin wrote: > > After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, > > mmsys header can remove the useless DDP_COMPONENT_DITHER enum. > > > > Signed-off-by: jason-jh.lin > > Reviewed-by:

Re: [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195

2022-04-16 Thread Chun-Kuang Hu
Rob Herring 於 2022年4月14日 週四 上午7:02寫道: > > On Mon, 11 Apr 2022 11:58:43 +0800, Rex-BC Chen wrote: > > Disp_aal of MT8192 and MT8195 are fully compatible with disp_aal of > > MT8183. Therefore, we move the them to item "mediatek,mt8183-disp-aal". > > > > Signed-off-by: Rex-BC Chen > > --- > >

Re: [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183

2022-04-16 Thread Chun-Kuang Hu
Rob Herring 於 2022年4月14日 週四 上午7:02寫道: > > On Mon, 11 Apr 2022 11:58:41 +0800, Rex-BC Chen wrote: > > The driver data of MT8183 and MT8173 are different. > > > > For MT8173, the gamma module is inside disp_aal. When we need to adjust > > gamma value, we need to use "has_gamma" to control gamma

[GIT PULL] mediatek drm next for 5.19

2022-05-04 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Add display support for MT8186 2. Miscellaneous refinement and fixup. Regards, Chun-Kuang. The following changes since commit 3123109284176b1532874591f7c81f3837bbdc17: Linux 5.18-rc1 (2022-04-03 14:08:21 -0700) are available in the git repository at:

Re: [PATCH] drm/mediatek: dsi: Add atomic {destroy, duplicate}_state, reset callbacks

2022-08-25 Thread Chun-Kuang Hu
Chen-Yu Tsai 於 2022年8月19日 週五 晚上9:29寫道: > > On Fri, Jul 22, 2022 at 1:27 AM AngeloGioacchino Del Regno > wrote: > > > > Add callbacks for atomic_destroy_state, atomic_duplicate_state and > > atomic_reset to restore functionality of the DSI driver: this solves > > vblank timeouts when another

Re: [PATCH v17 03/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

2022-09-05 Thread Chun-Kuang Hu
Hi, Bo-Chen: Please help to fix the compile warning: ../drivers/gpu/drm/mediatek/mtk_dp.c: In function ‘mtk_dp_video_mute’: ../drivers/gpu/drm/mediatek/mtk_dp.c:947:23: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=] 947 |

Re: [PATCH v17 00/10] Add MT8195 DisplayPort driver

2022-09-05 Thread Chun-Kuang Hu
ntained the DisplayPort driver. > >> > >> This series can be tested using 5.19-rc2 kernel and I test it in MT8195 > >> Tomato Chromebook. Modetest these modes: > > > > Applied to drm-misc-next, thanks! > > Hello Chun-Kuang Hu, > > Angelo told me

Re: [PATCH 2/5] drm/mediatek: Drop of_gpio header

2022-08-25 Thread Chun-Kuang Hu
it/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Cc: Matthias Brugger > Cc: linux-media...@lists.infradead.org > Signed-off-by: Maíra Canal > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 1 - > drivers/gpu/drm/mediatek/mtk_hdmi.c |

Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

2022-08-25 Thread Chun-Kuang Hu
Hi, cgel: 於 2022年8月25日 週四 下午3:24寫道: > > From: ye xingchen > > Return the value drm_mode_config_helper_suspend() directly instead of > storing it in another redundant variable. Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v2 3/3] drm/mediatek: dp: Fix warning in mtk_dp_video_mute()

2022-09-17 Thread Chun-Kuang Hu
d > here > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ~^ > || > |unsigned int > |

Re: [PATCH v2 2/3] drm/mediatek: dp: Remove unused register definitions

2022-09-17 Thread Chun-Kuang Hu
Hi, Bo-Chen: Bo-Chen Chen 於 2022年9月16日 週五 晚上9:38寫道: > > Some definitions in mtk_dp_reg.h are not used, so remove these > redundant codes. Acked-by: Chun-Kuang Hu > > Signed-off-by: Bo-Chen Chen > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: Matthias B

Re: [PATCH v2] drm: mediatek: Fix display vblank timeout when disable dsi

2022-09-17 Thread Chun-Kuang Hu
Hi, Allen: Allen-KH Cheng 於 2022年9月14日 週三 晚上10:00寫道: > > From: Xinlei Lee > > Dsi is turned off at bridge.disable, causing crtc to wait for vblank > timeout. It is necessary to add count protection to turn off dsi and > turn off at post_disable. If turn off dsi in post_disable(), you should

Re: [PATCH v2 0/3] Refactor MediaTek DP drivers

2022-09-17 Thread Chun-Kuang Hu
Hi, Dmitry: My tree has no mtk-dp driver yet. Would you like to pick this series? Regards, Chun-Kuang. Bo-Chen Chen 於 2022年9月16日 週五 晚上9:38寫道: > > For this series, we do some clean-up and fix a build warning. > This series is based on linux-next-20220915. > > Changes for v2: > 1. Update commit

Re: [PATCH -next] drm/mediatek: dp: change mtk_dp_driver to static

2022-09-17 Thread Chun-Kuang Hu
Hi, Dmity: My tree has no mtk dp driver yet. Would you like to pick this patch? Acked-by: Chun-Kuang Hu Dmitry Osipenko 於 2022年9月15日 週四 下午5:04寫道: > > On 9/13/22 16:49, Yang Yingliang wrote: > > mtk_dp_driver is only used in mtk_dp.c now, change it > > to static. > >

Re: [PATCH v2 1/3] drm/mediatek: dp: Reduce indentation in mtk_dp_bdg_detect()

2022-09-17 Thread Chun-Kuang Hu
Bo-Chen Chen 於 2022年9月16日 週五 晚上9:38寫道: > > In order to improve human readability, reduce the indentation by > returning early if the dp/edp cable is not plugged in. Acked-by: Chun-Kuang Hu > > Signed-off-by: Bo-Chen Chen > --- > drivers/gpu/drm/m

Re: [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup

2022-09-17 Thread Chun-Kuang Hu
xup() operation. Acked-by: Chun-Kuang Hu > > Signed-off-by: Sam Ravnborg > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Cc: Matthias Brugger > Cc: linux-media...@lists.infradead.org > Cc: linux-arm-ker...@lists.infradead.org > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c |

Re: [PATCH v1 03/12] drm/mediatek: Drop chain_mode_fixup call in mode_valid()

2022-09-17 Thread Chun-Kuang Hu
re added and is seems safe to remove the call now. Acked-by: Chun-Kuang Hu > > Signed-off-by: Sam Ravnborg > Reviewed-by: Maxime Ripard > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Cc: Matthias Brugger > Cc: Dafna Hirschfeld > Cc: linux-media...@lists.infradead.org > Cc

Re: [PATCH] drm/mediatek: Fix wrong dither settings

2022-09-12 Thread Chun-Kuang Hu
Hi, Allen: Allen-KH Cheng 於 2022年9月8日 週四 晚上10:12寫道: > > The width and height arguments in the cmdq packet for mtk_dither_config() > are inverted. We fix the incorrect width and height for dither settings > in mtk_dither_config(). Applied to mediatek-drm-fixes [1], thanks. [1]

[GIT PULL] mediatek drm next for 6.1

2022-09-22 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Drop of_gpio header 2. Remove the unneeded result Regards, Chun-Kuang. The following changes since commit 568035b01cfb107af8d2e4bd2fb9aea22cf5b868: Linux 6.0-rc1 (2022-08-14 15:50:18 -0700) are available in the Git repository at:

[GIT PULL] mediatek drm fixes for 6.0

2022-09-21 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. dsi: Add atomic {destroy,duplicate}_state, reset callbacks 2. drm/mediatek: Fix wrong dither settings 3. dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff() Regards, Chun-Kuang. The following changes since commit

Re: [PATCH v13,2/3] drm: mediatek: Set dpi format in mmsys

2022-12-26 Thread Chun-Kuang Hu
Hi, Xinlei: 於 2022年10月24日 週一 上午10:05寫道: > > From: Xinlei Lee > > Dpi output needs to adjust the output format to dual edge for MT8186. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards,

Re: [PATCH v13,3/3] drm: mediatek: Add mt8186 dpi compatibles and platform data

2022-12-26 Thread Chun-Kuang Hu
Hi, Xinlei: 於 2022年10月24日 週一 上午10:05寫道: > > From: Xinlei Lee > > Add the compatible because use edge_cfg_in_mmsys in mt8186. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. >

Re: [PATCH v4 1/6] dt-bindings: mediatek: modify VDOSYS0 display device tree Documentations for MT8188

2022-12-27 Thread Chun-Kuang Hu
Hi, Nathan: nathan.lu 於 2022年12月6日 週二 上午10:01寫道: > > From: Nathan Lu > > modify VDOSYS0 display device tree Documentations for MT8188. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards,

Re: [PATCH v5] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-11-23 Thread Chun-Kuang Hu
Hi, Justin: Justin Green 於 2022年11月17日 週四 凌晨3:33寫道: > > From: Justin Green > > Tested on MT8195 and confirmed both correct video output and improved DRAM > bandwidth performance. I've break this patch into two patches and apply to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v2,2/2] drm: mediatek: Add mt8188 dpi compatibles and platform data

2022-11-23 Thread Chun-Kuang Hu
Hi, Xinlei: 於 2022年10月20日 週四 晚上7:46寫道: > > From: xinlei lee > > For MT8188, the vdosys0 only supports 1T1P mode, so we need to add the > compatible for mt8188 edp-intf. For this series, applied to mediatek-drm-next [1], thanks. [1]

[GIT PULL] mediatek drm next for 6.2

2022-11-23 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Fixup of dpi and hdmi 2. Move panel connector to head 3. Add MT8188 dpi support 4. Add MT8195 AFBC support Regards, Chun-Kuang. The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) are

Re: [PATCH] drm/mediatek: Drop unbalanced obj unref

2023-01-26 Thread Chun-Kuang Hu
Hi, Rob: Rob Clark 於 2023年1月20日 週五 上午7:12寫道: > > From: Rob Clark > > In the error path, mtk_drm_gem_object_mmap() is dropping an obj > reference that it doesn't own. Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH] drm/mediatek: dp: Remove extra semicolon

2023-01-26 Thread Chun-Kuang Hu
Hi, Deepak: Deepak R Varma 於 2023年1月14日 週六 下午11:41寫道: > > Remove unnecessary semicolon at the end of switch block closing brace. > Issue identified using semicolon Coccinelle semantic patch. Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH] drm/mediatek: Remove dependency on GEM DMA helper

2023-01-26 Thread Chun-Kuang Hu
Hi, Rob: Rob Clark 於 2023年1月20日 週五 上午6:40寫道: > > From: Rob Clark > > It appears that the dependency on the DMA helpers was only for > drm_gem_dma_vm_ops. Applied to mediatek-drm-next [1], thanks. [1]

[GIT PULL] mediatek drm next for 6.3

2023-01-30 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Reduce the time of dsi from LP11 to sending cmd 2. Remove dependency on GEM DMA helper 3. Drop unbalanced obj unref 4. Fix the fallback for mediatek,mt8186-disp-ccorr 5. Fixup for error path. Regards, Chun-Kuang. The following changes since commit

Re: [PATCH v5] drm/mediatek: Add support for AR30 and BA30

2023-01-30 Thread Chun-Kuang Hu
Hi, Justin: Justin Green 於 2023年1月31日 週二 上午4:36寫道: > > Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver. > > Tested using "modetest -P" on an MT8195. > > Signed-off-by: Justin Green > --- > v2: > * Rebase and resolve merge conflicts with the AFBC patch. > v3: > * Moved

Re: [PATCH] drm/mediatek: mtk_drm_crtc: Add checks for devm_kcalloc

2023-01-27 Thread Chun-Kuang Hu
Hi, Ruanjinjie: Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. AngeloGioacchino Del Regno 於 2022年12月5日 週一 下午7:53寫道: > > Il 05/12/22 10:51, ruanjinjie ha scritto: > > As the

Re: [PATCH v2] drm/mediatek: Clean dangling pointer on bind error path

2023-01-27 Thread Chun-Kuang Hu
Hi, Nicolas: Nícolas F. R. A. Prado 於 2022年11月22日 週二 下午10:39寫道: > > mtk_drm_bind() can fail, in which case drm_dev_put() is called, > destroying the drm_device object. However a pointer to it was still > being held in the private object, and that pointer would be passed along > to DRM in

Re: [PATCH v3] drm/mediatek: Add support for AR30 and BA30

2023-01-28 Thread Chun-Kuang Hu
Hi, Justin: Justin Green 於 2023年1月28日 週六 上午7:01寫道: > > Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver. > > Tested using "modetest -P" on an MT8195. > > Signed-off-by: Justin Green > --- > v2: > * Rebase and resolve merge conflicts with the AFBC patch. > v3: > * Moved

Re: [PATCH] drm/mediatek: Remove unused GEM DMA header include

2023-01-28 Thread Chun-Kuang Hu
Hi, Rob: Rob Clark 於 2023年1月28日 週六 上午12:54寫道: > > From: Rob Clark > > No longer needed since the removal of dependency on DMA helper. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards,

Re: [PATCH v2 8/9] dt-bindings: display: mediatek: Fix the fallback for mediatek,mt8186-disp-ccorr

2023-01-28 Thread Chun-Kuang Hu
Hi, Allen: Allen-KH Cheng 於 2023年1月18日 週三 下午5:18寫道: > > The mt8186-disp-ccorr is not fully compatible with the mt8183-disp-ccorr > implementation. It causes a crash when system resumes if it binds to the > device. > > We should use mt8192-disp-ccorr as fallback of mt8186-disp-ccorr. Applied to

Re: [PATCH] drm/mediatek: Implement shutdown

2023-01-28 Thread Chun-Kuang Hu
Hi, Ricardo: Ricardo Ribalda 於 2022年11月28日 週一 下午6:42寫道: > > Poweroff the device properly, otherwise the device will not come back > from kexec(). > > Signed-off-by: Ricardo Ribalda > --- > To: Chun-Kuang Hu > To: Philipp Zabel > To: David Airlie > To: Daniel

Re: [PATCH v2 1/3] drm/mediatek: dsi: Reduce the time of dsi from LP11 to sending cmd

2023-01-26 Thread Chun-Kuang Hu
Hi, Xinlei: 於 2023年1月10日 週二 下午1:55寫道: > > From: Xinlei Lee > > According to Figure 16 Turnaround Procedure on page 36 in [1], you > can see the status of LP-00 -> LP10 -> LP11. This state can correspond > to the state of DSI from LP00 -> LP11 in mtk_dsi_lane_ready function > in mtk_dsi.c. > >

Re: [PATCH v2] drm/mediatek: Add support for AR30 and BA30

2023-01-26 Thread Chun-Kuang Hu
Hi, Justin: Justin Green 於 2023年1月11日 週三 上午4:47寫道: > > Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver. > > Tested using "modetest -P" on an MT8195. > > Signed-off-by: Justin Green > --- > v2: > * Rebase and resolve merge conflicts with the AFBC patch. > >

Re: [PATCH v2] drm/mediatek: stop using 0 as NULL pointer

2023-01-26 Thread Chun-Kuang Hu
Hi, Miles: Miles Chen 於 2023年1月11日 週三 上午10:52寫道: > > Use NULL for NULL pointer to fix the following sparse warning: > drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain > integer as NULL pointer Applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v5 6/6] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

2022-11-10 Thread Chun-Kuang Hu
Matthias Brugger 於 2022年11月9日 週三 晚上7:25寫道: > > > > On 27/09/2022 17:27, Jason-JH.Lin wrote: > > After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, > > mmsys header can remove the useless DDP_COMPONENT_DITHER enum. > > > > Signed-off-by: Jason-JH.Lin > > Reviewed-by:

Re: [PATCH v3] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-11-14 Thread Chun-Kuang Hu
* , , Hi, Justin: Justin Green 於 2022年10月13日 週四 凌晨3:12寫道: > > Tested on MT8195 and confirmed both correct video output and improved DRAM > bandwidth performance. > > v3: > * Replaced pitch bitshift math with union based approach. > * Refactored overlay register writes to shared code between

Re: [PATCH v4] drm: mediatek: Modify dpi power on/off sequence.

2022-11-13 Thread Chun-Kuang Hu
Hi, Xinlei: 於 2022年11月9日 週三 下午6:01寫道: > > From: Xinlei Lee > > Modify dpi power on/off sequence so that the first gpio operation will take > effect. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Re: [PATCH v2] drm/mediatek: make eDP panel as the first connected connector

2022-11-13 Thread Chun-Kuang Hu
Hi Gil: Gil Dekel 於 2022年11月11日 週五 凌晨2:49寫道: > > [Why] > Some userspaces assume that the first connected connector is the "main" > display, which supposed to display, for example, the login screen. > For laptops, this should be the internal connector. > > [How] > This patch calls

Re: [PATCH] drm/mediatek: Fix return type of mtk_hdmi_bridge_mode_valid()

2022-11-13 Thread Chun-Kuang Hu
Hi, Nathan: Nathan Chancellor 於 2022年11月2日 週三 晚上11:47寫道: > > With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), > indirect call targets are validated against the expected function > pointer prototype to make sure the call target is valid to help mitigate > ROP attacks. If they

Re: [PATCH v7 RESEND 3/3] drm/mediatek: Enable AR30 and BA30 overlays on MT8195

2023-03-08 Thread Chun-Kuang Hu
Hi, Justin: Justin Green 於 2023年3月8日 週三 下午11:34寫道: > Describe more about what and why this patch does. The other modification looks good to me. Regards, Chun-Kuang. > Tested using "modetest -P" on an MT8195 device. > > Signed-off-by: Justin Green > --- >

Re: [PATCH v8 0/3] drm/mediatek: Add support for 10-bit overlays

2023-03-12 Thread Chun-Kuang Hu
Hi, Justin: Justin Green 於 2023年3月10日 週五 上午5:05寫道: > > This patch series adds support for 10-bit overlays to the Mediatek DRM driver. > Specifically, we add support for AR30 and BA30 overlays on MT8195 devices and > lay the groundwork for supporting more 10-bit formats on more devices. I've

Re: [PATCH v2] drm/mediatek: dp: Only trigger DRM HPD events if bridge is attached

2023-03-12 Thread Chun-Kuang Hu
Hi, Chen-Yu: Chen-Yu Tsai 於 2023年2月2日 週四 下午12:57寫道: > > The MediaTek DisplayPort interface bridge driver starts its interrupts > as soon as its probed. However when the interrupts trigger the bridge > might not have been attached to a DRM device. As drm_helper_hpd_irq_event() > does not check

Re: [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock

2023-03-15 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月15日 週三 下午5:36寫道: > > Le lun. 13 mars 2023 à 16:21, Chun-Kuang Hu a écrit > : > > > > > > > > + dpi->dpi_clk = devm_clk_get_optional(dev, "dpi"); > > > > For MT8365, DPI clock is

Re: [PATCH v30 0/7] Add MediaTek SoC DRM (vdosys1) support for mt8195

2023-03-23 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2023年3月23日 週四 下午4:58寫道: > > Il 21/03/23 13:18, Nancy.Lin ha scritto: > > The hardware path of vdosys1 with DPTx output need to go through by several > > modules, such as, OVL_ADAPTOR and MERGE. > > > > Add DRM and these modules support by the patches

Re: [PATCH v7 RESEND 2/3] drm/mediatek: Add support for AR30 and BA30 overlays

2023-03-08 Thread Chun-Kuang Hu
Hi, Justin: Justin Green 於 2023年3月8日 週三 下午11:34寫道: > > Tested using "modetest -P" on an MT8195 device. I think you could not test this when only apply the first two patches of this series, so move the test information to the third patch. In this patch, you could describe more about what and why

Re: [PATCH v7 RESEND 1/3] drm/mediatek: Refactor pixel format logic

2023-03-08 Thread Chun-Kuang Hu
Hi, Justin: Justin Green 於 2023年3月8日 週三 下午11:34寫道: > > Add an DDP component interface for querying pixel format support and move list > of supported pixel formats into DDP components instead of mtk_drm_plane.c Reviewed-by: Chun-Kuang Hu > > Tested by running Chrome on an MT8

Re: [PATCH v5] dt-bindings: display: mediatek: clean unnecessary item

2023-03-13 Thread Chun-Kuang Hu
gt; Fix MTK color correction binding > > The fallback compatible has been duplicated in the 137272ef1b0f commit. > > To: Chun-Kuang Hu > To: Philipp Zabel > To: David Airlie > To: Daniel Vetter > To: Rob Herring > To: Krzysztof Kozlowski > To: Matthias Brugger > To: Ange

Re: [PATCH 03/21] dt-bindings: display: mediatek: color: add binding for MT8365 SoC

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > Display Color for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Alexandre Mergnat > --- > Documentation/device

Re: [PATCH 02/21] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > Display Color Correction for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Alexandre Mergnat > --- > Documentatio

Re: [PATCH 04/21] dt-bindings: display: mediatek: dither: add binding for MT8365 SoC

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > Display Dither for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Alexandre Mergnat > --- > Documentation/device

Re: [PATCH 08/21] dt-bindings: display: mediatek: gamma: add binding for MT8365 SoC

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > Display GAMMA for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Alexandre Mergnat > --- > Documentation/device

Re: [PATCH 10/21] dt-bindings: display: mediatek: rdma: add binding for MT8365 SoC

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > Display Data Path Read DMA for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Alexandre Mergnat > --- > Documentatio

Re: [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > From: Fabien Parent > > DPI for MT8365 is compatible with MT8192 but requires an additional > clock. Modify the documentation to requires this clock only on MT8365 SoCs. If MT8365 DPI has additional clock, why it is compatible with

Re: [PATCH v3] dt-bindings: display: mediatek: Fix the duplicated fallback

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Chun-Kuang Hu 於 2023年3月13日 週一 下午10:36寫道: > > Hi, Alexandre: > > Alexandre Mergnat 於 2023年3月7日 週二 上午12:20寫道: > > > > The item which have the mediatek,mt8192-disp-ccorr const compatible already > > exist above. Remove duplicated fallback. >

Re: [PATCH v3] dt-bindings: display: mediatek: Fix the duplicated fallback

2023-03-13 Thread Chun-Kuang Hu
The fallback compatible has been duplicated in the 137272ef1b0f commit. > > To: Chun-Kuang Hu > To: Philipp Zabel > To: David Airlie > To: Daniel Vetter > To: Rob Herring > To: Krzysztof Kozlowski > To: Matthias Brugger > To: AngeloGioacchino Del Regno > To: Allen-KH Ch

Re: [PATCH 05/21] dt-bindings: display: mediatek: dsi: add binding for MT8365 SoC

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > Display Serial Interface for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Alexandre Mergnat > --- > .../bindings/disp

Re: [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > Display Adaptive Ambient Light for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Alexandre Mergnat > --- > Doc

Re: [PATCH 09/21] dt-bindings: display: mediatek: ovl: add binding for MT8365 SoC

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > Display Overlay for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8192 SoC. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Alexandre Mergnat > --- > Documentation/device

Re: [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock

2023-03-13 Thread Chun-Kuang Hu
Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > From: Fabien Parent > > MT8365 requires an additional clock for DPI. Add support for that > additional clock. > > Signed-off-by: Fabien Parent > Signed-off-by: Alexandre Mergnat > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 18

Re: [PATCH v30 0/7] Add MediaTek SoC DRM (vdosys1) support for mt8195

2023-03-22 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2023年3月21日 週二 下午8:19寫道: > > The hardware path of vdosys1 with DPTx output need to go through by several > modules, such as, OVL_ADAPTOR and MERGE. For this series, applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v8 0/2] Change mmsys compatible for mt8195 mediatek-drm

2023-03-16 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2023年3月16日 週四 下午5:03寫道: > > Il 06/03/23 09:06, Jason-JH.Lin ha scritto: > > For previous MediaTek SoCs, such as MT8173, there are 2 display HW > > pipelines binding to 1 mmsys with the same power domain, the same > > clock driver and the same mediatek-drm

Re: [PATCH v28 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

2023-03-06 Thread Chun-Kuang Hu
Signed-off-by: Nancy.Lin > Reviewed-by: Chun-Kuang Hu > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: Krzysztof Kozlowski > Tested-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,ethdr.yaml | 188 ++ > 1 fi

Re: [PATCH v3 1/2] drm/mediatek: Add mdp_rdma get format function

2023-04-12 Thread Chun-Kuang Hu
Hi, Daniel: Daniel Vetter 於 2023年4月11日 週二 下午6:32寫道: > > On Thu, Mar 30, 2023 at 11:26:13AM +0800, Nancy.Lin wrote: > > Add mdp_rdma get_format and get_num_formats function. > > > > Signed-off-by: Nancy.Lin > > The mtk get_formats stuff seems like a lot of midlayering for not much > reasons? Is

Re: [PATCH] drm/mediatek: Clarify/finish documentation for some driver structures

2023-04-21 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2023年4月19日 週三 下午2:16寫道: > > Il 21/03/23 12:14, AngeloGioacchino Del Regno ha scritto: > > The documentation for some of the driver structures in mediatek-drm > > was set to be kerneldoc but some code additions didn't actually update > > the comments

Re: [PATCH 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-04-03 Thread Chun-Kuang Hu
Hi, Julien: Julien Stephan 於 2023年4月3日 週一 下午3:20寫道: > > From: Phi-bang Nguyen > > This is a new driver that supports the MIPI CSI CD-PHY for mediatek > mt8365 soc > > Signed-off-by: Louis Kuo > Signed-off-by: Phi-bang Nguyen > [Julien Stephan: use regmap] > [Julien Stephan: use GENMASK] >

Re: [PATCH 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-04-03 Thread Chun-Kuang Hu
Hi, Julien: Julien Stephan 於 2023年4月3日 週一 下午3:20寫道: > > From: Phi-bang Nguyen > > This is a new driver that supports the MIPI CSI CD-PHY for mediatek > mt8365 soc > > Signed-off-by: Louis Kuo > Signed-off-by: Phi-bang Nguyen > [Julien Stephan: use regmap] > [Julien Stephan: use GENMASK] >

Re: [PATCH] drm/mediatek: dp: change the aux retries times when receiving AUX_DEFER

2023-04-03 Thread Chun-Kuang Hu
Hi, Xinlei: Xinlei Lee (李昕磊) 於 2023年4月3日 週一 下午5:18寫道: > > On Mon, 2023-04-03 at 11:49 +0800, Chun-Kuang Hu wrote: > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > > > > > Hi, Xinle

Re: [PATCH 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-04-03 Thread Chun-Kuang Hu
Hi, Julien: Julien Stephan 於 2023年4月3日 週一 下午3:20寫道: > > From: Phi-bang Nguyen > > This is a new driver that supports the MIPI CSI CD-PHY for mediatek > mt8365 soc > > Signed-off-by: Louis Kuo > Signed-off-by: Phi-bang Nguyen > [Julien Stephan: use regmap] > [Julien Stephan: use GENMASK] >

[GIT PULL] mediatek drm next for 6.4

2023-04-10 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Add support for 10-bit overlays 2. Add MediaTek SoC DRM (vdosys1) support for mt8195 3. Change mmsys compatible for mt8195 mediatek-drm 4. Only trigger DRM HPD events if bridge is attached 5. Change the aux retries times when receiving AUX_DEFER Regards,

Re: [PATCH v30 0/7] Add MediaTek SoC DRM (vdosys1) support for mt8195

2023-03-27 Thread Chun-Kuang Hu
Hi, Angelo: AngeloGioacchino Del Regno 於 2023年3月24日 週五 下午4:38寫道: > > Il 24/03/23 00:25, Chun-Kuang Hu ha scritto: > > Hi, Angelo: > > > > AngeloGioacchino Del Regno 於 > > 2023年3月23日 週四 下午4:58寫道: > >> > >> Il 21/03/23 13:18, Nancy.Lin ha scrit

Re: [PATCH 18/21] drm/mediatek: dsi: Improves the DSI lane setup robustness

2023-03-27 Thread Chun-Kuang Hu
Hi, Xinlei: Could you help to review this patch? Regards, Chun-Kuang. Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > > Currently, mtk_dsi_lane_ready (which setup the DSI lane) is triggered > before mtk_dsi_poweron. lanes_ready flag toggle to true during > mtk_dsi_lane_ready function, and the

Re: [v3, PATCH] drm/mediatek: add dma buffer control for drm plane disable

2023-03-27 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2023年3月20日 週一 上午11:05寫道: > > Fixes: 41016fe1028e4 (drm: Rename plane->state variables in atomic update and > disable) [1] has introduction how to add Fixes tag, one information is: please use the ‘Fixes:’ tag with the first 12 characters of the SHA-1 ID, and the

Re: [PATCH v6] drm/mediatek: add mediatek-drm of vdosys0 support for mt8188

2023-03-27 Thread Chun-Kuang Hu
Hi, Jason: Jason-JH.Lin 於 2023年3月24日 週五 下午6:06寫道: > > From: Nathan Lu > > add driver data of mt8188 vdosys0 to mediatek-drm and the sub driver. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next > >

Re: [PATCH v3 1/2] drm/mediatek: Add mdp_rdma get format function

2023-04-02 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2023年3月30日 週四 上午11:26寫道: > > Add mdp_rdma get_format and get_num_formats function. For the series, applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > >

Re: [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC

2023-04-02 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2023年3月31日 週五 下午10:55寫道: > > Hi Chun-Kuang Hu, > > On 13/03/2023 16:02, Chun-Kuang Hu wrote: > > Hi, Alexandre: > > > > Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: > >> > >> Display Adaptive Ambient Light for MT836

<    2   3   4   5   6   7   8   >