Re: [PATCH v4 2/4] dt-bindings: display: mediatek: get mipitx calibration data from nvmem

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > Add properties to get get mipitx calibration data. Reviewed-by: Chun-Kuang Hu > > Reviewed-by: Rob Herring > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt| 5 +

Re: [PATCH v4 4/4] drm/mediatek: config mipitx impedance with calibration data

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > Read calibration data from nvmem, and config mipitx impedance with > calibration data to make sure their impedance are 100ohm. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c | 57 +++ > 1 file

Re: [PATCH v4 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > Add a property to control mipi tx drive current: > "drive-strength-microamp" Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt

Re: [PATCH v4 3/4] drm/mediatek: add the mipitx driving control

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > Add a property in device tree to control the driving by different > board. Reviewed-by: Chun-Kuang Hu > > Reviewed-by: Matthias Brugger > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/m

Re: [PATCH v4 4/4] drm/mediatek: config mipitx impedance with calibration data

2020-04-05 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月5日 週日 下午9:39寫道: > > > On Sat, 2020-04-04 at 22:26 +0800, Chun-Kuang Hu wrote: > > Hi, Jitao: > > > > Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > > > > > Read calibration data from nvmem, and config mipitx impedance w

Re: [PATCH] drm: mediatek: fix device passed to cmdq

2020-04-06 Thread Chun-Kuang Hu
0.748721] mediatek-drm mediatek-drm.1.auto: error -2 can't parse > gce-client-reg property (0) > ... > [2.659645] mediatek-drm mediatek-drm.1.auto: failed to request channel > [2.666270] mediatek-drm mediatek-drm.1.auto: failed to request channel Reviewed-by: Chun-Kua

Re: [PATCH v2] drm: mediatek: fix device passed to cmdq

2020-04-09 Thread Chun-Kuang Hu
0.748721] mediatek-drm mediatek-drm.1.auto: error -2 can't parse > gce-client-reg property (0) > ... > [2.659645] mediatek-drm mediatek-drm.1.auto: failed to request channel > [2.666270] mediatek-drm mediatek-drm.1.auto: failed to request channel Reviewed-by: Chun-Kua

Re: [PATCH v5 4/4] drm/mediatek: config mipitx impedance with calibration data

2020-04-10 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月10日 週五 下午12:33寫道: > > Read calibration data from nvmem, and config mipitx impedance with > calibration data to make sure their impedance are 100ohm. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_mipi_tx.c| 40 +++ > drive

Re: [PATCH v6 4/4] drm/mediatek: config mipitx impedance with calibration data

2020-04-11 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月11日 週六 下午3:45寫道: > > Read calibration data from nvmem, and config mipitx impedance with > calibration data to make sure their impedance are 100ohm. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/m

Re: [PATCH v12 4/5] soc / drm: mediatek: Move routing control to mmsys device

2020-04-16 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年3月26日 週四 下午11:45寫道: > > > > On 26/03/2020 15:51, CK Hu wrote: > > Hi, Matthias: > > > > On Thu, 2020-03-26 at 12:54 +0100, Matthias Brugger wrote: > >> Hi CK, > >> > >> On 26/03/2020 00:05, CK Hu wrote: > >>> Hi, Matthias: > >>> > >>> On Wed, 2020-03-25 at 17

Re: [PATCH v15 1/3] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage

2020-04-18 Thread Chun-Kuang Hu
git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Acked-by: Rob Herring > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao Shi > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt | 6

Re: [PATCH v15 3/3] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current

2020-04-18 Thread Chun-Kuang Hu
nkuang.hu/linux.git/log/?h=mediatek-drm-next Regards,Chun-Kuang. > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/drivers/gpu/drm/me

Re: [PATCH v6 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current

2020-04-18 Thread Chun-Kuang Hu
Hi, Rob: How do you think about this patch? This patch looks good to me. Regards, Chun-Kuang. Jitao Shi 於 2020年4月11日 週六 下午3:44寫道: > > Add a property to control mipi tx drive current: > "drive-strength-microamp" > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao

Re: [PATCH v6 1/4] drm/mediatek: disable tmds on mt2701

2020-09-14 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年9月4日 週五 下午7:01寫道: > > From: chunhui dai > > Without that patch if you use specific resolutions like 1280x1024, > I can see distortion in the output. It seems as if the > frequency for updating the pixel of the image is out of sync. > > For initialization tmds n

[GIT PULL] mediatek drm next for 5.10

2020-09-14 Thread Chun-Kuang Hu
u (3): drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver drm/mediatek: Separate mtk_hdmi_phy to an independent module phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu (1): MAINTAINERS: add files for Mediatek DRM drivers E

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月5日 週六 下午4:31寫道: > > if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > Reviewed-by: Chun-Kuang Hu &

Re: [PATCH] drm/mediatek: add exception handing in mtk_drm_probe() if component init fail

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月9日 週三 下午4:50寫道: > > mtk_ddp_comp_init() is called in a loop in mtk_drm_probe(), if it > fail, previous successive init component is not proccessed. > > Thus uninitialize valid component and put their device if component > init failed. Reviewed

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_drm_kms_init()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月11日 週五 下午7:22寫道: > > if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have > a corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. Reviewed-by: Chun-Kuang Hu > &

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_hdmi_dt_parse_pdata()

2020-09-14 Thread Chun-Kuang Hu
Hi, Yu Kuai: Yu Kuai 於 2020年9月11日 週五 下午7:22寫道: > > if of_find_device_by_node() succeed, mtk_drm_kms_init() doesn't have > a corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. Reviewed-by: Chun-Kuang Hu > &

[GIT PULL] mediatek drm fixes for 5.9

2020-09-16 Thread Chun-Kuang Hu
call ---- Chun-Kuang Hu (1): drm/mediatek: Use CPU when fail to get cmdq event Jitao Shi (1): drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp Wang Hai (1): drm/mediatek: Remove duplicated include Yu Kuai (4): drm/mediatek: Add mis

[PATCH] soc: mediatek: cmdq: Remove timeout handler in helper function

2020-09-20 Thread Chun-Kuang Hu
For each client driver, its timeout handler need to dump hardware register or its state machine information, so remove timeout handler in helper function and let client driver implement its own timeout handler. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3

Re: [PATCH] soc: mediatek: cmdq: Remove timeout handler in helper function

2020-09-21 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年9月21日 週一 下午4:53寫道: > > > > On 21/09/2020 01:42, Chun-Kuang Hu wrote: > > For each client driver, its timeout handler need to dump hardware register > > or its state machine information, so remove timeout handler in helper > >

[PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-09-27 Thread Chun-Kuang Hu
proprietary one to get the necessary data in callback function. Remove struct cmdq_client to access client instance data by struct mbox_client. Chun-Kuang Hu (4): soc / drm: mediatek: cmdq: Remove timeout handler in helper function mailbox / soc / drm: mediatek: Use mailbox rx_callback instead of

[PATCH 1/4] soc / drm: mediatek: cmdq: Remove timeout handler in helper function

2020-09-27 Thread Chun-Kuang Hu
For each client driver, its timeout handler need to dump hardware register or its state machine information, and their way to detect timeout are also different, so remove timeout handler in helper function and let client driver implement its own timeout handler. Signed-off-by: Chun-Kuang Hu

[PATCH 3/4] mailbox / soc / drm: mediatek: Remove struct cmdq_client

2020-09-27 Thread Chun-Kuang Hu
mbox_client to get struct client_instance. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 35 drivers/soc/mediatek/mtk-cmdq-helper.c | 52 include/linux/mailbox/mtk-cmdq-mailbox.h | 1 - include/linux/soc/mediatek/mtk-cmdq.h

[PATCH 2/4] mailbox / soc / drm: mediatek: Use mailbox rx_callback instead of cmdq_task_cb

2020-09-27 Thread Chun-Kuang Hu
rx_callback is a standard mailbox callback mechanism and could cover the function of proprietary cmdq_task_cb, so use the standard one instead of the proprietary one. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 17 +-- drivers/mailbox/mtk-cmdq-mailbox.c

[PATCH 4/4] drm/mediatek: Detect CMDQ execution timeout

2020-09-27 Thread Chun-Kuang Hu
CMDQ is used to update display register in vblank period, so it should be execute in next vblank. If it fail to execute in next 2 vblank, tiemout happen. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion

Re: [GIT PULL] mediatek drm next for 5.10

2020-09-28 Thread Chun-Kuang Hu
Hi, Dave & Daniel: I does not see these patches in drm-next branch. Does these patches have any problem? Regards, Chun-Kuang. Chun-Kuang Hu 於 2020年9月15日 週二 上午7:12寫道: > > Hi, Dave & Daniel: > > This includes: > > 1. Move Mediatek HDMI PHY driver from DRM folder to P

Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-10-02 Thread Chun-Kuang Hu
Hi, Jassi: Jassi Brar 於 2020年10月3日 週六 上午4:30寫道: > > On Sun, Sep 27, 2020 at 6:04 PM Chun-Kuang Hu wrote: > > > > CMDQ helper provide timer to detect execution timeout, but DRM driver > > could have a better way to detect execution timeout by vblank IRQ. > > For DR

[PATCH v5 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-08-22 Thread Chun-Kuang Hu
phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu (1): MAINTAINERS: add files for Mediatek DRM drivers MAINTAINERS | 1 + drivers/gpu/drm/mediatek/Kconfig | 2 +- drivers/gpu/drm/mediatek/Makefile

[PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kc

[PATCH v5 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig| 9

[PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-22 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAIN

[PATCH v5 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-08-22 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_h

Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-08-26 Thread Chun-Kuang Hu
Hi, Jitao: Chun-Kuang Hu 於 2020年8月18日 週二 下午10:45寫道: > > Hi, Jitao: > > Jitao Shi 於 2020年8月18日 週二 上午10:41寫道: > > > > On Tue, 2020-08-18 at 07:42 +0800, Chun-Kuang Hu wrote: > > > Hi, Jitao: > > > > > > Jitao Shi 於 2020年8月17日 週一 下午9:07寫道: >

Re: [PATCH -next] drm/mediatek: remove duplicate include

2020-08-26 Thread Chun-Kuang Hu
Hi, Wang Hai: Chun-Kuang Hu 於 2020年8月21日 週五 上午7:23寫道: > > Hi, Wang Hai: > > Wang Hai 於 2020年8月19日 週三 上午11:00寫道: > > > > Remove mtk_drm_ddp.h which is included more than once > > > > Reviewed-by: Chun-Kuang Hu > Applied to mediatek-drm-fixes [1], thank

Re: [PATCH v5 1/7] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-27 Thread Chun-Kuang Hu
inux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Frank Wunderlich > Acked-by: Rob Herring > Reviewed-by: Chun-Kuang Hu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt| 2 +- > .../devicetree/bindings/display/mediatek/mediatek,dpi

Re: [PATCH v5 2/7] drm/mediatek: add ddp routing for mt7623

2020-08-27 Thread Chun-Kuang Hu
ext [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Signed-off-by: Frank Wunderlich > Reviewed-by: Chun-Kuang Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 23 +++ >

Re: [PATCH v5 5/7] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-27 Thread Chun-Kuang Hu
Agree with Matthias, so squash this patch into 4/7, and applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Regards, > Matthias > > > Signed-off-by: Jitao Shi &

Re: Aw: Re: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

2020-08-27 Thread Chun-Kuang Hu
Hi, Frank: Matthias Brugger 於 2020年8月27日 週四 下午10:28寫道: > > > > On 27/08/2020 15:41, Frank Wunderlich wrote: > > Hi Matthias, > > > > any opinions about the dts-changes? > > > > they look good to me. > > > maybe series except the tmds-Patch get merged...so i add it only to my own > > repo till we

Re: [PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-30 Thread Chun-Kuang Hu
Hi, Chunfeng & Kishon: How do you feel about this patch? Regards, Chun-Kuang. Chun-Kuang Hu 於 2020年8月23日 週日 上午9:48寫道: > > From: CK Hu > > mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder

Re: [PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-30 Thread Chun-Kuang Hu
Hi, Chunfeng & Kishon: How do you feel about this patch? Regards, Chun-Kuang. Chun-Kuang Hu 於 2020年8月23日 週日 上午9:48寫道: > > Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > inform

Re: [PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-31 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年8月31日 週一 上午9:48寫道: > > On Mon, 2020-08-31 at 07:03 +0800, Chun-Kuang Hu wrote: > > Hi, Chunfeng & Kishon: > > > > How do you feel about this patch? > It's fine to me, > > Reviewed-by: Chunfeng Yun > Could you giv

Re: [PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-31 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2020年8月31日 週一 上午9:50寫道: > > On Sun, 2020-08-23 at 09:48 +0800, Chun-Kuang Hu wrote: > > Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to > > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > > in

Re: [PATCH v9 10/32] drm: mediatek: use common helper for a scatterlist contiguity check

2020-09-01 Thread Chun-Kuang Hu
Hi, Marek: Marek Szyprowski 於 2020年8月26日 週三 下午2:35寫道: > > Use common helper for checking the contiguity of the imported dma-buf and > do this check before allocating resources, so the error path is simpler. > Acked-by: Chun-Kuang Hu > Signed-off-by: Marek Szyprowski > ---

Re: [PATCH v9 11/32] drm: mediatek: use common helper for extracting pages array

2020-09-01 Thread Chun-Kuang Hu
to > sg_free_table(sgt) before its kfree(sgt)? Yes, we need another patch to fix that bug, But for this patch, Acked-by: Chun-Kuang Hu > > > Signed-off-by: Marek Szyprowski > > --- > > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 9 ++--- > > 1 file changed,

Re: [PATCH v5 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-09-02 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年8月23日 週日 上午9:48寫道: > > mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_hdmi_phy driver into phy driver folder. For this series, applied to mediatek-drm-next

[PATCH] drm/mediatek: Use CPU when fail to get cmdq event

2020-09-02 Thread Chun-Kuang Hu
Even though cmdq client is created successfully, without the cmdq event, cmdq could not work correctly, so use CPU when fail to get cmdq event. Fixes: 60fa8c13ab1a ("drm/mediatek: Move gce event property to mutex device node") Signed-off-by: Chun-Kuang Hu --- drivers/gpu/dr

Re: [PATCH v5 0/7] make hdmi work on bananapi-r2

2020-09-03 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年9月3日 週四 下午11:07寫道: > > Hi > > Any opinion about DTS Patches? Which maintainer will include it in tree? Is > any ack/review needed? According to maintainer list [1], the maintainer is ARM/Mediatek SoC support M: Matthias Brugger L: linux-arm-ker...@lists.infradead.org (m

Re: [PATCH] drm/mediatek: add missing put_device() call in mtk_ddp_comp_init()

2020-09-07 Thread Chun-Kuang Hu
Hi Yu Kuai: Yu Kuai 於 2020年9月5日 週六 下午4:31寫道: > > if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have > a corresponding put_device(). Thus add put_device() to fix the exception > handling for this function implementation. > This patch looks good to me, but I find another thing r

Re: [PATCH] drm/mediatek: Use CPU when fail to get cmdq event

2020-09-08 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年9月3日 週四 上午6:06寫道: > > Even though cmdq client is created successfully, without the cmdq event, > cmdq could not work correctly, so use CPU when fail to get cmdq event. Applied to mediatek-drm-fixes [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chu

Re: [RESEND PATCH v2 1/2] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-09-09 Thread Chun-Kuang Hu
will be > named next_bridge. This is a DRM-bridge related patch, how do you think about it? Regards, Chun-Kuang. > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v2: None > > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++

Re: [RESEND PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-09-09 Thread Chun-Kuang Hu
. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v2: > - Maintain error message when attach to bridge fails. (Boris) > > drivers/gpu/drm/mediatek/mtk_dpi.c | 71 ++ > 1 file changed, 42 insertions(+

Re: [RESEND PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-09-12 Thread Chun-Kuang Hu
Hi, Daniel Vetter 於 2020年9月10日 週四 下午1:48寫道: > > On Thu, Sep 10, 2020 at 06:35:21AM +0800, Chun-Kuang Hu wrote: > > Hi, Andrzej & Neil: > > > > Enric Balletbo i Serra 於 2020年8月26日 週三 > > 下午4:53寫道: > > > > > > > > Convert mt

Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > > From: Bibby Hsieh > > We can select output component by decive node port. > Main path default output component is DSI. > External path default output component is DPI. > > without this Patch i get this warning: > > WARNING: CPU: 3 PID: 70

Re: [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:19寫道: > > From: chunhui dai > > - disable tmds on phy on mt2701 > - support other resolutions like 1280x1024 If this patch does two things, it should be broken into two patches. > > without this Patch i see flickering on my TFT (1280x1024), > so

Re: [PATCH v2 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > Describe why need this patch. I think the reason is: For current mediatek dsi encoder, its possible crtc is fixed in crtc 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In some SoC the possible crtc is not fixed in this ca

Re: [PATCH v2 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-01 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年7月28日 週二 下午7:18寫道: > > From: Jitao Shi > > [Detail] > dpi/dsi get the possible_crtc by > mtk_drm_find_possible_crtc_by_comp(*drm_dev, ddp_comp) > I would like more information of why do this patch. For example: For current mediatek dsi encoder, its possible

Re: [PATCH v2 2/5] drm/mediatek: fix boot up for 720 and 480 but 1080

2020-08-02 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月2日 週日 下午12:44寫道: > > Hi, > > Am 2. August 2020 02:08:44 MESZ schrieb Chun-Kuang Hu > : > >Hi, Frank: > >> - disable tmds on phy on mt2701 > >> - support other resolutions like 1280x1024 > > > >If this

Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-02 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月2日 週日 下午4:06寫道: > > > Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr > > Von: "Chun-Kuang Hu" > > An: "Frank Wunderlich" > > Cc: "Chun-Kuang Hu" , "Philipp Zabel" > > , "Davi

Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

2020-08-03 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月3日 週一 下午6:43寫道: > > Hi > > Gesendet: Montag, 03. August 2020 um 01:47 Uhr > > Von: "Chun-Kuang Hu" > > > Now I just care about the bls to dpi. So in mediatek,disp.txt, you > > just need to add a Optional propertie

Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts > > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_drm_

Re: [PATCH v3 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-04 Thread Chun-Kuang Hu
e, so search > pipeline information to find out the correct possible crtc. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Stu Hsieh > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 42 + > drivers/gpu/drm/mediatek/mtk_

Re: [PATCH v3 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-04 Thread Chun-Kuang Hu
d in this case, so call > mtk_drm_find_possible_crtc_by_comp() to find out the correct possible > crtc. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++- > drivers/gpu/drm/mediatek/mtk_dsi.c

Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Ryder Lee > > Add display subsystem related device nodes for MT7623. > > Cc: CK Hu > Signed-off-by: chunhui dai > Signed-off-by: Bibby Hsieh > Signed-off-by: Ryder Lee > Signed-off-by: Frank Wunderlich > Tested-by: Frank Wunderl

Re: Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月4日 週二 下午10:44寫道: > > Hi, > > > Gesendet: Dienstag, 04. August 2020 um 16:34 Uhr > > Von: "Chun-Kuang Hu" > > > > -static const enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = { > > > +static enum mtk_ddp_comp_id mt2712

Re: Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
ards Frank > > > > Gesendet: Dienstag, 04. August 2020 um 17:00 Uhr > > Von: "Chun-Kuang Hu" > > An: "Frank Wunderlich" > > > + mipi_tx0: mipi-dphy@1001 { > > > + compatible = "mediatek,mt7623-mipi-tx&quo

Re: [PATCH v4 2/6] drm/mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月5日 週三 上午12:56寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts Reviewed-by: Chun-Kuang Hu > >

Re: [PATCH v4 1/6] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月5日 週三 上午12:56寫道: > > From: Frank Wunderlich > > mt7623 uses mt2701/mt8173 for drm, but have own compatibles Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Frank Wunderlich > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt

Re: [RESEND v7, PATCH 6/7] drm/mediatek: add support for mediatek SOC MT8183

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午11:05寫道: > > This patch add support for mediatek SOC MT8183 > 1. add ovl private data > 2. add rdma private data > 3. add mutes private data > 4. add main and external path module for crtc create > > Signed-off-by: Yongqiang Niu [snip] > + > stati

Re: [RESEND v7, PATCH 0/7] add drm support for MT8183

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: This series is 'v8', not 'RESEND v7' Yongqiang Niu 於 2020年8月8日 週六 上午10:56寫道: > > This series are based on 5.8-rc1 and provide 7 patch > to support mediatek SOC MT8183 > > Change since v6 > - move ddp component define into mtk_mmsys.h > - add mmsys private data to support different

Re: [RESEND v7, PATCH 2/7] drm/mediatek: move ddp component define into mtk_mmsys.h

2020-08-08 Thread Chun-Kuang Hu
Yongqiang Niu 於 2020年8月8日 週六 上午11:05寫道: > > mmsys is the driver which control the routing of these ddp component, > so the definition of mtk_ddp_comp_id should be placed in mtk-mmsys.h > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Yongqiang Niu > --- > dri

Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午11:04寫道: > > rdma fifo size may be different even in same SOC, add this > property to the corresponding rdma > > Change-Id: I67635ec7f3f59cf4cbc7737285e5e28ff0ab71c9 Remove change-id. > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/

Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-08-08 Thread Chun-Kuang Hu
Hi, Yongqiang: Chun-Kuang Hu 於 2020年8月9日 週日 上午8:56寫道: > > Hi, Yongqiang: > > Yongqiang Niu 於 2020年8月8日 週六 上午11:04寫道: > > > > rdma fifo size may be different even in same SOC, add this > > property to the corresponding rdma > > > > Change-Id: I67635ec7f

Re: [RESEND v7, PATCH 3/7] mtk-mmsys: add mmsys private data

2020-08-10 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月8日 週六 上午10:56寫道: > > the reason why split out display connection function: > 1. there will more and more Mediatek Soc upstream, and the display path > connection function mtk_mmsys_ddp_mout_en, mtk_mmsys_ddp_sel_in and > mtk_mmsys_ddp_sout_sel will complicate

Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-08-17 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年8月17日 週一 下午9:07寫道: > > horizontal_backporch_byte should be hbp * bpp - hbp extra bytes. > So remove the wrong subtraction 10. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > >

Re: [PATCH v2] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-08-18 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年8月18日 週二 上午10:41寫道: > > On Tue, 2020-08-18 at 07:42 +0800, Chun-Kuang Hu wrote: > > Hi, Jitao: > > > > Jitao Shi 於 2020年8月17日 週一 下午9:07寫道: > > > > > > horizontal_backporch_byte should be hbp * bpp - hbp extra bytes

[PATCH v4 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-19 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu Reviewed-by: Chunfeng Yun Reviewed-by: Mat

[PATCH v4 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-08-19 Thread Chun-Kuang Hu
refix. Changes in v2: - include module.h in mtk_hdmi.c CK Hu (3): drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver drm/mediatek: Separate mtk_hdmi_phy to an independent module phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder Chun-Kuang

[PATCH v4 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-08-19 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_h

[PATCH v4 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-08-19 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu Reviewed-by: Chunfeng Yun --- drivers/gpu/drm

[PATCH v4 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-19 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu Reviewed-by: Matthias Brugger --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAIN

Re: [PATCH -next] drm/mediatek: remove duplicate include

2020-08-20 Thread Chun-Kuang Hu
Hi, Wang Hai: Wang Hai 於 2020年8月19日 週三 上午11:00寫道: > > Remove mtk_drm_ddp.h which is included more than once > Reviewed-by: Chun-Kuang Hu > Reported-by: Hulk Robot > Signed-off-by: Wang Hai > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - > 1 file changed, 1 de

Re: [PATCH v4 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-08-20 Thread Chun-Kuang Hu
Hi, Randy: Randy Dunlap 於 2020年8月19日 週三 下午11:58寫道: > > On 8/19/20 8:44 AM, Chun-Kuang Hu wrote: > > diff --git a/drivers/gpu/drm/mediatek/Kconfig > > b/drivers/gpu/drm/mediatek/Kconfig > > index aa74aac3cbcc..ca3cd871a350 100644 > > --- a/drivers/gpu/drm/mediatek

Re: [PATCH v4 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-20 Thread Chun-Kuang Hu
Hi, Randy: Randy Dunlap 於 2020年8月20日 週四 上午12:00寫道: > > On 8/19/20 8:44 AM, Chun-Kuang Hu wrote: > > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig > > index dee757c957f2..10f0ec2d5b54 100644 > > --- a/drivers/phy/mediatek/Kconfig > > +++

Re: [PATCH v4 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-20 Thread Chun-Kuang Hu
Hi, Sam: Sam Ravnborg 於 2020年8月20日 週四 上午12:04寫道: > > Hi Chun-Kuang > > Two small details below. > > Sam > > On Wed, Aug 19, 2020 at 11:44:20PM +0800, Chun-Kuang Hu wrote: > > From: CK Hu > > > > mtk_hdmi_phy is currently placed inside mediatek

Re: [PATCH v1 04/21] mtk-mmsys: add mt8192 mmsys support

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:16寫道: > > add mt8192 mmsys support > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/Makefile | 1 + > drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 159 > ++ > 2 files changed, 160 insertions(

Re: [PATCH v1 05/21] mtk-mmsys: add ovl mout on support

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:16寫道: > > add ovl mout on support > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 23 +++ > drivers/soc/mediatek/mtk-mmsys.c | 8 > include/linux/soc/mediatek/mtk-mmsys.h

Re: [PATCH v1 06/21] drm/mediatek: add disp config and mm 26mhz clock into mutex device

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:06寫道: > > there are 2 more clock need enable for display. > parser these clock when mutex device probe, > enable and disable when mutex on/off > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 49 > +++

Re: [PATCH v1 07/21] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2020-08-20 Thread Chun-Kuang Hu
HI, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:06寫道: > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > b

Re: [PATCH v1 08/21] drm/mediatek: check if fb is null

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:06寫道: > > It's possible that state->base.fb is null. Add a check before access its > format. Add a Fixes tag. Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- > 1 file changed, 1 ins

Re: [PATCH v1 09/21] drm/mediatek: fix aal size config

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:18寫道: > > fix aal size config > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c >

Re: [PATCH v1 14/21] drm/mediatek: add bypass shadow register function call for ddp component

2020-08-20 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2020年8月20日 週四 下午2:18寫道: > > the shadow register for mt8192 ddp component is enable, > we need disable it before enable ddp component MT2701 has shadow register and use it. Why MT8192 have shadow register but disable it? I would like to use shadow register like MT27

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: > > Hi Chun-Kuang, > > Missatge de Enric Balletbo i Serra del > dia dv., 1 de maig 2020 a les 17:25: > > > > Use the drm_bridge_connector helper to create a connector for pipelines > > that use drm_bridge. This allows splitting connector

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月14日 週四 下午11:42寫道: > > Hi Chun-Kuang, > > On 14/5/20 16:28, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: > >> > >> Hi Chun-Kuang, > >> > >&g

Re: [PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-16 Thread Chun-Kuang Hu
Hi, Enric: Chun-Kuang Hu 於 2020年5月10日 週日 上午9:24寫道: > > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月4日 週一 > 下午10:14寫道: > > > > The mtk-dpi driver still uses the drm_encoder API which is now somehow > > deprecated. We started to move all the Mediatek d

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-16 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月15日 週五 上午1:35寫道: > > Hi again, > > On 14/5/20 19:12, Enric Balletbo i Serra wrote: > > Hi Chun-Kuang, > > > > On 14/5/20 18:44, Chun-Kuang Hu wrote: > >> Hi, Enric: > >> > >> Enric Balletbo i Se

[GIT PULL v2] mediatek drm next for 5.8

2020-05-17 Thread Chun-Kuang Hu
ek a bit drm/mediatek: Eliminate the magic number in array size Chun-Kuang Hu (1): Merge tag 'v5.7-next-drm-stable' of ssh://gitolite.kernel.org/.../matthias.bgg/linux into mediatek-drm-next Enric Balletbo i Serra (4): dt-bindings: mediatek: Update mmsys binding to reflect

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-05-18 Thread Chun-Kuang Hu
just delete the call to > of_device_get_match_data. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Matthias Brugger > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >

Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-05-19 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月19日 週二 下午5:40寫道: > > There are some `static const u8` variables that are not used, this > triggers a warning building with `make W=1`, it is safe to remove them, > so do it and make the compiler more happy. > Reviewed-by: Chun-Kuang Hu

<    2   3   4   5   6   7   8   >