;enum drm_mode_status' in the driver too.
>
> Signed-off-by: Luc Van Oostenryck
amd-gfx mailing list should be sufficient for changes like these.
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c| 8
> drivers/gpu/drm/amd
On 2018-04-24 08:09 AM, Daniel Vetter wrote:
> On Mon, Apr 23, 2018 at 02:19:44PM -0700, Manasi Navare wrote:
>> On Mon, Apr 23, 2018 at 10:40:06AM -0400, Harry Wentland wrote:
>>> On 2018-04-20 04:32 PM, Manasi Navare wrote:
>>>> On Wed, Apr 18, 2018 at 09:39:0
On 2017-10-11 03:46 PM, Maarten Lankhorst wrote:
> Op 11-10-17 om 20:55 schreef Leo:
>>
>>
>> On 2017-10-11 10:30 AM, Maarten Lankhorst wrote:
>>> Op 11-10-17 om 16:24 schreef sunpeng...@amd.com:
From: "Leo (Sunpeng) Li"
Use the correct for_each_new/old_* iterators instead of for_ea
On 2017-10-12 05:15 PM, sunpeng...@amd.com wrote:
> From: "Leo (Sunpeng) Li"
>
> To conform to DRM's new API, we should not be accessing a DRM object's
> internal state directly. Rather, the DRM for_each_old/new_* iterators,
> and drm_atomic_get_old/new_* interface should be used.
>
> This is an
Patches 3-6 are
Reviewed-by: Harry Wentland
Harry
On 2017-10-12 05:15 PM, sunpeng...@amd.com wrote:
> From: "Leo (Sunpeng) Li"
>
> Hi Dave,
>
> This series reworks the previous patch. Patch 1 is a v2 of the previous,
> and additional patches are from the feedback
On 2017-10-13 01:26 PM, Andrey Grodzovsky wrote:
>
>
> On 10/13/2017 12:18 PM, Harry Wentland wrote:
>> On 2017-10-12 05:15 PM, sunpeng...@amd.com wrote:
>>> From: "Leo (Sunpeng) Li"
>>>
>>> To conform to DRM's new API, we should no
rm/amd/dc: Add dc display driver (v2)")
> CC: Harry Wentland
> Signed-off-by: Fengguang Wu
Reviewed-by: Harry Wentland
Harry
> ---
>
> gpio_service.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/gpu/drm/amd/amdgpu/../disp
/coccinelle/free/ifnullfree.cocci
>
> Fixes: f09cd1f46388 ("drm/amd/display: Use kernel alloc/free")
> Signed-off-by: Fengguang Wu
Reviewed-by: Harry Wentland
Harry
> ---
>
> gpio_service.c |6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>
.
>
> v3: Say "functions considered" instead of "affected functions". The
> latter implies that changes are made to each.
>
> Signed-off-by: Leo (Sunpeng) Li
Patches 1-2 (v3) are also
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/dis
On 2017-10-18 04:10 AM, Daniel Vetter wrote:
> On Tue, Oct 17, 2017 at 09:01:52PM +0200, Nicolai Hähnle wrote:
>> On 17.10.2017 19:16, Daniel Vetter wrote:
>>> On Tue, Oct 17, 2017 at 5:40 PM, Michel Dänzer wrote:
On 17/10/17 05:04 PM, Daniel Vetter wrote:
> On Tue, Oct 17, 2017 at 03:46:
t;
> Marking the constant as explicitly unsigned makes it work fine everywhere
> without warnings.
>
> Signed-off-by: Arnd Bergmann
Thanks for these fixes.
Series is
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +-
> 1 fil
to build again.
>
> Signed-off-by: Arnd Bergmann
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/os_types.h | 4
> 1 file changed, 4 deletions(-)
>
> v2: remove accidtental comment change.
>
> diff --git a/drivers/gpu/drm/amd
Bergmann
Looks like 'str' isn't even used here.
Either way, this change by itself is correct and
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu
Thanks, Dan, for bringing this to our attention. We (the display guys here)
weren't aware of smatch and will give it a spin and try to address some of the
remaining items (after your, Dave's, and Ernst's patches).
Harry
On 2017-11-06 06:34 AM, Dan Carpenter wrote:
> Linux-next was offline for t
On 2018-03-06 02:51 AM, Daniel Vetter wrote:
> On Fri, Feb 23, 2018 at 11:26:41AM -0500, Harry Wentland wrote:
>> On 2018-02-22 04:42 PM, Ville Syrjala wrote:
>>> From: Ville Syrjälä
>>>
>>> The documentation for the ctm matrix suggests a two's com
On 2018-03-06 05:35 AM, Daniel Vetter wrote:
> On Mon, Mar 05, 2018 at 05:44:16PM -0500, Harry Wentland wrote:
>> On 2018-03-05 04:33 PM, Alex Deucher wrote:
>>> On Mon, Mar 5, 2018 at 4:15 PM, Ville Syrjälä
>>> wrote:
>>>> On Mon, Mar 05, 2018 at 12:59:00P
ty
>
Yeah, it's because the dc_sink carries the EDID and is only created at this
point for us. It's bugged me ever since we did this. Might be time to think of
a solution to it now.
Harry
>>
>> Otherwise I think this is a real good patch.
>>
>> Thanks,
On 2018-03-06 12:13 PM, Daniel Vetter wrote:
> On Tue, Mar 06, 2018 at 11:23:23AM -0500, Harry Wentland wrote:
>> On 2018-03-06 07:18 AM, Ville Syrjälä wrote:
>>> On Tue, Mar 06, 2018 at 10:31:27AM +0100, Daniel Vetter wrote:
>>>> On Tue, Feb 27, 2018 at 02:57:0
On 2018-03-06 10:10 PM, Shirish S wrote:
> Add reverse iterator for_each_oldnew_plane_in_state_reverse to
> compliment the for_each_oldnew_plane_in_state way or reading plane
> states.
>
> The plane states are required to be read in reverse order for
> amd drivers, cause the z order convention fol
On 2018-03-22 01:54 PM, Emil Velikov wrote:
> Hi Ville,
>
> On 22 March 2018 at 15:22, Ville Syrjala
> wrote:
>> From: Ville Syrjälä
>>
>> I really just wanted to fix i915 to re-enable its planes afer load
>> detection (a two line patch). This is what I actually ended up with
>> after I ran int
On 2018-03-22 11:23 AM, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> We want to get rid of plane->fb on atomic drivers. Stop setting it.
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: "David (ChunMing) Zhou"
> Cc: Harry Wentland
>
On 2018-03-30 12:00 PM, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in DRM_ERROR error message text
>
> Signed-off-by: Colin Ian King
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
a Response Timeout period of 300us.
>
> This state is useful in a MST dock + MST monitor configuration that
> doesn't wake up from D3 state.
>
> v2: Use spaces instead of tabs (Jani)
>
> Signed-off-by: Dhinakaran Pandiyan
Reviewed-by: Harry Wentland
Harry
> --
On 2017-08-16 01:22 PM, Daniel Vetter wrote:
> On Wed, Aug 16, 2017 at 7:12 PM, Alex Deucher wrote:
>> On Wed, Aug 16, 2017 at 10:22 AM, Jerry Zuo wrote:
>>> During page flip atomic_check and atomic_commit can return
>>> -ERESTARTSYS to restart the ioctl. When this happens we fail to
>>> put the
On 2017-08-29 09:12 AM, Himanshu Jha wrote:
> kfree on NULL pointer is a no-op and therefore checking is redundant.
>
> Signed-off-by: Himanshu Jha
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 6 +-
> .../gpu/drm/a
files are utterly horrible to read and not
> anything close to kernel coding style standards. But that's the point,
> they're essentially gospel from hw engineers that happens to be
> parseable by gcc.
>
> Signed-off-by: Daniel Vetter
Thanks for the feedback, ack a
On 2017-09-27 12:48 PM, Daniel Vetter wrote:
> On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul wrote:
>> Any chance we can address the i2c/gpio [re-]implementations as well?
>
> It's already on the list. Part of this is code that's probably dead,
> the other is a bit too much layer cake still left, an
Patches to make DC use kzalloc/krealloc/kfree directly.
Also updating the TODO list after a closer look at I2C in DC.
Harry Wentland (3):
drm/amd/display: Use kernel alloc/free
drm/amd/display: Remove alloc/free macros
drm/amd/display: DC I2C review
drivers/gpu/drm/amd/display/TODO
Abstractions are frowned upon.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
drivers/gpu/drm/amd/display/dc/basics/logger.c | 18 ---
drivers/gpu/drm/amd/display/dc/basics/vector.c | 19 +++
drivers/gpu/drm/amd/display/dc/bios
x27;s
currently functionality in DRM. If not we can propose something.
4) HDMI retimer programming
Some boards have an HDMI retimer that we need to program to pass PHY
compliance.
1 & 3 might be a good exercise if someone is looking for things to do.
Signed-off-by: Harry Wentland
---
drivers/
Now that we don't abstract kernel alloc interfaces we don't need
those anymore.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dm_services.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dm_services.h
b/drivers/gpu/drm/amd/
On 2017-09-27 02:12 PM, Harry Wentland wrote:
> On 2017-09-27 12:48 PM, Daniel Vetter wrote:
>> On Wed, Sep 27, 2017 at 6:38 PM, Sean Paul wrote:
>>> Any chance we can address the i2c/gpio [re-]implementations as well?
>>
>> It's already on the list. Part o
)
+ kfree(ptr)
v2: use GFP_KERNEL, not GFP_ATOMIC. add cocci script
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
drivers/gpu/drm/amd/display/dc/basics/logger.c | 18 ---
drivers/gpu/drm/amd/display/dc/basics/vector.c | 19 +++
drivers
x27;s
currently functionality in DRM. If not we can propose something.
4) HDMI retimer programming
Some boards have an HDMI retimer that we need to program to pass PHY
compliance.
1 & 3 might be a good exercise if someone is looking for things to do.
v2: Merge dp_dual_mode_adaptor TODO
Signed-off
It's not in a good shape and currently completely unused.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 9 -
drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 2 +-
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dwb.c
This threw me for a loop when I read the docs. I imagine this is the
intended definition:
http://www.dictionary.com/browse/nerf
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/drm_ioctl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm
On 2018-02-15 12:32 AM, Daniele Castagna wrote:
> From: "uma.shankar at intel.com (Uma Shankar)"
>
> Add plane gamma as blob property and size as a
> range property.
>
Plane degamma & CTM make sense to me but I'm not sure why gamma would be on a
per-plane basis. That said, HW sometimes has the
On 2018-02-15 11:40 AM, Daniel Stone wrote:
> Hi Harry,
>
> On 15 February 2018 at 16:28, Harry Wentland wrote:
>> This threw me for a loop when I read the docs. I imagine this is the
>> intended definition:
>> http://www.dictionary.com/browse/nerf
>
9 have a dedicated csc for yuv->rgb before degamma? Or are you
> supposed to use the same csc for that as you'd use for ctm? In that case
> I can understand why the hw would have a gamm lut on each side of the
> csc. But it would also means that you can't do yuv->rgb and
On 2018-02-19 03:28 PM, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Include color_enconding and color_range in the plane state dump.
>
> v2: Add kerneldoc (danvet)
>
> Cc: Harry Wentland
> Cc: Daniel Vetter
> Cc: Daniel Stone
> Cc: Russell King - ARM Linux
On 2018-02-19 10:27 AM, Daniel Vetter wrote:
> On Thu, Feb 15, 2018 at 03:33:17PM -0500, Alex Deucher wrote:
>> On Thu, Feb 15, 2018 at 2:56 PM, Harry Wentland
>> wrote:
>>> On 2018-02-15 11:40 AM, Daniel Stone wrote:
>>>> Hi Harry,
>>>>
&
not trying :-)
>
This shouldn't really hurt anything, other than throw DEBUG warnings if
DEBUG_MUTEXES is on.
Acked-by: Harry Wentland
Harry
> Cheers, Daniel
>
>> ---
>> drivers/gpu/drm/drm_modeset_lock.c | 1 +
>> 1 file changed, 1 insertion(+)
>&
kar
> Cc: Shashank Sharma
> Signed-off-by: Ville Syrjälä
Good clarification. Our new CTM implementation (1) actually assumed two's
complement but nobody's using it yet, so we'll patch it to convert.
Reviewed-by: Harry Wentland
(1) https://patchwork.freedesktop.org/patc
On 2018-03-01 02:56 AM, S, Shirish wrote:
> From: Shirish S
>
> Add reverse iterator for_each_oldnew_plane_in_state_reverse to compliment the
> for_each_oldnew_plane_in_state way or reading plane states.
>
> The plane states are required to be read in reverse order for amd drivers,
> cause the
On 2018-03-05 04:33 PM, Alex Deucher wrote:
> On Mon, Mar 5, 2018 at 4:15 PM, Ville Syrjälä
> wrote:
>> On Mon, Mar 05, 2018 at 12:59:00PM -0800, Eric Anholt wrote:
>>> Ville Syrjala writes:
>>>
From: Ville Syrjälä
To make life easier for drivers, let's have the core check that th
ed-off-by: Manasi Navare
Both patches look right according to DP 1.4 spec.
Series is
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/drm_dp_helper.c | 4
> drivers/gpu/drm/drm_dp_mst_topology.c | 3 +++
> include/drm/drm_dp_helper.h | 1 +
> 3 files c
On 2018-01-24 01:37 PM, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> We use 32bit bitmasks to track planes/crtcs/encoders/connectors.
> Naturally we can only do that if the index of those objects stays
> below 32. Issue a warning whenever we exceed that limit, hopefully
> prompting someone to f
On 2018-01-24 04:24 PM, Ville Syrjälä wrote:
> On Wed, Jan 24, 2018 at 04:01:18PM -0500, Harry Wentland wrote:
>> On 2018-01-24 01:37 PM, Ville Syrjala wrote:
>>> From: Ville Syrjälä
>>>
>>> We use 32bit bitmasks to track planes/crtcs/encoders/connectors.
>
it the maximum
> value the ida is allowed to hand out. The error handling is already
> in place.
>
> v2: Return an error to the caller (Harry)
> v3: Print a debug message so that we know what happened (Maarten)
>
> Cc: Harry Wentland
> Cc: Maarten Lankhorst
> Cc: D
On 2018-01-29 05:55 PM, Alex Deucher wrote:
> On Mon, Jan 29, 2018 at 5:35 PM, wrote:
>> On Mon, Jan 29, 2018 at 03:40:34PM -0500, Alex Deucher wrote:
>>> On Mon, Jan 29, 2018 at 3:34 PM, wrote:
As far as I can remember, not for the new features ofc, DCE programming
for GCN1
is
t; Acked-by: Daniel Vetter
Reviewed-by: Harry Wentland
Harry
> Cc: Daniel Vetter
> ---
> drivers/gpu/drm/drm_atomic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 51a848c553
On 2018-01-31 09:31 AM, Chris Chiu wrote:
> Hi,
> We are working with new laptops that have the AMD Ravenl Ridge
> chipset with this `/proc/cpuinfo`
> https://gist.github.com/mschiu77/b06dba574e89b9a30cf4c450eaec49bc
>
> With the latest kernel 4.15, there're lots of different
> panics/oops
On 2018-01-30 05:28 AM, Maarten Lankhorst wrote:
> Op 29-01-18 om 16:41 schreef Leo Li:
>> Updated IGT results seem sane:
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7698/shards.html
>>
>> Would someone be able to apply this patch?
>>
> Thanks for the reminder, pushed.
>
Thanks, Maarten
On 2018-02-01 05:30 AM, Maarten Lankhorst wrote:
> Op 31-01-18 om 20:57 schreef Harry Wentland:
>> On 2018-01-30 05:28 AM, Maarten Lankhorst wrote:
>>> Op 29-01-18 om 16:41 schreef Leo Li:
>>>> Updated IGT results seem sane:
>>>> https://intel-gfx-ci.01.o
cture to a new shared header file and uses the superset
> of the members, to ensure the interfaces are all compatible.
>
> Fixes: ae79c310b1a6 ("drm/amd/display: Add DCE12 bios parser support")
> Signed-off-by: Arnd Bergmann
Thanks for the fix.
Reviewed-by: Harry We
On 2018-02-01 08:55 PM, db...@chromium.org wrote:
> From: Dominik Behr
>
> v2: now with fixed result comparison and spelling fixes
>
> Signed-off-by: Dominik Behr
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
> drivers/gpu/drm/amd/display/dc/core/dc_link.c
On 2018-02-02 11:02 AM, Arnd Bergmann wrote:
> On Fri, Feb 2, 2018 at 4:39 PM, Harry Wentland wrote:
>> On 2018-02-02 07:31 AM, Arnd Bergmann wrote:
>>> Building the amd display driver with link-time optimizations revealed a bug
>>
>> Curious how I'd go about bu
On 2018-02-02 04:37 PM, db...@chromium.org wrote:
> From: Dominik Behr
>
> Replace SUCESSFULL with SUCCESSFUL.
>
> Signed-off-by: Dominik Behr
Series is
Reviewed-by: Harry Wentland
Will pull it into amd-stg over the weekend or on Monday.
Harry
> ---
> driver
it reference HW vblank count. Explicitly typecasting this down
> to u32 either fixes a potential problem or serves to add clarity in case
> the typecasting was implicitly done.
>
> Cc: Keith Packard
> Cc: Alex Deucher
> Cc: Harry Wentland
> Signed-off-by: Dhinakaran Pan
ous parentheses
> [-Werror,-Wparentheses-equality]
> if ((data->graphics_micro_tile_mode == bw_def_rotated_micro_tiling)) {
>
> Signed-off-by: Matthias Kaehlcke
Thanks.
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c |
m-conversion]
> xfm_dce, tbl_entry, GRAPHICS_CSC_ADJUST_TYPE_SW);
>
> Signed-off-by: Matthias Kaehlcke
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dce110/dce110_opp_csc_v.c | 2
On 2018-02-07 08:51 PM, Matthias Kaehlcke wrote:
> Use subdir-ccflags instead of specifying the same flags for every source
> file.
>
> Signed-off-by: Matthias Kaehlcke
> Reviewed-by: Guenter Roeck
> ---
> Changes in v2:
> - added 'Reviewed-by: Guenter Roeck ' tag
>
> drivers/gpu/drm/amd/displ
of two like -mpreferred-stack-boundary.
>
> Probe for both compiler options and use the correct one, similar to
> what is done in arch/x86/Makefile.
>
> Signed-off-by: Matthias Kaehlcke
Series is
Reviewed-by: Harry Wentland
Harry
> ---
> Changes in v3:
> - patch added
On 2018-02-08 04:03 PM, Harry Wentland wrote:
> On 2018-02-08 03:53 PM, Matthias Kaehlcke wrote:
>> calcs uses the compiler option -mpreferred-stack-boundary=4 to configure
>> a stack alignment of 16 bytes. Clang uses the option -mstack-alignment
>> instead, which exp
On 2018-02-09 04:28 PM, Matthias Kaehlcke wrote:
> dce_clock_set_min_clocks_state() assigns (intentionally) a value of type
> 'enum dm_pp_clocks_state' to a variable of type 'enum dm_pp_power_level'
> without an explicit cast. This causes clang to raise the following
> warning:
>
> drivers/gpu/drm
On 2017-07-24 09:35 AM, Ricardo Ribalda Delgado wrote:
> amd_powerplay_display_configuration_change is never called.
>
> Signed-off-by: Ricardo Ribalda Delgado
> ---
> drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 21 -
> drivers/gpu/drm/amd/powerplay/inc/amd_powerplay.
On 2017-07-24 10:06 AM, Ricardo Ribalda Delgado wrote:
> Hi Harry
> On Mon, Jul 24, 2017 at 4:01 PM, Harry Wentland
> wrote:
>
>>
>> This is used and needed by the DC display driver. See
>> display/amdgpu_dm/amdgpu_dm_services.c:193 in Alex's
by another one during suspend),
> no hotplug event will be triggered so the change will not be caught at
> resume time. Detecting that the EDID changed allows detecting it.
>
This makes sense and could be used by other drivers.
Acked-by: Harry Wentland
Harry
> Signe
On 2017-07-26 09:47 AM, Ricardo Ribalda Delgado wrote:
> Hi Harry
>
> On Mon, Jul 24, 2017 at 5:45 PM, Harry Wentland
> wrote:
>> On 2017-07-24 10:06 AM, Ricardo Ribalda Delgado wrote:
>>> Hi Harry
>>> On Mon, Jul 24, 2017 at 4:01 PM, Harry Wentland
>&
Hi David,
upstream kernels currently have only headless support. We're still
working on getting our display driver accepted upstream but in the
meantime you can compile it yourself from
https://cgit.freedesktop.org/~agd5f/linux/?h=amd-staging-4.12. With this
you should have no issues booting to de
"%s: Link Training Error, could not \
> - get CR after %d tries. \
> - Possibly voltage swing issue", __func__,
> + "%s: Link Training Error, could not get CR
Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> b/drivers
Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Harry Wentland
Harry
> ---
> .../drm/amd/display/dc/dce110/dce110_mem_input_v.c | 28
> +++---
> 1 file changed, 8 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce
off-by: Colin Ian King
Thanks. I got the same patch but was too slow to post.
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm
state);
> + if (!disconnected_acrtc)
> + return;
>
> - if (!disconnected_acrtc || !acrtc_state->stream)
> + acrtc_state = to_dm_crtc_state(disconnected_acrtc->base.state);
> + if (!acrtc_state->stream)
> return;
This part is already in
On 2017-12-04 08:08 AM, Arnd Bergmann wrote:
> Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y
> and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions
> that do a comparison of floating-point variables:
>
> drivers/gpu/drm/amd/display/dc/calcs/dc
On 2017-12-05 07:05 AM, Arnd Bergmann wrote:
> On Mon, Dec 4, 2017 at 9:34 PM, Harry Wentland wrote:
>> On 2017-12-04 08:08 AM, Arnd Bergmann wrote:
>>> Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y
>>> and CONFIG_KCOV_ENABLE_COMPARISONS=
0")
>
> Signed-off-by: Colin Ian King
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> b
This looks similar to this bug that I spotted while finally going through my
large dri-devel backlog: https://bugzilla.kernel.org/show_bug.cgi?id=198123
The discussion continues here
https://lists.freedesktop.org/archives/dri-devel/2017-December/160667.html
Not sure if this is related but the s
Hi Drake,
thanks for your extensive testing, solid test results, and help in tracking
bugs across multiple branches. These results are quite helpful.
If you have any questions don't hesitate to let us know.
Btw, great job you're doing with Endless OS. I've never tried it but I like
your approa
On 2017-12-27 04:04 AM, Michel Dänzer wrote:
> On 2017-12-27 05:43 AM, Dieter Nützel wrote:
>> Hello AMD team,
>>
>> I got this since latest 'amd-staging-drm-next' git update
>> (#b956c586e58a) during boot with Polaris RX580 DC on:
>>
>> [ 3.586342] [drm:dal_bios_parser_init_cmd_tbl [amdgpu]] *E
On 2017-12-31 10:17 AM, Alex Deucher wrote:
> On Fri, Dec 29, 2017 at 6:11 AM, Daniel Drake wrote:
>> From: Yue Hin Lau
>>
>> Signed-off-by: Yue Hin Lau
>> Reviewed-by: Eric Bernstein
>> Acked-by: Harry Wentland
>> Signed-off-by: Alex Deucher
&
A515-41G (AMD A10-9620 RADEON R5)
>
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=104319
>
> Harry Wentland (1):
> drm/amd/display: Both timing_sync and multisync need stream_count > 1
>
> Leo (Sunpeng) Li (1):
> drm/amd/display: Change frontend/backend pr
On 2018-01-05 10:54 AM, Li, Samuel wrote:
> I think Andrey approved your patch last December?
> If you mean the driver actually set up fb in gart memory, that is not
> included in this series. I can do that in another patch.
>
Sounds good.
Harry
> Regards,
> Samuel Li
>
>
>> -Original Me
On 2018-01-04 04:11 PM, Samuel Li wrote:
> From: Christian König
>
> On CZ and newer APUs we can pin the fb into GART as well as VRAM.
>
> v2: Don't enable gpu_vm_support for Raven yet since it leads to
> a black screen. Need to debug this further before enabling.
I can't find the part to e
nabling.
>
> Change-Id: Id0f8af3110e54a3aabf7a258871867bc121cc1a2
> Signed-off-by: Christian König
> Reviewed-by: Andrey Grodzovsky
> Acked-by: Alex Deucher
> Signed-off-by: Samuel Li
Looks good for amdgpu_dm change. Still don't know much about memory spaces but
patch is
Acked-by
Li
No expert on this but looks sane to me.
Acked-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c
> b/drivers/gpu/drm/drm_atomic_helper.c
> index
Oland is DCE 6 and won't default to DC.
Harry
On 2024-01-04 10:51, Christian König wrote:
> Hi Olliver,
>
> well as long as you don't explicitly disable the support for the older hw
> generations the R7 250 is still supported and should still work perfectly
> fine.
>
> What you see here is basi
On 2023-12-08 08:32, Pekka Paalanen wrote:
> On Wed, 8 Nov 2023 11:36:42 -0500
> Harry Wentland wrote:
>
>> A whole slew of tests for CTM handling that greatly helped in
>> debugging the CTM code. The extent of tests might seem a bit
>> silly but they're
On 2023-12-08 08:11, Pekka Paalanen wrote:
> On Wed, 8 Nov 2023 11:36:40 -0500
> Harry Wentland wrote:
>
>> We add two 3x4 matrices into the VKMS color pipeline. The reason
>> we're adding matrices is so that we can test that application
>> of a matrix and it
> 4294967296 00 00 00 00 4294967296 00
>
> DPP Color Caps: input_lut_shared:0 icsc:1 dgam_ram:1 dgam_rom:
> srgb:1,bt2020:1,gamma2_2:0,pq:0,hlg:0 post_csc:0 gamcor:0
> dgam_rom_for_yuv:1 3d_lut:1 blnd_lut:1 oscs:0
>
On 2024-01-19 13:25, Ville Syrjälä wrote:
On Fri, Jan 19, 2024 at 03:12:35PM -0300, André Almeida wrote:
AMD GPUs can do async flips with changes on more properties than just
the FB ID, so implement a custom check_async_props for AMD planes.
Allow amdgpu to do async flips with IN_FENCE_ID an
On 2024-01-23 13:02, Xaver Hugl wrote:
> Am Mo., 22. Jan. 2024 um 16:50 Uhr schrieb Harry Wentland
> :
>>
>>
>>
>> On 2024-01-19 13:25, Ville Syrjälä wrote:
>>> On Fri, Jan 19, 2024 at 03:12:35PM -0300, André Almeida wrote:
>>>> AMD GPUs can
properties.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3034
Cc: sta...@vger.kernel.org
Signed-off-by: Xaver Hugl
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a
On 2023-12-07 14:30, Xaver Hugl wrote:
Sorry, it looks like I sent this too soon. I tested the patch on a
second PC and it doesn't fix the issue there.
Ah, too bad. Won't merge it then.
Harry
Am Do., 7. Dez. 2023 um 19:25 Uhr schrieb Xaver Hugl :
With VRR, every atomic commit affectin
On 2023-12-07 09:30, Pekka Paalanen wrote:
> On Wed, 8 Nov 2023 11:36:23 -0500
> Harry Wentland wrote:
>
>> Debugging LUT math is much easier when we can unit test
>> it. Add kunit functionality to VKMS and add tests for
>> - get_lut_index
>> - lerp_u16
&
On 2024-09-09 13:11, Alex Deucher wrote:
> On Sun, Sep 8, 2024 at 7:23 AM Tobias Jakobi
> wrote:
>>
>> On 9/8/24 09:35, Christopher Snowhill wrote:
>>
>>> On Mon Sep 2, 2024 at 2:40 AM PDT, tjakobi wrote:
From: Tobias Jakobi
Hello,
this fixes a nasty race condition in
gamut mapping).
> Here's a branch that generates the color pipeline each frame and
> triggers this:
> https://invent.kde.org/plasma/kwin/-/commits/work/zamundaaa/drm-colorop-list-add-corruption
>
Thanks for the test branch. Got a repro and will investigate.
Harry
>
>
>
Signed-off-by: Harry Wentland
---
It was a stupid mistake on my part. The duplicate_state
function needs to take a reference to the blob.
This should fix it. Please give it a try if you can.
I'll roll it into the patch that introduces the bug in
my v6.
Harry
drivers/gpu/drm/drm_colorop.
On 2024-08-26 12:57, Mario Limonciello wrote:
> On 8/24/2024 13:33, Thomas Weißschuh wrote:
>> Not all platforms provide the full range of PWM backlight capabilities
>> supported by the hardware through ATIF.
>> Use the generic drm panel minimum backlight quirk infrastructure to
>> override the
1001 - 1100 of 1155 matches
Mail list logo
