Re: [PATCH v6] drm/rockchip: Refactor the component match logic.

2017-03-20 Thread Heiko Stuebner
effy Chen <jeffy.c...@rock-chips.com> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> > Acked-by: Mark Yao <mark@rock-chips.com> On rk3036 and rk3288 Tested-by: Heiko Stuebner <he...@sntech.de> ___ dri-devel ma

Re: [PATCH v6 5/7] drm/rockchip: vop: add a series of vop support

2017-07-28 Thread Heiko Stuebner
l framework is 3, >vop little framework is 2. > minor version: on same structure, newer design vop will bigger >then old one. > > Signed-off-by: Mark Yao <mark@rock-chips.com> on rk3036 and rk3288 Tested-by: Heiko Stuebner <he...@sntech.

Re: [PATCH v6 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal

2017-07-28 Thread Heiko Stuebner
ps.com> rk3036 and rk3288 are not negatively affected by this, so on rk3036 and rk3288 Tested-by: Heiko Stuebner <he...@sntech.de> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 1/5] dt-bindings: gpu: add the RK3399 mali for rockchip specifics

2017-07-22 Thread Heiko Stuebner
Am Montag, 17. Juli 2017, 16:14:27 CEST schrieb Caesar Wang: > RK3399's GPU uses the quad-core Mali-T860, which is the new generation of > high-end graphics processors from ARM. > > This patch added "rockchip,rk3399-mali" for dt-bindings, in order to > support IPA of gpu thermal in later. > >

Re: [PATCH v5 1/7] drm/rockchip: vop: initialize registers directly

2017-07-25 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:22 CEST schrieb Mark Yao: > At present we are using init_table to initialize some > registers, but the Register init table use un-document define, > it is unreadable, and sometimes we only want to update tiny > bits, init table method is not friendly,

Re: [PATCH v5 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

2017-07-25 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:27 CEST schrieb Mark Yao: > Since the drm atomic framework, only a small part of the vop > register needs sync write, Currently seems only following registers > need sync write: >cfg_done, standby and interrupt related register. > > All ctrl

Re: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

2017-07-25 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao: > In the hardware design process, the design of line flags > register is associated with the interrupt register, > placing the line flags in the interrupt definition is > more reasonable, and it would make multi-vop define

Re: [PATCH v6.1 4/7] drm/rockchip: vop: group vop registers

2017-07-28 Thread Heiko Stuebner
-by: Jeffy Chen <jeffy.c...@rock-chips.com> on rk3036 and rk3288 Tested-by: Heiko Stuebner <he...@sntech.de> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series

2017-07-28 Thread Heiko Stuebner
Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:35 CEST schrieb Mark Yao: > Signed-off-by: Mark Yao > Acked-by: Rob Herring > --- > Changes in v5: > - clean document commit title > - move changes description out of docummit commit msg > > Changes in v2: > -

Re: [PATCH v6 1/7] drm/rockchip: vop: initialize registers directly

2017-07-26 Thread Heiko Stuebner
iendly, it's diffcult to > reuse for difference chips. > > To make it clean, initialize registers directly, and drops > init_table mechanism out. > > Signed-off-by: Mark Yao <mark@rock-chips.com> on rk3036 and rk3288 Tested-by: Heik

Re: [PATCH v6 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

2017-07-26 Thread Heiko Stuebner
All ctrl registers are using the sync write method that is > inefficient, hardcode the write_relaxed flags to vop registers, > then can only do synchronize write for those actual needed register. > > Signed-off-by: Mark Yao <mark@rock-chips.com> on rk3036 and rk3288 Tested-by: Heik

Re: [PATCH v6 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

2017-07-26 Thread Heiko Stuebner
ine easilier. > > Signed-off-by: Mark Yao <mark@rock-chips.com> > Reviewed-by: Sean Paul <seanp...@chromium.org> on rk3036 and rk3288 Tested-by: Heiko Stuebner <he...@sntech.de> Heiko ___ dri-devel mailing lis

Re: [PATCH v2 0/5] arm64: dts: rockchip: support mail and IPA thermal for rk3399

2017-07-19 Thread Heiko Stuebner
Am Mittwoch, 19. Juli 2017, 17:06:59 CEST schrieb Caesar Wang: > Hi Rob & Heiko, > > Do we have the chance to merge these patches? From the mali-thermal thingy, it doesn't look like Rob likes that IPA stuff. So I'll most likely pick the other patches that rely on approved bindings after I

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Heiko Stuebner
Am Donnerstag, 22. Juni 2017, 16:02:44 CEST schrieb Mark yao: > On 2017年06月22日 15:31, Heiko Stuebner wrote: > >> + > >> >+/** > >> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of > >> >chips > >>

Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2017-06-22 Thread Heiko Stuebner
Hi Mark, Am Donnerstag, 22. Juni 2017, 15:17:24 CEST schrieb Mark Yao: > RK3399 and RK3288 shared the same HDMI IP controller, only some light > difference with GRF configure. > > Signed-off-by: Yakir Yang > Signed-off-by: Mark Yao > --- > Changes

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

2017-09-07 Thread Heiko Stuebner
Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao: > On 2017年09月07日 20:09, Heiko Stübner wrote: > > Hi Mark, > > > > Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: > >> Looks good for me, so: > >> Reviewed-by: Mark Yao > >> > >> I'd like to

Re: [PATCH v2 6/8] arm64: dts: rockchip: rk3399: Correct MIPI DPHY PLL clock

2017-09-26 Thread Heiko Stuebner
Am Dienstag, 26. September 2017, 15:55:21 CEST schrieb Nickey Yang: > Mipi-dphy's ref_clk connect to clk_dphy_pll inside rk3399. > clk_24m -> Gate11[14] -> clk_mipidphy_ref -> Gate21[0] -> clk_dphy_pll > So correct it. > > Signed-off-by: Nickey Yang I've already

Re: [PATCH v2 7/8] arm64: dts: rockchip: add a grf clk for dw-mipi-dsi

2017-09-26 Thread Heiko Stuebner
Am Dienstag, 26. September 2017, 15:55:22 CEST schrieb Nickey Yang: > The clk of grf must be enabled before writing grf > register for rk3399. > > Signed-off-by: Nickey Yang applied as fix for 4.14 Thanks Heiko ___

Re: [PATCH v7 1/3] dt-bindings: display: Add Document for Rockchip Soc LVDS

2017-08-29 Thread Heiko Stuebner
Am Dienstag, 29. August 2017, 18:17:11 CEST schrieb Mark yao: > On 2017年08月23日 14:26, Sandy Huang wrote: > > This patch add Document for Rockchip Soc RK3288 LVDS, > > This based on the patches from Mark yao and Heiko Stuebner. > > > > Signed-off-by: Sandy Huang <h...@

Re: [PATCH] MAINTAINERS: change maintainer for Rockchip drm drivers

2017-11-24 Thread Heiko Stuebner
ote: > > For personal reasons, Mark Yao will leave rockchip, > > can not continue maintain drm/rockchip, Sandy Huang > > will take over the drm/rockchip. > > > > Cc: Sandy Huang <h...@rock-chips.com> > > Cc: Heiko Stuebner <he...@sntech.de> > > > &g

Re: [PATCH 04/41] drm/rockchip: Respect page offset for PRIME mmap calls

2017-12-12 Thread Heiko Stuebner
mium.org> > Signed-off-by: Sean Paul <seanp...@chromium.org> With the same testas patch 3 (rk3328 + lima) Tested-by: Heiko Stuebner <he...@sntech.de> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

2017-12-04 Thread Heiko Stuebner
Am Mittwoch, 29. November 2017, 10:47:55 CET schrieb Brian Norris: > From: Nickey Yang > > We might include additional ports in derivative device trees, so the > 'port' node should have an address, and the parent 'ports' node needs > /#{addres,size}-cells. > > v4: >

Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

2017-12-04 Thread Heiko Stuebner
Hi Laurent, Am Montag, 4. Dezember 2017, 15:22:07 CET schrieb Laurent Pinchart: > On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote: > > From: Nickey Yang > > > > We might include additional ports in derivative device trees, so the > > 'port' node should

Re: [PATCH 8/8] phy: rockchip: add inno hdmi phy to makefile

2017-12-09 Thread Heiko Stuebner
Hi Algea, Am Montag, 25. September 2017, 19:43:56 CET schrieb Algea Cao: > Support some SOCs,such as RK3328. > > Signed-off-by: Algea Cao I've tried tracking down the 8 patches of this series, but the only one I could find was this patch 8/8. Are you still working on

Re: [PATCH v2 5/7] drm/rockchip: dw_hdmi: add hclk_vio

2017-12-10 Thread Heiko Stuebner
Hi Algea, Am Samstag, 30. September 2017, 09:45:12 CET schrieb Algea Cao: > Add clk hclk_vio and enable it when hdmi bind. Could you explain what the hclk_vio reference is needed for please? Because from from what I tracked down in the TRM and code, this hclk_vio is defined wrong in the

Re: [PATCH 02/41] drm/rockchip: Get rid of some unnecessary code

2017-12-12 Thread Heiko Stuebner
and code. The commit message talks about *_fb-callbacks, while the patch removes a seemingly unsused mutex, which I guess falls under the "some unused fields" part. In any case, I didn't see any ill effects when testing this patch, so Tested-by: Heiko Stuebner <he...@sntech.de> > -

Re: [PATCH 03/41] drm/rockchip: support prime import sg table

2017-12-12 Thread Heiko Stuebner
importing the buffer to producing actual output, so Tested-by: Heiko Stuebner <he...@sntech.de> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/4] Move DP phy switch to PHY driver

2017-12-01 Thread Heiko Stuebner
Am Freitag, 1. Dezember 2017, 13:42:46 CET schrieb Doug Anderson: > Hi, > > On Wed, Nov 29, 2017 at 6:27 PM, Chris Zhong wrote: > > Hi Doug > > > > Thank you for mentioning this patch. > > > > I think the focus of the discussion is: can we put the grf control bit to > > dts.

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-30 Thread Heiko Stuebner
Hi Jeffy, Sean, Am Donnerstag, 19. Oktober 2017, 11:48:02 CET schrieb Jeffy Chen: > > Make edp display works on chromebook kevin(at least for boot animation). > > Also solve some issues i meet during the bringup. > > Changes in v6: > Don't change order of rockchip_drm_psr_register(). > >

Re: [PATCH] video: fbdev: remove unused auo_k190xfb drivers

2018-04-27 Thread Heiko Stuebner
king project, reality is that I don't think I'll ever continue on trying to mainline these and if later someone wants to resurrect these (very old now) devices, they'll probably need a drm- driver anyway. So for the removal Reviewed-by: Heiko Stuebner <he...@sntech.de> Heiko

[PATCH v3 6/6] drm/rockchip: dw_hdmi: add dw-hdmi support for the rk3328

2018-05-15 Thread Heiko Stuebner
The rk3328 uses a dw-hdmi controller with an external hdmi phy from Innosilicon which uses the generic phy framework for access. Add the necessary data and the compatible for the rk3328 to the rockchip dw-hdmi driver. Signed-off-by: Heiko Stuebner <he...@sntech.de> Tested-by: Robin

[PATCH v3 4/6] drm/rockchip: dw_hdmi: allow including external phys

2018-05-15 Thread Heiko Stuebner
Some variants of the dw-hdmi on Rockchip socs use a separate phy block accessed via the generic phy framework, so allow them to be included if such a phy reference is found. Signed-off-by: Heiko Stuebner <he...@sntech.de> Tested-by: Robin Murphy <robin.mur...@arm.com> --- dri

[PATCH v3 2/6] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-05-15 Thread Heiko Stuebner
-switching is necessary. Signed-off-by: Heiko Stuebner <he...@sntech.de> Tested-by: Robin Murphy <robin.mur...@arm.com> --- changes in v3: - fixed wording issue found by Robin Murphy drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH v3 5/6] drm/rockchip: dw_hdmi: store rockchip_hdmi reference in phy_data object

2018-05-15 Thread Heiko Stuebner
and use this reference later on. Inspiration for this comes from meson and sunxi dw-hdmi, which are using the same method. Signed-off-by: Heiko Stuebner <he...@sntech.de> Tested-by: Robin Murphy <robin.mur...@arm.com> --- changes in v3: - reword commit message drivers/gpu/drm/rock

[PATCH v3 0/6] drm/rockchip: hdmi support for rk3328

2018-05-15 Thread Heiko Stuebner
Cerveny - phy: use unsigned long for all tmdsclk rate uses - phy: simplify tmds rate calculation - dropped patch exporting some dw-hdmi phy functions as a similar patch entered drm-misc already Heiko Stuebner (6): drm/bridge: dw-hdmi: allow forcing vendor phy-type drm/rockchip: dw_hdmi: Allow

[PATCH v3 3/6] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-05-15 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner <he...@sntech.de> Reviewed-by: Rob Herring <r...@k

[PATCH v3 1/6] drm/bridge: dw-hdmi: allow forcing vendor phy-type

2018-05-15 Thread Heiko Stuebner
it may be necessary to allow forcing other types, but for now we'll keep it simply to the case actually seen in the wild. Signed-off-by: Heiko Stuebner <he...@sntech.de> Tested-by: Robin Murphy <robin.mur...@arm.com> --- changes in v3: - only allow forcing vendor type, as suggested by Laure

Re: [PATCH v5 4/4] drm/rockchip: support dp training outside dp firmware

2018-05-18 Thread Heiko Stuebner
Am Freitag, 18. Mai 2018, 03:45:46 CEST schrieb Brian Norris: > On Thu, May 17, 2018 at 6:41 PM, hl wrote: > > On Thursday, May 17, 2018 09:51 PM, Sean Paul wrote: > >> On Thu, May 17, 2018 at 05:18:00PM +0800, Lin Huang wrote: > >>> DP firmware uses fixed phy config values

Re: [PATCH v3 01/26] drm/bridge: allow optionally specifying an owner .odev device

2018-05-19 Thread Heiko Stuebner
->of_node; > + else > + remote = lvds->bridge->odev->of_node; > if (of_property_read_string(dev->of_node, "rockchip,output", )) > /* default set it as output rgb */ > lvds->output = DISPLAY_OUTPUT_RGB; for the Rock

Re: [PATCH v3 24/26] drm/bridge: remove the .of_node member

2018-05-19 Thread Heiko Stuebner
s->panel) > remote = lvds->panel->dev->of_node; > - else if (lvds->bridge->of_node) > - remote = lvds->bridge->of_node; > else > remote = lvds->bridge->odev->of_node; > if (of_property_read_strin

Re: [PATCH 2/3] drm/rockchip: lvds: avoid duplicating drm_bridge_attach

2018-05-20 Thread Heiko Stuebner
Am Mittwoch, 2. Mai 2018, 09:40:24 CEST schrieb Peter Rosin: > drm_bridge_attach takes care of these assignments, so there is no need > to open-code them a second time. > > Signed-off-by: Peter Rosin applied to drm-misc-next Thanks Heiko

Re: [PATCH] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-05-25 Thread Heiko Stuebner
s the vop can simply > > also track its enabled state and ignore irqs in that case. > > > > So remove the enable/disable handling and add appropriate condition > > to the irq handler. > > > > Signed-off-by: Sandy Huang <h...@rock-chips.com> &

Re: [PATCH v5 3/4] phy: rockchip-typec: support variable phy config value

2018-05-18 Thread Heiko Stuebner
Hi, Am Donnerstag, 17. Mai 2018, 11:17:59 CEST schrieb Lin Huang: > the phy config values used to fix in dp firmware, but some boards > need change these values to do training and get the better eye diagram > result. So support that in phy driver. > > Signed-off-by: Chris Zhong

Re: [PATCH v5 2/4] Documentation: bindings: add phy_config for Rockchip USB Type-C PHY

2018-05-18 Thread Heiko Stuebner
Am Donnerstag, 17. Mai 2018, 11:17:58 CEST schrieb Lin Huang: > If want to do training outside DP Firmware, need phy voltage swing > and pre_emphasis value. > > Signed-off-by: Lin Huang > --- > Changes in v2: > - None > Changes in v3: > - modify property description and add

Re: [PATCH v5 4/4] drm/rockchip: support dp training outside dp firmware

2018-05-18 Thread Heiko Stuebner
Am Freitag, 18. Mai 2018, 17:36:56 CEST schrieb Sean Paul: > On Fri, May 18, 2018 at 10:52:17AM +0200, Heiko Stuebner wrote: > > Am Freitag, 18. Mai 2018, 03:45:46 CEST schrieb Brian Norris: > > > On Thu, May 17, 2018 at 6:41 PM, hl <h...@rock-chips.com> wrote: > > &g

[PATCH v3 1/2] drm/rockchip: vop: split out core clock enablement into separate functions

2018-06-12 Thread Heiko Stuebner
;) Cc: sta...@vger.kernel.org Signed-off-by: Heiko Stuebner Tested-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 44 +++-- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip

[PATCH v3 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-12 Thread Heiko Stuebner
Signed-off-by: Heiko Stuebner Tested-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 28 ++--- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 9a

[PATCH v3 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change

2018-06-12 Thread Heiko Stuebner
, because of possible concurrency issues with vop enable/disable changes in v3: - fix comment in patch2 - add stable+fixes tags Heiko Stuebner (1): drm/rockchip: vop: split out core clock enablement into separate functions Sandy Huang (1): drm/rockchip: vop: fix irq disabled after vop driver

Re: [PATCH v4 1/3] drm/panel: refactor INNOLUX P079ZCA panel driver

2018-06-14 Thread Heiko Stuebner
Am Mittwoch, 14. März 2018, 13:02:13 CEST schrieb Emil Velikov: > Hi Lin, > > On 14 March 2018 at 09:12, Lin Huang wrote: > > From: huang lin > > > > Refactor Innolux P079ZCA panel driver, let it support > > multi panel. > > > > Change-Id: If89be5e56dba8cb498e2d50c1bbeb0e8016123a2 > >

Re: [PATCH v3 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-18 Thread Heiko Stuebner
Am Montag, 18. Juni 2018, 10:44:58 CEST schrieb Tomasz Figa: > Hi Heiko, > > On Tue, Jun 12, 2018 at 9:15 PM Heiko Stuebner wrote: > > > > From: Sandy Huang > > > > The vop irq is shared between vop and iommu and irq probing in the > > iommu driver moved t

Re: [PATCH v2 4/8] dt-bindings: display: rockchip: update DSI controller

2018-06-18 Thread Heiko Stuebner
Am Montag, 18. Juni 2018, 12:28:02 CEST schrieb Heiko Stuebner: > From: Nickey Yang > > This patch update describe panel/port links, including > unit addresses in documentation of device tree bindings > for the rockchip DSI controller based on the Synopsys > DesignWare MIPI D

[PATCH v2 8/8] drm/rockchip: dsi: add dual mipi support

2018-06-18 Thread Heiko Stuebner
to determine the dual-dsi state and get access to both controller instances. Signed-off-by: Heiko Stuebner --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 67 ++- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 + drivers/gpu

[PATCH v2 1/8] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

2018-06-18 Thread Heiko Stuebner
-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index fd7999642cf8..07cde255cab2 100644 --- a/drivers/gpu/drm

[PATCH v2 5/8] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver

2018-06-18 Thread Heiko Stuebner
add SPDX header instead of license blurb drop old versioning to not confuse people Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul Reviewed-by: Archit Taneja Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/Kco

[PATCH v2 3/8] drm/bridge/synopsys: dsi: defer probing if panel not available in bridge-attach

2018-06-18 Thread Heiko Stuebner
) drm_bridge_attach fails with -EINVAL due to empty panel_bridge So emit a -EPROBE_DEFER in that case to give the driver another chance at getting the display later. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v2 7/8] drm/bridge/synopsys: dsi: add dual-dsi support

2018-06-18 Thread Heiko Stuebner
outputs. To activate, the implementation-specific code should set the slave using dw_mipi_dsi_set_slave() before calling __dw_mipi_dsi_bind(). v2: - expect real interface number of lanes - keep links to both master and slave Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner --- drivers

[PATCH v2 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-06-18 Thread Heiko Stuebner
dw_mipi_dsi instead of the platform-device. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15 +++ include/drm/bridge/dw_mipi_dsi.h | 5 + 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw

[PATCH v2 4/8] dt-bindings: display: rockchip: update DSI controller

2018-06-18 Thread Heiko Stuebner
From: Nickey Yang This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang Reviewed-by: Brian Norris Signed-off-by: Heiko

[PATCH v2 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

2018-06-18 Thread Heiko Stuebner
dw-dsi copy in the Rockchip driver. But of course Acks / Reviews of the dsi-bridge changes would be needed. [0] https://patchwork.kernel.org/patch/10172381/ [1] https://lkml.org/lkml/2014/8/5/396 [2] https://patchwork.kernel.org/patch/5075161/ Heiko Stuebner (5): drm/bridge/synopsys: dsi: move mi

[PATCH v2 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-06-18 Thread Heiko Stuebner
From a specified output port of one dsi controller this function allows to iterate over the list of registered dsi controllers trying to find a second instance connected to the same display, like it is used in dual-dsi setups. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/drm_mipi_dsi.c

Re: [PATCH v4 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change

2018-06-18 Thread Heiko Stuebner
Am Dienstag, 12. Juni 2018, 15:20:26 CEST schrieb Heiko Stuebner: > This still tries to address the hang seen by Ezequiel Garcia on rk3288. > > As Tomasz noted, trying to count enablement can run into concurrency > issues, so instead we'll just check if the vop is runtime-enab

[PATCH v4 1/2] drm/rockchip: vop: split out core clock enablement into separate functions

2018-06-12 Thread Heiko Stuebner
;) Cc: sta...@vger.kernel.org Signed-off-by: Heiko Stuebner Tested-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 44 +++-- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip

[PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-12 Thread Heiko Stuebner
irqs in rk_iommu_probe()") Cc: sta...@vger.kernel.org Signed-off-by: Sandy Huang Signed-off-by: Heiko Stuebner Tested-by: Ezequiel Garcia --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 25 ++--- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v4 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change

2018-06-12 Thread Heiko Stuebner
, because of possible concurrency issues with vop enable/disable changes in v3: - fix comment in patch2 - add stable+fixes tags changes in v4: - address Marc's comments to patch2 Heiko Stuebner (1): drm/rockchip: vop: split out core clock enablement into separate functions Sandy Huang (1

Re: [PATCH v3 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-12 Thread Heiko Stuebner
Am Dienstag, 12. Juni 2018, 14:39:03 CEST schrieb Marc Zyngier: > Hi Heiko, > > On 12/06/18 13:15, Heiko Stuebner wrote: > > From: Sandy Huang > > > > The vop irq is shared between vop and iommu and irq probing in the > > iommu driver moved to the probe fu

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-07 Thread Heiko Stuebner
your DSI-related writings below, did provide some new thought- directions for me, so thanks for that. > On Thu, Jun 07, 2018 at 03:25:18PM +0200, Heiko Stuebner wrote: > > Am Donnerstag, 7. Juni 2018, 12:39:03 CEST schrieb Andrzej Hajda: > > > On 07.06.2018 01:08, Heiko Stuebner wr

[PATCH 1/8] drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to __dw_mipi_dsi_remove

2018-06-11 Thread Heiko Stuebner
-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 226171a3ece1..5ee605cbcf9d 100644 --- a/drivers/gpu/drm

[PATCH 4/8] dt-bindings: display: rockchip: update DSI controller

2018-06-11 Thread Heiko Stuebner
From: Nickey Yang This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang Reviewed-by: Brian Norris Signed-off-by: Heiko

[PATCH v8 5/8] drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver

2018-06-11 Thread Heiko Stuebner
-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul Reviewed-by: Archit Taneja Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/Kconfig |2 +- drivers/gpu/drm/rockchip/Makefile |2 +- .../gpu/drm/rockchip/dw-mipi

[PATCH 2/8] drm/bridge/synopsys: dsi: don't call __dw_mipi_dsi_probe from dw_mipi_dsi_bind

2018-06-11 Thread Heiko Stuebner
dw_mipi_dsi instead of the platform-device. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15 +++ include/drm/bridge/dw_mipi_dsi.h | 5 + 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw

[PATCH 3/8] drm/bridge/synopsys: dsi: defer probing if panel not available in bridge-attach

2018-06-11 Thread Heiko Stuebner
) drm_bridge_attach fails with -EINVAL due to empty panel_bridge So emit a -EPROBE_DEFER in that case to give the driver another chance at getting the display later. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[RFC PATCH 0/8] drm/rockchip: migrate to common dw-mipi-dsi bridge and dual-dsi

2018-06-11 Thread Heiko Stuebner
first, so that we can get rid of the dw-dsi copy in the Rockchip driver. [0] https://patchwork.kernel.org/patch/10172381/ [1] https://lkml.org/lkml/2014/8/5/396 [2] https://patchwork.kernel.org/patch/5075161/ Heiko Stuebner (5): drm/bridge/synopsys: dsi: move mipi_dsi_host_unregister to

[PATCH 7/8] drm/bridge/synopsys: dsi: add dual-dsi support

2018-06-11 Thread Heiko Stuebner
outputs. To activate, the implementation-specific code should set the slave using dw_mipi_dsi_set_slave() before calling __dw_mipi_dsi_bind(). Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 93 +-- include/drm/bridge

[PATCH 6/8] drm/dsi: add helper function to find the second host in a dual-dsi setup

2018-06-11 Thread Heiko Stuebner
From a specified output port of one dsi controller this function allows to iterate over the list of registered dsi controllers trying to find a second instance connected to the same display, like it is used in dual-dsi setups. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/drm_mipi_dsi.c

[PATCH 8/8] drm/rockchip: dsi: add dual mipi support

2018-06-11 Thread Heiko Stuebner
to determine the dual-dsi state and get access to both controller instances. Signed-off-by: Heiko Stuebner --- .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 67 ++- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 + drivers/gpu

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-11 Thread Heiko Stuebner
other dual-dsi part via separate ports as well. So no more hackery with endpoints and I can just follow Archit's dual-dsi binding text. Am Freitag, 8. Juni 2018, 10:47:05 CEST schrieb Andrzej Hajda: > On 08.06.2018 00:50, Heiko Stuebner wrote: > > Am Donnerstag, 7. Juni 2018, 23:10:20

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-04 Thread Heiko Stuebner
ce operating in dual-channel DSI mode. > > Signed-off-by: Archit Taneja Looks like a great solution for that problem, so Reviewed-by: Heiko Stuebner As I'm looking into that for my rk3399-scarlet device right now and couldn't find this patchset in the kernel yet, is it planned to merge or ref

Re: [RFC v2 2/2] dt-bindings: mipi-dsi: Add dual-channel DSI related info

2018-06-06 Thread Heiko Stuebner
übner wrote: > >>> Am Mittwoch, 6. Juni 2018, 07:59:29 CEST schrieb Archit Taneja: > >>>> On Monday 04 June 2018 05:47 PM, Heiko Stuebner wrote: > >>>>> Am Donnerstag, 18. Januar 2018, 05:53:55 CEST schrieb Archit Taneja: > >>>>>>

[PATCH v2 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change

2018-05-28 Thread Heiko Stuebner
, because of possible concurrency issues with vop enable/disable Heiko Stuebner (1): drm/rockchip: vop: split out core clock enablement into separate functions Sandy Huang (1): drm/rockchip: vop: fix irq disabled after vop driver probed drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 72

[PATCH v2 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-05-28 Thread Heiko Stuebner
priate condition to the irq handler. changes in v2: - move to just check the power-domain state - add clock handling Signed-off-by: Sandy Huang <h...@rock-chips.com> [add commit message, moved to pm_runtime_get_if_in_use] Signed-off-by: Heiko Stuebner <he...@sntech.de> --- driver

[PATCH v2 1/2] drm/rockchip: vop: split out core clock enablement into separate functions

2018-05-28 Thread Heiko Stuebner
Judging from the iommu code, both the hclk and aclk are necessary for register access. Split them off into separate functions from the regular vop enablement, so that we can use them elsewhere as well. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/ro

[PATCH v5 1/4] drm/panel: p079zca: refactor panel driver to support multiple panels

2018-07-02 Thread Heiko Stuebner
Huang Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 143 -- 1 file changed, 100 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c index bb53e0850764

[PATCH v5 3/4] dt-bindings: Add Innolux P097PFG panel bindings

2018-07-02 Thread Heiko Stuebner
power supplies as required Signed-off-by: Lin Huang Signed-off-by: Heiko Stuebner --- .../display/panel/innolux,p097pfg.txt | 24 +++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,p097pfg.txt diff

[PATCH v5 4/4] drm/panel: p079zca: support Innolux P097PFG panel

2018-07-02 Thread Heiko Stuebner
d-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 200 +- 1 file changed, 196 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c index 630b0c2549ef..8d25b87bfbd6 1

[PATCH v5 0/4] Innolux P097PFG panel

2018-07-02 Thread Heiko Stuebner
The Innolux p097pfg is one of two possible panels used in the gru-scarlet ChromeOS devices. This v5 mainly addresses the very valuable comments from Emil regarding power-supply and delay handling as well as documenting the (unsatisfying) source of the init commands. Individual changelogs inside

[PATCH v5 2/4] drm/panel: p079zca: add variable unprepare_delay properties

2018-07-02 Thread Heiko Stuebner
Huang [add sleep-mode delay] Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c index

[PATCH v2 3/3] drm/panel: add Kingdisplay kd097d04 panel driver

2018-07-02 Thread Heiko Stuebner
thing all panels do - document origins of the init sequence - lanes per dsi interface to 4 (two interfaces). Matches how tegra and pending rockchip dual-dsi handle (dual-)dsi lanes - spdx header instead of license boilerplate Signed-off-by: Nickey Yang Signed-off-by: Heiko Stuebner --- driver

[PATCH v2 1/3] dt-bindings: Add vendor prefix for kingdisplay

2018-07-02 Thread Heiko Stuebner
From: Nickey Yang Kingdisplay Technology Co., Ltd, established in China Shenzhen in 2006, is a national high-tech enterprise specializing in the R, manufacturing and marketing of TFT-LCM and touch panel. Signed-off-by: Nickey Yang Acked-by: Rob Herring Signed-off-by: Heiko Stuebner

[PATCH v2 2/3] dt-bindings: Add KINGDISPLAY KD097D04 panel bindings

2018-07-02 Thread Heiko Stuebner
From: Nickey Yang The KINGDISPLAY KD097D04 is a 9.7" panel with a 1536x2048 resolution and connected to DSI using 8 lanes. Signed-off-by: Nickey Yang Acked-by: Rob Herring Signed-off-by: Heiko Stuebner --- .../display/panel/kingdisplay,kd097d04.txt| 22 +++ 1

[PATCH v2 0/3] Kingdisplay-kd097d04-panel

2018-07-02 Thread Heiko Stuebner
The Innolux p097pfg is one of two possible panels used in the gru-scarlet ChromeOS devices. This v2 updates the driver with changes from the ChromeOS side and tries to address most of the comments received from Sean Paul. Nickey Yang (3): dt-bindings: Add vendor prefix for kingdisplay

Re: [PATCH] drm/rockchip: vop: fixup linebuffer mode calc error

2018-06-27 Thread Heiko Stuebner
Hi Sandy, Am Dienstag, 26. Juni 2018, 10:16:44 CEST schrieb Sandy Huang: > linebuffer mode should be LB_YUV_3840X5 when width is bigger > than 1280 in yuv mode. > seperate yuv and rgb case make the scl_vop_cal_lb_mode() logic > is clearer. > > Signed-off-by: Sandy Huang applied to

Re: [PATCH 07/10] drm/rockchip: Use drm_crtc_mask()

2018-06-27 Thread Heiko Stuebner
Am Dienstag, 26. Juni 2018, 21:47:13 CEST schrieb Ville Syrjala: > From: Ville Syrjälä > > Use drm_crtc_mask() where appropriate. > > Cc: Sandy Huang > Cc: "Heiko Stübner" > Signed-off-by: Ville Syrjälä thanks for that small cleanup, applied to drm-misc-next Thanks Heiko

Re: [PATCH 03/40] drm/rockchip: Respect page offset for PRIME mmap calls

2018-01-22 Thread Heiko Stuebner
Thierry Escande <thierry.esca...@collabora.com> On rk3036 + lima and rk3328 + lima Tested-by: Heiko Stuebner <he...@sntech.de> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 02/40] drm/rockchip: support prime import sg table

2018-01-22 Thread Heiko Stuebner
(e.g. zero-copy video decode, camera). > > Signed-off-by: Haixia Shi <h...@chromium.org> > Signed-off-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> On rk3036 + lima and rk332

[PATCH 4/9] drm/bridge: dw-hdmi: export hotplug functions

2018-02-05 Thread Heiko Stuebner
ll 3 hotplug-related functions] Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 11 +++ include/drm/bridge/dw_hdmi.h | 6 +- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/syn

[PATCH 6/9] dt-bindings: allow optional phys in Rockchip dw_hdmi binding

2018-02-05 Thread Heiko Stuebner
Some newer Rockchip SoCs use an Innosilicon hdmiphy accessed via general mmio, so allow these to be referenced via the regular phy interfaces and therefore add optional phy-related properties to the binding. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- Documentation/devicetree/bi

[PATCH 5/9] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching

2018-02-05 Thread Heiko Stuebner
-switching is necessary. Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 1eb02a

[PATCH 2/9] phy: add Rockchip Innosilicon hdmi phy

2018-02-05 Thread Heiko Stuebner
From: Zheng Yang <zhengy...@rock-chips.com> Add a driver for the Innosilicon hdmi phy used on rk3228/rk3229 and rk3328 socs from Rockchip. Signed-off-by: Zheng Yang <zhengy...@rock-chips.com> Signed-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/ph

[PATCH 3/9] drm/bridge: dw-hdmi: allow overriding of phy-type reading

2018-02-05 Thread Heiko Stuebner
-off-by: Heiko Stuebner <he...@sntech.de> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +++- include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

[PATCH 0/9] drm/rockchip: hdmi support for rk3328

2018-02-05 Thread Heiko Stuebner
. Algea Cao (1): drm/bridge: dw-hdmi: export hotplug functions Heiko Stuebner (6): drm/bridge: dw-hdmi: allow overriding of phy-type reading drm/rockchip: dw_hdmi: Allow outputs that don't need output switching dt-bindings: allow optional phys in Rockchip dw_hdmi binding drm/rockchip

<    1   2   3   4   5   6   7   8   >